18707 2008-04-23 22:06:33 -0700 SQUIRRELFISH: eval always performs toString() on its argument 2008-04-23 22:35:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 18624 1 zwarich webkit-unassigned oldest_to_newest 78732 0 zwarich 2008-04-23 22:06:33 -0700 The following JavaScriptCore tests fail because eval always performs toString() on its argument, instead of returning the argument verbatim if it is not a string: ecma/GlobalObject/15.1.2.1-1.js ecma/NativeObjects/15-2.js ecma/Number/15.7.3.1-2.js ecma/ObjectObjects/15.2.3-1.js 78733 1 20785 zwarich 2008-04-23 22:19:59 -0700 Created attachment 20785 Proposed patch Here is a patch that fixes the problem. It shows no difference on SunSpider. 78734 2 20785 mjs 2008-04-23 22:27:30 -0700 Comment on attachment 20785 Proposed patch r=me 78735 3 zwarich 2008-04-23 22:35:52 -0700 Committed in r32459. 20785 2008-04-23 22:19:59 -0700 2008-04-23 22:27:30 -0700 Proposed patch tostring.diff text/plain 1050 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyNDU3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDQt MjMgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4NzA3OiBTUVVJUlJF TEZJU0g6IGV2YWwgYWx3YXlzIHBlcmZvcm1zIHRvU3RyaW5nKCkgb24gaXRzIGFyZ3VtZW50Cisg ICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MDc+CisK KyAgICAgICAgVGhpcyBmaXhlcyA0IG1vcmUgcmVncmVzc2lvbiB0ZXN0cy4KKworICAgICAgICAq IFZNL01hY2hpbmUuY3BwOgorICAgICAgICAoS0pTOjpldmFsKToKKwogMjAwOC0wNC0yMyAgR2Vv ZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1h Y2llaiBTdGFjaG93aWFrLgpJbmRleDogVk0vTWFjaGluZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0v TWFjaGluZS5jcHAJKHJldmlzaW9uIDMyNDU1KQorKysgVk0vTWFjaGluZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTUwMiw2ICs1MDIsOSBAQCBzdGF0aWMgTkVWRVJfSU5MSU5FIEpTVmFsdWUqIGV2 YWwoRXhlY1N0CiB7CiAgICAgSlNWYWx1ZSogeCA9IGFyZ2MgPj0gMiA/IHJbYXJndiArIDFdLnUu anNWYWx1ZSA6IGpzVW5kZWZpbmVkKCk7CiAgICAgCisgICAgaWYgKCF4LT5pc1N0cmluZygpKQor ICAgICAgICByZXR1cm4geDsKKyAgICAKICAgICBVU3RyaW5nIHMgPSB4LT50b1N0cmluZyhleGVj KTsKICAgICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpIHsKICAgICAgICAgZXhjZXB0aW9uVmFs dWUgPSBleGVjLT5leGNlcHRpb24oKTsK