187014 2018-06-25 13:52:24 -0700 [ews-build] Add support for Bindings-tests-EWS 2018-07-05 09:47:46 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187023 https://bugs.webkit.org/show_bug.cgi?id=187330 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1436226 0 aakash_jain 2018-06-25 13:52:24 -0700 We should add support for Binding-tests-EWS. 1436227 1 343535 aakash_jain 2018-06-25 13:57:49 -0700 Created attachment 343535 Proposed patch 1436230 2 ews-watchlist 2018-06-25 14:00:50 -0700 Attachment 343535 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247: [TestRunBindingsTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247: [TestRunBindingsTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259: [TestRunBindingsTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259: [TestRunBindingsTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1436231 3 aakash_jain 2018-06-25 14:03:14 -0700 This is similar to what we use in other Buildbot code. Also tested on ews-build.webkit-uat.org (http://ews-build.webkit-uat.org/#/builders/14/builds/5) 1436232 4 aakash_jain 2018-06-25 14:03:58 -0700 style-queue warnings are false positive. 1436256 5 aakash_jain 2018-06-25 14:28:51 -0700 Committed r233175: <https://trac.webkit.org/changeset/233175> 1436260 6 webkit-bug-importer 2018-06-25 14:31:10 -0700 <rdar://problem/41440190> 343535 2018-06-25 13:57:49 -0700 2018-06-25 14:22:51 -0700 Proposed patch ews_bindings_ews.patch text/plain 3838 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzE3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE4LTA2LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgc3VwcG9ydCBmb3IgQmluZGluZ3MtdGVzdHMt RVdTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcw MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHk6CisgICAgICAgIChCaW5kaW5n c0ZhY3RvcnkpOiBBZGRlZCBSdW5CaW5kaW5nc1Rlc3RzIGJ1aWxkIHN0ZXAgdG8gQmluZGluZ3NG YWN0b3J5LgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToK KyAgICAgICAgKFJ1bkJpbmRpbmdzVGVzdHMpOiBBZGRlZCBidWlsZC1zdGVwIGZvciBydW5uaW5n IEJpbmRpbmdzIHRlc3RzLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weTogQWRkZWQgdW5pdC10ZXN0cy4KKwogMjAxOC0wNi0yNSAgQWFrYXNo IEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1idWlsZF0gQWRk IHN1cHBvcnQgZm9yIFN0eWxlLUVXUwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL2ZhY3Rvcmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyMzMxNzApCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0z OSw2ICszOSwxMiBAQCBjbGFzcyBTdHlsZUZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIHNlbGYu YWRkU3RlcChDaGVja1N0eWxlKCkpCiAKIAorY2xhc3MgQmluZGluZ3NGYWN0b3J5KEZhY3Rvcnkp OgorICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbj1Ob25lLCBh cmNoaXRlY3R1cmVzPU5vbmUsIGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9uZSwgKiprd2FyZ3MpOgor ICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBh cmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cykKKyAgICAgICAgc2VsZi5h ZGRTdGVwKFJ1bkJpbmRpbmdzVGVzdHMoKSkKKworCiBjbGFzcyBHVEtGYWN0b3J5KEZhY3Rvcnkp OgogICAgIHBhc3MKIApAQCAtNzUsOSArODEsNSBAQCBjbGFzcyBKU0NUZXN0c0ZhY3RvcnkoRmFj dG9yeSk6CiAgICAgcGFzcwogCiAKLWNsYXNzIEJpbmRpbmdzRmFjdG9yeShGYWN0b3J5KToKLSAg ICBwYXNzCi0KLQogY2xhc3MgV2Via2l0cHlGYWN0b3J5KEZhY3RvcnkpOgogICAgIHBhc3MKSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9u IDIzMzE3MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQko d29ya2luZyBjb3B5KQpAQCAtNzEsMyArNzEsMTEgQEAgY2xhc3MgQ2hlY2tTdHlsZShzaGVsbC5T aGVsbENvbW1hbmQpOgogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsnY2hlY2std2Via2l0LXN0eWxl J10KICAgICBmbHVua09uRmFpbHVyZSA9IFRydWUKICAgICBjb21tYW5kID0gWydUb29scy9TY3Jp cHRzL2NoZWNrLXdlYmtpdC1zdHlsZSddCisKKworY2xhc3MgUnVuQmluZGluZ3NUZXN0cyhzaGVs bC5TaGVsbENvbW1hbmQpOgorICAgIG5hbWUgPSAnYmluZGluZ3MtdGVzdHMnCisgICAgZGVzY3Jp cHRpb24gPSBbJ2JpbmRpbmdzLXRlc3RzIHJ1bm5pbmcnXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9 IFsnYmluZGluZ3MtdGVzdHMnXQorICAgIGZsdW5rT25GYWlsdXJlID0gVHJ1ZQorICAgIGNvbW1h bmQgPSBbJ1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzJ10KSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJl dmlzaW9uIDIzMzE3MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw c191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjI4LDUgKzIyOCwzNyBAQCBUb3RhbCBl cnJvcnMgZm91bmQ6IDggaW4gNDggZmlsZXMnJycpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0 ZXAoKQogCiAKK2NsYXNzIFRlc3RSdW5CaW5kaW5nc1Rlc3RzKEJ1aWxkU3RlcE1peGluQWRkaXRp b25zLCB1bml0dGVzdC5UZXN0Q2FzZSk6CisgICAgZGVmIHNldFVwKHNlbGYpOgorICAgICAgICBz ZWxmLmxvbmdNZXNzYWdlID0gVHJ1ZQorICAgICAgICByZXR1cm4gc2VsZi5zZXRVcEJ1aWxkU3Rl cCgpCisKKyAgICBkZWYgdGVhckRvd24oc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLnRlYXJE b3duQnVpbGRTdGVwKCkKKworICAgIGRlZiB0ZXN0X3N1Y2Nlc3Moc2VsZik6CisgICAgICAgIHNl bGYuc2V0dXBTdGVwKFJ1bkJpbmRpbmdzVGVzdHMoKSkKKyAgICAgICAgc2VsZi5leHBlY3RSZW1v dGVDb21tYW5kcygKKyAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAg ICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5n cy10ZXN0cyddLAorICAgICAgICAgICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKyAwLAor ICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3Rh dGVfc3RyaW5nPSdiaW5kaW5ncy10ZXN0cycpCisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAo KQorCisgICAgZGVmIHRlc3RfZmFpbHVyZShzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAo UnVuQmluZGluZ3NUZXN0cygpKQorICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAor ICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAg ICAgICAgICAgY29tbWFuZD1bJ1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzJ10sCisg ICAgICAgICAgICAgICAgICAgICAgICApCisgICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygn c3RkaW8nLCBzdGRvdXQ9J0ZBSUw6IChKUykgSlNUZXN0SW50ZXJmYWNlLmNwcCcpCisgICAgICAg ICAgICArIDIsCisgICAgICAgICkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1G QUlMVVJFLCBzdGF0ZV9zdHJpbmc9J2JpbmRpbmdzLXRlc3RzIChmYWlsdXJlKScpCisgICAgICAg IHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCisKIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CiAg ICAgdW5pdHRlc3QubWFpbigpCg==