186983 2018-06-24 16:53:40 -0700 Fix the composition underline to be transformed by -apple-color-filter 2018-06-24 18:53:41 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1435945 0 simon.fraser 2018-06-24 16:53:40 -0700 Fix the composition underline to be transformed by -apple-color-filter 1435946 1 343471 simon.fraser 2018-06-24 16:55:16 -0700 Created attachment 343471 Patch 1435947 2 simon.fraser 2018-06-24 16:55:30 -0700 rdar://problem/40515558 1435950 3 343471 zalan 2018-06-24 17:25:14 -0700 Comment on attachment 343471 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343471&action=review > Source/WebCore/rendering/InlineTextBox.cpp:1172 > + Color underlineColor = underline.compositionUnderlineColor == CompositionUnderlineColor::TextColor ? renderer().style().visitedDependentColorWithColorFilter(CSSPropertyWebkitTextFillColor) : renderer().style().colorByApplyingColorFilter(underline.color); > + context.setStrokeColor(underlineColor); How do you know when to use the transformed color? 1435952 4 simon.fraser 2018-06-24 18:18:57 -0700 (In reply to zalan from comment #3) > Comment on attachment 343471 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343471&action=review > > > Source/WebCore/rendering/InlineTextBox.cpp:1172 > > + Color underlineColor = underline.compositionUnderlineColor == CompositionUnderlineColor::TextColor ? renderer().style().visitedDependentColorWithColorFilter(CSSPropertyWebkitTextFillColor) : renderer().style().colorByApplyingColorFilter(underline.color); > > + context.setStrokeColor(underlineColor); > > How do you know when to use the transformed color? All the colors we paint with should use the transformed color (except for semantic colors). 1435954 5 343471 commit-queue 2018-06-24 18:53:06 -0700 Comment on attachment 343471 Patch Clearing flags on attachment: 343471 Committed r233135: <https://trac.webkit.org/changeset/233135> 1435955 6 commit-queue 2018-06-24 18:53:07 -0700 All reviewed patches have been landed. Closing bug. 1435956 7 zalan 2018-06-24 18:53:41 -0700 (In reply to Simon Fraser (smfr) from comment #4) > (In reply to zalan from comment #3) > > Comment on attachment 343471 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=343471&action=review > > > > > Source/WebCore/rendering/InlineTextBox.cpp:1172 > > > + Color underlineColor = underline.compositionUnderlineColor == CompositionUnderlineColor::TextColor ? renderer().style().visitedDependentColorWithColorFilter(CSSPropertyWebkitTextFillColor) : renderer().style().colorByApplyingColorFilter(underline.color); > > > + context.setStrokeColor(underlineColor); > > > > How do you know when to use the transformed color? > > All the colors we paint with should use the transformed color (except for > semantic colors). RenderStyle API does not really give me any guidance in that direction. 343471 2018-06-24 16:55:16 -0700 2018-06-24 18:53:06 -0700 Patch bug-186983-20180624165515.patch text/plain 5621 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZmYjAyMWFkNWY4NDhl MDZmYjc4NDljMGM5ODBkOGY0NjQ0N2IyMS4uNDFkMDZjYTUxM2JhMjhhOThkNzc2NjlhZDkwYTU1 MGQ1NmI0MDU3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA2LTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCB0aGUgY29t cG9zaXRpb24gdW5kZXJsaW5lIHRvIGJlIHRyYW5zZm9ybWVkIGJ5IC1hcHBsZS1jb2xvci1maWx0 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Njk4 MworICAgICAgICByZGFyOi8vcHJvYmxlbS80MDUxNTU1OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVHJhbnNmb3JtIHRoZSBjb21wb3Np dGlvbiB1bmRlcmxpbmUgY29sb3Igd2l0aCB0aGUgY29sb3IgZmlsdGVyLgorCisgICAgICAgIFRl c3Q6IGNzczMvY29sb3ItZmlsdGVycy9jb2xvci1maWx0ZXItY29tcG9zaXRpb24tdW5kZXJsaW5l LWNvbG9yLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OklubGluZVRleHRCb3g6OnBhaW50Q29tcG9zaXRpb25VbmRlcmxpbmUg Y29uc3QpOgorCiAyMDE4LTA2LTIzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW01haWxdIFVzZSB0aGUgTWFpbCBWaWV3ZXIgd2lkdGggYXMgdGhlIGJhc2UgZm9y IHJlc29sdmluZyBob3Jpem9udGFsIHZpZXdwb3J0IHVuaXRzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKaW5kZXggM2U3ZTE2MWNiZDkwM2JjNTNjNjZlN2IwYzMy NTdlYjhiZGRkZWI0Zi4uY2VhMWNkMDBlZGIwMDRlMzdlZGFjNWNkNGYzMDYwYmFjZjIyNmU2YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcApAQCAtMTE2OCw3 ICsxMTY4LDggQEAgdm9pZCBJbmxpbmVUZXh0Qm94OjpwYWludENvbXBvc2l0aW9uVW5kZXJsaW5l KFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBGbG9hdFAKICAgICB3aWR0aCAtPSAyOwogCiAg ICAgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0ID0gcGFpbnRJbmZvLmNvbnRleHQoKTsKLSAgICBj b250ZXh0LnNldFN0cm9rZUNvbG9yKHVuZGVybGluZS5jb21wb3NpdGlvblVuZGVybGluZUNvbG9y ID09IENvbXBvc2l0aW9uVW5kZXJsaW5lQ29sb3I6OlRleHRDb2xvciA/IHJlbmRlcmVyKCkuc3R5 bGUoKS52aXNpdGVkRGVwZW5kZW50Q29sb3JXaXRoQ29sb3JGaWx0ZXIoQ1NTUHJvcGVydHlXZWJr aXRUZXh0RmlsbENvbG9yKSA6IHVuZGVybGluZS5jb2xvcik7CisgICAgQ29sb3IgdW5kZXJsaW5l Q29sb3IgPSB1bmRlcmxpbmUuY29tcG9zaXRpb25VbmRlcmxpbmVDb2xvciA9PSBDb21wb3NpdGlv blVuZGVybGluZUNvbG9yOjpUZXh0Q29sb3IgPyByZW5kZXJlcigpLnN0eWxlKCkudmlzaXRlZERl cGVuZGVudENvbG9yV2l0aENvbG9yRmlsdGVyKENTU1Byb3BlcnR5V2Via2l0VGV4dEZpbGxDb2xv cikgOiByZW5kZXJlcigpLnN0eWxlKCkuY29sb3JCeUFwcGx5aW5nQ29sb3JGaWx0ZXIodW5kZXJs aW5lLmNvbG9yKTsKKyAgICBjb250ZXh0LnNldFN0cm9rZUNvbG9yKHVuZGVybGluZUNvbG9yKTsK ICAgICBjb250ZXh0LnNldFN0cm9rZVRoaWNrbmVzcyhsaW5lVGhpY2tuZXNzKTsKICAgICBjb250 ZXh0LmRyYXdMaW5lRm9yVGV4dChGbG9hdFBvaW50KGJveE9yaWdpbi54KCkgKyBzdGFydCwgYm94 T3JpZ2luLnkoKSArIGxvZ2ljYWxIZWlnaHQoKSAtIGxpbmVUaGlja25lc3MpLCB3aWR0aCwgcmVu ZGVyZXIoKS5kb2N1bWVudCgpLnByaW50aW5nKCkpOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQ5N2UyN2EzMDU5MjMz OGEwZDhjZmY3OTUyOWI2OTk0ZGQ2OWYxMzQuLjY5NjBmYzIxNjZmYzcxNTJkODQ0ZGI3YWE5NzMw ZTU2YTQ3ODNmMWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wNi0yNCAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggdGhlIGNvbXBvc2l0 aW9uIHVuZGVybGluZSB0byBiZSB0cmFuc2Zvcm1lZCBieSAtYXBwbGUtY29sb3ItZmlsdGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY5ODMKKyAg ICAgICAgcmRhcjovL3Byb2JsZW0vNDA1MTU1NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgICogY3NzMy9jb2xvci1maWx0ZXJzL2NvbG9y LWZpbHRlci1jb21wb3NpdGlvbi11bmRlcmxpbmUtY29sb3ItZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogY3NzMy9jb2xvci1maWx0ZXJzL2NvbG9yLWZpbHRlci1jb21wb3NpdGlvbi11 bmRlcmxpbmUtY29sb3IuaHRtbDogQWRkZWQuCisKIDIwMTgtMDYtMjMgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFpbF0gVXNlIHRoZSBNYWlsIFZpZXdlciB3 aWR0aCBhcyB0aGUgYmFzZSBmb3IgcmVzb2x2aW5nIGhvcml6b250YWwgdmlld3BvcnQgdW5pdHMK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvY29sb3ItZmlsdGVycy9jb2xvci1maWx0ZXIt Y29tcG9zaXRpb24tdW5kZXJsaW5lLWNvbG9yLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9j c3MzL2NvbG9yLWZpbHRlcnMvY29sb3ItZmlsdGVyLWNvbXBvc2l0aW9uLXVuZGVybGluZS1jb2xv ci1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNmMTYyZTE2Y2E3ODk4NTM2Yzg2NzFkYTA4MTAy ZDRlOWJkYTQwN2QKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2NvbG9yLWZp bHRlcnMvY29sb3ItZmlsdGVyLWNvbXBvc2l0aW9uLXVuZGVybGluZS1jb2xvci1leHBlY3RlZC5o dG1sCkBAIC0wLDAgKzEsMzMgQEAKKzwhRE9DVFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVu bmVyIFsgZW5hYmxlQ29sb3JGaWx0ZXI9dHJ1ZSBdIC0tPgorPHN0eWxlPgorICAgIGRpdiB7Cisg ICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgdG9wOiAwOworICAgICAgICBsZWZ0 OiAwOworICAgIH0KKyAgICAjdGVzdCB7CisgICAgICAgIGNvbG9yOiBncmVlbjsKKyAgICAgICAg Zm9udDogMjBweC8xIE1vbm9zcGFjZTsKKyAgICAgICAgb3V0bGluZTogbm9uZTsKKyAgICB9Cisg ICAgI292ZXJsYXBwaW5nLXRvcCB7CisgICAgICAgIGJhY2tncm91bmQ6IHdoaXRlOworICAgICAg ICB3aWR0aDogMTAwcHg7CisgICAgICAgIGhlaWdodDogMTVweDsKKyAgICB9CisgICAgI292ZXJs YXBwaW5nLXJpZ2h0IHsKKyAgICAgICAgYmFja2dyb3VuZDogd2hpdGU7CisgICAgICAgIHdpZHRo OiA1MHB4OworICAgICAgICBoZWlnaHQ6IDUwcHg7CisgICAgICAgIGxlZnQ6IDUwcHg7CisgICAg fQorPC9zdHlsZT4KKzxkaXYgY29udGVudGVkaXRhYmxlIGlkPSJ0ZXN0Ij48L2Rpdj4KKzwhLS0g VGhlIG92ZXJsYXBwaW5nIERJVnMgYXJlIGhpZGluZyB0aGUgIl5eXl5eIiBjaGFyYWN0ZXJzIGFu ZCB0aGUgY2FyZXQgdG8gc2hvdyBvbmx5IHRoZSBjb21wb3NpdGlvbiB1bmRlcmxpbmUuIC0tPgor PGRpdiBpZD0ib3ZlcmxhcHBpbmctdG9wIj48L2Rpdj4KKzxkaXYgaWQ9Im92ZXJsYXBwaW5nLXJp Z2h0Ij48L2Rpdj4KKzxzY3JpcHQ+CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3Qi KS5mb2N1cygpOworICAgIGlmICh3aW5kb3cudGV4dElucHV0Q29udHJvbGxlcikKKyAgICAgICAg dGV4dElucHV0Q29udHJvbGxlci5zZXRNYXJrZWRUZXh0KCJeXl5eXiIsIDUsIDApOworPC9zY3Jp cHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2NvbG9yLWZpbHRlcnMvY29sb3ItZmls dGVyLWNvbXBvc2l0aW9uLXVuZGVybGluZS1jb2xvci5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy9j b2xvci1maWx0ZXJzL2NvbG9yLWZpbHRlci1jb21wb3NpdGlvbi11bmRlcmxpbmUtY29sb3IuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi43NTYyNmUyZGFmY2NlYzdhYjU5ZDljYTI5M2YyOTFjMzdmZmQyMWI1Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9jb2xvci1maWx0ZXJzL2NvbG9yLWZp bHRlci1jb21wb3NpdGlvbi11bmRlcmxpbmUtY29sb3IuaHRtbApAQCAtMCwwICsxLDM0IEBACis8 IURPQ1RZUEUgaHRtbD48IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGVuYWJsZUNvbG9yRmlsdGVy PXRydWUgXSAtLT4KKzxzdHlsZT4KKyAgICBkaXYgeworICAgICAgICBwb3NpdGlvbjogYWJzb2x1 dGU7CisgICAgICAgIHRvcDogMDsKKyAgICAgICAgbGVmdDogMDsKKyAgICB9CisgICAgI3Rlc3Qg eworICAgICAgICBjb2xvcjogcmdiKDI1NSwgMTI4LCAyNTUpOworICAgICAgICBmb250OiAyMHB4 LzEgTW9ub3NwYWNlOworICAgICAgICBvdXRsaW5lOiBub25lOworICAgICAgICAtYXBwbGUtY29s b3ItZmlsdGVyOiBpbnZlcnQoMSk7CisgICAgfQorICAgICNvdmVybGFwcGluZy10b3AgeworICAg ICAgICBiYWNrZ3JvdW5kOiB3aGl0ZTsKKyAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgICBo ZWlnaHQ6IDE1cHg7CisgICAgfQorICAgICNvdmVybGFwcGluZy1yaWdodCB7CisgICAgICAgIGJh Y2tncm91bmQ6IHdoaXRlOworICAgICAgICB3aWR0aDogNTBweDsKKyAgICAgICAgaGVpZ2h0OiA1 MHB4OworICAgICAgICBsZWZ0OiA1MHB4OworICAgIH0KKzwvc3R5bGU+Cis8ZGl2IGNvbnRlbnRl ZGl0YWJsZSBpZD0idGVzdCI+PC9kaXY+Cis8IS0tIFRoZSBvdmVybGFwcGluZyBESVZzIGFyZSBo aWRpbmcgdGhlICJeXl5eXiIgY2hhcmFjdGVycyBhbmQgdGhlIGNhcmV0IHRvIHNob3cgb25seSB0 aGUgY29tcG9zaXRpb24gdW5kZXJsaW5lLiAtLT4KKzxkaXYgaWQ9Im92ZXJsYXBwaW5nLXRvcCI+ PC9kaXY+Cis8ZGl2IGlkPSJvdmVybGFwcGluZy1yaWdodCI+PC9kaXY+Cis8c2NyaXB0PgorICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0IikuZm9jdXMoKTsKKyAgICBpZiAod2luZG93 LnRleHRJbnB1dENvbnRyb2xsZXIpCisgICAgICAgIHRleHRJbnB1dENvbnRyb2xsZXIuc2V0TWFy a2VkVGV4dCgiXl5eXl4iLCA1LCAwKTsKKzwvc2NyaXB0Pgo=