186961 2018-06-22 21:44:45 -0700 [Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC 2021-01-28 15:15:45 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 221107 221108 1 darin darin andersca benjamin cdumez cmarcelo dbates ddkilzer ews-watchlist mitz webkit-bug-importer oldest_to_newest 1435770 0 darin 2018-06-22 21:44:45 -0700 [Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC 1435771 1 343419 darin 2018-06-22 21:45:38 -0700 Created attachment 343419 Patch 1435859 2 darin 2018-06-23 08:30:40 -0700 Committed r233128: <https://trac.webkit.org/changeset/233128> 1435860 3 webkit-bug-importer 2018-06-23 08:31:21 -0700 <rdar://problem/41398383> 1438352 4 343419 ddkilzer 2018-07-01 15:36:29 -0700 Comment on attachment 343419 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343419&action=review > Source/WTF/Configurations/Base.xcconfig:36 > +CLANG_ENABLE_OBJC_ARC = YES; > CLANG_ENABLE_OBJC_WEAK = YES; Note that you can remove "CLANG_ENABLE_OBJC_WEAK = YES;" when enabling ARC, as -fobjc-arc is a superset of -fobjc-weak. 1438355 5 mitz 2018-07-01 15:39:22 -0700 (In reply to David Kilzer (:ddkilzer) from comment #4) > Comment on attachment 343419 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343419&action=review > > > Source/WTF/Configurations/Base.xcconfig:36 > > +CLANG_ENABLE_OBJC_ARC = YES; > > CLANG_ENABLE_OBJC_WEAK = YES; > > Note that you can remove "CLANG_ENABLE_OBJC_WEAK = YES;" when enabling ARC, > as -fobjc-arc is a superset of -fobjc-weak. See bug 186396 comment 2 and my response. 343419 2018-06-22 21:45:38 -0700 2018-06-23 07:55:25 -0700 Patch bug-186961-20180622214538.patch text/plain 4461 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZiMzZlMjkwZWEzYmEzYzVmNDcyNzhk MmUyNDVmZmUxY2I4ZjdkNjguLjkzNTE1ZWRhNzc1NzRhNTc4YzIzODk3MTczYmE2OTE3MDBlMzJk YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDYtMjIgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gQ29udmVydCB0aGUgc21hbGwgYml0IG9mIE9i amVjdGl2ZS1DKysgY29kZSBpbiBXVEYgdG8gQVJDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6IFR1 cm4gb24gQVJDLgorCisgICAgICAgICogd3RmL2NvY29hL01lbW9yeVByZXNzdXJlSGFuZGxlckNv Y29hLm1tOgorICAgICAgICAoV1RGOjpNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnVuaW5zdGFsbCk6 IFJlbW92ZSBjYWxscyB0byBkaXNwYXRjaF9yZWxlYXNlLgorICAgICAgICAoV1RGOjpNZW1vcnlQ cmVzc3VyZUhhbmRsZXI6OmhvbGRPZmYpOiBEaXR0by4KKworICAgICAgICAqIHd0Zi9tYWMvTWFp blRocmVhZE1hYy5tbToKKyAgICAgICAgKFdURjo6aW5pdGlhbGl6ZU1haW5UaHJlYWRQbGF0Zm9y bSk6IFJlbW92ZSBjYWxsIHRvIHJldGFpbi4KKyAgICAgICAgKFdURjo6aW5pdGlhbGl6ZVdlYlRo cmVhZFBsYXRmb3JtKTogRGl0dG8uCisKIDIwMTgtMDYtMjIgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gcmVkdWNlIHVubmVjZXNzYXJ5IHVzZSBvZiAu bW0gc291cmNlIGZpbGVzIGluIFdURiwgc3BydWNlIHVwIHNvbWUgaW1wbGVtZW50YXRpb24gZGV0 YWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmln IGIvU291cmNlL1dURi9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCmluZGV4IDhkZmQ1OWVm ZWNhZWFlMDQzNWJkNGY0NGM3ZjVjYzE3ZmViM2RkY2QuLjA1ODcwNjA0MmUwMmUwM2MzZGIxYzg4 YzYyZWNiNTYzYzJlNTcwMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ29uZmlndXJhdGlvbnMv QmFzZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvV1RGL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25m aWcKQEAgLTMyLDYgKzMyLDcgQEAgQUxXQVlTX1NFQVJDSF9VU0VSX1BBVEhTID0gTk87CiAKIENM QU5HX0NYWF9MQU5HVUFHRV9TVEFOREFSRCA9IGdudSsrMTQ7CiBDTEFOR19DWFhfTElCUkFSWSA9 IGxpYmMrKzsKK0NMQU5HX0VOQUJMRV9PQkpDX0FSQyA9IFlFUzsKIENMQU5HX0VOQUJMRV9PQkpD X1dFQUsgPSBZRVM7CiBDTEFOR19XQVJOX0JMT0NLX0NBUFRVUkVfQVVUT1JFTEVBU0lORyA9IFlF UzsKIENMQU5HX1dBUk5fQk9PTF9DT05WRVJTSU9OID0gWUVTOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvY29jb2EvTWVtb3J5UHJlc3N1cmVIYW5kbGVyQ29jb2EubW0gYi9Tb3VyY2UvV1RG L3d0Zi9jb2NvYS9NZW1vcnlQcmVzc3VyZUhhbmRsZXJDb2NvYS5tbQppbmRleCBmN2VlNjQ3N2Ez MDU5YjQ3OTE0NmNhYzBjYjExM2IwMjhmMGI1YTRhLi43NTRjYWU2ZTYwNTk1N2Q3ZTZiNGM3MDI2 NGZkZTk5YTEyMWZlNTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9NZW1vcnlQ cmVzc3VyZUhhbmRsZXJDb2NvYS5tbQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9NZW1vcnlQ cmVzc3VyZUhhbmRsZXJDb2NvYS5tbQpAQCAtMTM0LDEzICsxMzQsMTEgQEAgdm9pZCBNZW1vcnlQ cmVzc3VyZUhhbmRsZXI6OnVuaW5zdGFsbCgpCiAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hf Z2V0X21haW5fcXVldWUoKSwgXnsKICAgICAgICAgaWYgKF9jYWNoZV9ldmVudF9zb3VyY2UpIHsK ICAgICAgICAgICAgIGRpc3BhdGNoX3NvdXJjZV9jYW5jZWwoX2NhY2hlX2V2ZW50X3NvdXJjZSk7 Ci0gICAgICAgICAgICBkaXNwYXRjaF9yZWxlYXNlKF9jYWNoZV9ldmVudF9zb3VyY2UpOwogICAg ICAgICAgICAgX2NhY2hlX2V2ZW50X3NvdXJjZSA9IDA7CiAgICAgICAgIH0KIAogICAgICAgICBp ZiAoX3RpbWVyX2V2ZW50X3NvdXJjZSkgewogICAgICAgICAgICAgZGlzcGF0Y2hfc291cmNlX2Nh bmNlbChfdGltZXJfZXZlbnRfc291cmNlKTsKLSAgICAgICAgICAgIGRpc3BhdGNoX3JlbGVhc2Uo X3RpbWVyX2V2ZW50X3NvdXJjZSk7CiAgICAgICAgICAgICBfdGltZXJfZXZlbnRfc291cmNlID0g MDsKICAgICAgICAgfQogICAgIH0pOwpAQCAtMTYzLDcgKzE2MSw2IEBAIHZvaWQgTWVtb3J5UHJl c3N1cmVIYW5kbGVyOjpob2xkT2ZmKFNlY29uZHMgc2Vjb25kcykKICAgICAgICAgICAgIGRpc3Bh dGNoX3NvdXJjZV9zZXRfZXZlbnRfaGFuZGxlcihfdGltZXJfZXZlbnRfc291cmNlLCBeewogICAg ICAgICAgICAgICAgIGlmIChfdGltZXJfZXZlbnRfc291cmNlKSB7CiAgICAgICAgICAgICAgICAg ICAgIGRpc3BhdGNoX3NvdXJjZV9jYW5jZWwoX3RpbWVyX2V2ZW50X3NvdXJjZSk7Ci0gICAgICAg ICAgICAgICAgICAgIGRpc3BhdGNoX3JlbGVhc2UoX3RpbWVyX2V2ZW50X3NvdXJjZSk7CiAgICAg ICAgICAgICAgICAgICAgIF90aW1lcl9ldmVudF9zb3VyY2UgPSAwOwogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnNpbmdsZXRvbigpLmlu c3RhbGwoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL21hYy9NYWluVGhyZWFkTWFjLm1t IGIvU291cmNlL1dURi93dGYvbWFjL01haW5UaHJlYWRNYWMubW0KaW5kZXggYjVjZjBlYmVmYTA4 MGQwMWI1ZTA0ZGZhNzYzMGVhODQ0YzRlOGJkZC4uMjcwYmU3OTRlODU0MWI3ZmUyNzc2ZGVkZjgz ZTI0MTYxODZlNTVmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvbWFjL01haW5UaHJlYWRN YWMubW0KKysrIGIvU291cmNlL1dURi93dGYvbWFjL01haW5UaHJlYWRNYWMubW0KQEAgLTQzLDgg KzQzLDcgQEAKICNpbmNsdWRlIDx3dGYvaW9zL1dlYkNvcmVUaHJlYWQuaD4KICNlbmRpZgogCi1A aW50ZXJmYWNlIEpTV1RGTWFpblRocmVhZENhbGxlciA6IE5TT2JqZWN0IHsKLX0KK0BpbnRlcmZh Y2UgSlNXVEZNYWluVGhyZWFkQ2FsbGVyIDogTlNPYmplY3QKIC0gKHZvaWQpY2FsbDsKIEBlbmQK IApAQCAtNTUsMTIgKzU0LDEyIEBAIC0gKHZvaWQpY2FsbAogICAgIFdURjo6ZGlzcGF0Y2hGdW5j dGlvbnNGcm9tTWFpblRocmVhZCgpOwogfQogCi1AZW5kIC8vIGltcGxlbWVudGF0aW9uIEpTV1RG TWFpblRocmVhZENhbGxlcgorQGVuZAogCiBuYW1lc3BhY2UgV1RGIHsKIAogc3RhdGljIEpTV1RG TWFpblRocmVhZENhbGxlciogc3RhdGljTWFpblRocmVhZENhbGxlcjsKLXN0YXRpYyBib29sIGlz VGltZXJQb3N0ZWQ7IC8vIFRoaXMgaXMgb25seSBhY2Nlc3NlZCBvbiB0aGUgJ21haW4nIHRocmVh ZC4KK3N0YXRpYyBib29sIGlzVGltZXJQb3N0ZWQ7IC8vIFRoaXMgaXMgb25seSBhY2Nlc3NlZCBv biB0aGUgbWFpbiB0aHJlYWQuCiBzdGF0aWMgYm9vbCBtYWluVGhyZWFkRXN0YWJsaXNoZWRBc1B0 aHJlYWRNYWluOwogc3RhdGljIHB0aHJlYWRfdCBtYWluVGhyZWFkUHRocmVhZDsKIHN0YXRpYyBO U1RocmVhZCogbWFpblRocmVhZE5TVGhyZWFkOwpAQCAtNzgsNyArNzcsNyBAQCB2b2lkIGluaXRp YWxpemVNYWluVGhyZWFkUGxhdGZvcm0oKQogI2lmICFVU0UoV0VCX1RIUkVBRCkKICAgICBtYWlu VGhyZWFkRXN0YWJsaXNoZWRBc1B0aHJlYWRNYWluID0gZmFsc2U7CiAgICAgbWFpblRocmVhZFB0 aHJlYWQgPSBwdGhyZWFkX3NlbGYoKTsKLSAgICBtYWluVGhyZWFkTlNUaHJlYWQgPSBbW05TVGhy ZWFkIGN1cnJlbnRUaHJlYWRdIHJldGFpbl07CisgICAgbWFpblRocmVhZE5TVGhyZWFkID0gW05T VGhyZWFkIGN1cnJlbnRUaHJlYWRdOwogI2Vsc2UKICAgICBtYWluVGhyZWFkRXN0YWJsaXNoZWRB c1B0aHJlYWRNYWluID0gdHJ1ZTsKICAgICBBU1NFUlQoIW1haW5UaHJlYWRQdGhyZWFkKTsKQEAg LTE4Niw3ICsxODUsNyBAQCB2b2lkIGluaXRpYWxpemVXZWJUaHJlYWRQbGF0Zm9ybSgpCiAKICAg ICBtYWluVGhyZWFkRXN0YWJsaXNoZWRBc1B0aHJlYWRNYWluID0gZmFsc2U7CiAgICAgbWFpblRo cmVhZFB0aHJlYWQgPSBwdGhyZWFkX3NlbGYoKTsKLSAgICBtYWluVGhyZWFkTlNUaHJlYWQgPSBb W05TVGhyZWFkIGN1cnJlbnRUaHJlYWRdIHJldGFpbl07CisgICAgbWFpblRocmVhZE5TVGhyZWFk ID0gW05TVGhyZWFkIGN1cnJlbnRUaHJlYWRdOwogCiAgICAgc1dlYlRocmVhZCA9ICZUaHJlYWQ6 OmN1cnJlbnQoKTsKIH0K