186945 2018-06-22 15:45:23 -0700 [Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924 2018-07-03 14:02:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 185699 187300 1 jer.noble jer.noble commit-queue eric.carlson jeremyj-wk ryanhaddad simon.fraser tsavell webkit-bug-importer oldest_to_newest 1435645 0 jer.noble 2018-06-22 15:45:23 -0700 [Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924 1435648 1 jer.noble 2018-06-22 15:45:56 -0700 <rdar://problem/37277469> 1435653 2 343383 jer.noble 2018-06-22 15:49:21 -0700 Created attachment 343383 Patch 1435700 3 343383 commit-queue 2018-06-22 17:15:58 -0700 Comment on attachment 343383 Patch Clearing flags on attachment: 343383 Committed r233112: <https://trac.webkit.org/changeset/233112> 1435701 4 commit-queue 2018-06-22 17:15:59 -0700 All reviewed patches have been landed. Closing bug. 1438951 5 commit-queue 2018-07-03 13:40:41 -0700 Re-opened since this is blocked by bug 187300 1438973 6 tsavell 2018-07-03 14:01:15 -0700 *** Bug 187293 has been marked as a duplicate of this bug. *** 1438975 7 ryanhaddad 2018-07-03 14:02:15 -0700 *** Bug 182527 has been marked as a duplicate of this bug. *** 343383 2018-06-22 15:49:21 -0700 2018-06-22 17:15:58 -0700 Patch bug-186945-20180622154920.patch text/plain 3012 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI1NGRkYWVjNWZiZDA5 NzQ5OGI3YzQyNGExYzJjNmE5MmU5ZjE1MS4uNGI5OTZmNDM4NWM5YjljMjFiNTJmZDBmM2ZkN2Y5 NTNjMDBlN2Y0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA2LTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtGdWxsc2NyZWVuXSBSZXN0 b3JlIEFTU0VSVF9OT1RfUkVBQ0hFRCgpIGNoZWNrcyBpbiBleGl0IGZ1bGxzY3JlZW4gaGFuZGxl ciBhZnRlciByMjMxOTI0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODY5NDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3Mjc3NDY5PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW9z L1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQ6OmV4aXRGdWxsc2NyZWVuKToKKyAgICAgICAgKFZpZGVvRnVsbHNj cmVlbkludGVyZmFjZUFWS2l0OjpleGl0RnVsbHNjcmVlbkhhbmRsZXIpOgorICAgICAgICAoVmlk ZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmNsZWFudXBGdWxsc2NyZWVuKToKKwogMjAxOC0w Ni0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVj YWxjIHN0eWxlcyBldmVyeSB0aW1lIGRlZmF1bHRBcHBlYXJhbmNlIGNoYW5nZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl QVZLaXQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlQVZLaXQubW0KaW5kZXggYTc1NWQxYjRiZDk5Nzk5NTYxN2ZmM2ZiMmRkZDE4ZWE2MTc5 YzkxMC4uYWMzZmVmN2RkODMwM2FmODc3Njk0ZTg5ZGU3OTg3OGUwNTE5OWE3ZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VBVktpdC5tbQpAQCAtMTAxMSw4ICsxMDExLDEwIEBAIHZvaWQgVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQ6OmV4aXRGdWxsc2NyZWVuKGNvbnN0IEludFJlY3QmIGZpbmFsUmVj dCkKICAgICAgICAgfV07CiAgICAgfSBlbHNlIGlmIChtX2N1cnJlbnRNb2RlLmlzRnVsbHNjcmVl bigpKSB7CiAgICAgICAgIFttX3BsYXllclZpZXdDb250cm9sbGVyIGV4aXRGdWxsU2NyZWVuQW5p bWF0ZWQ6WUVTIGNvbXBsZXRpb25IYW5kbGVyOltwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZlB0cih0 aGlzKSwgdGhpc10gKEJPT0wgc3VjY2VzcywgTlNFcnJvciogZXJyb3IpIG11dGFibGUgewotICAg ICAgICAgICAgaWYgKCFzdWNjZXNzKQorICAgICAgICAgICAgaWYgKCFzdWNjZXNzKSB7CiAgICAg ICAgICAgICAgICAgV1RGTG9nQWx3YXlzKCItW0FWUGxheWVyVmlld0NvbnRyb2xsZXIgZXhpdEZ1 bGxTY3JlZW5BbmltYXRlZDpjb21wbGV0aW9uSGFuZGxlcjpdIGZhaWxlZCB3aXRoIGVycm9yICVz IiwgW1tlcnJvciBsb2NhbGl6ZWREZXNjcmlwdGlvbl0gVVRGOFN0cmluZ10pOworICAgICAgICAg ICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgfQogCiAgICAgICAgICAg ICBtX2V4aXRDb21wbGV0ZWQgPSB0cnVlOwogCkBAIC0xMDQ3LDggKzEwNDksMTAgQEAgdm9pZCBW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51cEZ1bGxzY3JlZW4oKQogICAgIGlm IChtX2N1cnJlbnRNb2RlLmhhc0Z1bGxzY3JlZW4oKSkgewogICAgICAgICBbW21fcGxheWVyVmll d0NvbnRyb2xsZXIgdmlld10gbGF5b3V0SWZOZWVkZWRdOwogICAgICAgICBbbV9wbGF5ZXJWaWV3 Q29udHJvbGxlciBleGl0RnVsbFNjcmVlbkFuaW1hdGVkOk5PIGNvbXBsZXRpb25IYW5kbGVyOltd IChCT09MIHN1Y2Nlc3MsIE5TRXJyb3IqIGVycm9yKSB7Ci0gICAgICAgICAgICBpZiAoIXN1Y2Nl c3MpCisgICAgICAgICAgICBpZiAoIXN1Y2Nlc3MpIHsKICAgICAgICAgICAgICAgICBXVEZMb2dB bHdheXMoIi1bQVZQbGF5ZXJWaWV3Q29udHJvbGxlciBleGl0RnVsbFNjcmVlbkFuaW1hdGVkOmNv bXBsZXRpb25IYW5kbGVyOl0gZmFpbGVkIHdpdGggZXJyb3IgJXMiLCBbW2Vycm9yIGxvY2FsaXpl ZERlc2NyaXB0aW9uXSBVVEY4U3RyaW5nXSk7CisgICAgICAgICAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CisgICAgICAgICAgICB9CiAgICAgICAgIH1dOwogICAgIH0KICAgICAKQEAgLTE3 OTAsOCArMTc5NCwxMCBAQCB2b2lkIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojpkb0V4 aXRGdWxsc2NyZWVuKCkKIAogdm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZXhp dEZ1bGxzY3JlZW5IYW5kbGVyKEJPT0wgc3VjY2VzcywgTlNFcnJvciogZXJyb3IpCiB7Ci0gICAg aWYgKCFzdWNjZXNzKQorICAgIGlmICghc3VjY2VzcykgewogICAgICAgICBXVEZMb2dBbHdheXMo Ii1bQVZQbGF5ZXJWaWV3Q29udHJvbGxlciBleGl0RnVsbFNjcmVlbkFuaW1hdGVkOmNvbXBsZXRp b25IYW5kbGVyOl0gZmFpbGVkIHdpdGggZXJyb3IgJXMiLCBbW2Vycm9yIGxvY2FsaXplZERlc2Ny aXB0aW9uXSBVVEY4U3RyaW5nXSk7CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAg IH0KIAogICAgIExPRyhGdWxsc2NyZWVuLCAiVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OmRpZEV4aXRGdWxsc2NyZWVuKCVwKSAtICVkIiwgdGhpcywgc3VjY2Vzcyk7CiAK