186939 2018-06-22 13:41:02 -0700 NetworkLoadChecker should not check CORS for 304 responses triggered by WebProcess revalidation 2018-06-25 14:14:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue webkit-bug-importer oldest_to_newest 1435583 0 youennf 2018-06-22 13:41:02 -0700 As per spec, NetworkLoadChecker should not check CORS for 304 responses if the WebProcess is asking for revalidation. Instead, the WebProcess should do it 1435587 1 youennf 2018-06-22 13:52:52 -0700 <rdar://problem/40941725> 1435588 2 343362 youennf 2018-06-22 13:54:47 -0700 Created attachment 343362 Patch 1436196 3 youennf 2018-06-25 13:04:07 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/11663 1436239 4 343362 commit-queue 2018-06-25 14:14:13 -0700 Comment on attachment 343362 Patch Clearing flags on attachment: 343362 Committed r233172: <https://trac.webkit.org/changeset/233172> 1436240 5 commit-queue 2018-06-25 14:14:15 -0700 All reviewed patches have been landed. Closing bug. 343362 2018-06-22 13:54:47 -0700 2018-06-25 14:14:13 -0700 Patch bug-186939-20180622135446.patch text/plain 5499 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlZjZiMWM2ZDc1ODU5MDYy YWEwYTEwY2JjYjU3YmE3YzU4YjkyMTIuLjAwMzllMGRjNjU0ZGU4YmQxMzRjNTQxMTRkNDU5Yzgw ZGUyMmYxNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDYtMjIgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtMb2FkQ2hlY2tlciBz aG91bGQgbm90IGNoZWNrIENPUlMgZm9yIDMwNCByZXNwb25zZXMgdHJpZ2dlcmVkIGJ5IFdlYlBy b2Nlc3MgcmV2YWxpZGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODY5MzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQwOTQxNzI1PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3MvTmV0d29ya0xvYWRDaGVja2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0xv YWRDaGVja2VyOjp2YWxpZGF0ZVJlc3BvbnNlKToKKwogMjAxOC0wNi0yMCAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBVc2UgdGhlIGlzRGlyZWN0b3J5 OiB2YXJpYW50cyBvZiBOU1VSTCBtZXRob2RzIG1vcmUgdG8gZWxpbWluYXRlIHVubmVjZXNzYXJ5 IGZpbGUgc3lzdGVtIGFjdGl2aXR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL05ldHdvcmtMb2FkQ2hlY2tlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL05ldHdvcmtMb2FkQ2hlY2tlci5jcHAKaW5kZXggNzU3Yjk4NWMyOTE4MjMwOGJiZTJlMWM1 ZmM1MjRlMWE0ODRjZWRkNy4uM2E2MGQxZWQ0MDAyMDNmMjY0ODU5ZjBkMDhjZjUwMTI0MmM5M2Mw NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZENo ZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWRD aGVja2VyLmNwcApAQCAtMTYwLDYgKzE2MCwxMCBAQCBSZXNvdXJjZUVycm9yIE5ldHdvcmtMb2Fk Q2hlY2tlcjo6dmFsaWRhdGVSZXNwb25zZShSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKIAog ICAgIEFTU0VSVChtX29wdGlvbnMubW9kZSA9PSBGZXRjaE9wdGlvbnM6Ok1vZGU6OkNvcnMpOwog CisgICAgLy8gSWYgd2UgaGF2ZSBhIDMwNCwgdGhlIGNhY2hlZCByZXNwb25zZSBpcyBpbiBXZWJQ cm9jZXNzIHNvIHdlIGxldCBXZWJQcm9jZXNzIGRvIHRoZSBDT1JTIGNoZWNrIG9uIHRoZSBjYWNo ZWQgcmVzcG9uc2UuCisgICAgaWYgKHJlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkgPT0gMzA0KQor ICAgICAgICByZXR1cm4geyB9OworCiAgICAgU3RyaW5nIGVycm9yTWVzc2FnZTsKICAgICBpZiAo IXBhc3Nlc0FjY2Vzc0NvbnRyb2xDaGVjayhyZXNwb25zZSwgbV9zdG9yZWRDcmVkZW50aWFsc1Bv bGljeSwgKm1fb3JpZ2luLCBlcnJvck1lc3NhZ2UpKQogICAgICAgICByZXR1cm4gUmVzb3VyY2VF cnJvciB7IFN0cmluZyB7IH0sIDAsIG1fdXJsLCBXVEZNb3ZlKGVycm9yTWVzc2FnZSksIFJlc291 cmNlRXJyb3I6OlR5cGU6OkFjY2Vzc0NvbnRyb2wgfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nCmluZGV4IGI4OWI4MmI0ZmUyY2E1MDlmZTU0MzU3NjllZjQ2M2QzNTk0YWY2OTYuLjE5ZTRl NmRjMDMyOGY0YmI1MDFkYWNhYzk2OWRiN2Q5M2Y3YjBmZWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTIyICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBOZXR3b3JrTG9hZENoZWNrZXIgc2hvdWxkIG5v dCBjaGVjayBDT1JTIGZvciAzMDQgcmVzcG9uc2VzIHRyaWdnZXJlZCBieSBXZWJQcm9jZXNzIHJl dmFsaWRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg2OTM5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDk0MTcyNT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0 cy9jb3JzL3Jlc291cmNlcy9jYWNoZS0zMDQucHk6IEFkZGVkLgorICAgICAgICAqIHdlYi1wbGF0 Zm9ybS10ZXN0cy9jb3JzL3NjcmlwdC0zMDQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiB3ZWItcGxhdGZvcm0tdGVzdHMvY29ycy9zY3JpcHQtMzA0Lmh0bWw6IEFkZGVkLgorCiAyMDE4 LTA2LTE5ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSVENS dHBTZW5kZXIucmVwbGFjZVRyYWNrKG51bGwpIGVuZHMgY3VycmVudCB0cmFjawpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jb3JzL3Jlc291 cmNlcy9jYWNoZS0zMDQucHkgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2NvcnMvcmVzb3VyY2VzL2NhY2hlLTMwNC5weQpuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43YWNkZmQ2OTc2 ODIwMGRmMTA5ODFiYjMxYzk3NjM0ODAwYzc3NDQxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jb3JzL3Jlc291cmNlcy9jYWNo ZS0zMDQucHkKQEAgLTAsMCArMSwxMCBAQAorZGVmIG1haW4ocmVxdWVzdCwgcmVzcG9uc2UpOgor ICAgIG1hdGNoID0gcmVxdWVzdC5oZWFkZXJzLmdldCgiSWYtTm9uZS1NYXRjaCIsIE5vbmUpCisg ICAgaWYgbWF0Y2ggaXMgbm90IE5vbmUgYW5kIG1hdGNoID09ICJteWJlc3RzY3JpcHQtdjEiOgor ICAgICAgICByZXNwb25zZS5zdGF0dXMgPSAoMzA0LCAiWUVQIikKKyAgICAgICAgcmV0dXJuICIi CisgICAgcmVzcG9uc2UuaGVhZGVycy5zZXQoIkFjY2Vzcy1Db250cm9sLUFsbG93LU9yaWdpbiIs ICIqIikKKyAgICByZXNwb25zZS5oZWFkZXJzLnNldCgiQ2FjaGUtQ29udHJvbCIsICJtdXN0LXJl dmFsaWRhdGUiKQorICAgIHJlc3BvbnNlLmhlYWRlcnMuc2V0KCJFVGFnIiwgIm15YmVzdHNjcmlw dC12MSIpCisgICAgcmVzcG9uc2UuaGVhZGVycy5zZXQoIkNvbnRlbnQtVHlwZSIsICJ0ZXh0L2ph dmFzY3JpcHQiKQorICAgIHJldHVybiAiZnVuY3Rpb24gaGVwKCkgeyB9IgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jb3JzL3NjcmlwdC0z MDQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9jb3JzL3NjcmlwdC0zMDQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjcyODUxZmE5MjVi N2RmZmM2NWU0ZTNkNTdhOGY5OTNlN2M2NWE5NGUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2NvcnMvc2NyaXB0LTMwNC1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw0IEBACisKK1BBU1MgTG9hZCBhIGZyZXNoIGNyb3NzLW9yaWdp biBzY3JpcHQgCitQQVNTIFJlbG9hZCBzYW1lIGNyb3NzLW9yaWdpbiBzY3JpcHQgZnJvbSB0aGUg bWVtb3J5IGNhY2hlIGFmdGVyIHJldmFsaWRhdGlvbiAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jb3JzL3NjcmlwdC0zMDQuaHRtbCBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY29ycy9zY3JpcHQt MzA0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZTE2NGNhNmY0MWI3NjFjOTM4ODQ4NTQyOTg3NDJkZGY1MGM3 OWE5NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvY29ycy9zY3JpcHQtMzA0Lmh0bWwKQEAgLTAsMCArMSw0MCBAQAorPCFkb2N0 eXBlIGh0bWw+Cis8aHRtbD4KKyAgPGhlYWQ+CisgICAgPG1ldGEgY2hhcnNldD0idXRmLTgiPgor ICAgIDxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzLmpzIj48L3NjcmlwdD4KKyAg ICA8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+ CisgICAgPHNjcmlwdCBzcmM9Ii9jb21tb24vZ2V0LWhvc3QtaW5mby5zdWIuanMiPjwvc2NyaXB0 PgorICAgIDxzY3JpcHQgc3JjPSIvY29tbW9uL3V0aWxzLmpzIj48L3NjcmlwdD4KKyAgPC9oZWFk PgorICA8Ym9keT4KKyAgICA8ZGl2IGlkPSJ0ZXN0RGl2Ij48L2Rpdj4KKyAgICA8c2NyaXB0Pgor Citjb25zdCBzY3JpcHRVUkwgPSBnZXRfaG9zdF9pbmZvKCkuSFRUUF9SRU1PVEVfT1JJR0lOICsg Ii9jb3JzL3Jlc291cmNlcy9jYWNoZS0zMDQucHk/IiArIHRva2VuKCk7CisKK2Z1bmN0aW9uIGxv YWRTY3JpcHQodGVzdCkKK3sKKyAgICBjb25zdCBzY3JpcHQgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCJzY3JpcHQiKTsKKyAgICBzY3JpcHQuY3Jvc3NPcmlnaW4gPSAiYW5vbnltb3VzIjsKKyAg ICBzY3JpcHQuc3JjID0gc2NyaXB0VVJMOworICAgIHJldHVybiBuZXcgUHJvbWlzZSgocmVzb2x2 ZSwgcmVqZWN0KSA9PiB7CisgICAgICAgIC8vIExldCdzIGFkZCBhIHNtYWxsIHRpbWVvdXQgc28g dGhhdCB0aGUgc2NyaXB0IGlzIGZ1bGx5IGxvYWRlZCBpbiBtZW1vcnkgY2FjaGUgYmVmb3JlIHJl bG9hZGluZyBpdC4KKyAgICAgICAgc2NyaXB0Lm9ubG9hZCA9IHRlc3Quc3RlcF90aW1lb3V0KHJl c29sdmUsIDUwKTsKKyAgICAgICAgc2NyaXB0Lm9uZXJyb3IgPSByZWplY3Q7CisgICAgICAgIHRl c3REaXYuYXBwZW5kQ2hpbGQoc2NyaXB0KTsKKyAgICB9KTsKK30KKworcHJvbWlzZV90ZXN0KCh0 ZXN0KSA9PiB7CisgICAgcmV0dXJuIGxvYWRTY3JpcHQodGVzdCk7Cit9LCAiTG9hZCBhIGZyZXNo IGNyb3NzLW9yaWdpbiBzY3JpcHQiKTsKKworcHJvbWlzZV90ZXN0KCh0ZXN0KSA9PiB7CisgICAg cmV0dXJuIGxvYWRTY3JpcHQodGVzdCk7Cit9LCAiUmVsb2FkIHNhbWUgY3Jvc3Mtb3JpZ2luIHNj cmlwdCBmcm9tIHRoZSBtZW1vcnkgY2FjaGUgYWZ0ZXIgcmV2YWxpZGF0aW9uIik7CisKKzwvc2Ny aXB0PgorICA8L2JvZHk+Cis8L2h0bWw+CisK