186935 2018-06-22 11:55:16 -0700 Expose colorFilterEnabled SPI in WKPreferencesPrivate 2018-06-22 13:21:29 -0700 1 1 1 Unclassified WebKit WebKit API Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 luming_yin webkit-unassigned commit-queue luming_yin realdawei simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1435526 0 luming_yin 2018-06-22 11:55:16 -0700 We should expose the colorFilterEnabled SPI in WKPreferencesPrivate. 1435532 1 343350 luming_yin 2018-06-22 12:09:58 -0700 Created attachment 343350 Patch for bug 186935. 1435533 2 343350 thorton 2018-06-22 12:14:15 -0700 Comment on attachment 343350 Patch for bug 186935. View in context: https://bugs.webkit.org/attachment.cgi?id=343350&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:140 > +@property (nonatomic, setter=_setColorFilterEnabled:) BOOL _colorFilterEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA)); Needs WK_IOS_TBA 1435534 3 343351 luming_yin 2018-06-22 12:17:01 -0700 Created attachment 343351 Updated patch for bug 186935. 1435548 4 343351 commit-queue 2018-06-22 12:56:48 -0700 Comment on attachment 343351 Updated patch for bug 186935. Clearing flags on attachment: 343351 Committed r233089: <https://trac.webkit.org/changeset/233089> 1435549 5 commit-queue 2018-06-22 12:56:49 -0700 All reviewed patches have been landed. Closing bug. 1435552 6 webkit-bug-importer 2018-06-22 12:57:20 -0700 <rdar://problem/41378619> 1435560 7 realdawei 2018-06-22 13:11:34 -0700 Looks like this patch broke the iOS build sample output: https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6738/steps/compile-webkit/logs/stdio ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/slave/ios-simulator-11-release/build/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKPreferences-77E55B3F73300247.o UIProcess/API/Cocoa/WKPreferences.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) 1435568 8 thorton 2018-06-22 13:17:38 -0700 I’ll fix it. 1435570 9 thorton 2018-06-22 13:21:29 -0700 Build fix in https://trac.webkit.org/changeset/233094/webkit 343350 2018-06-22 12:09:58 -0700 2018-06-22 12:17:01 -0700 Patch for bug 186935. patch.diff text/plain 2394 luming_yin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTNmM2FkN2FjODcuLmIzNDE1ZjM4N2JkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE4LTA2LTIyICBMdW1pbmcgWWluICA8bHVtaW5nX3lpbkBhcHBsZS5jb20+CisK KyAgICAgICAgRXhwb3NlIGNvbG9yRmlsdGVyRW5hYmxlZCBTUEkgaW4gV0tQcmVmZXJlbmNlc1By aXZhdGUuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg2OTM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTEwOTM4Nz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBfc2V0Q29sb3JGaWx0 ZXJFbmFibGVkOl0pOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIF9jb2xvckZpbHRlckVuYWJs ZWRdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRl Lmg6CisKIDIwMTgtMDYtMTkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgW1dlYktpdCBvbiB3YXRjaE9TXSBWZW5kIHVzZXJuYW1lIHRleHQgY29udGVu dCB0eXBlIHdoZW4gdXNpbmcgc2NyaWJibGUgaW4gbG9naW4gZmllbGRzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCmluZGV4IDVmYzBi YzVhNzNhLi4xMTBhYThjZTU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0KQEAgLTg2Miw2ICs4NjIsMTYgQEAgLSAoQk9PTClf cGFnZUNhY2hlU3VwcG9ydHNQbHVnaW5zCiAgICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+cGFnZUNh Y2hlU3VwcG9ydHNQbHVnaW5zKCk7CiB9CiAKKy0gKHZvaWQpX3NldENvbG9yRmlsdGVyRW5hYmxl ZDooQk9PTCllbmFibGVkCit7CisgICAgX3ByZWZlcmVuY2VzLT5zZXRDb2xvckZpbHRlckVuYWJs ZWQoZW5hYmxlZCk7Cit9CisKKy0gKEJPT0wpX2NvbG9yRmlsdGVyRW5hYmxlZAoreworICAgIHJl dHVybiBfcHJlZmVyZW5jZXMtPmNvbG9yRmlsdGVyRW5hYmxlZCgpOworfQorCiAtICh2b2lkKV9z ZXRTaG91bGRQcmludEJhY2tncm91bmRzOihCT09MKWVuYWJsZWQKIHsKICAgICBfcHJlZmVyZW5j ZXMtPnNldFNob3VsZFByaW50QmFja2dyb3VuZHMoZW5hYmxlZCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oCmlu ZGV4IGMwMDVmY2JjMjdmLi42YzE0YWYzZTZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTEzNyw2 ICsxMzcsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tFZGl0YWJsZUxpbmtCZWhh dmlvcikgewogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0U2hvdWxkRW5hYmxlVGV4 dEF1dG9zaXppbmdCb29zdDopIEJPT0wgX3Nob3VsZEVuYWJsZVRleHRBdXRvc2l6aW5nQm9vc3Qg V0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAK IEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldFN0b3JhZ2VBY2Nlc3NQcm9tcHRzRW5h YmxlZDopIEJPT0wgX3N0b3JhZ2VBY2Nlc3NQcm9tcHRzRW5hYmxlZCBXS19BUElfQVZBSUxBQkxF KG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKK0Bwcm9wZXJ0eSAobm9uYXRv bWljLCBzZXR0ZXI9X3NldENvbG9yRmlsdGVyRW5hYmxlZDopIEJPT0wgX2NvbG9yRmlsdGVyRW5h YmxlZCBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSk7CiAKICNpZiAhVEFSR0VU X09TX0lQSE9ORQogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0V2ViR0xFbmFibGVk OikgQk9PTCBfd2ViR0xFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzLjQpKTsK 343351 2018-06-22 12:17:01 -0700 2018-06-22 12:56:48 -0700 Updated patch for bug 186935. patch.diff text/plain 2411 luming_yin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTNmM2FkN2FjODcuLmIzNDE1ZjM4N2JkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE4LTA2LTIyICBMdW1pbmcgWWluICA8bHVtaW5nX3lpbkBhcHBsZS5jb20+CisK KyAgICAgICAgRXhwb3NlIGNvbG9yRmlsdGVyRW5hYmxlZCBTUEkgaW4gV0tQcmVmZXJlbmNlc1By aXZhdGUuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg2OTM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTEwOTM4Nz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBfc2V0Q29sb3JGaWx0 ZXJFbmFibGVkOl0pOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIF9jb2xvckZpbHRlckVuYWJs ZWRdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRl Lmg6CisKIDIwMTgtMDYtMTkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgW1dlYktpdCBvbiB3YXRjaE9TXSBWZW5kIHVzZXJuYW1lIHRleHQgY29udGVu dCB0eXBlIHdoZW4gdXNpbmcgc2NyaWJibGUgaW4gbG9naW4gZmllbGRzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCmluZGV4IDVmYzBi YzVhNzNhLi4xMTBhYThjZTU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0KQEAgLTg2Miw2ICs4NjIsMTYgQEAgLSAoQk9PTClf cGFnZUNhY2hlU3VwcG9ydHNQbHVnaW5zCiAgICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+cGFnZUNh Y2hlU3VwcG9ydHNQbHVnaW5zKCk7CiB9CiAKKy0gKHZvaWQpX3NldENvbG9yRmlsdGVyRW5hYmxl ZDooQk9PTCllbmFibGVkCit7CisgICAgX3ByZWZlcmVuY2VzLT5zZXRDb2xvckZpbHRlckVuYWJs ZWQoZW5hYmxlZCk7Cit9CisKKy0gKEJPT0wpX2NvbG9yRmlsdGVyRW5hYmxlZAoreworICAgIHJl dHVybiBfcHJlZmVyZW5jZXMtPmNvbG9yRmlsdGVyRW5hYmxlZCgpOworfQorCiAtICh2b2lkKV9z ZXRTaG91bGRQcmludEJhY2tncm91bmRzOihCT09MKWVuYWJsZWQKIHsKICAgICBfcHJlZmVyZW5j ZXMtPnNldFNob3VsZFByaW50QmFja2dyb3VuZHMoZW5hYmxlZCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oCmlu ZGV4IGMwMDVmY2JjMjdmLi4zNzM4NmQ0MjNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTEzNyw2 ICsxMzcsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tFZGl0YWJsZUxpbmtCZWhh dmlvcikgewogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0U2hvdWxkRW5hYmxlVGV4 dEF1dG9zaXppbmdCb29zdDopIEJPT0wgX3Nob3VsZEVuYWJsZVRleHRBdXRvc2l6aW5nQm9vc3Qg V0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAK IEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldFN0b3JhZ2VBY2Nlc3NQcm9tcHRzRW5h YmxlZDopIEJPT0wgX3N0b3JhZ2VBY2Nlc3NQcm9tcHRzRW5hYmxlZCBXS19BUElfQVZBSUxBQkxF KG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKK0Bwcm9wZXJ0eSAobm9uYXRv bWljLCBzZXR0ZXI9X3NldENvbG9yRmlsdGVyRW5hYmxlZDopIEJPT0wgX2NvbG9yRmlsdGVyRW5h YmxlZCBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEp KTsKIAogI2lmICFUQVJHRVRfT1NfSVBIT05FCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVy PV9zZXRXZWJHTEVuYWJsZWQ6KSBCT09MIF93ZWJHTEVuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRSht YWNvc3goMTAuMTMuNCkpOwo=