186913 2018-06-22 01:47:55 -0700 [GLIB] Several TestSSL tests are failing only in the bots 2018-10-29 13:32:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned csaavedra lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1435384 0 cgarcia 2018-06-22 01:47:55 -0700 /webkit/WebKitWebView/tls-errors-policy: FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:44:virtual void SSLTest::provisionalLoadFailed(const gchar*, GError*): assertion failed (error == (soup_http_error_quark, 6)): WebKit encountered an internal error (WebKitErrorDomain, 300) (process:67260): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed /webkit/WebKitWebView/load-failed-with-tls-errors: FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:44:virtual void SSLTest::provisionalLoadFailed(const gchar*, GError*): assertion failed (error == (soup_http_error_quark, 6)): WebKit encountered an internal error (WebKitErrorDomain, 300) (process:67377): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed I can't reproduce this locally. It happens in the bots for both GTK and WPE. 1445808 1 mcatanzaro 2018-07-27 12:31:00 -0700 Also /webkit/WebKitWebView/tls-subresource (flaky): /webkit/WebKitWebView/tls-subresource: FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:298:static void TLSSubresourceTest::subresourceFailedCallback(WebKitWebResource*, GError*): code should not be reached There's also a huge amount of warnings, which are *not* failing the tests, which is bad. I think the problem is the warnings are coming from the network or web process. UI process warnings would surely cause the tests to fail. I think we should run the tests with G_DEBUG=fatal-warnings to ensure these don't get ignored: TEST: ./Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestSSL... /webkit/WebKitWebView/ssl: PASS /webkit/WebKitWebView/insecure-content: PASS /webkit/WebKitWebView/tls-errors-policy: PASS (process:2989): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed /webkit/WebKitWebView/tls-errors-redirect-to-http: PASS (process:3031): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed /webkit/WebKitWebView/tls-http-auth: PASS (process:3059): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed /webkit/WebKitWebView/tls-subresource: FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:298:static void TLSSubresourceTest::subresourceFailedCallback(WebKitWebResource*, GError*): code should not be reached (process:3087): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed /webkit/WebKitWebView/load-failed-with-tls-errors: FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:267:void testLoadFailedWithTLSErrors(TLSErrorsTest*, gconstpointer): assertion failed (test->m_loadEvents[1] == LoadTrackingTest::LoadCommitted): (6 == 3) (process:3118): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed (process:3144): GLib-GIO-CRITICAL **: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed /webkit/WebKitWebView/web-socket-tls-errors: PASS libsoup-DEBUG: stopping input source libsoup-DEBUG: closing io stream libsoup-DEBUG: closed: completed io stream close libsoup-DEBUG: stopping input source libsoup-DEBUG: closing io stream libsoup-DEBUG: closed: completed io stream close 1472874 2 csaavedra 2018-10-29 01:17:47 -0700 Carlos had fixed this in libsoup some time ago but the patch was not added to jhbuild. I did last week so this is not failing anymore. 1472875 3 csaavedra 2018-10-29 01:23:04 -0700 Committed r237542: <https://trac.webkit.org/changeset/237542> 1473026 4 webkit-bug-importer 2018-10-29 13:32:32 -0700 <rdar://problem/45647195>