186901 2018-06-21 16:58:50 -0700 skip imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html 2018-07-17 13:52:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 realdawei webkit-unassigned lforschler ryanhaddad webkit-bug-importer zalan oldest_to_newest 1435308 0 realdawei 2018-06-21 16:58:50 -0700 temporarily Skipping imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html because it has failed ever since it was merged. sample results: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r233036%20(8249)/imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002-stderr.txt ASSERTION FAILED: !beforeChild || beforeChild->parent() == &parent ./rendering/updating/RenderTreeBuilder.cpp(404) : void WebCore::RenderTreeBuilder::attachToRenderElementInternal(WebCore::RenderElement &, RenderPtr<WebCore::RenderObject>, WebCore::RenderObject *) 1 0x10900ecc9 WTFCrash 2 0x1156b8038 WebCore::RenderTreeBuilder::attachToRenderElementInternal(WebCore::RenderElement&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>, WebCore::RenderObject*) 3 0x1156b2b93 WebCore::RenderTreeBuilder::attachToRenderElement(WebCore::RenderElement&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>, WebCore::RenderObject*) 4 0x1156b3f00 WebCore::RenderTreeBuilder::Inline::attachIgnoringContinuation(WebCore::RenderInline&, std::__1::unique_ptr<WebCore::RenderObject, WebCore::RenderObjectDeleter>, 1435328 1 zalan 2018-06-21 17:30:16 -0700 Didn't r233055 fix the assertion? (It still fails, I know, but the assertion should be all gone after r233055) 1435329 2 realdawei 2018-06-21 17:35:01 -0700 (In reply to zalan from comment #1) > Didn't r233055 fix the assertion? (It still fails, I know, but the assertion > should be all gone after r233055) Ah yes you're right. Assertion is gone, now it just fails. I hold off on the skip 1435728 3 ryanhaddad 2018-06-22 17:58:56 -0700 It looks like the test was skipped in https://trac.webkit.org/changeset/233069/webkit, so we should probably undo that. 1442775 4 ryanhaddad 2018-07-17 13:51:11 -0700 Unskipped in https://trac.webkit.org/r233895 1442776 5 webkit-bug-importer 2018-07-17 13:52:19 -0700 <rdar://problem/42300426>