186881 2018-06-21 01:41:15 -0700 Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants. 2018-06-27 02:37:25 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emilio emilio commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1435054 0 emilio 2018-06-21 01:41:15 -0700 Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants. 1435056 1 343225 emilio 2018-06-21 01:45:55 -0700 Created attachment 343225 Patch 1436658 2 koivisto 2018-06-26 14:08:25 -0700 r=me 1436906 3 343225 commit-queue 2018-06-27 02:28:34 -0700 Comment on attachment 343225 Patch Rejecting attachment 343225 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343225, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=343225&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=186881&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 343225 from bug 186881. Fetching: https://bugs.webkit.org/attachment.cgi?id=343225 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej patching file Source/WebCore/style/StyleTreeResolver.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/8356970 1436908 4 emilio 2018-06-27 02:34:32 -0700 Committed r233251: <https://trac.webkit.org/changeset/233251> 1436909 5 webkit-bug-importer 2018-06-27 02:37:25 -0700 <rdar://problem/41514587> 343225 2018-06-21 01:45:55 -0700 2018-06-27 02:28:34 -0700 Patch bug-186881-20180621104553.patch text/plain 3626 emilio U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI3MWJmYjJhOGI0MGM5 Njc4MzBiMDE4ODVkMWYyYTVhN2I1MWFkOC4uY2NkM2I2YjJmZjJiNTQyNzM4OWE0MjVmYjBmZjUw YjhmN2JmNjkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw4ICsxLDIzIEBACisyMDE4LTA2LTIxICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlvPgorCisgICAgICAgIE1vdmUgY2xl YXJDaGlsZE5lZWRzU3R5bGVSZWNhbGMgaW50byByZXNldFN0eWxlRm9yTm9uUmVuZGVyZWREZXNj ZW5kYW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4Njg4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEV2ZXJ5IGNhbGxlciBkb2VzIHRoaXMgYWxyZWFkeS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHN0eWxlL1N0eWxlVHJlZVJlc29s dmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjpyZXNldFN0eWxlRm9yTm9uUmVuZGVy ZWREZXNjZW5kYW50cyk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6VHJlZVJlc29sdmVyOjpy ZXNvbHZlQ29tcG9zZWRUcmVlKToKKwogMjAxOC0wNi0yMCAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBsZWFrcyBpbiBXZWJDb3JlIGZvdW5kIGJ5IGNs YW5nIHN0YXRpYyBhbmFseXplciBpbiBkZWVwIG1vZGUKICAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzE4Njg2NT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCiAK ICAgICAgICAgKiBwbGF0Zm9ybS9tYWMvV2ViQ29yZU5TVVJMRXh0cmFzLm1tOgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVUcmVlUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvc3R5bGUvU3R5bGVUcmVlUmVzb2x2ZXIuY3BwCmluZGV4IGU1NGNlNTIxMGUxYzMzNWM5 MjU0MzA0NjY5MGFjYTEwYzJlZjFmNzcuLjcwODNkZDIyNmRhYTBjMmEzODZjMzBhOWNmYjA1MzJk OGJmNGI2N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlVHJlZVJlc29s dmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVRyZWVSZXNvbHZlci5jcHAK QEAgLTE0MCwyMSArMTQwLDIwIEBAIHN0YXRpYyB2b2lkIHJlc2V0U3R5bGVGb3JOb25SZW5kZXJl ZERlc2NlbmRhbnRzKEVsZW1lbnQmIGN1cnJlbnQpCiB7CiAgICAgZm9yIChhdXRvJiBjaGlsZCA6 IGNoaWxkcmVuT2ZUeXBlPEVsZW1lbnQ+KGN1cnJlbnQpKSB7CiAgICAgICAgIGlmIChjaGlsZC5u ZWVkc1N0eWxlUmVjYWxjKCkpIHsKICAgICAgICAgICAgIGNoaWxkLnJlc2V0Q29tcHV0ZWRTdHls ZSgpOwogICAgICAgICAgICAgY2hpbGQucmVzZXRTdHlsZVJlbGF0aW9ucygpOwogICAgICAgICAg ICAgY2hpbGQuc2V0SGFzVmFsaWRTdHlsZSgpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKGNo aWxkLmNoaWxkTmVlZHNTdHlsZVJlY2FsYygpKSB7CisgICAgICAgIGlmIChjaGlsZC5jaGlsZE5l ZWRzU3R5bGVSZWNhbGMoKSkKICAgICAgICAgICAgIHJlc2V0U3R5bGVGb3JOb25SZW5kZXJlZERl c2NlbmRhbnRzKGNoaWxkKTsKLSAgICAgICAgICAgIGNoaWxkLmNsZWFyQ2hpbGROZWVkc1N0eWxl UmVjYWxjKCk7Ci0gICAgICAgIH0KICAgICB9CisgICAgY3VycmVudC5jbGVhckNoaWxkTmVlZHNT dHlsZVJlY2FsYygpOwogfQogCiBzdGF0aWMgYm9vbCBhZmZlY3RzUmVuZGVyZWRTdWJ0cmVlKEVs ZW1lbnQmIGVsZW1lbnQsIGNvbnN0IFJlbmRlclN0eWxlJiBuZXdTdHlsZSkKIHsKICAgICBpZiAo ZWxlbWVudC5yZW5kZXJlcigpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAobmV3U3R5 bGUuZGlzcGxheSgpICE9IERpc3BsYXlUeXBlOjpOb25lKQogICAgICAgICByZXR1cm4gdHJ1ZTsK QEAgLTQ3OCwxNyArNDc3LDE2IEBAIHZvaWQgVHJlZVJlc29sdmVyOjpyZXNvbHZlQ29tcG9zZWRU cmVlKCkKICAgICAgICAgICAgIGl0LnRyYXZlcnNlTmV4dFNraXBwaW5nQ2hpbGRyZW4oKTsKICAg ICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CiAKICAgICAgICAgYXV0byYgZWxlbWVudCA9 IGRvd25jYXN0PEVsZW1lbnQ+KG5vZGUpOwogCiAgICAgICAgIGlmIChpdC5kZXB0aCgpID4gU2V0 dGluZ3M6OmRlZmF1bHRNYXhpbXVtUmVuZGVyVHJlZURlcHRoKSB7CiAgICAgICAgICAgICByZXNl dFN0eWxlRm9yTm9uUmVuZGVyZWREZXNjZW5kYW50cyhlbGVtZW50KTsKLSAgICAgICAgICAgIGVs ZW1lbnQuY2xlYXJDaGlsZE5lZWRzU3R5bGVSZWNhbGMoKTsKICAgICAgICAgICAgIGl0LnRyYXZl cnNlTmV4dFNraXBwaW5nQ2hpbGRyZW4oKTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICB9CiAKICAgICAgICAgYXV0byogc3R5bGUgPSByZW5kZXJPckRpc3BsYXlDb250ZW50c1N0eWxl KGVsZW1lbnQpOwogICAgICAgICBhdXRvIGNoYW5nZSA9IE5vQ2hhbmdlOwogICAgICAgICBhdXRv IGRlc2NlbmRhbnRzVG9SZXNvbHZlID0gRGVzY2VuZGFudHNUb1Jlc29sdmU6Ok5vbmU7CiAKQEAg LTUxMSwyMCArNTA5LDE4IEBAIHZvaWQgVHJlZVJlc29sdmVyOjpyZXNvbHZlQ29tcG9zZWRUcmVl KCkKICAgICAgICAgICAgIGRlc2NlbmRhbnRzVG9SZXNvbHZlID0gZWxlbWVudFVwZGF0ZXMuZGVz Y2VuZGFudHNUb1Jlc29sdmU7CiAKICAgICAgICAgICAgIGlmIChlbGVtZW50VXBkYXRlcy51cGRh dGUuc3R5bGUpCiAgICAgICAgICAgICAgICAgbV91cGRhdGUtPmFkZEVsZW1lbnQoZWxlbWVudCwg cGFyZW50LmVsZW1lbnQsIFdURk1vdmUoZWxlbWVudFVwZGF0ZXMpKTsKIAogICAgICAgICAgICAg Y2xlYXJOZWVkc1N0eWxlUmVzb2x1dGlvbihlbGVtZW50KTsKICAgICAgICAgfQogCi0gICAgICAg IGlmICghc3R5bGUpIHsKKyAgICAgICAgaWYgKCFzdHlsZSkKICAgICAgICAgICAgIHJlc2V0U3R5 bGVGb3JOb25SZW5kZXJlZERlc2NlbmRhbnRzKGVsZW1lbnQpOwotICAgICAgICAgICAgZWxlbWVu dC5jbGVhckNoaWxkTmVlZHNTdHlsZVJlY2FsYygpOwotICAgICAgICB9CiAKICAgICAgICAgYm9v bCBzaG91bGRJdGVyYXRlQ2hpbGRyZW4gPSBzdHlsZSAmJiAoZWxlbWVudC5jaGlsZE5lZWRzU3R5 bGVSZWNhbGMoKSB8fCBkZXNjZW5kYW50c1RvUmVzb2x2ZSAhPSBEZXNjZW5kYW50c1RvUmVzb2x2 ZTo6Tm9uZSk7CiAKICAgICAgICAgaWYgKCFtX2RpZFNlZVBlbmRpbmdTdHlsZXNoZWV0KQogICAg ICAgICAgICAgbV9kaWRTZWVQZW5kaW5nU3R5bGVzaGVldCA9IGhhc0xvYWRpbmdTdHlsZXNoZWV0 KG1fZG9jdW1lbnQuc3R5bGVTY29wZSgpLCBlbGVtZW50LCAhc2hvdWxkSXRlcmF0ZUNoaWxkcmVu KTsKIAogICAgICAgICBpZiAoIXNob3VsZEl0ZXJhdGVDaGlsZHJlbikgewogICAgICAgICAgICAg aXQudHJhdmVyc2VOZXh0U2tpcHBpbmdDaGlsZHJlbigpOwo=