186880 2018-06-21 01:10:02 -0700 [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add 2018-06-21 08:38:27 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180253 P2 Normal --- 1 fujii fujii aboya bugs-noreply calvaris mcatanzaro oldest_to_newest 1435050 0 fujii 2018-06-21 01:10:02 -0700 [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add Some LayoutTests fails. See Bug 180253 and Bug 116977 Comment 2 for detail. Callstack: > Thread 1 (Thread 0x7f0b1787af80 (LWP 4274)): > #0 0x00007f0b021173da in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:267 > #1 0x00007f0b115bebab in WebCore::PlatformTimeRanges::add (this=0x55e71ced1de0, start=..., end=...) at ../../Source/WebCore/platform/graphics/PlatformTimeRanges.cpp:139 > #2 0x00007f0b11edb993 in WebCore::MediaPlayerPrivateGStreamer::buffered (this=0x7f0a8b078000) at ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1116 > #3 0x00007f0b115a6e5c in WebCore::MediaPlayer::buffered (this=0x7f0af0054a80) at ../../Source/WebCore/platform/graphics/MediaPlayer.cpp:818 > #4 0x00007f0b10e761c2 in WebCore::HTMLMediaElement::buffered (this=0x7f0a8a2007b0) at ../../Source/WebCore/html/HTMLMediaElement.cpp:5081 > #5 0x00007f0b0fbd3613 in WebCore::jsHTMLMediaElementBufferedGetter (state=..., thisObject=..., throwScope=...) at DerivedSources/WebCore/JSHTMLMediaElement.cpp:686 (...) 1435061 1 343227 fujii 2018-06-21 02:20:13 -0700 Created attachment 343227 Patch 1435062 2 fujii 2018-06-21 02:23:35 -0700 This assertion failure is annoying. Looking into the code, I've found strange code in MediaPlayerPrivateGStreamer::buffered. I'd like to propose this patch. 1435063 3 calvaris 2018-06-21 02:30:30 -0700 LGTM. Alicia, what do you think? 1435067 4 343227 aboya 2018-06-21 02:58:41 -0700 Comment on attachment 343227 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343227&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1116 > + if (loaded.isValid() && loaded) LGTM. This will still create an empty [0, 0) range in some situations though. It maybe good to add `&& loaded > MediaTime::zeroTime()` to avoid that. 1435070 5 aboya 2018-06-21 03:03:04 -0700 (In reply to Alicia Boya García from comment #4) > Comment on attachment 343227 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343227&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1116 > > + if (loaded.isValid() && loaded) > > LGTM. This will still create an empty [0, 0) range in some situations > though. It maybe good to add `&& loaded > MediaTime::zeroTime()` to avoid > that. Nevermind, `loaded` already is true if different than zero. 1435072 6 fujii 2018-06-21 03:10:20 -0700 (In reply to Alicia Boya García from comment #5) > Nevermind, `loaded` already is true if different than zero. Agreed. Thank you for the review, Alicia. 1435073 7 fujii 2018-06-21 03:15:23 -0700 Committed r233033: <https://trac.webkit.org/changeset/233033> 1435126 8 343227 mcatanzaro 2018-06-21 08:38:27 -0700 Comment on attachment 343227 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343227&action=review > Source/WebCore/ChangeLog:18 > + No new tests (No behavior change). Nit: if there was no behavior change, then the execution of the program would not be visibly different. So there is definitely a behavior change: you fixed a crash! Instead, I would have mentioned that this fixed existing tests. 343227 2018-06-21 02:20:13 -0700 2018-06-21 03:07:46 -0700 Patch bug-186880-20180621022005.patch text/plain 5381 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI3MWJmYjJhOGI0MGM5 Njc4MzBiMDE4ODVkMWYyYTVhN2I1MWFkOC4uNDFkZmJjMWM5YTFiMWUwNzI2OWY5NzU5MzU3NDM1 YjExYjQwN2NjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTA2LTIxICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtHU3RyZWFt ZXJdIEFTU0VSVElPTiBGQUlMRUQ6IGVuZC5pc1ZhbGlkKCkgaW4gUGxhdGZvcm1UaW1lUmFuZ2Vz OjphZGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 Njg4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1 ZyAxODAyNTMgaGFzIGFkZGVkIGFzc2VydGlvbnMgdGhlIGFydWdtZW50cyBgc3RhcnRgIGFuZCBg ZW5kYCBpcworICAgICAgICB2YWxpZCBNZWRpYVRpbWUgaW4gUGxhdGZvcm1UaW1lUmFuZ2VzOjph ZGQuIFNpbmNlIHRoZW4sIHNvbWUKKyAgICAgICAgTGF5b3V0VGVzdHMgZmFpbCBkdWUgdG8gdGhl IGFzc2VydGlvbiBmYWlsdXJlLgorCisgICAgICAgIFRoZSBpbnZhbGlkIE1lZGlhVGltZSBpcyBh ZGRlZCBpbnRvIHRoZSBQbGF0Zm9ybVRpbWVSYW5nZXMgaW4KKyAgICAgICAgTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpidWZmZXJlZC4gQmVmb3JlIGFkZGluZyBNZWRpYVRpbWUsCisgICAg ICAgIG9yaWdpbmFsIGltcGxlbWVudGF0aW9uIGNoZWNrcyBNZWRpYVRpbWU6Om9wZXJhdG9yIGJv b2woKSByZXR1cm5zCisgICAgICAgIHRydWUuIEJ1dCwgdGhpcyBtZXRob2QgcmV0dXJucyB0cnVl IGlmIHRoZSB0aW1lIHZhbHVlIGlzIGludmFsaWQuCisgICAgICAgIFRoZW4sIFBsYXRmb3JtVGlt ZVJhbmdlczo6YWRkIGlzIGNhbGxlZCB3aXRoIGFuIGludmFsaWQgTWVkaWFUaW1lLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyAoTm8gYmVoYXZpb3IgY2hhbmdlKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpidWZmZXJlZCBj b25zdCk6IENoZWNrCisgICAgICAgIG1heFRpbWVMb2FkZWQoKSBpcyB2YWxpZCBiZWZvcmUgYWRk aW5nIHRvIGB0aW1lUmFuZ2VzYC4KKwogMjAxOC0wNi0yMCAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBsZWFrcyBpbiBXZWJDb3JlIGZvdW5kIGJ5IGNs YW5nIHN0YXRpYyBhbmFseXplciBpbiBkZWVwIG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggOWEwNzExZTczZGRhMDA2ODA1NTQzMzE4 ZTM5NzBhNDQ1YTAzZTRiYS4uZWJjMDQ3MmQ2ZWY1NGI2YzM5NjQyY2IyYWNkMjQxZjA1NjM2NmVm MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAK QEAgLTExMTIsNyArMTExMiw4IEBAIHN0ZDo6dW5pcXVlX3B0cjxQbGF0Zm9ybVRpbWVSYW5nZXM+ IE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6YnVmZmVyZWQoKSBjb25zCiAgICAgLy8gRmFs bGJhY2sgdG8gdGhlIG1vcmUgZ2VuZXJhbCBtYXhUaW1lTG9hZGVkKCkgaWYgbm8gcmFuZ2UgaGFz CiAgICAgLy8gYmVlbiBmb3VuZC4KICAgICBpZiAoIXRpbWVSYW5nZXMtPmxlbmd0aCgpKSB7Ci0g ICAgICAgIGlmIChNZWRpYVRpbWUgbG9hZGVkID0gbWF4VGltZUxvYWRlZCgpKQorICAgICAgICBN ZWRpYVRpbWUgbG9hZGVkID0gbWF4VGltZUxvYWRlZCgpOworICAgICAgICBpZiAobG9hZGVkLmlz VmFsaWQoKSAmJiBsb2FkZWQpCiAgICAgICAgICAgICB0aW1lUmFuZ2VzLT5hZGQoTWVkaWFUaW1l Ojp6ZXJvVGltZSgpLCBsb2FkZWQpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQyZDY4MzQwMzQwODE5NmRm NzdhYjVkNDdjNTQyZDgzZGI2NDBiOGUuLmExZDZmMjYxOWRkNmQ3ODUyMzJjNTgzYzM3OWQ3NDEy MjlkMWIwNWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxOC0wNi0yMSAgRnVqaWkgSGlyb25v cmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBBU1NF UlRJT04gRkFJTEVEOiBlbmQuaXNWYWxpZCgpIGluIFBsYXRmb3JtVGltZVJhbmdlczo6YWRkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY4ODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L2d0ay9UZXN0RXhwZWN0YXRpb25zOiBSZW1vdmVkIENyYXNoIG1hcmtzIG9mCisgICAgICAgIGNv bXBvc2l0aW5nL2dlb21ldHJ5L2NsaXBwZWQtdmlkZW8tY29udHJvbGxlci5odG1sLAorICAgICAg ICBmYXN0L2NhbnZhcy93ZWJnbC9vZXMtdGV4dHVyZS1oYWxmLWZsb2F0LXdpdGgtdmlkZW8uaHRt bCwKKyAgICAgICAgZmFzdC9jYW52YXMvd2ViZ2wvdGV4LWltYWdlLWFuZC1zdWItaW1hZ2UtMmQt d2l0aC12aWRlby1yZ2I1NjUuaHRtbCwKKyAgICAgICAgZmFzdC9jYW52YXMvd2ViZ2wvdGV4LWlt YWdlLWFuZC1zdWItaW1hZ2UtMmQtd2l0aC12aWRlby1yZ2JhNTU1MS5odG1sLAorICAgICAgICBm YXN0L2NhbnZhcy93ZWJnbC90ZXgtaW1hZ2UtYW5kLXN1Yi1pbWFnZS0yZC13aXRoLXZpZGVvLmh0 bWwsCisgICAgICAgIGZhc3QvZXZlbnRzL21lZGlhLWZvY3VzLWluLXN0YW5kYWxvbmUtbWVkaWEt ZG9jdW1lbnQuaHRtbCwKKyAgICAgICAgZnVsbHNjcmVlbi92aWRlby1jb250cm9scy10aW1lbGlu ZS5odG1sLAorICAgICAgICBodHRwL3Rlc3RzL2FwcGNhY2hlL3ZpZGVvLmh0bWwsIGFuZCBjb21w b3NpdGluZy92aWRlby9wb3N0ZXIuaHRtbC4KKwogMjAxOC0wNi0yMCAgUGVyIEFybmUgVm9sbGFu ICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IFRlc3QgaW1wb3J0ZWQvbW96 aWxsYS9jc3MtYW5pbWF0aW9ucy90ZXN0X3BzZXVkb0VsZW1lbnQtZ2V0LWFuaW1hdGlvbnMuaHRt bCBpcyBmYWlsaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpp bmRleCAwMzM3NjAzNDAyNThhOWJlYzlkYWZkNmZhYjAzNmZkNjQzOTg0ZjgyLi5lMDc5OWQ3MjIz YmJiMTViMGU0NTYwODdmNGRiMTAxNzk2Y2Q1MDNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI4NCwxNSArMTI4NCw2IEBAIHdlYmtpdC5vcmcvYi8x ODU1NDYgbWVkaWEvdmlkZW8tcGxheWJhY2tyYXRlLmh0bWwgWyBDcmFzaCBQYXNzIF0KIAogd2Vi a2l0Lm9yZy9iLzE4NTkxMCBtZWRpYS92aWRlby1kdXJhdGlvbi1rbm93bi1hZnRlci1lb3MuaHRt bCBbIENyYXNoIFBhc3MgXQogCi13ZWJraXQub3JnL2IvMTgwMjUzIFsgRGVidWcgXSBjb21wb3Np dGluZy9nZW9tZXRyeS9jbGlwcGVkLXZpZGVvLWNvbnRyb2xsZXIuaHRtbCBbIENyYXNoIF0KLXdl YmtpdC5vcmcvYi8xODAyNTMgWyBEZWJ1ZyBdIGZhc3QvY2FudmFzL3dlYmdsL29lcy10ZXh0dXJl LWhhbGYtZmxvYXQtd2l0aC12aWRlby5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzE4MDI1 MyBbIERlYnVnIF0gZmFzdC9jYW52YXMvd2ViZ2wvdGV4LWltYWdlLWFuZC1zdWItaW1hZ2UtMmQt d2l0aC12aWRlby1yZ2I1NjUuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8xODAyNTMgWyBE ZWJ1ZyBdIGZhc3QvY2FudmFzL3dlYmdsL3RleC1pbWFnZS1hbmQtc3ViLWltYWdlLTJkLXdpdGgt dmlkZW8tcmdiYTU1NTEuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8xODAyNTMgWyBEZWJ1 ZyBdIGZhc3QvY2FudmFzL3dlYmdsL3RleC1pbWFnZS1hbmQtc3ViLWltYWdlLTJkLXdpdGgtdmlk ZW8uaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8xODAyNTMgWyBEZWJ1ZyBdIGZhc3QvZXZl bnRzL21lZGlhLWZvY3VzLWluLXN0YW5kYWxvbmUtbWVkaWEtZG9jdW1lbnQuaHRtbCBbIENyYXNo IF0KLXdlYmtpdC5vcmcvYi8xODAyNTMgWyBEZWJ1ZyBdIGZ1bGxzY3JlZW4vdmlkZW8tY29udHJv bHMtdGltZWxpbmUuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8xODAyNTMgWyBEZWJ1ZyBd IGh0dHAvdGVzdHMvYXBwY2FjaGUvdmlkZW8uaHRtbCBbIENyYXNoIF0KLQogIyBDcmFzaGVzIG9u bHkgd2hlbiBHTk9NRSBpY29uIHRoZW1lIGlzIG5vdCBpbnN0YWxsZWQKIHdlYmtpdC5vcmcvYi8x ODY3NjcgZmFzdC9oaWRwaS9icm9rZW4taW1hZ2UtaWNvbi12ZXJ5LWhpZHBpLmh0bWwgWyBDcmFz aCBQYXNzIF0KIApAQCAtMTkzMSw4ICsxOTIyLDcgQEAgd2Via2l0Lm9yZy9iLzE4MzYwOCBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1dlYkNyeXB0b0FQSS93cmFwS2V5X3Vud3JhcEsK IAogd2Via2l0Lm9yZy9iLzE4MzYwOSBpbnNwZWN0b3IvdW5pdC10ZXN0cy90aHJvdHRsZS5odG1s IFsgUGFzcyBGYWlsdXJlIF0KIAotIyBDcmFzaCBpcyBidWcgIzE4MDI1Mwotd2Via2l0Lm9yZy9i LzE4MzIxNCBjb21wb3NpdGluZy92aWRlby9wb3N0ZXIuaHRtbCBbIFBhc3MgSW1hZ2VPbmx5RmFp bHVyZSBDcmFzaCBdCit3ZWJraXQub3JnL2IvMTgzMjE0IGNvbXBvc2l0aW5nL3ZpZGVvL3Bvc3Rl ci5odG1sIFsgUGFzcyBJbWFnZU9ubHlGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE4MzkwMyBo dHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWJ1ZmZlcmVkLXJhbmdlLWNvbnRhaW5zLWN1cnJlbnRUaW1l Lmh0bWwgWyBDcmFzaCBQYXNzIF0KIAo=