186872 2018-06-20 19:50:34 -0700 [ews-build] unit-tests fail when run from another directory 2018-06-21 11:53:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dean_johnson lforschler webkit-bug-importer oldest_to_newest 1434987 0 aakash_jain 2018-06-20 19:50:34 -0700 unit-tests fail when run from another directory, e.g.: [~/code/OpenSource/Tools/BuildSlaveSupport]$python ews-build/loadConfig_unittest.py E.................. ====================================================================== ERROR: test_configuration (__main__.ConfigDotJSONTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "ews-build/loadConfig_unittest.py", line 33, in test_configuration loadConfig.loadBuilderConfig({}) File "/Users/jain/code1/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig.py", line 39, in loadBuilderConfig config = json.load(open(os.path.join(master_prefix_path, 'config.json'))) IOError: [Errno 2] No such file or directory: './config.json' ---------------------------------------------------------------------- Ran 19 tests in 0.001s FAILED (errors=1) [~/code/OpenSource/Tools/BuildSlaveSupport]$cd ews-build [~/code/OpenSource/Tools/BuildSlaveSupport/ews-build]$python loadConfig_unittest.py ................... ---------------------------------------------------------------------- Ran 19 tests in 0.004s OK 1434993 1 343204 aakash_jain 2018-06-20 19:54:39 -0700 Created attachment 343204 Proposed patch Add support for passing master_prefix_path in loadConfig.py. This is similar to what we do in other similar Buildbot related code. 1435180 2 aakash_jain 2018-06-21 11:52:27 -0700 Committed r233050: <https://trac.webkit.org/changeset/233050> 1435181 3 webkit-bug-importer 2018-06-21 11:53:17 -0700 <rdar://problem/41337924> 343204 2018-06-20 19:54:39 -0700 2018-06-21 11:52:44 -0700 Proposed patch ews_unittest_dir.patch text/plain 2657 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzAyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA2LTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSB1bml0LXRlc3RzIGZhaWwgd2hlbiBydW4gZnJvbSBh bm90aGVyIGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg2ODcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZy5weToKKyAg ICAgICAgKGxvYWRCdWlsZGVyQ29uZmlnKTogQWRkIHN1cHBvcnQgZm9yIHBhc3NpbmcgbWFzdGVy X3ByZWZpeF9wYXRoLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2Fk Q29uZmlnX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ29uZmlnRG90SlNPTlRlc3QudGVzdF9jb25m aWd1cmF0aW9uKTogU2V0IG1hc3Rlcl9wcmVmaXhfcGF0aCBhcyBjdXJyZW50IGRpcmVjdG9yeS4K KwogMjAxOC0wNi0yMCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog ICAgICAgICBbV2ViS2l0IG9uIHdhdGNoT1NdIEZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzIHNvbWV0 aW1lcyBmbGlja2VyIHdoZW4gc2Nyb2xsaW5nCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvbG9hZENvbmZpZy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZy5weQkocmV2aXNpb24gMjMzMDI4KQorKysgVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkJKHdvcmtpbmcgY29w eSkKQEAgLTIyLDYgKzIyLDcgQEAKIAogCiBpbXBvcnQganNvbgoraW1wb3J0IG9zCiBpbXBvcnQg cmUKIAogZnJvbSBidWlsZGJvdC5zY2hlZHVsZXIgaW1wb3J0IEFueUJyYW5jaFNjaGVkdWxlciwg UGVyaW9kaWMsIERlcGVuZGVudCwgVHJpZ2dlcmFibGUsIE5pZ2h0bHkKQEAgLTM0LDkgKzM1LDkg QEAgQlVJTERFUl9OQU1FX0xFTkdUSF9MSU1JVCA9IDcwCiBTVEVQX05BTUVfTEVOR1RIX0xJTUlU ID0gNTAKIAogCi1kZWYgbG9hZEJ1aWxkZXJDb25maWcoYyk6Ci0gICAgY29uZmlnID0ganNvbi5s b2FkKG9wZW4oJ2NvbmZpZy5qc29uJykpCi0gICAgcGFzc3dvcmRzID0ganNvbi5sb2FkKG9wZW4o J3Bhc3N3b3Jkcy5qc29uJykpCitkZWYgbG9hZEJ1aWxkZXJDb25maWcoYywgdXNlX2xvY2FsaG9z dF93b3JrZXI9RmFsc2UsIG1hc3Rlcl9wcmVmaXhfcGF0aD0nLi8nKToKKyAgICBjb25maWcgPSBq c29uLmxvYWQob3Blbihvcy5wYXRoLmpvaW4obWFzdGVyX3ByZWZpeF9wYXRoLCAnY29uZmlnLmpz b24nKSkpCisgICAgcGFzc3dvcmRzID0ganNvbi5sb2FkKG9wZW4ob3MucGF0aC5qb2luKG1hc3Rl cl9wcmVmaXhfcGF0aCwgJ3Bhc3N3b3Jkcy5qc29uJykpKQogICAgIGNoZWNrV29ya2Vyc0FuZEJ1 aWxkZXJzRm9yQ29uc2lzdGVuY3koY29uZmlnWyd3b3JrZXJzJ10sIGNvbmZpZ1snYnVpbGRlcnMn XSkKIAogICAgIGNbJ3dvcmtlcnMnXSA9IFtXb3JrZXIod29ya2VyWyduYW1lJ10sIHBhc3N3b3Jk cy5nZXQod29ya2VyWyduYW1lJ10sICdwYXNzd29yZCcpKSBmb3Igd29ya2VyIGluIGNvbmZpZ1sn d29ya2VycyddXQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRD b25maWdfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHkJKHJldmlzaW9uIDIzMzAyOCkKKysrIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0yMyw2ICsyMyw3IEBACiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIAoraW1wb3J0 IG9zCiBpbXBvcnQgdW5pdHRlc3QKIAogaW1wb3J0IGxvYWRDb25maWcKQEAgLTMwLDcgKzMxLDgg QEAgaW1wb3J0IGxvYWRDb25maWcKIAogY2xhc3MgQ29uZmlnRG90SlNPTlRlc3QodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X2NvbmZpZ3VyYXRpb24oc2VsZik6Ci0gICAgICAgIGxv YWRDb25maWcubG9hZEJ1aWxkZXJDb25maWcoe30pCisgICAgICAgIGN3ZCA9IG9zLnBhdGguZGly bmFtZShvcy5wYXRoLmFic3BhdGgoX19maWxlX18pKQorICAgICAgICBsb2FkQ29uZmlnLmxvYWRC dWlsZGVyQ29uZmlnKHt9LCBtYXN0ZXJfcHJlZml4X3BhdGg9Y3dkKQogCiAKIGNsYXNzIFRhZ3NG b3JCdWlsZGVyVGVlc3QodW5pdHRlc3QuVGVzdENhc2UpOgo=