186869 2018-06-20 17:23:31 -0700 flattenDictionaryStruture needs to zero inline storage. 2018-06-21 11:45:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1434951 0 keith_miller 2018-06-20 17:23:31 -0700 flattenDictionaryStruture needs to zero inline storage. 1434954 1 343194 keith_miller 2018-06-20 17:34:03 -0700 Created attachment 343194 Patch 1434957 2 343194 saam 2018-06-20 17:42:14 -0700 Comment on attachment 343194 Patch r=me 1434975 3 343194 ews-watchlist 2018-06-20 19:00:07 -0700 Comment on attachment 343194 Patch Attachment 343194 did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/8271362 New failing tests: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-cjit 1435175 4 keith_miller 2018-06-21 11:41:44 -0700 (In reply to Build Bot from comment #3) > Comment on attachment 343194 [details] > Patch > > Attachment 343194 [details] did not pass jsc-ews (mac): > Output: https://webkit-queues.webkit.org/results/8271362 > > New failing tests: > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no- > cjit I think this test was flaky beforehand. 1435176 5 keith_miller 2018-06-21 11:44:08 -0700 Committed r233048: <https://trac.webkit.org/changeset/233048> 1435177 6 webkit-bug-importer 2018-06-21 11:45:27 -0700 <rdar://problem/41337578> 343194 2018-06-20 17:34:03 -0700 2018-06-20 19:00:07 -0700 Patch bug-186869-20180620173402.patch text/plain 6697 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk YzcyMzA0MjE2NzQ4MTgwMWY1MTNiOTc2MGMzMGRiNDYyZTkwMTk3Li4wNDUyNDUwNmUzNmYyZDFl YjA5NzM0YzJhZjQ5NDQ4NTRkYzYzNmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxOC0wNi0yMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBmbGF0dGVuRGljdGlvbmFyeVN0cnV0dXJlIG5lZWRzIHRvIHplcm8g aW5saW5lIHN0b3JhZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODY4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGFsc28gYWRkcyB0aGUgYXNzZXRpb24gdGhhdCB1bnVzZWQgcHJv cGVydHkgc3RvcmFnZSBpcworICAgICAgICB6ZXJvIG9yIEpTVmFsdWUoKSB0byBwdXREaXJlY3RJ bnRlcm5hbC4gQWRkaXRpb25hbGx5LCBmdW5jdGlvbnMKKyAgICAgICAgaGF2ZSBiZWVuIGFkZGVk IHRvICR2bSB0aGF0IGZsYXR0ZW4gZGljdGlvbmFyeSBvYmplY3RzIGFuZCByZXR1cm4KKyAgICAg ICAgdGhlIGlubGluZSBjYXBhY2l0eSBvZiBhbiBvYmplY3QuCisKKyAgICAgICAgKiBydW50aW1l L0pTT2JqZWN0SW5saW5lcy5oOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6cHV0RGlyZWN0SW50 ZXJuYWwpOgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmNwcDoKKyAgICAgICAgKEpTQzo6 U3RydWN0dXJlOjpmbGF0dGVuRGljdGlvbmFyeVN0cnVjdHVyZSk6CisgICAgICAgICogdG9vbHMv SlNEb2xsYXJWTS5jcHA6CisgICAgICAgIChKU0M6OmZ1bmN0aW9uSW5saW5lQ2FwYWNpdHkpOgor ICAgICAgICAoSlNDOjpmdW5jdGlvbkZsYXR0ZW5EaWN0aW9uYXJ5T2JqZWN0KToKKyAgICAgICAg KEpTQzo6SlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24pOgorCiAyMDE4LTA2LTE5ICBLZWl0aCBN aWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBicm9rZW4gYXNz ZXJ0aW9uIG9uIDMyLWJpdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNPYmplY3RJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09i amVjdElubGluZXMuaAppbmRleCBlYzMzMWExMzlkNjM0MWY3YmQ3OGU0ZjFlY2U1OWVjMmRkYzky NGE3Li40MDliZDk0YTIyZDZkNzlhODcxZDA1MGU4YWI1YjA0ZGVhNTY1ZDUwIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdElubGluZXMuaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdElubGluZXMuaApAQCAtMzgxLDYg KzM4MSwxMCBAQCBBTFdBWVNfSU5MSU5FIGJvb2wgSlNPYmplY3Q6OnB1dERpcmVjdEludGVybmFs KFZNJiB2bSwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZQogICAgICAgICBCdXR0ZXJmbHkqIG5l d0J1dHRlcmZseSA9IGFsbG9jYXRlTW9yZU91dE9mTGluZVN0b3JhZ2Uodm0sIG9sZENhcGFjaXR5 LCBuZXdDYXBhY2l0eSk7CiAgICAgICAgIG51a2VTdHJ1Y3R1cmVBbmRTZXRCdXR0ZXJmbHkodm0s IHN0cnVjdHVyZUlELCBuZXdCdXR0ZXJmbHkpOwogICAgIH0KKworICAgIC8vIFRoaXMgYXNzZXJ0 aW9uIHZlcmlmaWVzIHRoYXQgdGhlIGNvbmN1cnJlbnQgR0Mgd29uJ3QgcmVhZCBnYXJiYWdlIGlm IHRoZSBjb25jdXJyZW50R0MKKyAgICAvLyBpcyBydW5uaW5nIGF0IHRoZSBzYW1lIHRpbWUgd2Ug cHV0IHdpdGhvdXQgdHJhbnNpdGlvbmluZy4KKyAgICBBU1NFUlQoIWdldERpcmVjdChvZmZzZXQp IHx8ICFKU1ZhbHVlOjplbmNvZGUoZ2V0RGlyZWN0KG9mZnNldCkpKTsKICAgICBwdXREaXJlY3Qo dm0sIG9mZnNldCwgdmFsdWUpOwogICAgIHNldFN0cnVjdHVyZSh2bSwgbmV3U3RydWN0dXJlKTsK ICAgICBzbG90LnNldE5ld1Byb3BlcnR5KHRoaXMsIG9mZnNldCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAppbmRleCA4ZTAyMTljYmI2YjFhOWViZjE0NTE0 ZTE5NDJlMzRmYzRhNWM1ODMwLi4zMGVlZWU5Y2MyNmYxNDFiZWEwYzg5MzYwMmQxMmUxNDVhYTE1 OWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKQEAg LTc4Miw2ICs3ODIsMTEgQEAgU3RydWN0dXJlKiBTdHJ1Y3R1cmU6OmZsYXR0ZW5EaWN0aW9uYXJ5 U3RydWN0dXJlKFZNJiB2bSwgSlNPYmplY3QqIG9iamVjdCkKIAogICAgICAgICAvLyBXZSBuZWVk IHRvIHplcm8gb3VyIHVudXNlZCBwcm9wZXJ0eSBzcGFjZTsgb3RoZXJ3aXNlIHRoZSBHQyBtaWdo dCBzZWUgYQogICAgICAgICAvLyBzdGFsZSBwb2ludGVyIHdoZW4gd2UgYWRkIHByb3BlcnRpZXMg aW4gdGhlIGZ1dHVyZS4KKyAgICAgICAgbWVtc2V0KAorICAgICAgICAgICAgb2JqZWN0LT5pbmxp bmVTdG9yYWdlVW5zYWZlKCkgKyBpbmxpbmVTaXplKCksCisgICAgICAgICAgICAwLAorICAgICAg ICAgICAgKGlubGluZUNhcGFjaXR5KCkgLSBpbmxpbmVTaXplKCkpICogc2l6ZW9mKEVuY29kZWRK U1ZhbHVlKSk7CisKICAgICAgICAgQnV0dGVyZmx5KiBidXR0ZXJmbHkgPSBvYmplY3QtPmJ1dHRl cmZseSgpOwogICAgICAgICBtZW1zZXQoCiAgICAgICAgICAgICBidXR0ZXJmbHktPmJhc2UoYnV0 dGVyZmx5LT5pbmRleGluZ0hlYWRlcigpLT5wcmVDYXBhY2l0eSh0aGlzKSwgYmVmb3JlT3V0T2ZM aW5lQ2FwYWNpdHkpLApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pT RG9sbGFyVk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3Bw CmluZGV4IDk2MjA0YzZlOTMyOWU4ZDFhZGQ0ZDdhMjczNGUzN2RkMDBkMTA2MzkuLjE3YzQ2NTQw MzE5NzJmMWNmOWEyOTZkMGQ5MzQ5NzQyNTFiNjNjOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAKQEAgLTEzNzgsNiArMTM3OCwxNSBAQCBzdGF0aWMgRW5j b2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkluZGV4aW5nTW9kZShFeGVjU3RhdGUq IGV4ZWMpCiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1N0cmluZyhleGVjLCBzdHJlYW0u dG9TdHJpbmcoKSkpOwogfQogCitzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBm dW5jdGlvbklubGluZUNhcGFjaXR5KEV4ZWNTdGF0ZSogZXhlYykKK3sKKyAgICBWTSYgdm0gPSBl eGVjLT52bSgpOworICAgIGlmIChhdXRvKiBvYmplY3QgPSBqc0R5bmFtaWNDYXN0PEpTT2JqZWN0 Kj4odm0sIGV4ZWMtPmFyZ3VtZW50KDApKSkKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShqc051bWJlcihvYmplY3QtPnN0cnVjdHVyZSh2bSktPmlubGluZUNhcGFjaXR5KCkpKTsKKwor ICAgIHJldHVybiBlbmNvZGVkSlNVbmRlZmluZWQoKTsKK30KKwogLy8gR2V0cyB0aGUgZGF0YUxv ZyBkdW1wIG9mIGEgZ2l2ZW4gSlMgdmFsdWUgYXMgYSBzdHJpbmcuCiAvLyBVc2FnZTogcHJpbnQo InZhbHVlID0gIiArICR2bS52YWx1ZShqc1ZhbHVlKSkKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGZ1bmN0aW9uVmFsdWUoRXhlY1N0YXRlKiBleGVjKQpAQCAtMTY0Nyw2ICsx NjU2LDE1IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uUmV0 dXJuVHlwZUZvcihFeGVjU3RhdGUqIGV4ZWMpCiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShK U09OUGFyc2UoZXhlYywganNvblN0cmluZykpOwogfQogCitzdGF0aWMgRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkZsYXR0ZW5EaWN0aW9uYXJ5T2JqZWN0KEV4ZWNTdGF0ZSog ZXhlYykKK3sKKyAgICBWTSYgdm0gPSBleGVjLT52bSgpOworICAgIEpTVmFsdWUgdmFsdWUgPSBl eGVjLT5hcmd1bWVudCgwKTsKKyAgICBSRUxFQVNFX0FTU0VSVCh2YWx1ZS5pc09iamVjdCgpICYm IHZhbHVlLmdldE9iamVjdCgpLT5zdHJ1Y3R1cmUoKS0+aXNEaWN0aW9uYXJ5KCkpOworICAgIHZh bHVlLmdldE9iamVjdCgpLT5mbGF0dGVuRGljdGlvbmFyeU9iamVjdCh2bSk7CisgICAgcmV0dXJu IGVuY29kZWRKU1VuZGVmaW5lZCgpOworfQorCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hP U1RfQ0FMTCBmdW5jdGlvbkR1bXBCYXNpY0Jsb2NrRXhlY3V0aW9uUmFuZ2VzKEV4ZWNTdGF0ZSog ZXhlYykKIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwpAQCAtMTgyNCw2ICsxODQyLDcgQEAg dm9pZCBKU0RvbGxhclZNOjpmaW5pc2hDcmVhdGlvbihWTSYgdm0pCiAgICAgYWRkRnVuY3Rpb24o dm0sICJwcmludFN0YWNrIiwgZnVuY3Rpb25QcmludFN0YWNrLCAwKTsKIAogICAgIGFkZEZ1bmN0 aW9uKHZtLCAiaW5kZXhpbmdNb2RlIiwgZnVuY3Rpb25JbmRleGluZ01vZGUsIDEpOworICAgIGFk ZEZ1bmN0aW9uKHZtLCAiaW5saW5lQ2FwYWNpdHkiLCBmdW5jdGlvbklubGluZUNhcGFjaXR5LCAx KTsKICAgICBhZGRGdW5jdGlvbih2bSwgInZhbHVlIiwgZnVuY3Rpb25WYWx1ZSwgMSk7CiAgICAg YWRkRnVuY3Rpb24odm0sICJnZXRwaWQiLCBmdW5jdGlvbkdldFBJRCwgMCk7CiAKQEAgLTE4NTUs NiArMTg3NCw4IEBAIHZvaWQgSlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogICAg IGFkZEZ1bmN0aW9uKHZtLCAiZmluZFR5cGVGb3JFeHByZXNzaW9uIiwgZnVuY3Rpb25GaW5kVHlw ZUZvckV4cHJlc3Npb24sIDIpOwogICAgIGFkZEZ1bmN0aW9uKHZtLCAicmV0dXJuVHlwZUZvciIs IGZ1bmN0aW9uUmV0dXJuVHlwZUZvciwgMSk7CiAKKyAgICBhZGRGdW5jdGlvbih2bSwgImZsYXR0 ZW5EaWN0aW9uYXJ5T2JqZWN0IiwgZnVuY3Rpb25GbGF0dGVuRGljdGlvbmFyeU9iamVjdCwgMSk7 CisKICAgICBhZGRGdW5jdGlvbih2bSwgImR1bXBCYXNpY0Jsb2NrRXhlY3V0aW9uUmFuZ2VzIiwg ZnVuY3Rpb25EdW1wQmFzaWNCbG9ja0V4ZWN1dGlvblJhbmdlcyAsIDApOwogICAgIGFkZEZ1bmN0 aW9uKHZtLCAiaGFzQmFzaWNCbG9ja0V4ZWN1dGVkIiwgZnVuY3Rpb25IYXNCYXNpY0Jsb2NrRXhl Y3V0ZWQsIDIpOwogICAgIGFkZEZ1bmN0aW9uKHZtLCAiYmFzaWNCbG9ja0V4ZWN1dGlvbkNvdW50 IiwgZnVuY3Rpb25CYXNpY0Jsb2NrRXhlY3V0aW9uQ291bnQsIDIpOwpkaWZmIC0tZ2l0IGEvSlNU ZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBiODNlMjdlOGE5MmMwYWFk N2QxNTM4MWYwNDY5OWU1MTgxNTlmZjhjLi41N2YxZWM0NDcxY2I3ODE5MmU4ODNmNTM2ODUzMGFm YzYwNzllYjYzIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA2LTIwICBLZWl0aCBNaWxsZXIgIDxrZWl0 aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIGZsYXR0ZW5EaWN0aW9uYXJ5U3RydXR1cmUg bmVlZHMgdG8gemVybyBpbmxpbmUgc3RvcmFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Njg2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2ZsYXR0ZW4tb2JqZWN0LXplcm8tdW51c2Vk LWlubGluZS1wcm9wZXJ0aWVzLmpzOiBBZGRlZC4KKwogMjAxOC0wNi0xOSAgU2FhbSBCYXJhdGkg IDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXJlY3RBcmd1bWVudHM6OmNyZWF0ZSBu ZWVkcyB0byBpbml0aWFsaXplIHRvIHVuZGVmaW5lZCBpbnN0ZWFkIG9mIHRoZSBlbXB0eSB2YWx1 ZQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvZmxhdHRlbi1vYmplY3QtemVyby11bnVzZWQt aW5saW5lLXByb3BlcnRpZXMuanMgYi9KU1Rlc3RzL3N0cmVzcy9mbGF0dGVuLW9iamVjdC16ZXJv LXVudXNlZC1pbmxpbmUtcHJvcGVydGllcy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42ZmU1YTE0YzQ5NThiMWJi MmRmNjkxYjE4MmYwOTkyNmQ4M2FhMjkwCi0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJl c3MvZmxhdHRlbi1vYmplY3QtemVyby11bnVzZWQtaW5saW5lLXByb3BlcnRpZXMuanMKQEAgLTAs MCArMSw3IEBACitsZXQgbyA9IHsgZm9vOiAxLCBiYXI6IDIsIGJhejogMyB9OworaWYgKCR2bS5p bmxpbmVDYXBhY2l0eShvKSA8PSAzKQorICAgIHRocm93IG5ldyBFcnJvcigiVGhlcmUgc2hvdWxk IGJlIGlubGluZSBjYXBhY2l0eSIpOworCitkZWxldGUgby5mb287Ciskdm0uZmxhdHRlbkRpY3Rp b25hcnlPYmplY3Qobyk7CitvLmZvbyA9IDE7Cg==