186867 2018-06-20 16:46:54 -0700 Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab 2018-06-20 17:09:12 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates inspector-bugzilla-changes mattbaker webkit-bug-importer wilander oldest_to_newest 1434931 0 dbates 2018-06-20 16:46:54 -0700 Steps to reproduce: 1. Open a new browser window and open Web Inspector to the storage tab. 2. Visit http://gmail.com. 3. Login. 4. In Web Inspector, click Cookies form the right-hand side. At the time of writing there should be exactly two cookies GMAIL_RTT and GAPS that are not same-site cookies. That is the value of the Same-Site column should be empty. 1434932 1 dbates 2018-06-20 16:47:11 -0700 <rdar://problem/41175424> 1434938 2 343192 dbates 2018-06-20 16:58:46 -0700 Created attachment 343192 Patch 1434941 3 343192 mattbaker 2018-06-20 17:03:39 -0700 Comment on attachment 343192 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343192&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:143 > + sameSite: !cookie.sameSite || cookie.sameSite === WI.Cookie.SameSiteType.None ? "" : WI.Cookie.displayNameForSameSiteType(cookie.sameSite), I think this reads better as: sameSite: cookie.sameSite && cookie.sameSite !== WI.Cookie.SameSiteType.None ? WI.Cookie.displayNameForSameSiteType(cookie.sameSite) : "", 1434944 4 dbates 2018-06-20 17:09:12 -0700 Committed r233027: <https://trac.webkit.org/changeset/233027> 343192 2018-06-20 16:58:46 -0700 2018-06-20 17:03:39 -0700 Patch bug-186867-20180620165845.patch text/plain 2438 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 ODc1YzY0YzNjNDg1YWRlMzUwZjZjMDgzZDgzZmFmNzRiNGY3NzA2Li5lMmZlOGJiNDAwMGU4ZjI4 ZTY4ZDU4YzM3YWQwMGFlYzk1ZjgxMzM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNi0yMCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWxsIG5vbi1TYW1lLVNpdGUgY29va2llcyBhcmUg bWFya2VkIGFzIFNhbWUtU2l0ZSBTdHJpY3QgaW4gU3RvcmFnZSB0YWIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Njg2NworICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDExNzU0MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgY29va2llcyB0aGF0IGRvIG5vdCBoYXZl IGEgU2FtZS1TaXRlIHBvbGljeSB3b3VsZCBiZSBtYXJrZWQgdXAgYXMgU2FtZS0KKyAgICAgICAg U2l0ZSBTdHJpY3QgaW4gV2ViIEluc3BlY3RvcidzIGNvb2tpZSBzdG9yYWdlIGNvbnRlbnQgdmll dyAodW5kZXIgdGhlIHN0b3JhZ2UgdGFiKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvQ29va2llU3RvcmFnZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuQ29va2llU3RvcmFn ZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fcmVidWlsZFRhYmxlKTogT25seSBjb21wdXRlIHRoZSBk aXNwbGF5IG5hbWUgaWYKKyAgICAgICAgd2UgY29va2llLnNhbWVTaXRlIGlzIG5vbi1udWxsIGFu ZCBpcyBub3QgV0kuQ29va2llLlNhbWVTaXRlVHlwZS5Ob25lLiBNb3Jlb3ZlciwgcmVtb3ZlCisg ICAgICAgIGFuIGV4dHJhbmVvdXMgY2FsbCB0byBXSS5Db29raWUucGFyc2VTYW1lU2l0ZUF0dHJp YnV0ZVZhbHVlKCkgYXMgY29va2llLlNhbWVTaXRlIHJlcHJlc2VudHMKKyAgICAgICAgdGhlIGFs cmVhZHkgcGFyc2VkIHZhbHVlIChvbmUgb2YgdGhlIFdJLkNvb2tpZS5TYW1lU2l0ZVR5cGUtc2Nv cGVkIHZhbHVlcykuCisKIDIwMTgtMDYtMTggIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVHlwZUVycm9yOiBBcnJheS5wcm90b3R5cGUuc29y dCBwYXNzZWQgYmFkIHZhbHVlIGluIE5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3IF91cGRhdGVTb3J0 QW5kRmlsdGVyZWRFbnRyaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcu anMKaW5kZXggOGJlYzlhOWUxNTFmNjQwNTYxNzY3ZmYwZDQ0NWRkODBlNWRmODk5MS4uZTA1Y2I5 N2Q2ZTk5YTA4MDBlZDIzZmM0ODQ2NTg2N2RjNzYwODUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llU3RvcmFnZUNvbnRlbnRWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tp ZVN0b3JhZ2VDb250ZW50Vmlldy5qcwpAQCAtMTQwLDcgKzE0MCw3IEBAIFdJLkNvb2tpZVN0b3Jh Z2VDb250ZW50VmlldyA9IGNsYXNzIENvb2tpZVN0b3JhZ2VDb250ZW50VmlldyBleHRlbmRzIFdJ LkNvbnRlbnRWCiAgICAgICAgICAgICAgICAgc2l6ZTogTnVtYmVyLmJ5dGVzVG9TdHJpbmcoY29v a2llLnNpemUpLAogICAgICAgICAgICAgICAgIGh0dHA6IGNvb2tpZS5odHRwT25seSA/IGNoZWNr bWFyayA6ICIiLAogICAgICAgICAgICAgICAgIHNlY3VyZTogY29va2llLnNlY3VyZSA/IGNoZWNr bWFyayA6ICIiLAotICAgICAgICAgICAgICAgIHNhbWVTaXRlOiBjb29raWUuc2FtZVNpdGUgPyBX SS5Db29raWUuZGlzcGxheU5hbWVGb3JTYW1lU2l0ZVR5cGUoV0kuQ29va2llLnBhcnNlU2FtZVNp dGVBdHRyaWJ1dGVWYWx1ZShjb29raWUuc2FtZVNpdGUpKSA6ICIiLAorICAgICAgICAgICAgICAg IHNhbWVTaXRlOiAhY29va2llLnNhbWVTaXRlIHx8IGNvb2tpZS5zYW1lU2l0ZSA9PT0gV0kuQ29v a2llLlNhbWVTaXRlVHlwZS5Ob25lID8gIiIgOiBXSS5Db29raWUuZGlzcGxheU5hbWVGb3JTYW1l U2l0ZVR5cGUoY29va2llLnNhbWVTaXRlKSwKICAgICAgICAgICAgIH07CiAKICAgICAgICAgICAg IGlmIChjb29raWUudHlwZSAhPT0gV0kuQ29va2llVHlwZS5SZXF1ZXN0KQo=