186846 2018-06-20 07:59:25 -0700 Enable mock capture devices on the iOS simulator 2018-06-26 10:06:36 -0700 1 1 1 Unclassified WebKit WebRTC Safari 10 iPhone / iPad iOS 11 RESOLVED FIXED InRadar P2 Normal --- 1 karthik eric.carlson commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1434790 0 karthik 2018-06-20 07:59:25 -0700 Testing webRTC or making webRTC calls on iphone/ipad emulator is not possible at the moment. We assume it is because there are no media devices enumerated. The solution for this will be enabling the fake media source on the emulators so that webRTC calls can be placed. 1434791 1 webkit-bug-importer 2018-06-20 07:59:38 -0700 <rdar://problem/41289134> 1436134 2 343514 eric.carlson 2018-06-25 10:54:28 -0700 Created attachment 343514 Patch 1436550 3 343514 eric.carlson 2018-06-26 10:00:21 -0700 Comment on attachment 343514 Patch >Subversion Revision: 233147 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 542a83de155e76a30f1d8e3b9140de335fdcd7bf..9026180b4a28fcfd0325cb8db9e89db4a2ad4a48 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,15 @@ >+2018-06-25 Eric Carlson <eric.carlson@apple.com> >+ >+ Enable mock capture devices on the iOS simulator >+ https://bugs.webkit.org/show_bug.cgi?id=186846 >+ <rdar://problem/41289134> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Shared/WebPreferences.yaml: Use DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED. >+ * Shared/WebPreferencesDefaultValues.h: Define DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED, set to >+ true in the iOS simulator only. >+ > 2018-06-24 Michael Catanzaro <mcatanzaro@igalia.com> > > Unreviewed, fix GTK debug build after r233131 >diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml >index 542a45c17a78f97e0454e610ce5308dab3a4c301..cf07f047c734446736786d20df0ce3a8eea31ee8 100644 >--- a/Source/WebKit/Shared/WebPreferences.yaml >+++ b/Source/WebKit/Shared/WebPreferences.yaml >@@ -570,7 +570,7 @@ HTTPEquivEnabled: > > MockCaptureDevicesEnabled: > type: bool >- defaultValue: false >+ defaultValue: DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED > webcoreBinding: DeprecatedGlobalSettings > condition: ENABLE(MEDIA_STREAM) > >diff --git a/Source/WebKit/Shared/WebPreferencesDefaultValues.h b/Source/WebKit/Shared/WebPreferencesDefaultValues.h >index 514282d91e675460995fb6ee20f6af211e364ca3..15f3459bbda2d7bed6458257d66ab5f3a80a1505 100644 >--- a/Source/WebKit/Shared/WebPreferencesDefaultValues.h >+++ b/Source/WebKit/Shared/WebPreferencesDefaultValues.h >@@ -112,9 +112,11 @@ > #if PLATFORM(IOS_SIMULATOR) > #define DEFAULT_ACCELERATED_DRAWING_ENABLED false > #define DEFAULT_CANVAS_USES_ACCELERATED_DRAWING false >+#define DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED true > #else > #define DEFAULT_ACCELERATED_DRAWING_ENABLED true > #define DEFAULT_CANVAS_USES_ACCELERATED_DRAWING true >+#define DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED false > #endif > > #if PLATFORM(COCOA) >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 9d67f5c3f7366efc2084b74d4f421086966c220a..4f2baaa1ab4182128516b81206bb674d5f944840 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,13 @@ >+2018-06-25 Eric Carlson <eric.carlson@apple.com> >+ >+ Enable mock capture devices on the iOS simulator >+ https://bugs.webkit.org/show_bug.cgi?id=186846 >+ <rdar://problem/41289134> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * platform/ios/TestExpectations: Unskip fast/mediastream/getUserMedia-default.html. >+ > 2018-06-25 Antoine Quint <graouts@apple.com> > > [Web Animations] Make imported/mozilla/css-animations/test_animation-pausing.html pass reliably >diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations >index b366d4eed78d3ab644d412a76a67bc6be3763b64..2b188403ef0899d23d7b8b2ba69768e949ed35f3 100644 >--- a/LayoutTests/platform/ios/TestExpectations >+++ b/LayoutTests/platform/ios/TestExpectations >@@ -87,11 +87,14 @@ fast/events/continuous-platform-wheelevent-in-scrolling-div.html [ Skip ] > compositing/video/video-background-color.html [ WontFix ] > > # Not supported on iOS >-fast/mediastream > fast/speechsynthesis > gamepad > mhtml > >+# Some media stream tests crash because of OS issues, so skip all but one while we investigate. >+fast/mediastream [ Skip ] >+fast/mediastream/getUserMedia-default.html [ Pass ] >+ > # ENABLE(MEDIA_CAPTURE) is not enabled > fast/forms/file/file-input-capture.html > 1436554 4 343514 commit-queue 2018-06-26 10:06:34 -0700 Comment on attachment 343514 Patch Clearing flags on attachment: 343514 Committed r233203: <https://trac.webkit.org/changeset/233203> 1436555 5 commit-queue 2018-06-26 10:06:36 -0700 All reviewed patches have been landed. Closing bug. 343514 2018-06-25 10:54:28 -0700 2018-06-26 10:06:34 -0700 Patch bug-186846-20180625105427.patch text/plain 3613 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU0MmE4M2RlMTU1ZTc2YTMw ZjFkOGUzYjkxNDBkZTMzNWZkY2Q3YmYuLjkwMjYxODBiNGEyOGZjZmQwMzI1Y2I4ZGI5ZTg5ZGI0 YTJhZDRhNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDYtMjUgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIG1vY2sgY2Fw dHVyZSBkZXZpY2VzIG9uIHRoZSBpT1Mgc2ltdWxhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY4NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzQxMjg5MTM0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWw6IFVzZSBERUZBVUxUX01PQ0tfQ0FQVFVS RV9ERVZJQ0VTX0VOQUJMRUQuCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVs dFZhbHVlcy5oOiBEZWZpbmUgREVGQVVMVF9NT0NLX0NBUFRVUkVfREVWSUNFU19FTkFCTEVELCBz ZXQgdG8KKyAgICAgICAgdHJ1ZSBpbiB0aGUgaU9TIHNpbXVsYXRvciBvbmx5LgorCiAyMDE4LTA2 LTI0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCBmaXggR1RLIGRlYnVnIGJ1aWxkIGFmdGVyIHIyMzMxMzEKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IDU0MmE0NWMxN2E3OGY5N2UwNDU0 ZTYxMGNlNTMwOGRhYjNhNGMzMDEuLmNmMDdmMDQ3YzczNDQ0NjczNjc4NmQyMGRmMGNlM2E4ZWVh MzFlZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlh bWwKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAtNTcw LDcgKzU3MCw3IEBAIEhUVFBFcXVpdkVuYWJsZWQ6CiAKIE1vY2tDYXB0dXJlRGV2aWNlc0VuYWJs ZWQ6CiAgIHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBmYWxzZQorICBkZWZhdWx0VmFsdWU6 IERFRkFVTFRfTU9DS19DQVBUVVJFX0RFVklDRVNfRU5BQkxFRAogICB3ZWJjb3JlQmluZGluZzog RGVwcmVjYXRlZEdsb2JhbFNldHRpbmdzCiAgIGNvbmRpdGlvbjogRU5BQkxFKE1FRElBX1NUUkVB TSkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZh dWx0VmFsdWVzLmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRW YWx1ZXMuaAppbmRleCA1MTQyODJkOTFlNjc1NDYwOTk1ZmI2ZWUyMGY2YWYyMTFlMzY0Y2EzLi4x NWYzNDU5YmJkYTJkN2JlZDY0NTgyNTdkNjZhYjVmM2E4MGExNTA1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaApAQCAtMTEyLDkg KzExMiwxMSBAQAogI2lmIFBMQVRGT1JNKElPU19TSU1VTEFUT1IpCiAjZGVmaW5lIERFRkFVTFRf QUNDRUxFUkFURURfRFJBV0lOR19FTkFCTEVEIGZhbHNlCiAjZGVmaW5lIERFRkFVTFRfQ0FOVkFT X1VTRVNfQUNDRUxFUkFURURfRFJBV0lORyBmYWxzZQorI2RlZmluZSBERUZBVUxUX01PQ0tfQ0FQ VFVSRV9ERVZJQ0VTX0VOQUJMRUQgdHJ1ZQogI2Vsc2UKICNkZWZpbmUgREVGQVVMVF9BQ0NFTEVS QVRFRF9EUkFXSU5HX0VOQUJMRUQgdHJ1ZQogI2RlZmluZSBERUZBVUxUX0NBTlZBU19VU0VTX0FD Q0VMRVJBVEVEX0RSQVdJTkcgdHJ1ZQorI2RlZmluZSBERUZBVUxUX01PQ0tfQ0FQVFVSRV9ERVZJ Q0VTX0VOQUJMRUQgZmFsc2UKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oQ09DT0EpCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg OWQ2N2Y1YzNmNzM2NmVmYzIwODRiNzRkNGY0MjEwODY5NjZjMjIwYS4uNGYyYmFhYTFhYjQxODIx Mjg1MTZiODEyMDZiYjY3NGQ1Zjk0NDg0MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA2 LTI1ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEVu YWJsZSBtb2NrIGNhcHR1cmUgZGV2aWNlcyBvbiB0aGUgaU9TIHNpbXVsYXRvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2ODQ2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80MTI4OTEzND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zOiBVbnNraXAg ZmFzdC9tZWRpYXN0cmVhbS9nZXRVc2VyTWVkaWEtZGVmYXVsdC5odG1sLgorCiAyMDE4LTA2LTI1 ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYiBBbmlt YXRpb25zXSBNYWtlIGltcG9ydGVkL21vemlsbGEvY3NzLWFuaW1hdGlvbnMvdGVzdF9hbmltYXRp b24tcGF1c2luZy5odG1sIHBhc3MgcmVsaWFibHkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggYjM2NmQ0ZWVkNzhkM2FiNjQ0ZDQxMmE3NmE2N2JjNmJlMzc2 M2I2NC4uMmIxODg0MDNlZjA4OTlkMjNkN2I4YjJiYTY5NzY4ZTk0OWVkMzVmMyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vaW9zL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTg3LDExICs4NywxNCBAQCBm YXN0L2V2ZW50cy9jb250aW51b3VzLXBsYXRmb3JtLXdoZWVsZXZlbnQtaW4tc2Nyb2xsaW5nLWRp di5odG1sIFsgU2tpcCBdCiBjb21wb3NpdGluZy92aWRlby92aWRlby1iYWNrZ3JvdW5kLWNvbG9y Lmh0bWwgWyBXb250Rml4IF0KIAogIyBOb3Qgc3VwcG9ydGVkIG9uIGlPUwotZmFzdC9tZWRpYXN0 cmVhbQogZmFzdC9zcGVlY2hzeW50aGVzaXMKIGdhbWVwYWQKIG1odG1sCiAKKyMgU29tZSBtZWRp YSBzdHJlYW0gdGVzdHMgY3Jhc2ggYmVjYXVzZSBvZiBPUyBpc3N1ZXMsIHNvIHNraXAgYWxsIGJ1 dCBvbmUgd2hpbGUgd2UgaW52ZXN0aWdhdGUuCitmYXN0L21lZGlhc3RyZWFtIFsgU2tpcCBdCitm YXN0L21lZGlhc3RyZWFtL2dldFVzZXJNZWRpYS1kZWZhdWx0Lmh0bWwgWyBQYXNzIF0KKwogIyBF TkFCTEUoTUVESUFfQ0FQVFVSRSkgaXMgbm90IGVuYWJsZWQKIGZhc3QvZm9ybXMvZmlsZS9maWxl LWlucHV0LWNhcHR1cmUuaHRtbAogCg==