186840 2018-06-20 02:00:58 -0700 [GTK][ThreadedRendering][Nicosia] Themed elements cannot be rendered using threaded rendering 2018-06-20 04:06:05 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply calvaris cgarcia commit-queue oldest_to_newest 1434733 0 magomez 2018-06-20 02:00:58 -0700 Scrollbars in wkgtk are rendered by the gtk theme using cairo directly. In order to do this, the cairo cr of the current GraphicsContext is gotten through the PlatformContext. But when using threaded rendering, the GraphicsContext used for recording the commands doesn't have a PlatformContext, so when trying to draw the scrollbars there's a crash. 1434735 1 343143 magomez 2018-06-20 02:03:01 -0700 Created attachment 343143 Patch 1434738 2 343143 cgarcia 2018-06-20 02:11:10 -0700 Comment on attachment 343143 Patch Does this mean scrollbars will not be rendered at all when using the threaded painting? What about other places where graphicsContext.platformContext()->cr() is used, like RenderThemeGtk? 1434740 3 magomez 2018-06-20 02:16:26 -0700 (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 343143 [details] > Patch > > Does this mean scrollbars will not be rendered at all when using the > threaded painting? What about other places where > graphicsContext.platformContext()->cr() is used, like RenderThemeGtk? I was just doing more testing and I realized that,as you say, not only the scrollbars but everything that's rendered by the theme has the same problem. This is a wrong fix then. We need to be able to exclude layers with themed elements from the threaded rendering or completely disable threaded rendering in wkgtk. 1434748 4 magomez 2018-06-20 03:08:07 -0700 As theme integration is not a priority at this point, and we need to finish the threaded rendering path in wpe, we are going to keep it disabled on wkgtk for the moment. 1434751 5 343146 magomez 2018-06-20 03:14:56 -0700 Created attachment 343146 Patch 1434759 6 343146 commit-queue 2018-06-20 04:06:03 -0700 Comment on attachment 343146 Patch Clearing flags on attachment: 343146 Committed r233009: <https://trac.webkit.org/changeset/233009> 1434760 7 commit-queue 2018-06-20 04:06:05 -0700 All reviewed patches have been landed. Closing bug. 343143 2018-06-20 02:03:01 -0700 2018-06-20 03:14:52 -0700 Patch bug-186840-20180620110259.patch text/plain 2136 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThiYTkyNTA4NjhiNTA2 YzU1MWNiZmI1ZTA5MzQ5ZDE2MDJhYjFkZS4uODRlZGRhMDhlNTRhZGZkMTNlMDEwNjdiYzM1ZjFj ZWE3ZDcxMDk2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTIwICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bVGhyZWFkZWRS ZW5kZXJpbmddIERvIG5vdCB0cnkgdG8gcmVuZGVyIHNjcm9sbGJhcnMgaWYgdGhlIEdyYXBoaWNz Q29udGV4dCBkb2Vzbid0IGhhdmUgYSBQbGF0Zm9ybUNvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Njg0MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCB0cnkgdG8gcmVuZGVyIHRoZSBz Y3JvbGxiYXJzIGlmIHRoZSBHcmFwaGljc0NvbnRleHQgdXNlZCBkb2Vzbid0IGhhdmUgYSBQbGF0 Zm9ybUNvbnRleHQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJh clRoZW1lR3RrOjpwYWludCk6CisKIDIwMTgtMDYtMTkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRz QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIE1ha2UgaW1wb3J0ZWQvbW96 aWxsYS9jc3MtYW5pbWF0aW9ucy90ZXN0X3BzZXVkb0VsZW1lbnQtZ2V0LWFuaW1hdGlvbnMuaHRt bCBwYXNzIHJlbGlhYmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv U2Nyb2xsYmFyVGhlbWVHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9s bGJhclRoZW1lR3RrLmNwcAppbmRleCA4NDY2YWFjZGY3NDUyOWRmNzMyMTNlNzMwYjM4NjI4MGEx ZTYzNmZkLi5hZDBiMmFkZTU0MTdhZDJlMDQ5NWM2MjkwMGRmYjcxMzdiZGRkYmU0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKQEAg LTQ0OSw3ICs0NDksNyBAQCBJbnRSZWN0IFNjcm9sbGJhclRoZW1lR3RrOjpmb3J3YXJkQnV0dG9u UmVjdChTY3JvbGxiYXImIHNjcm9sbGJhciwgU2Nyb2xsYmFyUGFydAogI2lmIEdUS19DSEVDS19W RVJTSU9OKDMsIDIwLCAwKQogYm9vbCBTY3JvbGxiYXJUaGVtZUd0azo6cGFpbnQoU2Nyb2xsYmFy JiBzY3JvbGxiYXIsIEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRS ZWN0JiBkYW1hZ2VSZWN0KQogewotICAgIGlmIChncmFwaGljc0NvbnRleHQucGFpbnRpbmdEaXNh YmxlZCgpKQorICAgIGlmIChncmFwaGljc0NvbnRleHQucGFpbnRpbmdEaXNhYmxlZCgpIHx8ICFn cmFwaGljc0NvbnRleHQucGxhdGZvcm1Db250ZXh0KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK IAogICAgIGlmICghc2Nyb2xsYmFyLmVuYWJsZWQoKSkKQEAgLTY2Miw3ICs2NjIsNyBAQCBzdGF0 aWMgdm9pZCBhZGp1c3RSZWN0QWNjb3JkaW5nVG9NYXJnaW4oR3RrU3R5bGVDb250ZXh0KiBjb250 ZXh0LCBJbnRSZWN0JiByZWN0KQogCiBib29sIFNjcm9sbGJhclRoZW1lR3RrOjpwYWludChTY3Jv bGxiYXImIHNjcm9sbGJhciwgR3JhcGhpY3NDb250ZXh0JiBncmFwaGljc0NvbnRleHQsIGNvbnN0 IEludFJlY3QmIGRhbWFnZVJlY3QpCiB7Ci0gICAgaWYgKGdyYXBoaWNzQ29udGV4dC5wYWludGlu Z0Rpc2FibGVkKCkpCisgICAgaWYgKGdyYXBoaWNzQ29udGV4dC5wYWludGluZ0Rpc2FibGVkKCkg fHwgIWdyYXBoaWNzQ29udGV4dC5wbGF0Zm9ybUNvbnRleHQoKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCiAgICAgR1JlZlB0cjxHdGtTdHlsZUNvbnRleHQ+IHN0eWxlQ29udGV4dCA9IGNyZWF0 ZVN0eWxlQ29udGV4dCgmc2Nyb2xsYmFyKTsK 343146 2018-06-20 03:14:56 -0700 2018-06-20 04:06:03 -0700 Patch bug-186840-20180620121455.patch text/plain 1544 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQyYmQ1MmE2MmZiYTdk ZmExMGU1Njg4Y2I5YTY4ZTRhZTViZjg2Mi4uNzcwNDNlZTQ0NGQ0Zjg3OTc4MTA5OGM3YWY4OTFm ZjI2Mzg3NzhkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTIwICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bVGhyZWFkZWRS ZW5kZXJpbmddW05pY29zaWFdIFRoZW1lZCBlbGVtZW50cyBjYW5ub3QgYmUgcmVuZGVyZWQgdXNp bmcgdGhyZWFkZWQgcmVuZGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODY4NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBEaXNhYmxlIHRocmVhZGVkIHJlbmRlcmluZyBmb3IgR1RLIHBvcnQuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lhL05pY29zaWFQYWludGluZ0VuZ2lu ZS5jcHA6CisgICAgICAgIChOaWNvc2lhOjpQYWludGluZ0VuZ2luZTo6Y3JlYXRlKToKKwogMjAx OC0wNi0yMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAg ICBbR1RLXVtXUEVdW05pY29zaWFdIEFkZCBuYW1lIGZvciBOaWNvc2lhIFBhaW50aW5nIFRocmVh ZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEv Tmljb3NpYVBhaW50aW5nRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL25pY29zaWEvTmljb3NpYVBhaW50aW5nRW5naW5lLmNwcAppbmRleCAzYmQ5YmYzMjM3MDkx ZThjNzY5Nzg3OGE5OTJlYzY1YjBmOTc1NjViLi4wN2FlN2EyNjNjMDVlOGRkMzBlZDk1NTM0Njc2 ZWFlODU3ZTQwYzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9uaWNvc2lhL05pY29zaWFQYWludGluZ0VuZ2luZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdFbmdpbmUuY3BwCkBAIC0z Niw3ICszNiw3IEBAIG5hbWVzcGFjZSBOaWNvc2lhIHsKIAogc3RkOjp1bmlxdWVfcHRyPFBhaW50 aW5nRW5naW5lPiBQYWludGluZ0VuZ2luZTo6Y3JlYXRlKCkKIHsKLSNpZiBFTkFCTEUoREVWRUxP UEVSX01PREUpCisjaWYgRU5BQkxFKERFVkVMT1BFUl9NT0RFKSAmJiBQTEFURk9STShXUEUpCiAg ICAgaWYgKGNvbnN0IGNoYXIqIG51bVRocmVhZHNFbnYgPSBnZXRlbnYoIldFQktJVF9OSUNPU0lB X1BBSU5USU5HX1RIUkVBRFMiKSkgewogICAgICAgICB1bnNpZ25lZCBudW1UaHJlYWRzID0gMDsK ICAgICAgICAgaWYgKHNzY2FuZihudW1UaHJlYWRzRW52LCAiJXUiLCAmbnVtVGhyZWFkcykgPT0g MSkgewo=