186828 2018-06-19 17:10:42 -0700 flattenDictionaryStructure needs to zero properties that have been compressed away 2018-06-19 18:29:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1434648 0 keith_miller 2018-06-19 17:10:42 -0700 flattenDictionaryStructure needs to zero properties that have been compressed away 1434650 1 343122 keith_miller 2018-06-19 17:11:16 -0700 Created attachment 343122 Patch 1434651 2 343122 mark.lam 2018-06-19 17:21:47 -0700 Comment on attachment 343122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343122&action=review r=me > Source/JavaScriptCore/runtime/Structure.cpp:783 > + // We need to make sure we zero our unused butterfly space otherwise the GC might see a stale pointer. I think you can drop the "make sure we" part, and I suggest adding a semicolon after "space" and a comma after "otherwise". 1434673 3 343128 keith_miller 2018-06-19 18:21:03 -0700 Created attachment 343128 Patch for landing 1434674 4 keith_miller 2018-06-19 18:28:09 -0700 Committed r233001: <https://trac.webkit.org/changeset/233001> 1434675 5 webkit-bug-importer 2018-06-19 18:29:18 -0700 <rdar://problem/41272865> 343122 2018-06-19 17:11:16 -0700 2018-06-19 18:21:02 -0700 Patch bug-186828-20180619171116.patch text/plain 1802 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZjdkZjM0NDU2YmE4OTJiMzgyOGNlMDQyNTVhZjRhY2Y0ZjBkMDQ5Li4xYjM2NzRjNWU0ODQwYjM5 N2JmMTQ1Zjk4NjI5ZmJlZTI3OGQ0MWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wNi0xOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBmbGF0dGVuRGljdGlvbmFyeVN0cnVjdHVyZSBuZWVkcyB0byB6ZXJv IHByb3BlcnRpZXMgdGhhdCBoYXZlIGJlZW4gY29tcHJlc3NlZCBhd2F5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY4MjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIGEgYnVu Y2ggb2YgY3Jhc2hpbmcgTW96aWxsYSB0ZXN0cyBvbiB0aGUgYm90cy4KKworICAgICAgICAqIHJ1 bnRpbWUvU3RydWN0dXJlLmNwcDoKKyAgICAgICAgKEpTQzo6U3RydWN0dXJlOjpmbGF0dGVuRGlj dGlvbmFyeVN0cnVjdHVyZSk6CisKIDIwMTgtMDYtMTkgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21p bGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgY29uc3RydWN0QXJyYXkgdmFyaWFudHMgc2hvdWxk IHRha2UgdGhlIHNsb3cgcGF0aCBmb3Igc3ViY2xhc3NlcyBvZiBBcnJheQpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKaW5kZXggMDU5MGU1ZjgwNjczZjJjNmY1 YTQ5M2VhMjEyM2I1OWJhMzU2ZjQzMC4uZDIxY2JkOWVjZTMwZTFjMmZjNmM2NDYyNjEzYTgyNDU4 OWU4ZmI5YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0 dXJlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuY3Bw CkBAIC03NzksNiArNzc5LDEzIEBAIFN0cnVjdHVyZSogU3RydWN0dXJlOjpmbGF0dGVuRGljdGlv bmFyeVN0cnVjdHVyZShWTSYgdm0sIEpTT2JqZWN0KiBvYmplY3QpCiAgICAgICAgICAgICBvYmpl Y3QtPnB1dERpcmVjdCh2bSwgb2Zmc2V0Rm9yUHJvcGVydHlOdW1iZXIoaSwgbV9pbmxpbmVDYXBh Y2l0eSksIHZhbHVlc1tpXSk7CiAKICAgICAgICAgdGFibGUtPmNsZWFyRGVsZXRlZE9mZnNldHMo KTsKKworICAgICAgICAvLyBXZSBuZWVkIHRvIG1ha2Ugc3VyZSB3ZSB6ZXJvIG91ciB1bnVzZWQg YnV0dGVyZmx5IHNwYWNlIG90aGVyd2lzZSB0aGUgR0MgbWlnaHQgc2VlIGEgc3RhbGUgcG9pbnRl ci4KKyAgICAgICAgQnV0dGVyZmx5KiBidXR0ZXJmbHkgPSBvYmplY3QtPmJ1dHRlcmZseSgpOwor ICAgICAgICBtZW1zZXQoCisgICAgICAgICAgICBidXR0ZXJmbHktPmJhc2UoYnV0dGVyZmx5LT5p bmRleGluZ0hlYWRlcigpLT5wcmVDYXBhY2l0eSh0aGlzKSwgYmVmb3JlT3V0T2ZMaW5lQ2FwYWNp dHkpLAorICAgICAgICAgICAgMCwKKyAgICAgICAgICAgIChiZWZvcmVPdXRPZkxpbmVDYXBhY2l0 eSAtIG91dE9mTGluZVNpemUoKSkgKiBzaXplb2YoRW5jb2RlZEpTVmFsdWUpKTsKICAgICAgICAg Y2hlY2tPZmZzZXRDb25zaXN0ZW5jeSgpOwogICAgIH0KIAo= 343128 2018-06-19 18:21:03 -0700 2018-06-19 18:21:03 -0700 Patch for landing bug-186828-20180619182103.patch text/plain 2299 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZjdkZjM0NDU2YmE4OTJiMzgyOGNlMDQyNTVhZjRhY2Y0ZjBkMDQ5Li5jZTY5NDM0ZDE2NmQxNGM0 YjMzNDIyZjhlYThmYTZmOTY5YzIyOWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wNi0xOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBmbGF0dGVuRGljdGlvbmFyeVN0cnVjdHVyZSBuZWVkcyB0byB6ZXJv IHByb3BlcnRpZXMgdGhhdCBoYXZlIGJlZW4gY29tcHJlc3NlZCBhd2F5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY4MjgKKworICAgICAgICBSZXZp ZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIGEgYnVuY2ggb2Yg Y3Jhc2hpbmcgTW96aWxsYSB0ZXN0cyBvbiB0aGUgYm90cy4KKworICAgICAgICAqIHJ1bnRpbWUv U3RydWN0dXJlLmNwcDoKKyAgICAgICAgKEpTQzo6U3RydWN0dXJlOjpmbGF0dGVuRGljdGlvbmFy eVN0cnVjdHVyZSk6CisKIDIwMTgtMDYtMTkgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBh cHBsZS5jb20+CiAKICAgICAgICAgY29uc3RydWN0QXJyYXkgdmFyaWFudHMgc2hvdWxkIHRha2Ug dGhlIHNsb3cgcGF0aCBmb3Igc3ViY2xhc3NlcyBvZiBBcnJheQpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKaW5kZXggMDU5MGU1ZjgwNjczZjJjNmY1YTQ5M2Vh MjEyM2I1OWJhMzU2ZjQzMC4uMjc3ZjE0ODg5ZWE4MjFhMGI4NzQyZTQ0M2VlZDRiMzBiMTdmMmQ5 ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwCkBAIC03 NzksNiArNzc5LDEyIEBAIFN0cnVjdHVyZSogU3RydWN0dXJlOjpmbGF0dGVuRGljdGlvbmFyeVN0 cnVjdHVyZShWTSYgdm0sIEpTT2JqZWN0KiBvYmplY3QpCiAgICAgICAgICAgICBvYmplY3QtPnB1 dERpcmVjdCh2bSwgb2Zmc2V0Rm9yUHJvcGVydHlOdW1iZXIoaSwgbV9pbmxpbmVDYXBhY2l0eSks IHZhbHVlc1tpXSk7CiAKICAgICAgICAgdGFibGUtPmNsZWFyRGVsZXRlZE9mZnNldHMoKTsKKwor ICAgICAgICBCdXR0ZXJmbHkqIGJ1dHRlcmZseSA9IG9iamVjdC0+YnV0dGVyZmx5KCk7CisgICAg ICAgIG1lbXNldCgKKyAgICAgICAgICAgIGJ1dHRlcmZseS0+YmFzZShidXR0ZXJmbHktPmluZGV4 aW5nSGVhZGVyKCktPnByZUNhcGFjaXR5KHRoaXMpLCBiZWZvcmVPdXRPZkxpbmVDYXBhY2l0eSks CisgICAgICAgICAgICAwLAorICAgICAgICAgICAgKGJlZm9yZU91dE9mTGluZUNhcGFjaXR5IC0g b3V0T2ZMaW5lU2l6ZSgpKSAqIHNpemVvZihFbmNvZGVkSlNWYWx1ZSkpOwogICAgICAgICBjaGVj a09mZnNldENvbnNpc3RlbmN5KCk7CiAgICAgfQogCkBAIC04MDMsOSArODA5LDggQEAgU3RydWN0 dXJlKiBTdHJ1Y3R1cmU6OmZsYXR0ZW5EaWN0aW9uYXJ5U3RydWN0dXJlKFZNJiB2bSwgSlNPYmpl Y3QqIG9iamVjdCkKICAgICBXVEY6OnN0b3JlU3RvcmVGZW5jZSgpOwogICAgIG9iamVjdC0+c2V0 U3RydWN0dXJlSUREaXJlY3RseShpZCgpKTsKIAotICAgIC8vIEZJWE1FOiBUaGlzIGlzIHByb2Jh Ymx5IG5vIGxvbmdlciBuZWVkZWQgc2luY2Ugd2UgaGF2ZSBhIHN0cm9uZ2VyIG1lY2hhbmlzbQot ICAgIC8vIGZvciBkZXRlY3RpbmcgcmFjZXMgYW5kIHJlc2Nhbm5pbmcgYW4gb2JqZWN0LgotICAg IC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY5ODkKKyAgICAv LyBXZSBuZWVkIHRvIGRvIGEgd3JpdGViYXJyaWVyIGhlcmUgYmVjYXVzZSB0aGUgR0MgdGhyZWFk IG1pZ2h0IGJlIHNjYW5uaW5nIHRoZSBidXR0ZXJmbHkgd2hpbGUKKyAgICAvLyB3ZSBhcmUgc2h1 ZmZsaW5nIHByb3BlcnRpZXMgYXJvdW5kLiBTZWU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjY5ODkKICAgICB2bS5oZWFwLndyaXRlQmFycmllcihvYmplY3QpOwog CiAgICAgcmV0dXJuIHRoaXM7Cg==