186824 2018-06-19 15:38:44 -0700 [test262-runner] Reduce flakiness of unit tests for the runner 2019-11-07 10:54:01 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203964 InRadar P2 Normal --- 1 leo leo commit-queue dbates ews-watchlist msaboff webkit-bug-importer oldest_to_newest 1434613 0 leo 2018-06-19 15:38:44 -0700 [test262-runner] Reduce flakiness of unit tests for the runner 1434615 1 343115 leo 2018-06-19 15:39:08 -0700 Created attachment 343115 Patch 1434618 2 leo 2018-06-19 15:43:29 -0700 This is after the report from https://bugs.webkit.org/show_bug.cgi?id=186443#c34 The change on the Tools/Scripts/test262/Runner.pm avoids calls to the runner without enough files. That fixes the reported problem, but running the tests locally - calling `perl ./Tools/Scripts/test-webkitperl` - I noticed some flakiness in the runner that I'm trying to minimize by setting only one process for each time the test262-runner is called. Otherwise I was getting some non matching exit codes. 1434635 3 343115 msaboff 2018-06-19 16:43:05 -0700 Comment on attachment 343115 Patch r=me 1434646 4 343115 commit-queue 2018-06-19 17:09:34 -0700 Comment on attachment 343115 Patch Clearing flags on attachment: 343115 Committed r232996: <https://trac.webkit.org/changeset/232996> 1434647 5 commit-queue 2018-06-19 17:09:35 -0700 All reviewed patches have been landed. Closing bug. 1434649 6 webkit-bug-importer 2018-06-19 17:11:16 -0700 <rdar://problem/41270714> 343115 2018-06-19 15:39:08 -0700 2018-06-19 17:09:34 -0700 Patch bug-186824-20180619183907.patch text/plain 2361 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTMxM2ZlNzk3YTIwNTYxNWM2MmNmMWI0MzUzZDc0MTAy MzQ2OGEwMC4uNWRlYzFkMzUwMGRmNmM4NTBiNzYyZDQ5ZmI0MDZhNGNjODRlMWZhNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA2LTE5ICBMZW8gQmFsdGVyICA8bGVvbmFyZG8uYmFsdGVyQGdtYWlsLmNvbT4K KworICAgICAgICBbdGVzdDI2Mi1ydW5uZXJdIFJlZHVjZSBmbGFraW5lc3Mgb2YgdW5pdCB0ZXN0 cyBmb3IgdGhlIHJ1bm5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg2ODI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3Rlc3QyNjIvUnVubmVyLnBtOgorICAgICAgICAobWFpbik6Cisg ICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL3Rlc3QyNjJfdW5pdHRlc3QvdGVzdDI2Mi1ydW5u ZXItdGVzdHMucGw6CisKIDIwMTgtMDYtMTkgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIENyYXNoIHJ1bm5pbmcgY2hlY2std2Via2l0LXN0eWxlIG9uIHdlYnJ0 Yy8uLi4vZXhjZXB0aW9ucy5weQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1 bm5lci5wbSBiL1Rvb2xzL1NjcmlwdHMvdGVzdDI2Mi9SdW5uZXIucG0KaW5kZXggNGQ5ZTgyMmQ1 YjJkYzE1ZjBiMzIwMzEwNjJlNTQ2MmMzMmY3ZWRjZC4uNjZjYmFmZDU3ODA2MzQ1ZWE0MjdkNWJh MWY4NDZjNDgxNDk5NDI5YSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1bm5l ci5wbQorKysgYi9Ub29scy9TY3JpcHRzL3Rlc3QyNjIvUnVubmVyLnBtCkBAIC0zNDUsOCArMzQ1 LDggQEAgc3ViIG1haW4gewogICAgICAgICAgICAgJHNlbGVjdC0+YWRkKCRjaGlsZCk7CiAgICAg ICAgICAgICAjIGVhY2ggY2hpbGQgc3RhcnRzIHdpdGggYSBmaWxlOwogICAgICAgICAgICAgbXkg JGZpbGUgPSBzaGlmdCBAZmlsZXM7Ci0gICAgICAgICAgICBjaG9tcCAkZmlsZTsKICAgICAgICAg ICAgIGlmICgkZmlsZSkgeworICAgICAgICAgICAgICAgIGNob21wICRmaWxlOwogICAgICAgICAg ICAgICAgIHByaW50ICRjaGlsZCAiJGZpbGVcbiI7CiAgICAgICAgICAgICAgICAgJGFjdGl2ZUNo aWxkcmVuKys7CiAgICAgICAgICAgICB9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHBlcmwvdGVzdDI2Ml91bml0dGVzdC90ZXN0MjYyLXJ1bm5lci10ZXN0cy5wbCBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC90ZXN0MjYyX3VuaXR0ZXN0L3Rlc3QyNjItcnVubmVyLXRlc3RzLnBs CmluZGV4IGUwNDM4NjBmZTViMDdmOTc4NzZjNzU1MGE0ZDc4MGI5ZWEzY2Q0Y2IuLjY2MThkMmY1 ZmE1NTI4NjZkY2U4MjExZWE0YTJhYjIzMWM4NTQwNGQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cGVybC90ZXN0MjYyX3VuaXR0ZXN0L3Rlc3QyNjItcnVubmVyLXRlc3RzLnBsCisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC90ZXN0MjYyX3VuaXR0ZXN0L3Rlc3QyNjItcnVu bmVyLXRlc3RzLnBsCkBAIC00Nyw3ICs0Nyw3IEBAIGlmIChpc1dpbmRvd3MoKSB8fCBpc0N5Z3dp bigpIHx8IGlzV2luQ2Fpcm8oKSkgewogfQogCiBteSAkQmluID0gJEZpbmRCaW46OkJpbjsKLW15 ICRydW5uZXIgPSBhYnNfcGF0aCgiJEJpbi8uLi8uLi90ZXN0MjYyLXJ1bm5lciIpOworbXkgJHJ1 bm5lciA9IGFic19wYXRoKCIkQmluLy4uLy4uL3Rlc3QyNjItcnVubmVyIC1wIDEiKTsKIG15ICRt b2NrVGVzdDI2MiA9IGFic19wYXRoKCIkQmluL2ZpeHR1cmVzIik7CiAKIApAQCAtMTMzLDcgKzEz Myw3IEBAIGZvcmVhY2ggbXkgJHRlc3RDYXNlIChAdGVzdENhc2VzKSB7CiAgICAgbXkgJGV4aXRD b2RlID0gJD8gPj4gODsKICAgICBteSAkZXhwZWN0ZWRFeGl0Q29kZSA9ICR0ZXN0Q2FzZS0+e0VY SVRTVEFUVVN9OwogICAgIG15ICR0ZXN0TmFtZSA9ICAkdGVzdENhc2UtPntURVNUTkFNRX0gLiAi IChleGl0IGNvZGU6ICRleHBlY3RlZEV4aXRDb2RlKSI7Ci0gICAgaXMoJGV4aXRDb2RlLCAkdGVz dENhc2UtPntFWElUU1RBVFVTfSwgJHRlc3ROYW1lKTsKKyAgICBpcygkZXhpdENvZGUsICRleHBl Y3RlZEV4aXRDb2RlLCAkdGVzdE5hbWUpOwogCiAgICAgIyBUZXN0IHRoZSBudW1iZXIgb2Ygb2Nj dXJlbmNlcyBvZiBzdHJpbmcgIiEgTkVXIEZBSUwiCiAgICAgbXkgQG5ld0ZhaWxDb3VudCA9ICRv dXRwdXQgPX4gLyEgTkVXIEZBSUwvZzsK