186767 2018-06-18 08:33:45 -0700 [GTK] Do not depend on resources provided by the GNOME icon theme 2021-06-09 08:20:03 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez dpino annulen bugs-noreply calvaris clopez dpino ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio oldest_to_newest 1434003 0 aperez 2018-06-18 08:33:45 -0700 As per the discussion in bug #186638 (comments 15 to 17), we should NOT depend on gnome-icon-theme being installed, and therefore the resources built as part of WebKitGTK+ should include a copy of the needed icons. 1434075 1 mcatanzaro 2018-06-18 11:17:02 -0700 This entails fixing the following crash: Thread 1 (Thread 0x7fb014ea73c0 (LWP 575)): #0 _g_log_abort () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:554 #1 0x00007fb01cc9d415 in g_logv () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1362 #2 0x00007fb01cc9d562 in g_log () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1403 #3 0x00007fb01cc725de in g_bytes_get_size () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gbytes.c:267 #4 0x00007fb025074516 in WebCore::loadImageFromGResource(char const*) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007fb0250747eb in WebCore::Image::loadPlatformResource(char const*) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007fb0247688d4 in WebCore::CachedImage::brokenImage(float) const () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007fb024b14396 in WebCore::RenderImage::paintReplaced(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #8 0x00007fb024ba3d1c in WebCore::RenderReplaced::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #9 0x00007fb024b13612 in WebCore::RenderImage::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007fb024ae3a14 in WebCore::RenderElement::paintAsInlineBlock(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #11 0x00007fb024a4bb02 in WebCore::InlineElementBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #12 0x00007fb024a5a21a in WebCore::InlineFlowBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #13 0x00007fb024c057fc in WebCore::RootInlineBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #14 0x00007fb024b74d9f in WebCore::RenderLineBoxList::paint(WebCore::RenderBoxModelObject*, WebCore::PaintInfo&, WebCore::LayoutPoint const&) const () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #15 0x00007fb024a6bc09 in WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #16 0x00007fb024a89043 in WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #17 0x00007fb024a6772b in WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #18 0x00007fb024a6be87 in WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #19 0x00007fb024a6c09d in WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #20 0x00007fb024a6bbf8 in WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #21 0x00007fb024a89043 in WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #22 0x00007fb024a6772b in WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #23 0x00007fb024a6be87 in WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #24 0x00007fb024a6c09d in WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #25 0x00007fb024a6bbf8 in WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #26 0x00007fb024a89043 in WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #27 0x00007fb024a6772b in WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #28 0x00007fb024b33279 in WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int, WebCore::RenderObject*) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #29 0x00007fb024b4176a in WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int, WebCore::RenderObject*) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #30 0x00007fb024b5a394 in WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #31 0x00007fb024b5b230 in WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #32 0x00007fb024b5b555 in WebCore::RenderLayer::paintList(WTF::Vector<WebCore::RenderLayer*, 0ul, WTF::CrashOnOverflow, 16ul>*, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #33 0x00007fb024b5a02e in WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #34 0x00007fb024b5b230 in WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #35 0x00007fb024b5b39d in WebCore::RenderLayer::paint(WebCore::GraphicsContext&, WebCore::LayoutRect const&, WebCore::LayoutSize const&, unsigned int, WebCore::RenderObject*, unsigned int, WebCore::RenderLayer::SecurityOriginPaintPolicy) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #36 0x00007fb0247e498e in WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #37 0x00007fb02489c0da in WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #38 0x00007fb0239008fd in WebKit::WebPage::drawRect(WebCore::GraphicsContext&, WebCore::IntRect const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #39 0x00007fb023b44f31 in WebKit::DrawingAreaImpl::display(WebKit::UpdateInfo&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #40 0x00007fb023b4572b in WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState() () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #41 0x00007fb023b43248 in WebKit::AcceleratedDrawingArea::updateBackingStoreState(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #42 0x00007fb023b466eb in WebKit::DrawingAreaImpl::updateBackingStoreState(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #43 0x00007fb0239bd29b in void IPC::handleMessage<Messages::DrawingArea::UpdateBackingStoreState, WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)>(IPC::Decoder&, WebKit::DrawingArea*, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #44 0x00007fb0239bd182 in WebKit::DrawingArea::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #45 0x00007fb0236794f9 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #46 0x00007fb023829846 in WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #47 0x00007fb02367525b in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_delete<IPC::Decoder> >) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #48 0x00007fb023675e3c in IPC::Connection::dispatchOneMessage() () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #49 0x00007fb021663c2d in WTF::RunLoop::performWork() () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #50 0x00007fb021699e19 in WTF::RunLoop::RunLoop()::{lambda(void*)#1}::_FUN(void*) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #51 0x00007fb01cc9681a in g_main_dispatch () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148 #52 g_main_context_dispatch () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813 #53 0x00007fb01cc96ba8 in g_main_context_iterate () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886 #54 0x00007fb01cc96ec2 in g_main_loop_run () at /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082 #55 0x00007fb02169a810 in WTF::RunLoop::run() () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #56 0x00007fb023b51a62 in int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain>(int, char**) () from /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #57 0x00007fb01acd62e1 in __libc_start_main (main=0x555d01913ca0 <main>, argc=3, argv=0x7ffe827f5748, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffe827f5738) at ../csu/libc-start.c:291 #58 0x0000555d01913d2a in _start () STDERR: STDERR: warning: core file may not match specified executable file. STDERR: g_bytes_get_size: assertion 'bytes != NULL' failed We currently have the following code: static Ref<Image> loadMissingImageIconFromTheme(const char* name) { // ... if (iconInfo) { // Is the icon installed? return WTFMove(icon); } return loadImageFromGResource(name); } That's currently incorrect. But we won't need any code changes if fixing this bug. (It is surely preferable to lookup the icon at runtime, and only fall back to an embedded resource if missing.) Note I've added a test expectation against this bug, for fast/hidpi/broken-image-icon-very-hidpi.html. 1434316 2 calvaris 2018-06-19 00:53:10 -0700 Please, do not forget the media control icons if you bundle them 1767917 3 430895 dpino 2021-06-08 14:53:21 -0700 Created attachment 430895 Patch 1767922 4 dpino 2021-06-08 15:01:19 -0700 The only test filed under this bug at this moment is: fast/hidpi/broken-image-icon-very-hidpi.html The test has been consistently crashing for the last 4000 revisions with the following stacktrace (debug crash-log): Thread 1 (Thread 0x7f0d1bed4ec0 (LWP 13121)): #0 WTFCrash() () at ../../Source/WTF/wtf/Assertions.cpp:321 #1 0x00007f0d260f3cb7 in CRASH_WITH_INFO(...) () at WTF/Headers/wtf/Assertions.h:744 #2 0x00007f0d2a10d1fe in WebCore::loadImageFromGResource(char const*) (iconName=0x7f0d2e62a258 "missingImage@3x") at ../../Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:43 #3 0x00007f0d2a10d328 in WebCore::Image::loadPlatformResource(char const*) (name=0x7f0d2e62a258 "missingImage@3x") at ../../Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:54 #4 0x00007f0d29b7aabf in WebCore::CachedImage::brokenImage(float) const (this=0x7f0d1b55e800, deviceScaleFactor=3) at ../../Source/WebCore/loader/cache/CachedImage.cpp:219 #5 0x00007f0d2a4733c7 in WebCore::RenderImage::paintReplaced(WebCore::PaintInfo&, WebCore::LayoutPoint const&) (this=0x7f0cdb22f0f0, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderImage.cpp:506 ... So the issue seems to be that resource "missingImage@3x.png" is missing. 1767929 5 430900 dpino 2021-06-08 15:06:47 -0700 Created attachment 430900 Patch 1768096 6 430900 aperez 2021-06-09 01:18:10 -0700 Comment on attachment 430900 Patch The style-checker issue seems a bit like a false positive. It is possible to workaround it by appending to the list one item at a time, for example: set(WebKitResources "") list(APPEND WebKitResources "<file alias=\"css/gtk-theme.css\">gtk-theme.css</file>\n") list(APPEND WebKitResources "<file alias=\"images/missingImage\">missingImage.png</file>\n") list(APPEND WebKitResources "<file alias=\"images/missingImage@2x\">missingImage@2x.png</file>\n") ... We can either land manually to go around the false positive, or if you feel like reworking this a bit as suggested to avoid the style checker complaints, then it's fine to use the commit-queue :) 1768102 7 ews-feeder 2021-06-09 01:38:32 -0700 /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 1768125 8 430951 dpino 2021-06-09 03:17:09 -0700 Created attachment 430951 Patch 1768159 9 ews-feeder 2021-06-09 06:40:50 -0700 Committed r278658 (238640@main): <https://commits.webkit.org/238640@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430951. 430895 2021-06-08 14:53:21 -0700 2021-06-08 15:06:42 -0700 Patch bug-186767-20210609055320.patch text/plain 1509 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE5YjllZGExZTAxZjEzZmIw MDhiOWYzMWNiM2EyMDUyNWJhYjIzZGQuLjdmYTAzODBjMDRhODQ0ZTA5ZTI1ZjNhNjU2NjRjZWRi ZGRjY2UwMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTAgQEAKKzIwMjEtMDYtMDggIERpZWdvIFBp bm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBEbyBub3QgZGVw ZW5kIG9uIHJlc291cmNlcyBwcm92aWRlZCBieSB0aGUgR05PTUUgaWNvbiB0aGVtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NzY3CisKKyAgICAg ICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogQWRkIG1pc3NpbmcgcmVzb3VyY2UgIm1pc3NpbmdJbWFn ZUAzeC5wbmciIHRvIFdlYktpR1RLIHJlc291cmNlIGJ1bmRsZS4KKwogMjAyMS0wNi0wOCAgVHJ1 aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJl dmVydGluZyByMjc4NjA5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5j bWFrZSBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNmNmYWYyODgyYTcx ZTc4N2Y5ODE5ZjZmMDcyZjQzOTQ1YjI0ZWRiNS4uNmNiZjA4Yzc5MTc4NDY1YzhjNTZhN2EzZDgx ZDA2OWY4YzI0NTk1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFr ZQorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCkBAIC01NTAsNiArNTUwLDcg QEAgc2V0KFdlYktpdFJlc291cmNlcwogICAgICIgICAgICAgIDxmaWxlIGFsaWFzPVwiY3NzL2d0 ay10aGVtZS5jc3NcIj5ndGstdGhlbWUuY3NzPC9maWxlPlxuIgogICAgICIgICAgICAgIDxmaWxl IGFsaWFzPVwiaW1hZ2VzL21pc3NpbmdJbWFnZVwiPm1pc3NpbmdJbWFnZS5wbmc8L2ZpbGU+XG4i CiAgICAgIiAgICAgICAgPGZpbGUgYWxpYXM9XCJpbWFnZXMvbWlzc2luZ0ltYWdlQDJ4XCI+bWlz c2luZ0ltYWdlQDJ4LnBuZzwvZmlsZT5cbiIKKyAgICAiICAgICAgICA8ZmlsZSBhbGlhcz1cImlt YWdlcy9taXNzaW5nSW1hZ2VAM3hcIj5taXNzaW5nSW1hZ2VAM3gucG5nPC9maWxlPlxuIgogICAg ICIgICAgICAgIDxmaWxlIGFsaWFzPVwiaW1hZ2VzL3Bhbkljb25cIj5wYW5JY29uLnBuZzwvZmls ZT5cbiIKICAgICAiICAgICAgICA8ZmlsZSBhbGlhcz1cImltYWdlcy90ZXh0QXJlYVJlc2l6ZUNv cm5lclwiPnRleHRBcmVhUmVzaXplQ29ybmVyLnBuZzwvZmlsZT5cbiIKICAgICAiICAgICAgICA8 ZmlsZSBhbGlhcz1cImltYWdlcy90ZXh0QXJlYVJlc2l6ZUNvcm5lckAyeFwiPnRleHRBcmVhUmVz aXplQ29ybmVyQDJ4LnBuZzwvZmlsZT5cbiIK 430900 2021-06-08 15:06:47 -0700 2021-06-09 03:17:05 -0700 Patch bug-186767-20210609060646.patch text/plain 1578 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE5YjllZGExZTAxZjEzZmIw MDhiOWYzMWNiM2EyMDUyNWJhYjIzZGQuLmJmYjRiNDM4YTk2OTE3MjM2ZjhjYmYzZDJlMzY2ZGJi ZDFjYmFiMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDYtMDggIERpZWdvIFBp bm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBEbyBub3QgZGVw ZW5kIG9uIHJlc291cmNlcyBwcm92aWRlZCBieSB0aGUgR05PTUUgaWNvbiB0aGVtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NzY3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVz dHMuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogQWRkIG1pc3NpbmcgcmVzb3VyY2Ug Im1pc3NpbmdJbWFnZUAzeC5wbmciIHRvIFdlYktpR1RLIHJlc291cmNlIGJ1bmRsZS4KKwogMjAy MS0wNi0wOCAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJldmVydGluZyByMjc4NjA5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9Q bGF0Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXgg NmNmYWYyODgyYTcxZTc4N2Y5ODE5ZjZmMDcyZjQzOTQ1YjI0ZWRiNS4uNmNiZjA4Yzc5MTc4NDY1 YzhjNTZhN2EzZDgxZDA2OWY4YzI0NTk1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0 Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCkBAIC01 NTAsNiArNTUwLDcgQEAgc2V0KFdlYktpdFJlc291cmNlcwogICAgICIgICAgICAgIDxmaWxlIGFs aWFzPVwiY3NzL2d0ay10aGVtZS5jc3NcIj5ndGstdGhlbWUuY3NzPC9maWxlPlxuIgogICAgICIg ICAgICAgIDxmaWxlIGFsaWFzPVwiaW1hZ2VzL21pc3NpbmdJbWFnZVwiPm1pc3NpbmdJbWFnZS5w bmc8L2ZpbGU+XG4iCiAgICAgIiAgICAgICAgPGZpbGUgYWxpYXM9XCJpbWFnZXMvbWlzc2luZ0lt YWdlQDJ4XCI+bWlzc2luZ0ltYWdlQDJ4LnBuZzwvZmlsZT5cbiIKKyAgICAiICAgICAgICA8Zmls ZSBhbGlhcz1cImltYWdlcy9taXNzaW5nSW1hZ2VAM3hcIj5taXNzaW5nSW1hZ2VAM3gucG5nPC9m aWxlPlxuIgogICAgICIgICAgICAgIDxmaWxlIGFsaWFzPVwiaW1hZ2VzL3Bhbkljb25cIj5wYW5J Y29uLnBuZzwvZmlsZT5cbiIKICAgICAiICAgICAgICA8ZmlsZSBhbGlhcz1cImltYWdlcy90ZXh0 QXJlYVJlc2l6ZUNvcm5lclwiPnRleHRBcmVhUmVzaXplQ29ybmVyLnBuZzwvZmlsZT5cbiIKICAg ICAiICAgICAgICA8ZmlsZSBhbGlhcz1cImltYWdlcy90ZXh0QXJlYVJlc2l6ZUNvcm5lckAyeFwi PnRleHRBcmVhUmVzaXplQ29ybmVyQDJ4LnBuZzwvZmlsZT5cbiIK 430951 2021-06-09 03:17:09 -0700 2021-06-09 08:20:03 -0700 Patch bug-186767-20210609181708.patch text/plain 2367 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ0ZTk5ZTk1NTRjN2U5MDQy NzU1MzQ4ZmMyY2UzMGMyOTcwYzQyZTkuLmQwNzFiZmJmOWZkMzFjNDRjMDFmNGYwN2NhYzg5MjIy OTQxNzBlZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDYtMDkgIERpZWdvIFBp bm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBEbyBub3QgZGVw ZW5kIG9uIHJlc291cmNlcyBwcm92aWRlZCBieSB0aGUgR05PTUUgaWNvbiB0aGVtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NzY3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgQWRyaWFuIFBlcmV6IGRlIENhc3Ryby4KKworICAgICAgICBDb3ZlcmVk IGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6CisKIDIw MjEtMDYtMDkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWx5 IG9uIFNRTGl0ZURhdGFiYXNlOjpzZXRNYXhpbXVtU2l6ZSgpIGZvciBxdW90YSBtYW5hZ2VtZW50 IGluIExvY2FsU3RvcmFnZURhdGFiYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRm b3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCA2Y2Zh ZjI4ODJhNzFlNzg3Zjk4MTlmNmYwNzJmNDM5NDViMjRlZGI1Li5iMWY1NmIyMmI2ZTQyODBhYjZl ZjZjOTVkOThiYzMyZDViZDViOTJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3Jt R1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTU0Niwx NCArNTQ2LDE0IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKIAogV0VCS0lUX0JVSUxEX0lOU1BFQ1RP Ul9HUkVTT1VSQ0VTKCR7V2ViS2l0Mkd0a19ERVJJVkVEX1NPVVJDRVNfRElSfSkKIAotc2V0KFdl YktpdFJlc291cmNlcwotICAgICIgICAgICAgIDxmaWxlIGFsaWFzPVwiY3NzL2d0ay10aGVtZS5j c3NcIj5ndGstdGhlbWUuY3NzPC9maWxlPlxuIgotICAgICIgICAgICAgIDxmaWxlIGFsaWFzPVwi aW1hZ2VzL21pc3NpbmdJbWFnZVwiPm1pc3NpbmdJbWFnZS5wbmc8L2ZpbGU+XG4iCi0gICAgIiAg ICAgICAgPGZpbGUgYWxpYXM9XCJpbWFnZXMvbWlzc2luZ0ltYWdlQDJ4XCI+bWlzc2luZ0ltYWdl QDJ4LnBuZzwvZmlsZT5cbiIKLSAgICAiICAgICAgICA8ZmlsZSBhbGlhcz1cImltYWdlcy9wYW5J Y29uXCI+cGFuSWNvbi5wbmc8L2ZpbGU+XG4iCi0gICAgIiAgICAgICAgPGZpbGUgYWxpYXM9XCJp bWFnZXMvdGV4dEFyZWFSZXNpemVDb3JuZXJcIj50ZXh0QXJlYVJlc2l6ZUNvcm5lci5wbmc8L2Zp bGU+XG4iCi0gICAgIiAgICAgICAgPGZpbGUgYWxpYXM9XCJpbWFnZXMvdGV4dEFyZWFSZXNpemVD b3JuZXJAMnhcIj50ZXh0QXJlYVJlc2l6ZUNvcm5lckAyeC5wbmc8L2ZpbGU+XG4iCi0pCitzZXQo V2ViS2l0UmVzb3VyY2VzICIiKQorbGlzdChBUFBFTkQgV2ViS2l0UmVzb3VyY2VzICI8ZmlsZSBh bGlhcz1cImNzcy9ndGstdGhlbWUuY3NzXCI+Z3RrLXRoZW1lLmNzczwvZmlsZT5cbiIpCitsaXN0 KEFQUEVORCBXZWJLaXRSZXNvdXJjZXMgIjxmaWxlIGFsaWFzPVwiaW1hZ2VzL21pc3NpbmdJbWFn ZVwiPm1pc3NpbmdJbWFnZS5wbmc8L2ZpbGU+XG4iKQorbGlzdChBUFBFTkQgV2ViS2l0UmVzb3Vy Y2VzICI8ZmlsZSBhbGlhcz1cImltYWdlcy9taXNzaW5nSW1hZ2VAMnhcIj5taXNzaW5nSW1hZ2VA MngucG5nPC9maWxlPlxuIikKK2xpc3QoQVBQRU5EIFdlYktpdFJlc291cmNlcyAiPGZpbGUgYWxp YXM9XCJpbWFnZXMvbWlzc2luZ0ltYWdlQDN4XCI+bWlzc2luZ0ltYWdlQDN4LnBuZzwvZmlsZT5c biIpCitsaXN0KEFQUEVORCBXZWJLaXRSZXNvdXJjZXMgIjxmaWxlIGFsaWFzPVwiaW1hZ2VzL3Bh bkljb25cIj5wYW5JY29uLnBuZzwvZmlsZT5cbiIpCitsaXN0KEFQUEVORCBXZWJLaXRSZXNvdXJj ZXMgIjxmaWxlIGFsaWFzPVwiaW1hZ2VzL3RleHRBcmVhUmVzaXplQ29ybmVyXCI+dGV4dEFyZWFS ZXNpemVDb3JuZXIucG5nPC9maWxlPlxuIikKK2xpc3QoQVBQRU5EIFdlYktpdFJlc291cmNlcyAi PGZpbGUgYWxpYXM9XCJpbWFnZXMvdGV4dEFyZWFSZXNpemVDb3JuZXJAMnhcIj50ZXh0QXJlYVJl c2l6ZUNvcm5lckAyeC5wbmc8L2ZpbGU+XG4iKQogCiBpZiAoRU5BQkxFX1dFQl9BVURJTykKICAg ICBsaXN0KEFQUEVORCBXZWJLaXRSZXNvdXJjZXMK