186764 2018-06-18 07:32:20 -0700 [Threaded paintingEngine] Fix rendering glitches 2018-06-19 00:47:57 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 karl.leplat_ext webkit-unassigned bugs-noreply calvaris commit-queue loic.yhuel magomez olivier.blin zan oldest_to_newest 1433989 0 karl.leplat_ext 2018-06-18 07:32:20 -0700 By enabling NicosiaPaintingEngineThreaded instead of NicosiaPaintingEngineBasic which is the default implementation, we have seen that some frames are incomplete causing glitches on the screen. In fact, we are trying to upload buffers that have not finished processing. To avoid this problem, we must use the Nicosia::Buffer function waitUntilPaintingComplete() before each uploading. 1433991 1 342935 karl.leplat_ext 2018-06-18 07:40:35 -0700 Created attachment 342935 Patch 1434005 2 342935 commit-queue 2018-06-18 08:40:40 -0700 Comment on attachment 342935 Patch Clearing flags on attachment: 342935 Committed r232931: <https://trac.webkit.org/changeset/232931> 1434006 3 commit-queue 2018-06-18 08:40:41 -0700 All reviewed patches have been landed. Closing bug. 342935 2018-06-18 07:40:35 -0700 2018-06-18 08:40:40 -0700 Patch bug-186764-20180618164034.patch text/plain 3658 karl.leplat_ext U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg0Mzg4YmFjNjYwYjVj YWUwYjZmYTkyYTM1ZWYyZjc5MjRjZmQ0NS4uYTJiYWQ0MDRmYTFkOTk2M2ZhMmZhYTI4YjQxYmJi YjYwZmZhOWIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA2LTE4ICBLYXJs IExlcGxhdCAgPGthcmwubGVwbGF0X2V4dEBzb2Z0YXRob21lLmNvbT4KKworICAgICAgICBbVGhy ZWFkZWQgcGFpbnRpbmdFbmdpbmVdIEZpeCByZW5kZXJpbmcgZ2xpdGNoZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Njc2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv bmljb3NpYS9OaWNvc2lhUGFpbnRpbmdFbmdpbmVCYXNpYy5jcHA6CisgICAgICAgIChOaWNvc2lh OjpQYWludGluZ0VuZ2luZUJhc2ljOjpwYWludCk6CisgICAgICAgIFRvIGtlZXAgYmFja3dhcmRz IGNvbXBhdGliaWxpdHkgd2l0aCBubyBtdWx0aS10aHJlYWRlZCwKKyAgICAgICAgd2UgY2FsbCBO aWNvc2lhOjpCdWZmZXIgZnVuY3Rpb25zIGJlZ2luUGFpbnRpbmcoKSBhbmQgY29tcGxldGVQYWlu dGluZygpLgorCisKIDIwMTgtMDYtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIENyYXNoIHdoZW4gYWRkaW5nIGluLWJhbmQg dGV4dCB0cmFjayB3aXRoIHBsYXliaW4zIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggODljNDI1YmU0ZjU5 MTUzOWVkMjJjMWM5MjE2ODY1NjNlZDY4ZTBmOC4uMDY4NGMyNDhjYmM1M2UzMThmZTg3Yzk2ODk0 NmJkZjJlNGYzZTA5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wNi0xOCAgS2Fy bCBMZXBsYXQgIDxrYXJsLmxlcGxhdF9leHRAc29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW1Ro cmVhZGVkIHBhaW50aW5nRW5naW5lXSBGaXggcmVuZGVyaW5nIGdsaXRjaGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY3NjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9Db29yZGluYXRl ZEdyYXBoaWNzL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 Q29vcmRpbmF0ZWRCYWNraW5nU3RvcmVUaWxlOjpzd2FwQnVmZmVycyk6CisgICAgICAgIFdlIGNh bGwgTmljb3NpYTo6QnVmZmVyIGZ1bmN0aW9uIHdhaXRVbnRpbFBhaW50aW5nQ29tcGxldGUoKQor ICAgICAgICBpbiBvcmRlciB0byBzeW5jaHJvbml6ZSBvZiB1c2luZyBOaWNvc2lhOmJ1ZmZlciBi ZXR3ZWVuIE1haW5UaHJlYWQKKyAgICAgICAgYW5kIFRocmVhZGVkQ29tcG9zaXRvci4KKworCiAy MDE4LTA2LTE3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jh c2ggdW5kZXIgU3VzcGVuZGVkUGFnZVByb3h5Ojp+U3VzcGVuZGVkUGFnZVByb3h5KCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEvTmljb3NpYVBh aW50aW5nRW5naW5lQmFzaWMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv bmljb3NpYS9OaWNvc2lhUGFpbnRpbmdFbmdpbmVCYXNpYy5jcHAKaW5kZXggODBkYzFmMTBhYTE2 NDEzNzRhYmJhMDI3YWFhNmExNzRhMWY3OTdhOS4uM2ExNjRjMjhhNmZjNWI4MDI3MDUwN2QyOTEy NjNkYjllMDA0OTE4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdFbmdpbmVCYXNpYy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9OaWNvc2lhUGFpbnRpbmdFbmdpbmVCYXNp Yy5jcHAKQEAgLTQzLDYgKzQzLDggQEAgUGFpbnRpbmdFbmdpbmVCYXNpYzo6flBhaW50aW5nRW5n aW5lQmFzaWMoKSA9IGRlZmF1bHQ7CiAKIGJvb2wgUGFpbnRpbmdFbmdpbmVCYXNpYzo6cGFpbnQo R3JhcGhpY3NMYXllciYgbGF5ZXIsIFJlZjxCdWZmZXI+JiYgYnVmZmVyLCBjb25zdCBJbnRSZWN0 JiBzb3VyY2VSZWN0LCBjb25zdCBJbnRSZWN0JiBtYXBwZWRTb3VyY2VSZWN0LCBjb25zdCBJbnRS ZWN0JiB0YXJnZXRSZWN0LCBmbG9hdCBjb250ZW50c1NjYWxlKQogeworICAgIGJ1ZmZlci0+YmVn aW5QYWludGluZygpOworCiAgICAgYm9vbCBzdXBwb3J0c0FscGhhID0gYnVmZmVyLT5zdXBwb3J0 c0FscGhhKCk7CiAgICAgUGFpbnRpbmdDb250ZXh0OjpwYWludChidWZmZXIsCiAgICAgICAgIFsm bGF5ZXIsIHNvdXJjZVJlY3QsIG1hcHBlZFNvdXJjZVJlY3QsIHRhcmdldFJlY3QsIGNvbnRlbnRz U2NhbGUsIHN1cHBvcnRzQWxwaGFdCkBAIC02NSw2ICs2Nyw5IEBAIGJvb2wgUGFpbnRpbmdFbmdp bmVCYXNpYzo6cGFpbnQoR3JhcGhpY3NMYXllciYgbGF5ZXIsIFJlZjxCdWZmZXI+JiYgYnVmZmVy LCBjb25zCiAKICAgICAgICAgICAgIGNvbnRleHQucmVzdG9yZSgpOwogICAgICAgICB9KTsKKwor ICAgIGJ1ZmZlci0+Y29tcGxldGVQYWludGluZygpOworCiAgICAgcmV0dXJuIHRydWU7CiB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29v cmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEJhY2tpbmdTdG9yZS5jcHAKaW5kZXggNDJmYzJlNGFjZGNi NWJmMTAwMzQ5ZDMwMTFlMGQ5ZjY4YWY2YzAzMC4uM2I3MDhmOGRhYzkzMzYwZjJiN2MxN2E4ZjY4 ODFkNDE2ZmJkZjFlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEJhY2tpbmdTdG9yZS5jcHAK QEAgLTQ3LDYgKzQ3LDcgQEAgdm9pZCBDb29yZGluYXRlZEJhY2tpbmdTdG9yZVRpbGU6OnN3YXBC dWZmZXJzKFRleHR1cmVNYXBwZXImIHRleHR1cmVNYXBwZXIpCiAgICAgfSBlbHNlIGlmIChtX2J1 ZmZlci0+c3VwcG9ydHNBbHBoYSgpID09IG1fdGV4dHVyZS0+aXNPcGFxdWUoKSkKICAgICAgICAg bV90ZXh0dXJlLT5yZXNldChtX3RpbGVSZWN0LnNpemUoKSwgbV9idWZmZXItPnN1cHBvcnRzQWxw aGEoKSk7CiAKKyAgICBtX2J1ZmZlci0+d2FpdFVudGlsUGFpbnRpbmdDb21wbGV0ZSgpOwogICAg IG1fdGV4dHVyZS0+dXBkYXRlQ29udGVudHMobV9idWZmZXItPmRhdGEoKSwgbV9zb3VyY2VSZWN0 LCBtX2J1ZmZlck9mZnNldCwgbV9idWZmZXItPnN0cmlkZSgpKTsKICAgICBtX2J1ZmZlciA9IG51 bGxwdHI7CiB9Cg==