186756 2018-06-18 04:06:22 -0700 [GTK] Wrong variable used in RenderThemeGtk 2018-06-18 06:36:04 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela tpopela bugs-noreply calvaris cgarcia mcatanzaro oldest_to_newest 1433936 0 tpopela 2018-06-18 04:06:22 -0700 Found by Coverity scan: 1. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1304: cond_const: Condition "part != WebCore::SliderThumbHorizontalPart", taking false branch. Now the value of "part" is equal to 44. 2. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1304: cond_const: Condition "part != WebCore::SliderThumbVerticalPart", taking false branch. Now the value of "part" is equal to 45. 3. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1307: between: At condition "part == WebCore::SliderHorizontalPart", the value of "part" must be between 44 and 45. 4. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1307: dead_error_condition: The condition "part == WebCore::SliderHorizontalPart" cannot be true. 5. webkitgtk-2.20.3/Source/WebCore/rendering/RenderThemeGtk.cpp:1307: dead_error_line: Execution cannot reach the expression "WebCore::RenderThemeWidget::Type::HorizontalSlider" inside this statement: "sliderWidget = static_cast<...". # 1305| return; # 1306| # 1307|-> auto& sliderWidget = static_cast<RenderThemeSlider&>(RenderThemeWidget::getOrCreate(part == SliderHorizontalPart ? RenderThemeWidget::Type::HorizontalSlider : RenderThemeWidget::Type::VerticalSlider)); # 1308| sliderWidget.scale().setState(GTK_STATE_FLAG_NORMAL); # 1309| sliderWidget.trough().setState(GTK_STATE_FLAG_NORMAL); 1433937 1 342922 tpopela 2018-06-18 04:10:59 -0700 Created attachment 342922 Patch 1433942 2 342922 cgarcia 2018-06-18 04:15:14 -0700 Comment on attachment 342922 Patch Good catch! 1433967 3 342922 mcatanzaro 2018-06-18 06:36:02 -0700 Comment on attachment 342922 Patch Clearing flags on attachment: 342922 Committed r232928: <https://trac.webkit.org/changeset/232928> 1433968 4 mcatanzaro 2018-06-18 06:36:04 -0700 All reviewed patches have been landed. Closing bug. 342922 2018-06-18 04:10:59 -0700 2018-06-18 06:36:02 -0700 Patch bug-186756-20180618131058.patch text/plain 1808 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDdiZTJkNDkzN2JhYjAz ZTZlNTk1ZmQwNmUzMTg1MjUwNWM3YTA3Ni4uYjJlZWM1YTgzZDE3OWE0M2E4MTExNmRhNzk4YTEy NzZkNGQ5MWExMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTE4ICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gV3JvbmcgdmFy aWFibGUgdXNlZCBpbiBSZW5kZXJUaGVtZUd0aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIFNsaWRlclRodW1iSG9yaXpvbnRhbFBhcnQgaW5zdGVh ZCBvZiBTbGlkZXJIb3Jpem9udGFsUGFydC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU aGVtZUd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUd0azo6YWRqdXN0U2xp ZGVyVGh1bWJTaXplIGNvbnN0KToKKwogMjAxOC0wNi0xNyAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIEFub255bW91cyBibG9jayBjb2xsYXBzaW5nIGNhbiBkZXN0 cm95IHRoZSByZW5kZXJlcidzIHBhcmVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZUd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVHdGsuY3BwCmluZGV4IGQwNGE2ODQ1ZjI2YTNmZDBkNTYwOGY3YTYzYmJmNWYzMGZm Njg4NDQuLjhlOGZlMTBmNThlYjcyY2RmNDU1YjRhOTQ5ZmQ1YTI4ZmZmYzVkODAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtMTMxNCw3ICsxMzE0 LDcgQEAgdm9pZCBSZW5kZXJUaGVtZUd0azo6YWRqdXN0U2xpZGVyVGh1bWJTaXplKFJlbmRlclN0 eWxlJiBzdHlsZSwgY29uc3QgRWxlbWVudCopIGMKICAgICBpZiAocGFydCAhPSBTbGlkZXJUaHVt Ykhvcml6b250YWxQYXJ0ICYmIHBhcnQgIT0gU2xpZGVyVGh1bWJWZXJ0aWNhbFBhcnQpCiAgICAg ICAgIHJldHVybjsKIAotICAgIGF1dG8mIHNsaWRlcldpZGdldCA9IHN0YXRpY19jYXN0PFJlbmRl clRoZW1lU2xpZGVyJj4oUmVuZGVyVGhlbWVXaWRnZXQ6OmdldE9yQ3JlYXRlKHBhcnQgPT0gU2xp ZGVySG9yaXpvbnRhbFBhcnQgPyBSZW5kZXJUaGVtZVdpZGdldDo6VHlwZTo6SG9yaXpvbnRhbFNs aWRlciA6IFJlbmRlclRoZW1lV2lkZ2V0OjpUeXBlOjpWZXJ0aWNhbFNsaWRlcikpOworICAgIGF1 dG8mIHNsaWRlcldpZGdldCA9IHN0YXRpY19jYXN0PFJlbmRlclRoZW1lU2xpZGVyJj4oUmVuZGVy VGhlbWVXaWRnZXQ6OmdldE9yQ3JlYXRlKHBhcnQgPT0gU2xpZGVyVGh1bWJIb3Jpem9udGFsUGFy dCA/IFJlbmRlclRoZW1lV2lkZ2V0OjpUeXBlOjpIb3Jpem9udGFsU2xpZGVyIDogUmVuZGVyVGhl bWVXaWRnZXQ6OlR5cGU6OlZlcnRpY2FsU2xpZGVyKSk7CiAgICAgc2xpZGVyV2lkZ2V0LnNjYWxl KCkuc2V0U3RhdGUoR1RLX1NUQVRFX0ZMQUdfTk9STUFMKTsKICAgICBzbGlkZXJXaWRnZXQudHJv dWdoKCkuc2V0U3RhdGUoR1RLX1NUQVRFX0ZMQUdfTk9STUFMKTsKIAo=