186743 2018-06-16 13:36:56 -0700 Rename Document::hasHadActiveMediaStreamTrack to Document::hasHadCaptureMediaStreamTrack 2018-06-17 11:03:09 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1433816 0 youennf 2018-06-16 13:36:56 -0700 This will make it clearer that the code is about capture having happened and not generic media stream being created. 1433817 1 youennf 2018-06-16 13:46:37 -0700 <rdar://problem/41151193> 1433818 2 342888 youennf 2018-06-16 13:47:05 -0700 Created attachment 342888 Patch 1433886 3 342888 commit-queue 2018-06-17 11:03:07 -0700 Comment on attachment 342888 Patch Clearing flags on attachment: 342888 Committed r232915: <https://trac.webkit.org/changeset/232915> 1433887 4 commit-queue 2018-06-17 11:03:09 -0700 All reviewed patches have been landed. Closing bug. 342888 2018-06-16 13:47:05 -0700 2018-06-17 11:03:07 -0700 Patch bug-186743-20180616224704.patch text/plain 6909 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNmMTMyOGEyMmYzMzg4 OGYyOTYzNWJiZDUzMzNmMGRmMDQ5YjIxMS4uYjM4ODlhMjk5NmIxZjAxOTBhNjY2NGRlZjU5NGI5 YzQ3ODcyNWNjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE4LTA2LTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgRG9jdW1lbnQ6 Omhhc0hhZEFjdGl2ZU1lZGlhU3RyZWFtVHJhY2sgdG8gRG9jdW1lbnQ6Omhhc0hhZENhcHR1cmVN ZWRpYVN0cmVhbVRyYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODY3NDMKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNDExNTExOTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0 aW5nIHRlc3RzLgorCisgICAgICAgIFJlbmFtZSBzZXR0ZXIgYW5kIGdldHRlciB0byBiZSBtb3Jl IGFjY3VyYXRlLgorICAgICAgICBNb3ZlIHRoZSBwbGFjZSB0byBjYWxsIHRoZSBzZXR0ZXIgdG8g d2hlbiBjcmVhdGluZyBhIGNhcHR1cmUgc3RyZWFtLgorCisgICAgICAgICogTW9kdWxlcy9tZWRp YXN0cmVhbS9NZWRpYURldmljZXNSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh RGV2aWNlc1JlcXVlc3Q6OnN0YXJ0KToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL01l ZGlhU3RyZWFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtOjpzdGF0dXNEaWRD aGFuZ2UpOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpVc2VyTWVkaWFSZXF1ZXN0OjptZWRpYVN0cmVhbUlzUmVh ZHkpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OnNldEhhc0NhcHR1cmVNZWRpYVN0cmVhbVRyYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkRv Y3VtZW50OjpoYXNIYWRDYXB0dXJlTWVkaWFTdHJlYW1UcmFjayBjb25zdCk6CisgICAgICAgIChX ZWJDb3JlOjpEb2N1bWVudDo6c2V0SGFzQWN0aXZlTWVkaWFTdHJlYW1UcmFjayk6IERlbGV0ZWQu CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6aGFzSGFkQWN0aXZlTWVkaWFTdHJlYW1UcmFj ayBjb25zdCk6IERlbGV0ZWQuCisKIDIwMTgtMDYtMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIE5lZWQgdG8gcHJvcGVybHkgaGFuZGxlIHJlbW92YWwgb2Yg d29ya2VyIGluIFNXU2VydmVyOjp1bnJlZ2lzdGVyU2VydmljZVdvcmtlckNsaWVudCB0aW1lciBs YW1iZGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVk aWFEZXZpY2VzUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L01lZGlhRGV2aWNlc1JlcXVlc3QuY3BwCmluZGV4IDEyNDAwZGNmMmRlZWQ4ZmJjMjVlMWJmYTQy Mzk4ODIyMzI2ZjQxODMuLmUyYzViZjcwYTI2NzI0ZmQwNTdjOWE2YWU0NjFhZDVhZGE1M2Y5ZTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFEZXZp Y2VzUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9N ZWRpYURldmljZXNSZXF1ZXN0LmNwcApAQCAtMTIzLDcgKzEyMyw3IEBAIHZvaWQgTWVkaWFEZXZp Y2VzUmVxdWVzdDo6c3RhcnQoKQogICAgICAgICBWZWN0b3I8UmVmPE1lZGlhRGV2aWNlSW5mbz4+ IGRldmljZXM7CiAgICAgICAgIGZvciAoYXV0byYgZGV2aWNlSW5mbyA6IGNhcHR1cmVEZXZpY2Vz KSB7CiAgICAgICAgICAgICBhdXRvIGxhYmVsID0gZW1wdHlTdHJpbmcoKTsKLSAgICAgICAgICAg IGlmIChvcmlnaW5IYXNQZXJzaXN0ZW50QWNjZXNzIHx8IGRvY3VtZW50Lmhhc0hhZEFjdGl2ZU1l ZGlhU3RyZWFtVHJhY2soKSkKKyAgICAgICAgICAgIGlmIChvcmlnaW5IYXNQZXJzaXN0ZW50QWNj ZXNzIHx8IGRvY3VtZW50Lmhhc0hhZENhcHR1cmVNZWRpYVN0cmVhbVRyYWNrKCkpCiAgICAgICAg ICAgICAgICAgbGFiZWwgPSBkZXZpY2VJbmZvLmxhYmVsKCk7CiAKICAgICAgICAgICAgIGF1dG8g aWQgPSBSZWFsdGltZU1lZGlhU291cmNlQ2VudGVyOjpzaW5nbGV0b24oKS5oYXNoU3RyaW5nV2l0 aFNhbHQoZGV2aWNlSW5mby5wZXJzaXN0ZW50SWQoKSwgZGV2aWNlSWRlbnRpZmllckhhc2hTYWx0 KTsKQEAgLTEzNSw3ICsxMzUsNyBAQCB2b2lkIE1lZGlhRGV2aWNlc1JlcXVlc3Q6OnN0YXJ0KCkK ICAgICAgICAgICAgIGRldmljZXMuYXBwZW5kKE1lZGlhRGV2aWNlSW5mbzo6Y3JlYXRlKHNjcmlw dEV4ZWN1dGlvbkNvbnRleHQoKSwgbGFiZWwsIGlkLCBncm91cElkLCBkZXZpY2VUeXBlKSk7CiAg ICAgICAgIH0KIAotICAgICAgICBpZiAoIW9yaWdpbkhhc1BlcnNpc3RlbnRBY2Nlc3MgJiYgIWRv Y3VtZW50Lmhhc0hhZEFjdGl2ZU1lZGlhU3RyZWFtVHJhY2soKSkKKyAgICAgICAgaWYgKCFvcmln aW5IYXNQZXJzaXN0ZW50QWNjZXNzICYmICFkb2N1bWVudC5oYXNIYWRDYXB0dXJlTWVkaWFTdHJl YW1UcmFjaygpKQogICAgICAgICAgICAgZmlsdGVyRGV2aWNlTGlzdChkZXZpY2VzKTsKIAogICAg ICAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGRl dmljZXMgPSBXVEZNb3ZlKGRldmljZXMpXSgpIG11dGFibGUgewpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcAppbmRleCBiNzc4MDlkMmU3 NGUyMGM4NWVhMGMxZjExYjhmNzgzNGFjNjZlMTZiLi5jMjg0YTQxMDhkYjJmNjI0YTZkZmYxZDBj OTQ0ZGMyOWQyOGU4ZTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL01lZGlhU3RyZWFtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL01lZGlhU3RyZWFtLmNwcApAQCAtMzM2LDcgKzMzNiw2IEBAIHZvaWQgTWVkaWFTdHJl YW06OnN0YXR1c0RpZENoYW5nZSgpCiAgICAgaWYgKERvY3VtZW50KiBkb2N1bWVudCA9IHRoaXMt PmRvY3VtZW50KCkpIHsKICAgICAgICAgaWYgKCFtX2lzQWN0aXZlKQogICAgICAgICAgICAgcmV0 dXJuOwotICAgICAgICBkb2N1bWVudC0+c2V0SGFzQWN0aXZlTWVkaWFTdHJlYW1UcmFjaygpOwog ICAgICAgICBkb2N1bWVudC0+dXBkYXRlSXNQbGF5aW5nTWVkaWEoKTsKICAgICB9CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVl c3QuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1 ZXN0LmNwcAppbmRleCAwMGVjM2VkNjQ5N2FlZGUzOWMxMjNkNmU1M2IxYjgyM2Y3ODYzODU3Li43 ODViZjE2YTI1MTJlMzk3ZWE3ZDk5MDIxZWM1Zjg0NDJkOWU5M2MxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAK QEAgLTM1Myw2ICszNTMsNyBAQCB2b2lkIFVzZXJNZWRpYVJlcXVlc3Q6OlBlbmRpbmdBY3RpdmF0 aW9uTWVkaWFTdHJlYW06OmNoYXJhY3RlcmlzdGljc0NoYW5nZWQoKQogCiB2b2lkIFVzZXJNZWRp YVJlcXVlc3Q6Om1lZGlhU3RyZWFtSXNSZWFkeShSZWY8TWVkaWFTdHJlYW0+JiYgc3RyZWFtKQog eworICAgIHN0cmVhbS0+ZG9jdW1lbnQoKS0+c2V0SGFzQ2FwdHVyZU1lZGlhU3RyZWFtVHJhY2so KTsKICAgICBtX3Byb21pc2UucmVzb2x2ZShXVEZNb3ZlKHN0cmVhbSkpOwogICAgIC8vIFdlIGFy ZSBpbiBhbiBvYnNlcnZlciBpdGVyYXRvciBsb29wLCB3ZSBkbyBub3Qgd2FudCB0byBjaGFuZ2Ug dGhlIG9ic2VydmVycyB3aXRoaW4gdGhpcyBsb29wLgogICAgIGNhbGxPbk1haW5UaHJlYWQoW3N0 cmVhbSA9IFdURk1vdmUobV9wZW5kaW5nQWN0aXZhdGlvbk1lZGlhU3RyZWFtKV0geyB9KTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmgKaW5kZXggMGNiM2MxYzU4NDJkZDdkN2JiZjU0MjA3Y2I5MzljM2M3MDA0 NmM0NC4uNmVkMWU2ODc5Y2ExZTFkODlhZjg5YjIxYTJkZDBmZjY1ZmUzYzk5MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmgKQEAgLTEzMzIsOCArMTMzMiw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHJlbW92 ZVZpZXdwb3J0RGVwZW5kZW50UGljdHVyZShIVE1MUGljdHVyZUVsZW1lbnQmKTsKIAogI2lmIEVO QUJMRShNRURJQV9TVFJFQU0pCi0gICAgdm9pZCBzZXRIYXNBY3RpdmVNZWRpYVN0cmVhbVRyYWNr KCkgeyBtX2hhc0hhZEFjdGl2ZU1lZGlhU3RyZWFtVHJhY2sgPSB0cnVlOyB9Ci0gICAgYm9vbCBo YXNIYWRBY3RpdmVNZWRpYVN0cmVhbVRyYWNrKCkgY29uc3QgeyByZXR1cm4gbV9oYXNIYWRBY3Rp dmVNZWRpYVN0cmVhbVRyYWNrOyB9CisgICAgdm9pZCBzZXRIYXNDYXB0dXJlTWVkaWFTdHJlYW1U cmFjaygpIHsgbV9oYXNIYWRDYXB0dXJlTWVkaWFTdHJlYW1UcmFjayA9IHRydWU7IH0KKyAgICBi b29sIGhhc0hhZENhcHR1cmVNZWRpYVN0cmVhbVRyYWNrKCkgY29uc3QgeyByZXR1cm4gbV9oYXNI YWRDYXB0dXJlTWVkaWFTdHJlYW1UcmFjazsgfQogICAgIHZvaWQgc2V0RGV2aWNlSURIYXNoU2Fs dChjb25zdCBTdHJpbmcmIHNhbHQpIHsgbV9pZEhhc2hTYWx0ID0gc2FsdDsgfQogICAgIFN0cmlu ZyBkZXZpY2VJREhhc2hTYWx0KCkgY29uc3QgeyByZXR1cm4gbV9pZEhhc2hTYWx0OyB9CiAgICAg dm9pZCBzdG9wTWVkaWFDYXB0dXJlKCk7CkBAIC0xODk1LDcgKzE4OTUsNyBAQCBwcml2YXRlOgog I2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAgICAgSGFzaFNldDxIVE1MTWVkaWFFbGVtZW50Kj4g bV9tZWRpYVN0cmVhbVN0YXRlQ2hhbmdlRWxlbWVudHM7CiAgICAgU3RyaW5nIG1faWRIYXNoU2Fs dDsKLSAgICBib29sIG1faGFzSGFkQWN0aXZlTWVkaWFTdHJlYW1UcmFjayB7IGZhbHNlIH07Cisg ICAgYm9vbCBtX2hhc0hhZENhcHR1cmVNZWRpYVN0cmVhbVRyYWNrIHsgZmFsc2UgfTsKICNlbmRp ZgogCiAjaWZuZGVmIE5ERUJVRwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY0OTNkZTM0YTg4YzM1M2Y1ZTBmMjg0OTY5NWVm OWYzYWI2OTI2NjcuLmI2MjZjNmRiZTdhYWMxN2M3ODBjMDNkM2I1OGNjZDE0ZTkwMThiYTIgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0wNi0xNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CisKKyAgICAgICAgUmVuYW1lIERvY3VtZW50OjpoYXNIYWRBY3RpdmVNZWRpYVN0 cmVhbVRyYWNrIHRvIERvY3VtZW50OjpoYXNIYWRDYXB0dXJlTWVkaWFTdHJlYW1UcmFjaworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NzQzCisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzQxMTUxMTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL21lZGlhLWRldmljZXMtZW51 bWVyYXRlLWRldmljZXMuaHRtbDoKKwogMjAxOC0wNi0xNSAgTWljaGFlbCBDYXRhbnphcm8gIDxt Y2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV1bR1RLXVtXZWJHTF0gTGF5b3V0 IHRlc3QgZmFzdC9jYW52YXMvd2ViZ2wvc2ltdWxhdGVkLXZlcnRleEF0dHJpYjAtaW52YWxpZC1p bmRpY2llcy5odG1sIGlzIGZhaWxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbWVk aWFzdHJlYW0vbWVkaWEtZGV2aWNlcy1lbnVtZXJhdGUtZGV2aWNlcy5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9tZWRpYS1kZXZpY2VzLWVudW1lcmF0ZS1kZXZpY2VzLmh0bWwK aW5kZXggZTE3NWExOTRiZmZjNTYxZjgwZTQ0ZGUzZmM5MWM3NGJlOWY1MDY3Yy4uNmE5OWRiYTU5 NDJlOGFhZmU0MjA0ZGExYmFjOGMyODUwZGI1ZTMxNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9tZWRpYXN0cmVhbS9tZWRpYS1kZXZpY2VzLWVudW1lcmF0ZS1kZXZpY2VzLmh0bWwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9tZWRpYS1kZXZpY2VzLWVudW1lcmF0ZS1k ZXZpY2VzLmh0bWwKQEAgLTI3LDYgKzI3LDcgQEAKICAgICAgICAgICAgIGlmICh3aW5kb3cudGVz dFJ1bm5lcikKICAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLnNldFVzZXJNZWRpYVBlcm1pc3Np b24odHJ1ZSk7CiAKKyAgICAgICAgICAgIG5ldyB3aW5kb3cud2Via2l0QXVkaW9Db250ZXh0KCku Y3JlYXRlTWVkaWFTdHJlYW1EZXN0aW5hdGlvbigpOwogICAgICAgICAgICAgcmV0dXJuIG5hdmln YXRvci5tZWRpYURldmljZXMuZW51bWVyYXRlRGV2aWNlcygpCiAgICAgICAgICAgICAgICAgLnRo ZW4oKGRldmljZXMpID0+IHsKICAgICAgICAgICAgICAgICAgICAgZGV2aWNlQ291bnQgPSBkZXZp Y2VzLmxlbmd0aDsK