<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>186736</bug_id>
          
          <creation_ts>2018-06-16 12:31:57 -0700</creation_ts>
          <short_desc>JITThunks wastes 106KB of HashTable capacity on cnn.com</short_desc>
          <delta_ts>2022-02-12 19:52:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>207715</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>keith_miller</cc>
    
    <cc>saam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1433790</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-06-16 12:31:57 -0700</bug_when>
    <thetext>Using tooling from bug 186698, loading can and running &quot;notifyutil -p com.apple.WebKit.dumpHashTableCapacity&quot; shows:

Wasted capacity: 106528 bytes (used 24544 of 131072 bytes, utilization: 18.73%) - 1 allocations
1   0x11623be95 WTF::HashTable&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, WTF::KeyValuePair&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt; &gt;, WTF::KeyValuePairKeyExtractor&lt;WTF::KeyValuePair&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;, JSC::JITThunks::HostFunctionHash, WTF::HashMap&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt;, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits&lt;JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;::KeyValuePairTraits, JSC::JITThunks::HostFunctionHashTrait&gt;::HashTable()
2   0x11623be75 WTF::HashMap&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt;, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits&lt;JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;::HashMap()
3   0x11623be55 WTF::HashMap&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt;, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits&lt;JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;::HashMap()
4   0x116233661 JSC::JITThunks::JITThunks()
5   0x116233725 JSC::JITThunks::JITThunks()
6   0x1166be558 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
7   0x1166c1d51 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
8   0x1166c5406 JSC::VM::create(JSC::HeapType)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1433791</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-06-16 12:32:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/41189174&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1433810</commentid>
    <comment_count>2</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2018-06-16 12:44:19 -0700</bug_when>
    <thetext>On nytimes.com:

Wasted capacity: 98176 bytes (used 32896 of 131072 bytes, utilization: 25.10%) - 1 allocations
1   0x11623be95 WTF::HashTable&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, WTF::KeyValuePair&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt; &gt;, WTF::KeyValuePairKeyExtractor&lt;WTF::KeyValuePair&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;, JSC::JITThunks::HostFunctionHash, WTF::HashMap&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt;, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits&lt;JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;::KeyValuePairTraits, JSC::JITThunks::HostFunctionHashTrait&gt;::HashTable()
2   0x11623be75 WTF::HashMap&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt;, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits&lt;JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;::HashMap()
3   0x11623be55 WTF::HashMap&lt;std::__1::tuple&lt;JSC::TaggedNativeFunction, JSC::TaggedNativeFunction, WTF::String&gt;, JSC::Weak&lt;JSC::NativeExecutable&gt;, JSC::JITThunks::HostFunctionHash, JSC::JITThunks::HostFunctionHashTrait, WTF::HashTraits&lt;JSC::Weak&lt;JSC::NativeExecutable&gt; &gt; &gt;::HashMap()
4   0x116233661 JSC::JITThunks::JITThunks()
5   0x116233725 JSC::JITThunks::JITThunks()
6   0x1166be558 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
7   0x1166c1d51 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType)
8   0x1166c5406 JSC::VM::create(JSC::HeapType)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624249</commentid>
    <comment_count>3</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-29 01:19:38 -0800</bug_when>
    <thetext>Note that we recently compacted this into 1/4 size.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624250</commentid>
    <comment_count>4</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-29 01:19:54 -0800</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=207715</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1840822</commentid>
    <comment_count>5</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2022-02-12 19:52:15 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 207715 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>