186723 2018-06-16 10:10:33 -0700 [JSC] Inline JSArray::pushInline and Structure::nonPropertyTransition 2018-06-16 11:30:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1433725 0 ysuzuki 2018-06-16 10:10:33 -0700 [JSC] Inline JSArray::pushInline and Structure::nonPropertyTransition 1433727 1 342882 ysuzuki 2018-06-16 10:12:12 -0700 Created attachment 342882 Patch 1433739 2 342882 mark.lam 2018-06-16 11:17:27 -0700 Comment on attachment 342882 Patch r=me 1433746 3 ysuzuki 2018-06-16 11:29:46 -0700 Committed r232907: <https://trac.webkit.org/changeset/232907> 1433747 4 webkit-bug-importer 2018-06-16 11:30:23 -0700 <rdar://problem/41188757> 342882 2018-06-16 10:12:12 -0700 2018-06-16 11:17:27 -0700 Patch bug-186723-20180617021211.patch text/plain 6534 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NzEzZjE5OTRlMmU2YzRkY2NhNjUwZDBiYzg4ZmJkOGRhZWQyNDYzLi42NzZjOTVhYWRiM2M1OGU4 MjY0NWI4NWViMTI3NDU4NDBmOWUyYjVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOC0wNi0xNiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBJbmxpbmUgSlNBcnJheTo6cHVzaElubGluZSBhbmQgU3Ry dWN0dXJlOjpub25Qcm9wZXJ0eVRyYW5zaXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjcyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vdywgQ29XIC0+IG5vbi1Db1cgdHJhbnNpdGlvbiBpcyBo ZWF2eSBwYXRoLiBXZSBpbmxpbmUgdGhlIHBhcnQgb2YgU3RydWN0dXJlOjpub25Qcm9wZXJ0eVRy YW5zaXRpb24KKyAgICAgICAgdG8gY2F0Y2ggdGhlIG1ham9yIHBhdGguIEFuZCB3ZSBhbHNvIGlu bGluZSBKU0FycmF5OjpwdXNoSW5saW5lIHdlbGwgdG8gc3ByZWFkIHRoaXMgaW4gb3BlcmF0aW9u QXJyYXlQdXNoTXVsdGlwbGUuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpbXByb3ZlcyBTaXhTcGVl ZC9zcHJlYWQtbGl0ZXJhbC5lczUuCisKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBiYXNlbGluZSAgICAgICAgICAgICAgICAgIHBhdGNoZWQKKworICAgICAgICBzcHJlYWQt bGl0ZXJhbC5lczUgICAgICAxMTQuNDE0MCstNC41MTQ2ICAgICBeICAgIDEwNC41NDc1Ky0zLjYx NTcgICAgICAgIF4gZGVmaW5pdGVseSAxLjA5NDR4IGZhc3RlcgorCisgICAgICAgICogcnVudGlt ZS9KU0FycmF5SW5saW5lcy5oOgorICAgICAgICAoSlNDOjpKU0FycmF5OjpwdXNoSW5saW5lKToK KyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVyZS5jcHA6CisgICAgICAgIChKU0M6OlN0cnVjdHVy ZTo6bm9uUHJvcGVydHlUcmFuc2l0aW9uU2xvdyk6CisgICAgICAgIChKU0M6OlN0cnVjdHVyZTo6 bm9uUHJvcGVydHlUcmFuc2l0aW9uKTogRGVsZXRlZC4KKyAgICAgICAgKiBydW50aW1lL1N0cnVj dHVyZS5oOgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlSW5saW5lcy5oOgorICAgICAgICAo SlNDOjpTdHJ1Y3R1cmU6Om5vblByb3BlcnR5VHJhbnNpdGlvbik6CisKIDIwMTgtMDYtMTYgIFl1 c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0RGR10gUmVk dWNlIE9TUkV4aXQgZm9yIEtyYWtlbi9jcnlwdG8tYWVzIGR1ZSB0byBDb1cgYXJyYXkKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXlJbmxpbmVzLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5SW5saW5lcy5oCmluZGV4IGNmZTcz YmFmNjliY2MyZmQwOGE0ZDgxMGYxZjQzYjVjMzExOTllNTkuLjM5MzM4ZDA0N2E0NzMwMzZiZjll MTQwM2NkODZjZmE5NjhmYmI3MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTQXJyYXlJbmxpbmVzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNBcnJheUlubGluZXMuaApAQCAtODMsMTEgKzgzLDEyIEBAIEFMV0FZU19JTkxJTkUgZG91 YmxlIHRvTGVuZ3RoKEV4ZWNTdGF0ZSogZXhlYywgSlNPYmplY3QqIG9iaikKICAgICByZXR1cm4g bGVuZ3RoVmFsdWUudG9MZW5ndGgoZXhlYyk7CiB9CiAKLWlubGluZSB2b2lkIEpTQXJyYXk6OnB1 c2hJbmxpbmUoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHZhbHVlKQorQUxXQVlTX0lOTElORSB2 b2lkIEpTQXJyYXk6OnB1c2hJbmxpbmUoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHZhbHVlKQog ewogICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7CiAgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhS T1dfU0NPUEUodm0pOwogCityZWxvb3A6CiAgICAgQnV0dGVyZmx5KiBidXR0ZXJmbHkgPSB0aGlz LT5idXR0ZXJmbHkoKTsKIAogICAgIHN3aXRjaCAoaW5kZXhpbmdNb2RlKCkpIHsKQEAgLTIzMCw5 ICsyMzEsNyBAQCBpbmxpbmUgdm9pZCBKU0FycmF5OjpwdXNoSW5saW5lKEV4ZWNTdGF0ZSogZXhl YywgSlNWYWx1ZSB2YWx1ZSkKICAgICBkZWZhdWx0OiB7CiAgICAgICAgIFJFTEVBU0VfQVNTRVJU KGlzQ29weU9uV3JpdGUoaW5kZXhpbmdNb2RlKCkpKTsKICAgICAgICAgY29udmVydEZyb21Db3B5 T25Xcml0ZSh2bSk7Ci0gICAgICAgIHNjb3BlLnJlbGVhc2UoKTsKLSAgICAgICAgLy8gUmVsb29w LgotICAgICAgICByZXR1cm4gcHVzaElubGluZShleGVjLCB2YWx1ZSk7CisgICAgICAgIGdvdG8g cmVsb29wOwogICAgIH0KICAgICB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3RydWN0dXJlLmNwcAppbmRleCBhN2ZlZjQ1NDIyNjNmMGZjYWNjMmFmNzg2MDAwZDM5YmFiYmFj MGY3Li4wNTkwZTVmODA2NzNmMmM2ZjVhNDkzZWEyMTIzYjU5YmEzNTZmNDMwIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKQEAgLTY0NiwyMyArNjQ2LDEx IEBAIFByb3BlcnR5VGFibGUqIFN0cnVjdHVyZTo6dGFrZVByb3BlcnR5VGFibGVPckNsb25lSWZQ aW5uZWQoVk0mIHZtKQogICAgIHJldHVybiBtYXRlcmlhbGl6ZVByb3BlcnR5VGFibGUodm0sIHNl dFByb3BlcnR5VGFibGUpOwogfQogCi1TdHJ1Y3R1cmUqIFN0cnVjdHVyZTo6bm9uUHJvcGVydHlU cmFuc2l0aW9uKFZNJiB2bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIE5vblByb3BlcnR5VHJhbnNp dGlvbiB0cmFuc2l0aW9uS2luZCkKK1N0cnVjdHVyZSogU3RydWN0dXJlOjpub25Qcm9wZXJ0eVRy YW5zaXRpb25TbG93KFZNJiB2bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIE5vblByb3BlcnR5VHJh bnNpdGlvbiB0cmFuc2l0aW9uS2luZCkKIHsKICAgICB1bnNpZ25lZCBhdHRyaWJ1dGVzID0gdG9B dHRyaWJ1dGVzKHRyYW5zaXRpb25LaW5kKTsKICAgICBJbmRleGluZ1R5cGUgaW5kZXhpbmdNb2Rl SW5jbHVkaW5nSGlzdG9yeSA9IG5ld0luZGV4aW5nVHlwZShzdHJ1Y3R1cmUtPmluZGV4aW5nTW9k ZUluY2x1ZGluZ0hpc3RvcnkoKSwgdHJhbnNpdGlvbktpbmQpOwogICAgIAotICAgIGlmIChjaGFu Z2VzSW5kZXhpbmdUeXBlKHRyYW5zaXRpb25LaW5kKSkgewotICAgICAgICBpZiAoSlNHbG9iYWxP YmplY3QqIGdsb2JhbE9iamVjdCA9IHN0cnVjdHVyZS0+bV9nbG9iYWxPYmplY3QuZ2V0KCkpIHsK LSAgICAgICAgICAgIGlmIChnbG9iYWxPYmplY3QtPmlzT3JpZ2luYWxBcnJheVN0cnVjdHVyZShz dHJ1Y3R1cmUpKSB7Ci0gICAgICAgICAgICAgICAgU3RydWN0dXJlKiByZXN1bHQgPSBnbG9iYWxP YmplY3QtPm9yaWdpbmFsQXJyYXlTdHJ1Y3R1cmVGb3JJbmRleGluZ1R5cGUoaW5kZXhpbmdNb2Rl SW5jbHVkaW5nSGlzdG9yeSk7Ci0gICAgICAgICAgICAgICAgaWYgKHJlc3VsdC0+aW5kZXhpbmdN b2RlSW5jbHVkaW5nSGlzdG9yeSgpID09IGluZGV4aW5nTW9kZUluY2x1ZGluZ0hpc3RvcnkpIHsK LSAgICAgICAgICAgICAgICAgICAgc3RydWN0dXJlLT5kaWRUcmFuc2l0aW9uRnJvbVRoaXNTdHJ1 Y3R1cmUoKTsKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKLSAgICAgICAgICAg ICAgICB9Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9Ci0gICAgCiAgICAgU3RydWN0 dXJlKiBleGlzdGluZ1RyYW5zaXRpb247CiAgICAgaWYgKCFzdHJ1Y3R1cmUtPmlzRGljdGlvbmFy eSgpICYmIChleGlzdGluZ1RyYW5zaXRpb24gPSBzdHJ1Y3R1cmUtPm1fdHJhbnNpdGlvblRhYmxl LmdldCgwLCBhdHRyaWJ1dGVzKSkpIHsKICAgICAgICAgQVNTRVJUKGV4aXN0aW5nVHJhbnNpdGlv bi0+YXR0cmlidXRlc0luUHJldmlvdXMoKSA9PSBhdHRyaWJ1dGVzKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgKaW5kZXggNTAzY2U0NjI2YjExMDJjOGZhYjQ4NGEx ZTQyZTE1ZmM0MGY2ODMxMy4uYThiZDRiYjVkYjk5ZTc3ZDgzYjg5MGRhMTY1MDkzYjFlM2ZmNmVm OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgKQEAgLTE5NSw3 ICsxOTUsOCBAQCBjbGFzcyBTdHJ1Y3R1cmUgZmluYWwgOiBwdWJsaWMgSlNDZWxsIHsKICAgICBK U19FWFBPUlRfUFJJVkFURSBzdGF0aWMgU3RydWN0dXJlKiBzZWFsVHJhbnNpdGlvbihWTSYsIFN0 cnVjdHVyZSopOwogICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBTdHJ1Y3R1cmUqIGZyZWV6 ZVRyYW5zaXRpb24oVk0mLCBTdHJ1Y3R1cmUqKTsKICAgICBzdGF0aWMgU3RydWN0dXJlKiBwcmV2 ZW50RXh0ZW5zaW9uc1RyYW5zaXRpb24oVk0mLCBTdHJ1Y3R1cmUqKTsKLSAgICBKU19FWFBPUlRf UFJJVkFURSBzdGF0aWMgU3RydWN0dXJlKiBub25Qcm9wZXJ0eVRyYW5zaXRpb24oVk0mLCBTdHJ1 Y3R1cmUqLCBOb25Qcm9wZXJ0eVRyYW5zaXRpb24pOworICAgIHN0YXRpYyBTdHJ1Y3R1cmUqIG5v blByb3BlcnR5VHJhbnNpdGlvbihWTSYsIFN0cnVjdHVyZSosIE5vblByb3BlcnR5VHJhbnNpdGlv bik7CisgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3RhdGljIFN0cnVjdHVyZSogbm9uUHJvcGVydHlU cmFuc2l0aW9uU2xvdyhWTSYsIFN0cnVjdHVyZSosIE5vblByb3BlcnR5VHJhbnNpdGlvbik7CiAK ICAgICBKU19FWFBPUlRfUFJJVkFURSBib29sIGlzU2VhbGVkKFZNJik7CiAgICAgSlNfRVhQT1JU X1BSSVZBVEUgYm9vbCBpc0Zyb3plbihWTSYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvU3RydWN0dXJlSW5saW5lcy5oCmluZGV4IDZiZDhlZjRmZTI4ODIwNjA1NzI0Y2Ix MzM0ZTc4ZmVmMjYwNmNiZjYuLjFjOTQ2MjhjY2FiMGUxNjFjMTM1M2VhMTIyNDkwNTczNmU2ZGU4 ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZUlu bGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJbmxp bmVzLmgKQEAgLTUyMyw1ICs1MjMsMjQgQEAgQUxXQVlTX0lOTElORSBib29sIFN0cnVjdHVyZTo6 c2hvdWxkQ29udmVydFRvUG9seVByb3RvKGNvbnN0IFN0cnVjdHVyZSogYSwgY29uc3QKIAogICAg IHJldHVybiAhYU9iaiAmJiAhYk9iajsKIH0KLSAgICAKKworaW5saW5lIFN0cnVjdHVyZSogU3Ry dWN0dXJlOjpub25Qcm9wZXJ0eVRyYW5zaXRpb24oVk0mIHZtLCBTdHJ1Y3R1cmUqIHN0cnVjdHVy ZSwgTm9uUHJvcGVydHlUcmFuc2l0aW9uIHRyYW5zaXRpb25LaW5kKQoreworICAgIEluZGV4aW5n VHlwZSBpbmRleGluZ01vZGVJbmNsdWRpbmdIaXN0b3J5ID0gbmV3SW5kZXhpbmdUeXBlKHN0cnVj dHVyZS0+aW5kZXhpbmdNb2RlSW5jbHVkaW5nSGlzdG9yeSgpLCB0cmFuc2l0aW9uS2luZCk7CisK KyAgICBpZiAoY2hhbmdlc0luZGV4aW5nVHlwZSh0cmFuc2l0aW9uS2luZCkpIHsKKyAgICAgICAg aWYgKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBzdHJ1Y3R1cmUtPm1fZ2xvYmFsT2Jq ZWN0LmdldCgpKSB7CisgICAgICAgICAgICBpZiAoZ2xvYmFsT2JqZWN0LT5pc09yaWdpbmFsQXJy YXlTdHJ1Y3R1cmUoc3RydWN0dXJlKSkgeworICAgICAgICAgICAgICAgIFN0cnVjdHVyZSogcmVz dWx0ID0gZ2xvYmFsT2JqZWN0LT5vcmlnaW5hbEFycmF5U3RydWN0dXJlRm9ySW5kZXhpbmdUeXBl KGluZGV4aW5nTW9kZUluY2x1ZGluZ0hpc3RvcnkpOworICAgICAgICAgICAgICAgIGlmIChyZXN1 bHQtPmluZGV4aW5nTW9kZUluY2x1ZGluZ0hpc3RvcnkoKSA9PSBpbmRleGluZ01vZGVJbmNsdWRp bmdIaXN0b3J5KSB7CisgICAgICAgICAgICAgICAgICAgIHN0cnVjdHVyZS0+ZGlkVHJhbnNpdGlv bkZyb21UaGlzU3RydWN0dXJlKCk7CisgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7 CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQorCisg ICAgcmV0dXJuIG5vblByb3BlcnR5VHJhbnNpdGlvblNsb3codm0sIHN0cnVjdHVyZSwgdHJhbnNp dGlvbktpbmQpOworfQorCiB9IC8vIG5hbWVzcGFjZSBKU0MK