186710 2018-06-15 15:15:04 -0700 AutoTableLayout wastes 52KB of Vector capacity on nytimes.com 2018-06-25 08:57:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1433601 0 simon.fraser 2018-06-15 15:15:04 -0700 Tooling in bug 186698 Wasted capacity: 51960 bytes (used 17320 of 69280 bytes, utilization: 25.00%) - 433 allocations 1 0x108567241 WTF::VectorBuffer<WebCore::AutoTableLayout::Layout, 4ul>::VectorBuffer() 2 0x108567205 WTF::Vector<WebCore::AutoTableLayout::Layout, 4ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x108557c95 WTF::Vector<WebCore::AutoTableLayout::Layout, 4ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x108557c05 WebCore::AutoTableLayout::AutoTableLayout(WebCore::RenderTable*) 5 0x108557cdd WebCore::AutoTableLayout::AutoTableLayout(WebCore::RenderTable*) 6 0x1088630af WebCore::RenderTable::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) 7 0x1086d6d74 WebCore::RenderElement::initializeStyle() 8 0x108ab4954 WebCore::RenderTreeUpdater::createRenderer(WebCore::Element&, WebCore::RenderStyle&&) 1433602 1 webkit-bug-importer 2018-06-15 15:15:27 -0700 <rdar://problem/41173948> 1435990 2 343486 simon.fraser 2018-06-24 23:23:29 -0700 Created attachment 343486 Patch 1436072 3 343486 commit-queue 2018-06-25 08:57:17 -0700 Comment on attachment 343486 Patch Clearing flags on attachment: 343486 Committed r233148: <https://trac.webkit.org/changeset/233148> 1436073 4 commit-queue 2018-06-25 08:57:19 -0700 All reviewed patches have been landed. Closing bug. 343486 2018-06-24 23:23:29 -0700 2018-06-25 08:57:17 -0700 Patch bug-186710-20180624232328.patch text/plain 2505 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZmYjAyMWFkNWY4NDhl MDZmYjc4NDljMGM5ODBkOGY0NjQ0N2IyMS4uNDk2Zjc0NWQxYWM0MmY1M2JiMDNjMDRhZTNkYzQ5 NTM2YzU0OGE1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF1dG9UYWJsZUxh eW91dCB3YXN0ZXMgNTJLQiBvZiBWZWN0b3IgY2FwYWNpdHkgb24gbnl0aW1lcy5jb20KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjcxMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQ2FsbCBy ZXNpemVUb0ZpdCgpIHRvIG9ubHkgYWxsb2NhdGUgZW5vdWdoIGNhcGFjaXR5IGZvciB0aGUgbnVt YmVyIG9mIGNvbHVtbnMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkF1dG9UYWJsZUxheW91dDo6ZnVsbFJlY2FsYyk6CisgICAg ICAgIChXZWJDb3JlOjpBdXRvVGFibGVMYXlvdXQ6Omluc2VydFNwYW5DZWxsKTogV2hpdGVzcGFj ZSBmaXguCisgICAgICAgICogcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5oOgorCiAyMDE4LTA2 LTIzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01haWxdIFVz ZSB0aGUgTWFpbCBWaWV3ZXIgd2lkdGggYXMgdGhlIGJhc2UgZm9yIHJlc29sdmluZyBob3Jpem9u dGFsIHZpZXdwb3J0IHVuaXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv QXV0b1RhYmxlTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVM YXlvdXQuY3BwCmluZGV4IDM3Y2M0MDk5ZWU2MzE5M2FmODk3YzkxZWMxNGI0ODM2ZDZjZjlmMGMu LmUyZmVhODJiMjlmYWE4Nzg2YjU2NTI3ZTc3ZjczYWE5MDc3OTNjMDAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwCkBAIC0xNDYsNyArMTQ2LDcgQEAg dm9pZCBBdXRvVGFibGVMYXlvdXQ6OmZ1bGxSZWNhbGMoKQogICAgIG1fZWZmZWN0aXZlTG9naWNh bFdpZHRoRGlydHkgPSB0cnVlOwogCiAgICAgdW5zaWduZWQgbkVmZkNvbHMgPSBtX3RhYmxlLT5u dW1FZmZDb2xzKCk7Ci0gICAgbV9sYXlvdXRTdHJ1Y3QucmVzaXplKG5FZmZDb2xzKTsKKyAgICBt X2xheW91dFN0cnVjdC5yZXNpemVUb0ZpdChuRWZmQ29scyk7CiAgICAgbV9sYXlvdXRTdHJ1Y3Qu ZmlsbChMYXlvdXQoKSk7CiAgICAgbV9zcGFuQ2VsbHMuZmlsbCgwKTsKIApAQCAtNDgzLDcgKzQ4 Myw3IEBAIHZvaWQgQXV0b1RhYmxlTGF5b3V0OjppbnNlcnRTcGFuQ2VsbChSZW5kZXJUYWJsZUNl bGwgKmNlbGwpCiAgICAgaWYgKCFzaXplIHx8IG1fc3BhbkNlbGxzW3NpemUtMV0gIT0gMCkgewog ICAgICAgICBtX3NwYW5DZWxscy5ncm93KHNpemUgKyAxMCk7CiAgICAgICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCAxMDsgaSsrKQotICAgICAgICAgICAgbV9zcGFuQ2VsbHNbc2l6ZStpXSA9 IDA7CisgICAgICAgICAgICBtX3NwYW5DZWxsc1tzaXplICsgaV0gPSAwOwogICAgICAgICBzaXpl ICs9IDEwOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1 dG9UYWJsZUxheW91dC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91 dC5oCmluZGV4IDg2NzI5YzM5YjgyYjM0ZjQxOGIwMjNiZmQ2YjMzODUzZDI5MTUzYTcuLmY2MTdi ZDhkNjRlYjVhYTdlNThiY2VhMzRiM2M1MTY2YjA0MzIwMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0LmgKQEAgLTU5LDggKzU5LDggQEAgcHJpdmF0ZToKICAg ICAgICAgYm9vbCBlbXB0eUNlbGxzT25seSB7IHRydWUgfTsKICAgICB9OwogCi0gICAgVmVjdG9y PExheW91dCwgND4gbV9sYXlvdXRTdHJ1Y3Q7Ci0gICAgVmVjdG9yPFJlbmRlclRhYmxlQ2VsbCos IDQ+IG1fc3BhbkNlbGxzOworICAgIFZlY3RvcjxMYXlvdXQ+IG1fbGF5b3V0U3RydWN0OworICAg IFZlY3RvcjxSZW5kZXJUYWJsZUNlbGwqPiBtX3NwYW5DZWxsczsKICAgICBib29sIG1faGFzUGVy Y2VudCA6IDE7CiAgICAgbXV0YWJsZSBib29sIG1fZWZmZWN0aXZlTG9naWNhbFdpZHRoRGlydHkg OiAxOwogICAgIExheW91dFVuaXQgbV9zY2FsZWRXaWR0aEZyb21QZXJjZW50Q29sdW1uczsK