186706 2018-06-15 15:08:36 -0700 ContentSecurityPolicySourceList wastes 51KB of Vector capacity on cnn.com 2018-06-20 12:39:09 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser beidson cdumez commit-queue dbates ews-watchlist mkwst simon.fraser webkit-bug-importer wilander oldest_to_newest 1433590 0 simon.fraser 2018-06-15 15:08:36 -0700 Tooling from bug 186698: Wasted capacity: 51264 bytes (used 13248 of 64512 bytes, utilization: 20.54%) - 132 allocations 1 0x10810c735 WTF::VectorBuffer<WebCore::ContentSecurityPolicySource, 0ul>::VectorBuffer() 2 0x10810c715 WTF::Vector<WebCore::ContentSecurityPolicySource, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x108109d05 WTF::Vector<WebCore::ContentSecurityPolicySource, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x108109c72 WebCore::ContentSecurityPolicySourceList::ContentSecurityPolicySourceList(WebCore::ContentSecurityPolicy const&, WTF::String const&) 5 0x108109d55 WebCore::ContentSecurityPolicySourceList::ContentSecurityPolicySourceList(WebCore::ContentSecurityPolicy const&, WTF::String const&) 6 0x10810bec7 WebCore::ContentSecurityPolicySourceListDirective::ContentSecurityPolicySourceListDirective(WebCore::ContentSecurityPolicyDirectiveList const&, WTF::String const&, WTF::String const&) 7 0x10810bf1d WebCore::ContentSecurityPolicySourceListDirective::ContentSecurityPolicySourceListDirective(WebCore::ContentSecurityPolicyDirectiveList const&, WTF::String const&, WTF::String const&) 8 0x1080f0e3f void WebCore::ContentSecurityPolicyDirectiveList::setCSPDirective<WebCore::ContentSecurityPolicySourceListDirective>(WTF::String const&, WTF::String const&, std::__1::unique_ptr<WebCore::ContentSecurityPolicySourceListDirective, std::__1::default_delete<WebCore::ContentSecurityPolicySourceListDirective> >&) 1433592 1 webkit-bug-importer 2018-06-15 15:09:06 -0700 <rdar://problem/41173711> 1433600 2 cdumez 2018-06-15 15:14:43 -0700 Adding Daniel to cc since this is CSP. 1434853 3 343168 simon.fraser 2018-06-20 11:29:24 -0700 Created attachment 343168 Patch 1434871 4 343168 commit-queue 2018-06-20 12:39:07 -0700 Comment on attachment 343168 Patch Clearing flags on attachment: 343168 Committed r233019: <https://trac.webkit.org/changeset/233019> 1434872 5 commit-queue 2018-06-20 12:39:09 -0700 All reviewed patches have been landed. Closing bug. 343168 2018-06-20 11:29:24 -0700 2018-06-20 12:39:07 -0700 Patch bug-186706-20180620112923.patch text/plain 4289 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODAyMjE5MDNhNTJlZjg2 ZGExMGUwZWJiNTgxNjFlZTBmNTMxZjg3ZC4uZmU2MWQ5OGVhZjdkZWQxNGUzYzBjZjU4NGYyZGFl YjFmOTU5Y2E2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA2LTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENvbnRlbnRTZWN1 cml0eVBvbGljeVNvdXJjZUxpc3Qgd2FzdGVzIDUxS0Igb2YgVmVjdG9yIGNhcGFjaXR5IG9uIGNu bi5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 NjcwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h a2UgQ29udGVudFNlY3VyaXR5UG9saWN5U291cmNlTGlzdDo6cGFyc2UoKSBjYWxsIHNocmlua1Rv Rml0KCkgb24gbV9saXN0CisgICAgICAgIGFmdGVyIHBhcnNpbmcgdG8gZWxpbWluYXRlIHdhc3Rl ZCB2ZWN0b3IgY2FwYWNpdHkuCisgICAgICAgIAorICAgICAgICBTaHJpbmsgQ29udGVudFNlY3Vy aXR5UG9saWN5U291cmNlIGRvd24gdG8gNDAgYnl0ZXMgYnkgb3B0aW1pemluZyBwYWNraW5nLgor CisgICAgICAgICogcGFnZS9jc3AvQ29udGVudFNlY3VyaXR5UG9saWN5U291cmNlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNvbnRlbnRTZWN1cml0eVBvbGljeVNvdXJjZTo6Q29udGVudFNlY3Vy aXR5UG9saWN5U291cmNlKToKKyAgICAgICAgKiBwYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xp Y3lTb3VyY2UuaDoKKyAgICAgICAgKiBwYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xpY3lTb3Vy Y2VMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRTZWN1cml0eVBvbGljeVNvdXJj ZUxpc3Q6Om1hdGNoZXMgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudFNlY3VyaXR5 UG9saWN5U291cmNlTGlzdDo6cGFyc2UpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudFNlY3Vy aXR5UG9saWN5U291cmNlTGlzdDo6bWF0Y2hlcyk6IERlbGV0ZWQuCisgICAgICAgICogcGFnZS9j c3AvQ29udGVudFNlY3VyaXR5UG9saWN5U291cmNlTGlzdC5oOgorCiAyMDE4LTA2LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU3R5bGVSdWxlTWVkaWEgd2Fz dGVzIDE1OEtCIG9mIFZlY3RvciBjYXBhY2l0eSBvbiBjbm4uY29tCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xpY3lTb3VyY2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9jc3AvQ29udGVudFNlY3VyaXR5UG9saWN5U291cmNlLmNwcAppbmRl eCAxM2E4OTYzMDE5MGEyODAyNjhiOTZiOTlhZmU4M2U2N2NkNmI3NDFjLi5hODM0NGFkNjZkYmYx ZTJlMmUzMGEyMmM4NTAxZmYwOThiYjZmM2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xpY3lTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvY3NwL0NvbnRlbnRTZWN1cml0eVBvbGljeVNvdXJjZS5jcHAKQEAgLTM3LDggKzM3 LDggQEAgQ29udGVudFNlY3VyaXR5UG9saWN5U291cmNlOjpDb250ZW50U2VjdXJpdHlQb2xpY3lT b3VyY2UoY29uc3QgQ29udGVudFNlY3VyaXR5UG8KICAgICA6IG1fcG9saWN5KHBvbGljeSkKICAg ICAsIG1fc2NoZW1lKHNjaGVtZSkKICAgICAsIG1faG9zdChob3N0KQotICAgICwgbV9wb3J0KHBv cnQpCiAgICAgLCBtX3BhdGgocGF0aCkKKyAgICAsIG1fcG9ydChwb3J0KQogICAgICwgbV9ob3N0 SGFzV2lsZGNhcmQoaG9zdEhhc1dpbGRjYXJkKQogICAgICwgbV9wb3J0SGFzV2lsZGNhcmQocG9y dEhhc1dpbGRjYXJkKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9jc3AvQ29u dGVudFNlY3VyaXR5UG9saWN5U291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NzcC9Db250 ZW50U2VjdXJpdHlQb2xpY3lTb3VyY2UuaAppbmRleCA1NmNmMGRjOWU5Zjc0YmVkMWFkM2EzODc3 NjBmZTdhYzY2OTQyOWM2Li40ZWVhYmIwMTM2NTI1MWI2ZDg5NjMzY2E5NjgwZDAxNWYyMzEwNmFh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xp Y3lTb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQ b2xpY3lTb3VyY2UuaApAQCAtNTMsOCArNTMsOCBAQCBwcml2YXRlOgogICAgIGNvbnN0IENvbnRl bnRTZWN1cml0eVBvbGljeSYgbV9wb2xpY3k7CiAgICAgU3RyaW5nIG1fc2NoZW1lOwogICAgIFN0 cmluZyBtX2hvc3Q7Ci0gICAgc3RkOjpvcHRpb25hbDx1aW50MTZfdD4gbV9wb3J0OwogICAgIFN0 cmluZyBtX3BhdGg7CisgICAgc3RkOjpvcHRpb25hbDx1aW50MTZfdD4gbV9wb3J0OwogCiAgICAg Ym9vbCBtX2hvc3RIYXNXaWxkY2FyZDsKICAgICBib29sIG1fcG9ydEhhc1dpbGRjYXJkOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9jc3AvQ29udGVudFNlY3VyaXR5UG9saWN5U291 cmNlTGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xp Y3lTb3VyY2VMaXN0LmNwcAppbmRleCBiZTZkYzg4MWY0ODNkOGQ1OGRhNmZlYjk4ZTE0MmYzYjVm NTNmNjExLi40MGI1ZGQxZGU1MDhjODA2MDUzMzU2YjRmM2U2ODFiOGFlMDI0ZGRjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xpY3lTb3VyY2VM aXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xp Y3lTb3VyY2VMaXN0LmNwcApAQCAtMTMwLDcgKzEzMCw3IEBAIGJvb2wgQ29udGVudFNlY3VyaXR5 UG9saWN5U291cmNlTGlzdDo6aXNQcm90b2NvbEFsbG93ZWRCeVN0YXIoY29uc3QgVVJMJiB1cmwp IGNvCiAgICAgcmV0dXJuIGlzQWxsb3dlZDsKIH0KIAotYm9vbCBDb250ZW50U2VjdXJpdHlQb2xp Y3lTb3VyY2VMaXN0OjptYXRjaGVzKGNvbnN0IFVSTCYgdXJsLCBib29sIGRpZFJlY2VpdmVSZWRp cmVjdFJlc3BvbnNlKQorYm9vbCBDb250ZW50U2VjdXJpdHlQb2xpY3lTb3VyY2VMaXN0OjptYXRj aGVzKGNvbnN0IFVSTCYgdXJsLCBib29sIGRpZFJlY2VpdmVSZWRpcmVjdFJlc3BvbnNlKSBjb25z dAogewogICAgIGlmIChtX2FsbG93U3RhciAmJiBpc1Byb3RvY29sQWxsb3dlZEJ5U3Rhcih1cmwp KQogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTE5Niw2ICsxOTYsOCBAQCB2b2lkIENvbnRlbnRT ZWN1cml0eVBvbGljeVNvdXJjZUxpc3Q6OnBhcnNlKGNvbnN0IFVDaGFyKiBiZWdpbiwgY29uc3Qg VUNoYXIqIGVuZAogCiAgICAgICAgIEFTU0VSVChwb3NpdGlvbiA9PSBlbmQgfHwgaXNBU0NJSVNw YWNlKCpwb3NpdGlvbikpOwogICAgIH0KKyAgICAKKyAgICBtX2xpc3Quc2hyaW5rVG9GaXQoKTsK IH0KIAogLy8gc291cmNlICAgICAgICAgICAgPSBzY2hlbWUgIjoiCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xpY3lTb3VyY2VMaXN0LmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL2NzcC9Db250ZW50U2VjdXJpdHlQb2xpY3lTb3VyY2VMaXN0LmgK aW5kZXggMDRkYzI5YzMzZjRjYWMxMGE5MTg3OTAyYTIyNjVhOTdhOTM4NThhZS4uOWY2M2MzMDA2 YTBjYTdmMmUzMzk5NDgwMWI1NDJjMzY2NjhjMmU1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9jc3AvQ29udGVudFNlY3VyaXR5UG9saWN5U291cmNlTGlzdC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvY3NwL0NvbnRlbnRTZWN1cml0eVBvbGljeVNvdXJjZUxpc3QuaApAQCAt NDQsNyArNDQsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHBhcnNlKGNvbnN0IFN0cmluZyYpOwog Ci0gICAgYm9vbCBtYXRjaGVzKGNvbnN0IFVSTCYsIGJvb2wgZGlkUmVjZWl2ZVJlZGlyZWN0UmVz cG9uc2UpOworICAgIGJvb2wgbWF0Y2hlcyhjb25zdCBVUkwmLCBib29sIGRpZFJlY2VpdmVSZWRp cmVjdFJlc3BvbnNlKSBjb25zdDsKICAgICBib29sIG1hdGNoZXMoY29uc3QgQ29udGVudFNlY3Vy aXR5UG9saWN5SGFzaCYpIGNvbnN0OwogICAgIGJvb2wgbWF0Y2hlcyhjb25zdCBTdHJpbmcmIG5v bmNlKSBjb25zdDsKIAo=