186705 2018-06-15 15:07:11 -0700 StyleRuleMedia wastes 158KB of Vector capacity on cnn.com 2018-06-15 18:59:50 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser cdumez cdumez commit-queue koivisto simon.fraser webkit-bug-importer oldest_to_newest 1433586 0 simon.fraser 2018-06-15 15:07:11 -0700 Tooling from bug 186698: Wasted capacity: 158008 bytes (used 16128 of 174136 bytes, utilization: 9.26%) - 1356 allocations 1 0x1074c1355 WTF::VectorBuffer<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul>::VectorBuffer() 2 0x1074c1335 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x107497385 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x1074972da WebCore::StyleRuleGroup::StyleRuleGroup(WebCore::StyleRuleBase::Type, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 5 0x1074980cd WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 6 0x107498125 WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 7 0x1074de618 WebCore::StyleRuleMedia::create(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 8 0x1074dc1d8 WebCore::CSSParserImpl::consumeMediaRule(WebCore::CSSParserTokenRange, WebCore::CSSParserTokenRange) 1433588 1 webkit-bug-importer 2018-06-15 15:07:40 -0700 <rdar://problem/41173637> 1433630 2 342857 cdumez 2018-06-15 16:55:55 -0700 Created attachment 342857 Patch 1433653 3 342857 commit-queue 2018-06-15 18:59:48 -0700 Comment on attachment 342857 Patch Clearing flags on attachment: 342857 Committed r232899: <https://trac.webkit.org/changeset/232899> 1433654 4 commit-queue 2018-06-15 18:59:50 -0700 All reviewed patches have been landed. Closing bug. 342857 2018-06-15 16:55:55 -0700 2018-06-15 18:59:48 -0700 Patch bug-186705-20180615165555.patch text/plain 2529 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjljMjAzNjE0MzBmOTU4 NTAzYTY3NDA1NGIwMGRlYWY4OWEzMTU2OS4uMzVkYjNjOTAxZmQyYTc1YjNkMDJjOTE4M2ZhZmYx MDhlOTAxYmJjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA2LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3R5bGVSdWxlTWVkaWEgd2Fz dGVzIDE1OEtCIG9mIFZlY3RvciBjYXBhY2l0eSBvbiBjbm4uY29tCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY3MDUKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQxMTczNjM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENhbGwgc2hyaW5rVG9GaXQgb24gUmVmUHRyPFN0eWxlUnVsZUJhc2U+IHZlY3Rv cnMgaW4gQ1NTUGFyc2VySW1wbCwgYWZ0ZXIgd2UncmUKKyAgICAgICAgZG9uZSBwYXJzaW5nIGFu ZCBiZWZvcmUgY29uc3RydWN0aW5nIFN0eWxlUnVsZU1lZGlhLCBTdHlsZVJ1bGVTdXBwb3J0cyBh bmQKKyAgICAgICAgZGVmZXJyZWQgcnVsZXMgaW4gU3R5bGVSdWxlR3JvdXAuCisKKyAgICAgICAg KiBjc3MvcGFyc2VyL0NTU1BhcnNlckltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFy c2VySW1wbDo6cGFyc2VEZWZlcnJlZFJ1bGVMaXN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Bh cnNlckltcGw6OmNvbnN1bWVNZWRpYVJ1bGUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2Vy SW1wbDo6Y29uc3VtZVN1cHBvcnRzUnVsZSk6CisKIDIwMTgtMDYtMTUgIEFudHRpIEtvaXZpc3Rv ICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFNlbWFudGljIGNvbG9ycyBzaG91bGQgbm90 IGJlIHRyYW5zZm9ybWVkIGJ5IGNvbG9yLWZpbHRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL3BhcnNlci9DU1NQYXJzZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJz ZXIvQ1NTUGFyc2VySW1wbC5jcHAKaW5kZXggOTIyMzYwNjdkZDNmNmFmYmQzYjNmODY4NTZiNmVi NjY1NzgxNWJkZS4uNzg0NDE5MTc2MmIzYTllNjVkOWM0OWI3NDdhMWU5NWU2YTQ4OWY0MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlckltcGwuY3BwCkBAIC0xODUsNiAr MTg1LDcgQEAgdm9pZCBDU1NQYXJzZXJJbXBsOjpwYXJzZURlZmVycmVkUnVsZUxpc3QoQ1NTUGFy c2VyVG9rZW5SYW5nZSB0b2tlblJhbmdlLCBDU1NEZWYKICAgICBwYXJzZXIuY29uc3VtZVJ1bGVM aXN0KHRva2VuUmFuZ2UsIFJlZ3VsYXJSdWxlTGlzdCwgWyZjaGlsZFJ1bGVzXShjb25zdCBSZWZQ dHI8U3R5bGVSdWxlQmFzZT4mIHJ1bGUpIHsKICAgICAgICAgY2hpbGRSdWxlcy5hcHBlbmQocnVs ZSk7CiAgICAgfSk7CisgICAgY2hpbGRSdWxlcy5zaHJpbmtUb0ZpdCgpOwogfQogCiB2b2lkIENT U1BhcnNlckltcGw6OnBhcnNlRGVmZXJyZWRLZXlmcmFtZUxpc3QoQ1NTUGFyc2VyVG9rZW5SYW5n ZSB0b2tlblJhbmdlLCBDU1NEZWZlcnJlZFBhcnNlciYgZGVmZXJyZWRQYXJzZXIsIFN0eWxlUnVs ZUtleWZyYW1lcyYga2V5ZnJhbWVSdWxlKQpAQCAtNTUxLDYgKzU1Miw3IEBAIFJlZlB0cjxTdHls ZVJ1bGVNZWRpYT4gQ1NTUGFyc2VySW1wbDo6Y29uc3VtZU1lZGlhUnVsZShDU1NQYXJzZXJUb2tl blJhbmdlIHByZWx1CiAgICAgY29uc3VtZVJ1bGVMaXN0KGJsb2NrLCBSZWd1bGFyUnVsZUxpc3Qs IFsmcnVsZXNdKFJlZlB0cjxTdHlsZVJ1bGVCYXNlPiBydWxlKSB7CiAgICAgICAgIHJ1bGVzLmFw cGVuZChydWxlKTsKICAgICB9KTsKKyAgICBydWxlcy5zaHJpbmtUb0ZpdCgpOwogCiAgICAgaWYg KG1fb2JzZXJ2ZXJXcmFwcGVyKQogICAgICAgICBtX29ic2VydmVyV3JhcHBlci0+b2JzZXJ2ZXIo KS5lbmRSdWxlQm9keShtX29ic2VydmVyV3JhcHBlci0+ZW5kT2Zmc2V0KGJsb2NrKSk7CkBAIC01 NzcsNiArNTc5LDcgQEAgUmVmUHRyPFN0eWxlUnVsZVN1cHBvcnRzPiBDU1NQYXJzZXJJbXBsOjpj b25zdW1lU3VwcG9ydHNSdWxlKENTU1BhcnNlclRva2VuUmFuZ2UKICAgICBjb25zdW1lUnVsZUxp c3QoYmxvY2ssIFJlZ3VsYXJSdWxlTGlzdCwgWyZydWxlc10oUmVmUHRyPFN0eWxlUnVsZUJhc2U+ IHJ1bGUpIHsKICAgICAgICAgcnVsZXMuYXBwZW5kKHJ1bGUpOwogICAgIH0pOworICAgIHJ1bGVz LnNocmlua1RvRml0KCk7CiAKICAgICBpZiAobV9vYnNlcnZlcldyYXBwZXIpCiAgICAgICAgIG1f b2JzZXJ2ZXJXcmFwcGVyLT5vYnNlcnZlcigpLmVuZFJ1bGVCb2R5KG1fb2JzZXJ2ZXJXcmFwcGVy LT5lbmRPZmZzZXQoYmxvY2spKTsK