186703 2018-06-15 15:04:07 -0700 CachedRawResource wastes 57K of Vector capacity 2018-06-15 16:54:20 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser cdumez beidson cdumez commit-queue dbates ews-watchlist japhet simon.fraser webkit-bug-importer oldest_to_newest 1433579 0 simon.fraser 2018-06-15 15:04:07 -0700 On theverge.com, tooling from bug 186698: Wasted capacity: 57584 bytes (used 4880 of 62464 bytes, utilization: 7.81%) - 13 allocations 1 0x107ee28b5 WTF::VectorBuffer<WebCore::CachedRawResource::RedirectPair, 0ul>::VectorBuffer() 2 0x107ee2895 WTF::Vector<WebCore::CachedRawResource::RedirectPair, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x107ec4b75 WTF::Vector<WebCore::CachedRawResource::RedirectPair, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x107ec4b04 WebCore::CachedRawResource::CachedRawResource(WebCore::CachedResourceRequest&&, WebCore::CachedResource::Type, PAL::SessionID) 5 0x107ec4bcb WebCore::CachedRawResource::CachedRawResource(WebCore::CachedResourceRequest&&, WebCore::CachedResource::Type, PAL::SessionID) 6 0x107ed1700 WebCore::createResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&, PAL::SessionID) 7 0x107ed13ca WebCore::CachedResourceLoader::loadResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&) 8 0x107ece32d WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&, WebCore::CachedResourceLoader::ForPreload, WebCore::CachedResourceLoader::DeferOption) 1433580 1 webkit-bug-importer 2018-06-15 15:04:24 -0700 <rdar://problem/41173515> 1433610 2 cdumez 2018-06-15 15:27:59 -0700 Vector<RedirectPair> m_redirectChain; in CachedRawResource. We never reserve capacity explicitly and only call append() on it. 1433612 3 cdumez 2018-06-15 15:42:59 -0700 Looks like Vector has a default inlineCapacity of 0 but a minCapacity of 16. Note that the Vector contains ResourceResponse & ResponseRequest objects, which are large. 1433617 4 cdumez 2018-06-15 16:03:22 -0700 Note that as long as the vector is empty, its capacity is 0, even though the default minCapacity is 16. However, as soon as you append one element to the Vector, capacity jumps from 0 to 16. 1433618 5 342855 cdumez 2018-06-15 16:10:26 -0700 Created attachment 342855 Patch 1433628 6 342855 commit-queue 2018-06-15 16:54:19 -0700 Comment on attachment 342855 Patch Clearing flags on attachment: 342855 Committed r232897: <https://trac.webkit.org/changeset/232897> 1433629 7 commit-queue 2018-06-15 16:54:20 -0700 All reviewed patches have been landed. Closing bug. 342855 2018-06-15 16:10:26 -0700 2018-06-15 16:54:19 -0700 Patch bug-186703-20180615161025.patch text/plain 1855 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjljMjAzNjE0MzBmOTU4 NTAzYTY3NDA1NGIwMGRlYWY4OWEzMTU2OS4uOGNhMjhmMWVkMzYxMDAzZmU4N2RlNGY5ODM5MGY0 ZDUxMTcyZTgwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA2LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FjaGVkUmF3UmVzb3VyY2Ug d2FzdGVzIDU3SyBvZiBWZWN0b3IgY2FwYWNpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjcwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDEx NzM1MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIDAgYXMgbWluaW11bSBjYXBhY2l0eSBmb3IgQ2FjaGVkUmF3UmVzb3VyY2U6Om1fcmVkaXJl Y3RDaGFpbiwgaW5zdGVhZCBvZiB0aGUKKyAgICAgICAgZGVmYXVsdCB2YWx1ZSBvZiAxNi4gbV9y ZWRpcmVjdENoYWluIHVzdWFsbHkgY29udGFpbnMgdmVyeSBmZXcgaXRlbXMgc28gMTYgaXMKKyAg ICAgICAgd2FzdGVmdWwsIGVzcGVjaWFsbHkgY29uc2lkZXJpbmcgdGhhdCBtX3JlZGlyZWN0Q2hh aW4gY29udGFpbnMgZmFpcmx5IGxhcmdlCisgICAgICAgIG9iamVjdHMgKHN0ZDo6cGFpcjxSZXNv dXJjZVJlcXVlc3QsIFJlc291cmNlUmVzcG9uc2U+KS4gQ2FjaGVkUmF3UmVzb3VyY2UgYXJlCisg ICAgICAgIHN0b3JlZCBpbiB0aGUgbWVtb3J5IGNhY2hlIHNvIGl0IGlzIGltcG9ydGFudCB0byBu b3QgdXNlIG1vcmUgbWVtb3J5IHRoYW4KKyAgICAgICAgbmVjZXNzYXJ5LgorCisgICAgICAgIFdl IGFyZSBhbHNvIG5vdCB3b3JyaWVkIGFib3V0IHRoZSBwZXJmb3JtYW5jZSBjb3N0IG9mIGFsbG9j YXRpb25zIGhlcmUgc2luY2UKKyAgICAgICAgdGhpcyB2ZWN0b3IgaXMgb25seSBwb3B1bGF0ZWQg b24gSFRUUCByZWRpcmVjdHMuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVz b3VyY2UuaDoKKwogMjAxOC0wNi0xNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CiAKICAgICAgICAgU2VtYW50aWMgY29sb3JzIHNob3VsZCBub3QgYmUgdHJhbnNmb3JtZWQgYnkg Y29sb3ItZmlsdGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2Fj aGVkUmF3UmVzb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSYXdS ZXNvdXJjZS5oCmluZGV4IGYwNjk0ODczODNhOGVjMmE0NzRiZmVhMjg1ZWZjN2Y1YmExMjM3NWYu LjJkM2RhYzk5NjQzMjIyOGY5NDhmY2I2ZmQ0ZjY2ZDcwNjU0N2NlMWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5oCkBAIC04OSw3ICs4OSw3 IEBAIHByaXZhdGU6CiAgICAgICAgIGNvbnN0IFJlc291cmNlUmVzcG9uc2UgbV9yZWRpcmVjdFJl c3BvbnNlOwogICAgIH07CiAKLSAgICBWZWN0b3I8UmVkaXJlY3RQYWlyPiBtX3JlZGlyZWN0Q2hh aW47CisgICAgVmVjdG9yPFJlZGlyZWN0UGFpciwgMCwgQ3Jhc2hPbk92ZXJmbG93LCAwPiBtX3Jl ZGlyZWN0Q2hhaW47CiAKICAgICBzdHJ1Y3QgRGVsYXllZEZpbmlzaExvYWRpbmcgewogICAgICAg ICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBidWZmZXI7Cg==