186675 2018-06-15 09:56:16 -0700 Rollout r231818, as it introduced regression on tickets.com. 2018-11-07 13:32:47 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190884 InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1433416 0 pvollan 2018-06-15 09:56:16 -0700 Rollout https://trac.webkit.org/changeset/231818/webkit, as it introduced regression on tickets.com. This changeset would pause display links in background tasks, and when Safari is minimized. Perhaps we can throttle display links in background tabs instead? This changeset is also not needed to fix the associated bug https://bugs.webkit.org/show_bug.cgi?id=185627 anymore, since this was fixed by https://trac.webkit.org/changeset/232563. 1433417 1 pvollan 2018-06-15 09:57:25 -0700 <rdar://problem/41103671> 1433420 2 342821 pvollan 2018-06-15 10:01:37 -0700 Created attachment 342821 Patch 1433445 3 342821 commit-queue 2018-06-15 10:32:55 -0700 Comment on attachment 342821 Patch Clearing flags on attachment: 342821 Committed r232879: <https://trac.webkit.org/changeset/232879> 1433446 4 commit-queue 2018-06-15 10:32:56 -0700 All reviewed patches have been landed. Closing bug. 1476062 5 simon.fraser 2018-11-07 10:49:17 -0800 Won't this be a power regression? 1476171 6 pvollan 2018-11-07 13:32:47 -0800 (In reply to Simon Fraser (smfr) from comment #5) > Won't this be a power regression? I don't believe so, since starting/stopping a display link is controlled by cross-platform code by creating/deleting a DisplayRefreshMonitor. 342821 2018-06-15 10:01:37 -0700 2018-06-15 10:32:55 -0700 Patch bug-186675-20180615100136.patch text/plain 3405 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzI4NzYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTE1ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSb2xsb3V0IHIyMzE4MTgsIGFz IGl0IGludHJvZHVjZWQgcmVncmVzc2lvbiBvbiB0aWNrZXRzLmNvbS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjY3NQorCisgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0LgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlzcGF0Y2hBY3Rpdml0eVN0YXRl Q2hhbmdlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL0Rpc3BsYXlMaW5rLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6RGlzcGxheUxpbms6OnBhdXNlKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYktp dDo6RGlzcGxheUxpbms6OnJlc3VtZSk6IERlbGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL21h Yy9EaXNwbGF5TGluay5oOgorCiAyMDE4LTA2LTE1ICBUaGliYXVsdCBTYXVuaWVyICA8dHNhdW5p ZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdOiBBdm9pZCB1c2luZyB1bmluaXRp YWxpemVkIGxhdW5jaE9wdGlvbnMgaW4gZ2V0TGF1bmNoT3B0aW9ucwpJbmRleDogU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAyMzI4NzYpCisrKyBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NjAxLDEzICsxNjAxLDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpc3BhdGNoQWN0aXZpdHlTdGF0 ZQogI2VuZGlmCiAKICAgICBpZiAoY2hhbmdlZCAmIEFjdGl2aXR5U3RhdGU6OklzVmlzaWJsZSkg ewotICAgICAgICBpZiAoaXNWaWV3VmlzaWJsZSgpKSB7CisgICAgICAgIGlmIChpc1ZpZXdWaXNp YmxlKCkpCiAgICAgICAgICAgICBtX3Zpc2libGVQYWdlVG9rZW4gPSBtX3Byb2Nlc3MtPnZpc2li bGVQYWdlVG9rZW4oKTsKLSNpZiBQTEFURk9STShNQUMpICYmIEVOQUJMRShXRUJQUk9DRVNTX1dJ TkRPV1NFUlZFUl9CTE9DS0lORykKLSAgICAgICAgICAgIGlmIChtX2Rpc3BsYXlMaW5rKQotICAg ICAgICAgICAgICAgIG1fZGlzcGxheUxpbmstPnJlc3VtZSgpOwotI2VuZGlmCi0gICAgICAgIH0K ICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBtX3Zpc2libGVQYWdlVG9rZW4gPSBudWxscHRy OwogCkBAIC0xNjE1LDEwICsxNjEwLDYgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpc3BhdGNoQWN0 aXZpdHlTdGF0ZQogICAgICAgICAgICAgLy8gc3RhdGUsIGl0IG1pZ2h0IG5vdCBzZW5kIGJhY2sg YSByZXBseSAoc2luY2UgaXQgd29uJ3QgcGFpbnQgYW55dGhpbmcgaWYgdGhlIHdlYiBwYWdlIGlz IGhpZGRlbikgc28gd2UKICAgICAgICAgICAgIC8vIHN0b3AgdGhlIHVucmVzcG9uc2l2ZW5lc3Mg dGltZXIgaGVyZS4KICAgICAgICAgICAgIG1fcHJvY2Vzcy0+cmVzcG9uc2l2ZW5lc3NUaW1lcigp LnN0b3AoKTsKLSNpZiBQTEFURk9STShNQUMpICYmIEVOQUJMRShXRUJQUk9DRVNTX1dJTkRPV1NF UlZFUl9CTE9DS0lORykKLSAgICAgICAgICAgIGlmIChtX2Rpc3BsYXlMaW5rKQotICAgICAgICAg ICAgICAgIG1fZGlzcGxheUxpbmstPnBhdXNlKCk7Ci0jZW5kaWYKICAgICAgICAgfQogICAgIH0K IApJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL0Rpc3BsYXlMaW5rLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvRGlzcGxheUxpbmsuY3BwCShy ZXZpc2lvbiAyMzI4NzYpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvRGlzcGxheUxp bmsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MywyMCArODMsNiBAQCBib29sIERpc3BsYXlMaW5r OjpoYXNPYnNlcnZlcnMoKSBjb25zdAogICAgIHJldHVybiAhbV9vYnNlcnZlcnMuaXNFbXB0eSgp OwogfQogCi12b2lkIERpc3BsYXlMaW5rOjpwYXVzZSgpCi17Ci0gICAgaWYgKCFDVkRpc3BsYXlM aW5rSXNSdW5uaW5nKG1fZGlzcGxheUxpbmspKQotICAgICAgICByZXR1cm47Ci0gICAgQ1ZEaXNw bGF5TGlua1N0b3AobV9kaXNwbGF5TGluayk7Ci19Ci0KLXZvaWQgRGlzcGxheUxpbms6OnJlc3Vt ZSgpCi17Ci0gICAgaWYgKENWRGlzcGxheUxpbmtJc1J1bm5pbmcobV9kaXNwbGF5TGluaykpCi0g ICAgICAgIHJldHVybjsKLSAgICBDVkRpc3BsYXlMaW5rU3RhcnQobV9kaXNwbGF5TGluayk7Ci19 Ci0KIENWUmV0dXJuIERpc3BsYXlMaW5rOjpkaXNwbGF5TGlua0NhbGxiYWNrKENWRGlzcGxheUxp bmtSZWYgZGlzcGxheUxpbmtSZWYsIGNvbnN0IENWVGltZVN0YW1wKiwgY29uc3QgQ1ZUaW1lU3Rh bXAqLCBDVk9wdGlvbkZsYWdzLCBDVk9wdGlvbkZsYWdzKiwgdm9pZCogZGF0YSkKIHsKICAgICBE aXNwbGF5TGluayogZGlzcGxheUxpbmsgPSBzdGF0aWNfY2FzdDxEaXNwbGF5TGluayo+KGRhdGEp OwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL0Rpc3BsYXlMaW5rLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL0Rpc3BsYXlMaW5rLmgJKHJldmlz aW9uIDIzMjg3NikKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9EaXNwbGF5TGluay5o CSh3b3JraW5nIGNvcHkpCkBAIC00OSw5ICs0OSw2IEBAIHB1YmxpYzoKICAgICB2b2lkIHJlbW92 ZU9ic2VydmVyKHVuc2lnbmVkIG9ic2VydmVySUQpOwogICAgIGJvb2wgaGFzT2JzZXJ2ZXJzKCkg Y29uc3Q7CiAKLSAgICB2b2lkIHBhdXNlKCk7Ci0gICAgdm9pZCByZXN1bWUoKTsKLSAgICAKIHBy aXZhdGU6CiAgICAgc3RhdGljIENWUmV0dXJuIGRpc3BsYXlMaW5rQ2FsbGJhY2soQ1ZEaXNwbGF5 TGlua1JlZiwgY29uc3QgQ1ZUaW1lU3RhbXAqLCBjb25zdCBDVlRpbWVTdGFtcCosIENWT3B0aW9u RmxhZ3MsIENWT3B0aW9uRmxhZ3MqLCB2b2lkKiBkYXRhKTsKICAgICAK