18664 2008-04-21 11:52:26 -0700 SQUIRRELFISH: correctly throw a SyntaxError when parsing of eval code fails 2008-04-21 12:00:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 18624 1 zwarich webkit-unassigned oldest_to_newest 78435 0 zwarich 2008-04-21 11:52:26 -0700 SquirrelFish does not currently throw a SyntaxError when parsing of eval code fails. This causes the failure of some JavaScriptCore tests that expect a SyntaxError. 78437 1 20733 zwarich 2008-04-21 11:56:58 -0700 Created attachment 20733 Proposed patch Oliver already reviewed it, but I can't land it myself. This patch fixes 8 JavaScriptCore test failures. There is no change on SunSpider. 78438 2 oliver 2008-04-21 12:00:38 -0700 Committed r32332 20733 2008-04-21 11:56:58 -0700 2008-04-21 11:57:43 -0700 Proposed patch parseerror.diff text/plain 1056 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyMzI1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDQt MjEgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdGx5IHRocm93IGEg U3ludGF4RXJyb3Igd2hlbiBwYXJzaW5nIG9mIGV2YWwgY29kZSBmYWlscy4KKworICAgICAgICAq IFZNL01hY2hpbmUuY3BwOgorICAgICAgICAoS0pTOjpldmFsKToKKwogMjAwOC0wNC0yMSAgR2Vv ZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1h Y2llaiBTdGFjaG93aWFrLgpJbmRleDogVk0vTWFjaGluZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0v TWFjaGluZS5jcHAJKHJldmlzaW9uIDMyMjkwKQorKysgVk0vTWFjaGluZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTUxMCw3ICs1MTAsNyBAQCBzdGF0aWMgTkVWRVJfSU5MSU5FIEpTVmFsdWUqIGV2 YWwoRXhlY1N0CiAgICAgUmVmUHRyPEV2YWxOb2RlPiBldmFsTm9kZSA9IHBhcnNlcigpLnBhcnNl PEV2YWxOb2RlPihVU3RyaW5nKCksIDAsIHMuZGF0YSgpLCBzLnNpemUoKSwgJnNvdXJjZUlkLCAm ZXJyTGluZSwgJmVyck1zZyk7CiAgICAgCiAgICAgaWYgKCFldmFsTm9kZSkgewotICAgICAgICBl eGNlcHRpb25WYWx1ZSA9IHRocm93RXJyb3IoZXhlYywgU3ludGF4RXJyb3IsIGVyck1zZywgZXJy TGluZSwgc291cmNlSWQsIE5VTEwpOworICAgICAgICBleGNlcHRpb25WYWx1ZSA9IEVycm9yOjpj cmVhdGUoZXhlYywgU3ludGF4RXJyb3IsIGVyck1zZywgZXJyTGluZSwgc291cmNlSWQsIE5VTEwp OwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAK