186610 2018-06-13 15:41:09 -0700 [WPE][GTK] Enable process swap on navigation to new origin 2019-06-23 10:55:31 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186542 P2 Normal --- 1 mcatanzaro webkit-unassigned beidson bugs-noreply calvaris cdumez mcatanzaro oldest_to_newest 1432846 0 mcatanzaro 2018-06-13 15:41:09 -0700 We should probably enable process swap on navigation to new origin for WPE/GTK. (...right?) Hey Brady, could you help us understand: * Is there any reason we would NOT want to do this unconditionally? (It doesn't seem like something to expose public GTK/WPE API for.) * This is important because it's required for site isolation slash Spectre mitigation... right? 1432848 1 mcatanzaro 2018-06-13 15:44:41 -0700 Patch is trivial: diff --git a/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp b/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp index b52591d625e..829734126bc 100644 --- a/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp +++ b/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp @@ -335,6 +335,7 @@ static void webkitWebContextConstructed(GObject* object) configuration.setInjectedBundlePath(WebCore::FileSystem::stringFromFileSystemRepresentation(bundleFilename.get())); configuration.setMaximumProcessCount(1); configuration.setDiskCacheSpeculativeValidationEnabled(true); + configuration.setProcessSwapsOnNavigation(true); WebKitWebContext* webContext = WEBKIT_WEB_CONTEXT(object); WebKitWebContextPrivate* priv = webContext->priv; I tested this out and it sort of works. The navigation swap seems to occur as expected. However, back/forward list is broken: trying to navigate back past a process swap does not work properly. 1432849 2 cdumez 2018-06-13 15:46:15 -0700 It is not enabled by default for COCOA yet. We are still working on layout test failures and then we'll have to work on performance. There is a cost to launching new processes (launch time and losing caches for e.g.). 1432861 3 mcatanzaro 2018-06-13 16:10:09 -0700 OK, let's definitely delay until you think it's ready for Cocoa. 1547188 4 mcatanzaro 2019-06-23 10:55:31 -0700 Enabled in r246148.