186594 2018-06-13 09:33:14 -0700 [WPE] Pack inspector resources in a .gresource file instead of a shared library 2024-10-18 14:33:54 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193826 https://bugs.webkit.org/show_bug.cgi?id=280512 https://bugs.webkit.org/show_bug.cgi?id=281298 https://bugs.webkit.org/show_bug.cgi?id=281771 P2 Normal --- 186588 280561 1 aperez aperez bugs-noreply calvaris oldest_to_newest 1432671 0 aperez 2018-06-13 09:33:14 -0700 For the WPE port the inspector resources are bundled using for loading with GResource, built into an shared library which contains the bundled data, and finally loaded on-demand using GModule (which ends up using “dlopen”) when first needed. There are no other contents in the shared library, so we could as well generate a “*.gresource” data file instead (which is a GVDB file), and load it using “g_resource_load” (instead of using GModule). There are a few small advantages: - Disk space savings. GDVB files are slightly more compact than a shared library, and are mmap'd when loaded. - Loading the data does not involve the dynamic linker (no need for parsing an executable object, resolving symbols, etc.). - No intermediate build steps: the XML manifest gets built into the .gresource data file directly (compare with the current approach, which is: XML manifest → C source → object file → shared library). While there's nothing particularly important in the list above, it still would be nicer to use a data file instead of a shared library for the inspector resources. 1432675 1 aperez 2018-06-13 09:36:13 -0700 FWIW, the .gresource files being data, I understand the file would be installed into “${DATADIR}/wpe-webkit-${VERSION}” instead of “${LIBDIR}/wpe-webkit-${VERSION}” (as currently done). 2060172 2 lisiwei 2024-09-13 17:42:31 -0700 Pull request: https://github.com/WebKit/webkit/pull/33654 2063310 3 ews-feeder 2024-09-26 00:03:42 -0700 Committed 284269@main (8ceb1da47e75): <https://commits.webkit.org/284269@main> Reviewed commits have been landed. Closing PR #33654 and removing active labels.