186592 2018-06-13 08:52:45 -0700 [JSC] Always use Nuke & Set procedure for x86 2018-06-13 12:29:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1432662 0 ysuzuki 2018-06-13 08:52:45 -0700 [JSC] Always use Nuke & Set procedure for x86 1432663 1 342662 ysuzuki 2018-06-13 08:54:33 -0700 Created attachment 342662 Patch 1432686 2 342662 keith_miller 2018-06-13 10:05:21 -0700 Comment on attachment 342662 Patch r=me. 1432721 3 342662 ysuzuki 2018-06-13 11:06:13 -0700 Comment on attachment 342662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342662&action=review Thank you! > Source/JavaScriptCore/runtime/JSObject.cpp:1365 > + locker = holdLock(cellLock()); I’m discussing right now whether this lock can be removed. Anyway, this patch itself is unrelated to that since this still holds the lock. I’ll land this one. 1432730 4 342662 commit-queue 2018-06-13 11:33:02 -0700 Comment on attachment 342662 Patch Clearing flags on attachment: 342662 Committed r232798: <https://trac.webkit.org/changeset/232798> 1432731 5 commit-queue 2018-06-13 11:33:04 -0700 All reviewed patches have been landed. Closing bug. 1432756 6 webkit-bug-importer 2018-06-13 12:29:22 -0700 <rdar://problem/41097196> 342662 2018-06-13 08:54:33 -0700 2018-06-13 11:33:02 -0700 Patch bug-186592-20180614005432.patch text/plain 2960 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ODBiM2U1OTdlZjZlNzQ3Mzk5YjE3M2I5N2ZhZDU4NTRlM2Y3OTQ1Li45ODg0NjU2OTk0ZjFiZWFi MDFlMmY1MGU1N2Q1ZTQyMzY4NzFlZTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wNi0xMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBBbHdheXMgdXNlIE51a2UgJiBTZXQgcHJvY2VkdXJlIGZv ciB4ODYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 NjU5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IGFsd2F5cyB1c2UgbnVrZVN0cnVjdHVyZUFuZFN0b3JlQnV0dGVyZmx5IGZvciBDb250aWd1b3Vz IC0+IEFycmF5U3RvcmFnZSBjb252ZXJzaW9uIGlmIHRoZSBhcmNoaXRlY3R1cmUgaXMgeDg2Lgor ICAgICAgICBCeSBkb2luZyBzbywgd2UgY2FuIGNvbmN1cnJlbnRseSBsb2FkIHN0cnVjdHVyZSBh bmQgYnV0dGVyZmx5IGF0IGxlYXN0IGluIHg4NiBlbnZpcm9ubWVudCBldmVuIGluIG5vbi1jb2xs ZWN0b3IKKyAgICAgICAgdGhyZWFkcy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3Bw OgorICAgICAgICAoSlNDOjpKU09iamVjdDo6Y29udmVydENvbnRpZ3VvdXNUb0FycmF5U3RvcmFn ZSk6CisKIDIwMTgtMDYtMTIgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVtb3ZlIEpTVmlydHVhbE1hY2hpbmUgc2hyaW5rRm9vdHByaW50IHdoZW4gY2xpZW50 cyBtb3ZlIHRvIHNocmlua0Zvb3RwcmludFdoZW5JZGxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU09iamVjdC5jcHAKaW5kZXggYTRjOWJmMWVhZjY1MjRmZmEyZDczOGYwMDEzNzBi YWRjMzE3ZTQ2Zi4uNjk2YTE0NmVjYjVjOWQyOWRkYTYzZTczMGMyNGE0ZWVmMWEyNDJiYyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcApAQCAtMTM0NCw3ICsx MzQ0LDkgQEAgQXJyYXlTdG9yYWdlKiBKU09iamVjdDo6Y29udmVydENvbnRpZ3VvdXNUb0FycmF5 U3RvcmFnZShWTSYgdm0sIE5vblByb3BlcnR5VHJhbnMKICAgICAgICAgICAgIG5ld1N0b3JhZ2Ut Pm1fbnVtVmFsdWVzSW5WZWN0b3IrKzsKICAgICB9CiAgICAgCi0gICAgU3RydWN0dXJlKiBuZXdT dHJ1Y3R1cmUgPSBTdHJ1Y3R1cmU6Om5vblByb3BlcnR5VHJhbnNpdGlvbih2bSwgc3RydWN0dXJl KHZtKSwgdHJhbnNpdGlvbik7CisgICAgU3RydWN0dXJlSUQgb2xkU3RydWN0dXJlSUQgPSB0aGlz LT5zdHJ1Y3R1cmVJRCgpOworICAgIFN0cnVjdHVyZSogb2xkU3RydWN0dXJlID0gdm0uZ2V0U3Ry dWN0dXJlKG9sZFN0cnVjdHVyZUlEKTsKKyAgICBTdHJ1Y3R1cmUqIG5ld1N0cnVjdHVyZSA9IFN0 cnVjdHVyZTo6bm9uUHJvcGVydHlUcmFuc2l0aW9uKHZtLCBvbGRTdHJ1Y3R1cmUsIHRyYW5zaXRp b24pOwogCiAgICAgLy8gVGhpcyBoYXMgYSBjcmF6eSByYWNlIHdpdGggdGhlIGdhcmJhZ2UgY29s bGVjdG9yLiBXaGVuIGNoYW5naW5nIHRoZSBidXR0ZXJmbHkgYW5kIHN0cnVjdHVyZSwKICAgICAv LyB0aGUgbXV0YXRvciBhbHdheXMgc2V0cyB0aGUgc3RydWN0dXJlIGxhc3QuIFRoZSBjb2xsZWN0 b3Igd2lsbCBhbHdheXMgcmVhZCB0aGUgc3RydWN0dXJlCkBAIC0xMzU3LDE4ICsxMzU5LDEyIEBA IEFycmF5U3RvcmFnZSogSlNPYmplY3Q6OmNvbnZlcnRDb250aWd1b3VzVG9BcnJheVN0b3JhZ2Uo Vk0mIHZtLCBOb25Qcm9wZXJ0eVRyYW5zCiAgICAgLy8gYmVjYXVzZSBpdCB3aWxsIGZhaWwgdG8g ZGVjb2RlIHR3byBjb25zZWN1dGl2ZSBpbnQzMnMgYXMgaWYgaXQgd2FzIGEgSlNWYWx1ZS4KICAg ICAvLwogICAgIC8vIEZvcnR1bmF0ZWx5LCB3ZSBoYXZlIHRoZSBKU0NlbGwgbG9jayBmb3IgdGhp cyBwdXJwb3NlIQotICAgIAotICAgIGlmICh2bS5oZWFwLm11dGF0b3JTaG91bGRCZUZlbmNlZCgp KSB7Ci0gICAgICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2soY2VsbExvY2soKSk7Ci0gICAgICAg IHNldFN0cnVjdHVyZUlERGlyZWN0bHkobnVrZShzdHJ1Y3R1cmVJRCgpKSk7Ci0gICAgICAgIFdU Rjo6c3RvcmVTdG9yZUZlbmNlKCk7Ci0gICAgICAgIG1fYnV0dGVyZmx5LnNldCh2bSwgdGhpcywg bmV3U3RvcmFnZS0+YnV0dGVyZmx5KCkpOwotICAgICAgICBXVEY6OnN0b3JlU3RvcmVGZW5jZSgp OwotICAgICAgICBzZXRTdHJ1Y3R1cmUodm0sIG5ld1N0cnVjdHVyZSk7Ci0gICAgfSBlbHNlIHsK LSAgICAgICAgbV9idXR0ZXJmbHkuc2V0KHZtLCB0aGlzLCBuZXdTdG9yYWdlLT5idXR0ZXJmbHko KSk7Ci0gICAgICAgIHNldFN0cnVjdHVyZSh2bSwgbmV3U3RydWN0dXJlKTsKLSAgICB9CisKKyAg ICBMb2NrZXI8SlNDZWxsTG9jaz4gbG9ja2VyKE5vTG9ja2luZ05lY2Vzc2FyeSk7CisgICAgaWYg KHZtLmhlYXAubXV0YXRvclNob3VsZEJlRmVuY2VkKCkpCisgICAgICAgIGxvY2tlciA9IGhvbGRM b2NrKGNlbGxMb2NrKCkpOworICAgIG51a2VTdHJ1Y3R1cmVBbmRTZXRCdXR0ZXJmbHkodm0sIG9s ZFN0cnVjdHVyZUlELCBuZXdTdG9yYWdlLT5idXR0ZXJmbHkoKSk7CisgICAgc2V0U3RydWN0dXJl KHZtLCBuZXdTdHJ1Y3R1cmUpOwogICAgIAogICAgIHJldHVybiBuZXdTdG9yYWdlOwogfQo=