186583 2018-06-12 19:12:33 -0700 CFGSimplificationPhase should de-dupe jettisonedBlocks 2018-06-14 09:09:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff realdawei rmorisset ryanhaddad ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1432553 0 saam 2018-06-12 19:12:33 -0700 Otherwise, we may crash in removing a predecessor, since predecessor list is now also deduplicated. 1432554 1 saam 2018-06-12 19:13:00 -0700 This should fix the crash on this test: js/dom/JSON-stringify.html introduced by https://trac.webkit.org/changeset/232741/webkit 1432557 2 342622 saam 2018-06-12 19:20:59 -0700 Created attachment 342622 patch I'm in the middle of building, so I still need to test this, but I'm pretty sure it's the correct fix. 1432571 3 342622 saam 2018-06-12 21:23:39 -0700 Comment on attachment 342622 patch I've confirmed this fixes the crash. 1432614 4 rmorisset 2018-06-13 03:40:54 -0700 LGTM, but I'm not an official reviewer. 1432734 5 ryanhaddad 2018-06-13 11:36:56 -0700 Pinging reviewers. We need the fix ASAP as this is affecting EWS. 1432743 6 342622 commit-queue 2018-06-13 12:04:16 -0700 Comment on attachment 342622 patch Clearing flags on attachment: 342622 Committed r232800: <https://trac.webkit.org/changeset/232800> 1432744 7 commit-queue 2018-06-13 12:04:18 -0700 All reviewed patches have been landed. Closing bug. 1432758 8 webkit-bug-importer 2018-06-13 12:29:29 -0700 <rdar://problem/41097203> 1432949 9 ysuzuki 2018-06-14 01:01:08 -0700 I think ARES-6 is still crashing. https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6 1432996 10 saam 2018-06-14 08:56:55 -0700 (In reply to Yusuke Suzuki from comment #9) > I think ARES-6 is still crashing. > https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6 Michael is working on a fix 1432997 11 ysuzuki 2018-06-14 09:09:27 -0700 (In reply to Saam Barati from comment #10) > (In reply to Yusuke Suzuki from comment #9) > > I think ARES-6 is still crashing. > > https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6 > > Michael is working on a fix Nice! 342622 2018-06-12 19:20:59 -0700 2018-06-13 12:04:16 -0700 patch a-backup.diff text/plain 1970 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMyNzg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE4LTA2LTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENGR1NpbXBsaWZpY2F0aW9uUGhhc2Ugc2hvdWxkIGRlLWR1cGUgamV0dGlzb25lZEJsb2Nrcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NTgzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBtYWtp bmcgdGhlIHByZWRlY2Vzc29ycyBsaXN0IHVuaXF1ZSBpbiByMjMyNzQxLCBpdCByZXZlYWxlZCBh IGJ1ZyBpbnNpZGUKKyAgICAgICAgb2YgQ0ZHIHNpbXBsaWZpY2F0aW9uLCB3aGVyZSB3ZSB0cnkg dG8gcmVtb3ZlIHRoZSBzYW1lIHByZWRlY2Vzc29yIG1vcmUgdGhhbgorICAgICAgICBvbmNlIGZy b20gYSBibG9ja3MgcHJlZGVjZXNzb3JzIGxpc3QuIFdlIGJ1aWx0IHRoZSBsaXN0IG9mIGJsb2Nr cyB0byByZW1vdmUKKyAgICAgICAgZnJvbSB0aGUgbGlzdCBvZiBzdWNjZXNzb3JzLCB3aGljaCBp cyBub3QgdW5pcXVlLCBjYXVzaW5nIHVzIHRvIHRyeSB0byByZW1vdmUKKyAgICAgICAgdGhlIHNh bWUgcHJlZGVjZXNzb3IgbW9yZSB0aGFuIG9uY2UuIFRoZSBzb2x1dGlvbiBoZXJlIGlzIHRvIGp1 c3QgYWRkIHRvIHRoaXMKKyAgICAgICAgbGlzdCBvZiBibG9ja3MgdG8gcmVtb3ZlIG9ubHkgaWYg dGhlIGJsb2NrIGlzIG5vdCBhbHJlYWR5IGluIHRoZSBsaXN0LgorCisgICAgICAgICogZGZnL0RG R0NGR1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkNGR1NpbXBs aWZpY2F0aW9uUGhhc2U6OnJ1bik6CisKIDIwMTgtMDYtMTEgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVkdWNlIGdyYXBoIHNpemUgYnkgcmVwbGFjaW5nIHRl cm1pbmFsIG5vZGVzIGluIGJsb2NrcyB0aGF0IGhhdmUgYSBGb3JjZU9TUkV4aXQgd2l0aCBVbnJl YWNoYWJsZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDRkdTaW1wbGlmaWNh dGlvblBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0NGR1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwCShyZXZpc2lvbiAyMzI3NjcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0NGR1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xODIsNyArMTgyLDcgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICAg ICAgCiAgICAgICAgICAgICAgICAgICAgICAgICBWZWN0b3I8QmFzaWNCbG9jayosIDE+IGpldHRp c29uZWRCbG9ja3M7CiAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKEJhc2ljQmxvY2sqIHN1 Y2Nlc3NvciA6IHRlcm1pbmFsLT5zdWNjZXNzb3JzKCkpIHsKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpZiAoc3VjY2Vzc29yICE9IHRhcmdldEJsb2NrKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGlmIChzdWNjZXNzb3IgIT0gdGFyZ2V0QmxvY2sgJiYgIWpldHRpc29uZWRCbG9j a3MuY29udGFpbnMoc3VjY2Vzc29yKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg amV0dGlzb25lZEJsb2Nrcy5hcHBlbmQoc3VjY2Vzc29yKTsKICAgICAgICAgICAgICAgICAgICAg ICAgIH0KICAgICAgICAgICAgICAgICAgICAgICAgIAo=