186458 2018-06-09 02:37:07 -0700 [JSC] Array.prototype.sort should rejects null comparator 2018-06-12 05:10:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171621 1 ysuzuki ysuzuki commit-queue ews-watchlist joepeck keith_miller mark.lam msaboff realdawei saam webkit-bug-importer oldest_to_newest 1431553 0 ysuzuki 2018-06-09 02:37:07 -0700 [JSC] Array.prototype.sort should rejects null comparator 1431554 1 342364 ysuzuki 2018-06-09 02:41:10 -0700 Created attachment 342364 Patch 1431624 2 342364 keith_miller 2018-06-09 22:58:54 -0700 Comment on attachment 342364 Patch ha! How times change... r=me. 1431626 3 342364 ysuzuki 2018-06-10 00:10:11 -0700 Comment on attachment 342364 Patch Thanks 1431627 4 342364 commit-queue 2018-06-10 00:36:46 -0700 Comment on attachment 342364 Patch Clearing flags on attachment: 342364 Committed r232666: <https://trac.webkit.org/changeset/232666> 1431628 5 commit-queue 2018-06-10 00:36:47 -0700 All reviewed patches have been landed. Closing bug. 1431629 6 webkit-bug-importer 2018-06-10 00:37:20 -0700 <rdar://problem/40978395> 1432024 7 realdawei 2018-06-11 13:32:54 -0700 Looks like we have some new test262 errors after this revision: Sample Output: ! NEW FAIL test/built-ins/Array/prototype/sort/comparefn-nonfunction-call-throws.js (strict mode) ! NEW FAIL test/built-ins/Array/prototype/sort/comparefn-nonfunction-call-throws.js (default) https://build.webkit.org/builders/Apple%20Sierra%20Debug%20Test262%20%28Tests%29/builds/2822/steps/test262-test/logs/stdio 1432252 8 ysuzuki 2018-06-12 05:10:03 -0700 Committed r232750: <https://trac.webkit.org/changeset/232750> 342364 2018-06-09 02:41:10 -0700 2018-06-10 00:36:46 -0700 Patch bug-186458-20180609184109.patch text/plain 5937 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy Y2E2YzRkYzRmNWNjY2FmMGY0OGMzMTkxMmU3M2IwZGMyNDExNjcyLi4xYmUwMjU1NTBjMGQwMjdh YTU2NmIyOWJkMDhhNjY0NjhhNWY4YjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNi0wOSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBBcnJheS5wcm90b3R5cGUuc29ydCBzaG91bGQgcmVqZWN0 cyBudWxsIGNvbXBhcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NjQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcmVsYXhlZCBiZWhhdmlvciBpcyBvbmNlIGludHJvZHVjZWQgaW4gcjIx NjE2OSB0byBmaXggc29tZSBwYWdlcyBieSBhbGlnbmluZworICAgICAgICB0aGUgYmVoYXZpb3Ig dG8gQ2hyb21lIGFuZCBGaXJlZm94LgorCisgICAgICAgIEhvd2V2ZXIsIG5vdyBDaHJvbWUsIEZp cmVmb3ggYW5kIEVkZ2UgcmVqZWN0IGEgbnVsbCBjb21wYXJhdG9yLiBTbyBvbmx5IEphdmFTY3Jp cHRDb3JlCisgICAgICAgIGFjY2VwdHMgaXQuIFRoaXMgcGF0Y2ggcmV2ZXJ0cyByMjE2MTY5IHRv IGFsaWduIEpTQyB0byB0aGUgb3RoZXIgZW5naW5lcyBhbmQgZml4CisgICAgICAgIHRoZSBzcGVj IGlzc3VlLgorCisgICAgICAgICogYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUuanM6CisgICAgICAg IChzb3J0KToKKwogMjAxOC0wNi0wOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxl LmNvbT4KIAogICAgICAgICBbV2ViS2l0IG9uIHdhdGNoT1NdIFVwc3RyZWFtIHdhdGNoT1Mgc291 cmNlIGFkZGl0aW9ucyB0byBPcGVuU291cmNlIChQYXJ0IDEpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUuanMgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnVpbHRpbnMvQXJyYXlQcm90b3R5cGUuanMKaW5kZXggZTZkNGYxMDRhMmE1NWI1 MmU0NjYwMjc2OGNmY2Y1MDI3NmEzNzE4Zi4uOGEyOWVkMDI4NzI1N2ZjNDc3MTVhYzJiNjE0MmQ2 OGJjMDc5ZTVhNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL0Fy cmF5UHJvdG90eXBlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9BcnJh eVByb3RvdHlwZS5qcwpAQCAtNjAyLDcgKzYwMiw3IEBAIGZ1bmN0aW9uIHN0cmluZ1NvcnQoYXJy YXksIGxlbmd0aCkKIAogICAgIGlmICh0eXBlb2YgY29tcGFyYXRvciA9PSAiZnVuY3Rpb24iKQog ICAgICAgICBjb21wYXJhdG9yU29ydChhcnJheSwgbGVuZ3RoLCBjb21wYXJhdG9yKTsKLSAgICBl bHNlIGlmIChjb21wYXJhdG9yID09PSBudWxsIHx8IGNvbXBhcmF0b3IgPT09IEB1bmRlZmluZWQp CisgICAgZWxzZSBpZiAoY29tcGFyYXRvciA9PT0gQHVuZGVmaW5lZCkKICAgICAgICAgc3RyaW5n U29ydChhcnJheSwgbGVuZ3RoKTsKICAgICBlbHNlCiAgICAgICAgIEB0aHJvd1R5cGVFcnJvcigi QXJyYXkucHJvdG90eXBlLnNvcnQgcmVxdWlyZXMgdGhlIGNvbXBhcnNpb24gZnVuY3Rpb24gYmUg YSBmdW5jdGlvbiBvciB1bmRlZmluZWQiKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hha3JhQ29y ZS90ZXN0L0FycmF5L2FycmF5X3NvcnQuYmFzZWxpbmUtanNjIGIvSlNUZXN0cy9DaGFrcmFDb3Jl L3Rlc3QvQXJyYXkvYXJyYXlfc29ydC5iYXNlbGluZS1qc2MKaW5kZXggNmRkYzA5ODk3ZTA5ZWRk ZjQ0MDA1NTcyNGMyMWFjYmY2ZWM0NDIzZC4uODg1NjYzYTk3ZGZiYmUwMzUwNzRlZjBhN2QxMDI0 YTdjNGFiNzU0NCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFrcmFDb3JlL3Rlc3QvQXJyYXkvYXJy YXlfc29ydC5iYXNlbGluZS1qc2MKKysrIGIvSlNUZXN0cy9DaGFrcmFDb3JlL3Rlc3QvQXJyYXkv YXJyYXlfc29ydC5iYXNlbGluZS1qc2MKQEAgLTcsNCArNyw1IEBAIGZvcixzYW1wbGUsc29tZSxz dHJpbmdzLHRlc3RpbmcgLSBPdXRwdXQgZGlmZmVyZW50IGluIGNzY3JpcHQgZHVlIHRvIE5hTgog MSwyLDMKIDEwCiAxLDEuMiw0LDQuOCwxMgorVHlwZUVycm9yOiBBcnJheS5wcm90b3R5cGUuc29y dCByZXF1aXJlcyB0aGUgY29tcGFyc2lvbiBmdW5jdGlvbiBiZSBhIGZ1bmN0aW9uIG9yIHVuZGVm aW5lZAogMSwyLDMKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFu Z2VMb2cKaW5kZXggNjQxMTljOWVhZjljMGE4ZmZhMGE0MDczYzgwMmIxYzhlNzFhZDM3ZS4uNjcw NGVlNzBjZDcwMjQ2Y2I4ZjQ0MDViMmVmZTE3ODdmNjZlNTgzYSAxMDA2NDQKLS0tIGEvSlNUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx OC0wNi0wOSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KKworICAgICAg ICBbSlNDXSBBcnJheS5wcm90b3R5cGUuc29ydCBzaG91bGQgcmVqZWN0cyBudWxsIGNvbXBhcmF0 b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjQ1 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ2hh a3JhQ29yZS90ZXN0L0FycmF5L2FycmF5X3NvcnQuYmFzZWxpbmUtanNjOgorICAgICAgICAqIHN0 cmVzcy9hcnJheS1zb3J0LWJhZC1jb21wYXJhdG9yLmpzOgorICAgICAgICAodGVzdCk6CisgICAg ICAgICogc3RyZXNzL3NvcnQtbnVsbC1jb21wYXJhdG9yLmpzOiBSZW1vdmVkLgorICAgICAgICAq IHRlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWw6CisKIDIwMTgtMDYtMDcgIFNhYW0gQmFyYXRpICA8 c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBERkcgdG8gRlRMIE9TUiBlbnRyeSBj b2RlIG1vcmUgc2FuZSBieSByZW1vdmluZyBiYWQgUkVMRUFTRV9BU1NFUlRTIGFuZCBtYWtpbmcg aXQgdHJpZ2dlciBjb21waWxlcyBpbiBvdXRlciBsb29wcyBiZWZvcmUgaW5uZXIgb25lcwpkaWZm IC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvYXJyYXktc29ydC1iYWQtY29tcGFyYXRvci5qcyBiL0pT VGVzdHMvc3RyZXNzL2FycmF5LXNvcnQtYmFkLWNvbXBhcmF0b3IuanMKaW5kZXggMGQ5YjI3Y2M1 NDQ4YjA1OGRlYTAyZDI2OGY0MGIwNDViODkxMmUzYi4uYzA4MjAzYWUyNmVmNmEyZTJhZjUxZDdi MmU3NGUxMjU0ZmJjOWIyMyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvYXJyYXktc29ydC1i YWQtY29tcGFyYXRvci5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9hcnJheS1zb3J0LWJhZC1jb21w YXJhdG9yLmpzCkBAIC0xLDEwICsxLDE0IEBACiAvL0AgcnVuRGVmYXVsdAogCiBmdW5jdGlvbiB0 ZXN0KCkgeworICAgIHRyeSB7CisgICAgICAgIFsxLDJdLnNvcnQobnVsbCk7CisgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAgICAgfSBjYXRjaCAoZW51bGwpIHt9CiAgICAgdHJ5IHsKICAgICAg ICAgWzEsMl0uc29ydCh0cnVlKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0gY2F0Y2gg KGV0cnVlKSB7fQorICAgICAgICB9IGNhdGNoIChldHJ1ZSkge30KICAgICB0cnkgewogICAgICAg ICBbMSwyXS5zb3J0KHt9KTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvSlNU ZXN0cy9zdHJlc3Mvc29ydC1udWxsLWNvbXBhcmF0b3IuanMgYi9KU1Rlc3RzL3N0cmVzcy9zb3J0 LW51bGwtY29tcGFyYXRvci5qcwpkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggNDczOThm MDhjYWE4MDBjN2RmOTE3OGRjNmU2NDI0YTE0NjMxYWM4Ni4uMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9zb3J0LW51bGwtY29tcGFy YXRvci5qcworKysgL2Rldi9udWxsCkBAIC0xLDEwICswLDAgQEAKLS8vIFdoaWxlIHRoaXMgaXMg bm90IHJlcXVpcmVkIGJ5IHRoZSBzcGVjLiBJdCBsb29rcyBsaWtlIHNvbWUgd2Vic2l0ZXMgcmVs eSBvbiB0aGUgY29tcGFyYXRvciBiZWluZyBudWxsLgotCi1mdW5jdGlvbiBhc3NlcnRFcShhLCBi KSB7Ci0gICAgaWYgKGEgIT09IGIpCi0gICAgICAgIHRocm93IG5ldyBFcnJvcigpOwotfQotCi1s ZXQgYXJyYXkgPSBbMiwxXS5zb3J0KG51bGwpOwotYXNzZXJ0RXEoYXJyYXlbMF0sIDEpOwotYXNz ZXJ0RXEoYXJyYXlbMV0sIDIpOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0 aW9ucy55YW1sIGIvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sCmluZGV4IDM0ZWNl ODE4YzJjOGUwZWRhNWRiMmZlMWI1Y2MxYjEzYzAxN2EzN2YuLjc2OTEyMmRjODFlMWI4ZDZhODMy ZDdjYmU4MmY0MmI2NjU5ZDQ4MWQgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3Rh dGlvbnMueWFtbAorKysgYi9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKQEAgLTcw NSw5ICs3MDUsNiBAQCB0ZXN0L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvc2xpY2UvdGFyZ2V0 LWFycmF5LXdpdGgtbm9uLXdyaXRhYmxlLXByb3BlcnR5LmpzOgogdGVzdC9idWlsdC1pbnMvQXJy YXkvcHJvdG90eXBlL3NvcnQvUzE1LjQuNC4xMV9BNF9UMy5qczoKICAgZGVmYXVsdDogJ1Rlc3Qy NjJFcnJvcjogIzM6IHZhciBvYmogPSB7fTsgb2JqLnNvcnQgPSBBcnJheS5wcm90b3R5cGUuc29y dDsgb2JqWzBdID0gInoiOyBvYmpbMV0gPSAieSI7IG9ialsyXSA9ICJ4Ijsgb2JqLmxlbmd0aCA9 IC00Mjk0OTY3Mjk0OyBvYmouc29ydCgpOyBvYmpbMF0gPT09ICJ6Ii4gQWN0dWFsOiB5JwogICBz dHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogIzM6IHZhciBvYmogPSB7fTsgb2JqLnNvcnQgPSBB cnJheS5wcm90b3R5cGUuc29ydDsgb2JqWzBdID0gInoiOyBvYmpbMV0gPSAieSI7IG9ialsyXSA9 ICJ4Ijsgb2JqLmxlbmd0aCA9IC00Mjk0OTY3Mjk0OyBvYmouc29ydCgpOyBvYmpbMF0gPT09ICJ6 Ii4gQWN0dWFsOiB5JwotdGVzdC9idWlsdC1pbnMvQXJyYXkvcHJvdG90eXBlL3NvcnQvY29tcGFy ZWZuLW5vbmZ1bmN0aW9uLWNhbGwtdGhyb3dzLmpzOgotICBkZWZhdWx0OiAnVGVzdDI2MkVycm9y OiBzYW1wbGUuc29ydChudWxsKTsgRXhwZWN0ZWQgYSBUeXBlRXJyb3IgdG8gYmUgdGhyb3duIGJ1 dCBubyBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCi0gIHN0cmljdCBtb2RlOiAnVGVzdDI2 MkVycm9yOiBzYW1wbGUuc29ydChudWxsKTsgRXhwZWN0ZWQgYSBUeXBlRXJyb3IgdG8gYmUgdGhy b3duIGJ1dCBubyBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCiB0ZXN0L2J1aWx0LWlucy9B cnJheS9wcm90b3R5cGUvc3BsaWNlL1MxNS40LjQuMTJfQTNfVDEuanM6CiAgIGRlZmF1bHQ6ICdU ZXN0MjYyRXJyb3I6ICMxOiB2YXIgb2JqID0ge307IG9iai5zcGxpY2UgPSBBcnJheS5wcm90b3R5 cGUuc3BsaWNlOyBvYmpbMF0gPSAieCI7IG9ials0Mjk0OTY3Mjk1XSA9ICJ5Ijsgb2JqLmxlbmd0 aCA9IDQyOTQ5NjcyOTY7IHZhciBhcnIgPSBvYmouc3BsaWNlKDQyOTQ5NjcyOTUsMSk7IGFyci5s ZW5ndGggPT09IDEuIEFjdHVhbDogMCcKICAgc3RyaWN0IG1vZGU6ICdUZXN0MjYyRXJyb3I6ICMx OiB2YXIgb2JqID0ge307IG9iai5zcGxpY2UgPSBBcnJheS5wcm90b3R5cGUuc3BsaWNlOyBvYmpb MF0gPSAieCI7IG9ials0Mjk0OTY3Mjk1XSA9ICJ5Ijsgb2JqLmxlbmd0aCA9IDQyOTQ5NjcyOTY7 IHZhciBhcnIgPSBvYmouc3BsaWNlKDQyOTQ5NjcyOTUsMSk7IGFyci5sZW5ndGggPT09IDEuIEFj dHVhbDogMCcK