186446 2018-06-08 14:06:06 -0700 jumpTrueOrFalse only takes the fast path for boolean false 2018-06-08 17:57:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1431410 0 tzagallo 2018-06-08 14:06:06 -0700 jumpTrueOrFalse did a mask check to take the fast path for boolean literals, but it would only work for false. Change it so that it takes the fast path for true, false and undefined. 1431411 1 webkit-bug-importer 2018-06-08 14:06:44 -0700 <rdar://problem/40949995> 1431420 2 342326 tzagallo 2018-06-08 14:18:51 -0700 Created attachment 342326 Patch 1431440 3 342326 mark.lam 2018-06-08 15:02:24 -0700 Comment on attachment 342326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342326&action=review r=me with fixes. > Source/JavaScriptCore/ChangeLog:11 > + the fast path for true, false and undefined. and null too. This is only for 64-bit. For 32-bit, it was already taking the fast path for true or false, and still does for only those 2 values. Please add this to the ChangeLog comment so that we don't miscommunicate the scope of this change. > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1824 > + btqnz t0, ~15, .slow nit: I prefer you use ~0xf instead so that we can think in terms of the bits being masked. 1431498 4 342346 tzagallo 2018-06-08 17:06:27 -0700 Created attachment 342346 Patch for landing 1431512 5 342346 commit-queue 2018-06-08 17:57:29 -0700 Comment on attachment 342346 Patch for landing Clearing flags on attachment: 342346 Committed r232658: <https://trac.webkit.org/changeset/232658> 1431513 6 commit-queue 2018-06-08 17:57:30 -0700 All reviewed patches have been landed. Closing bug. 342326 2018-06-08 14:18:51 -0700 2018-06-08 17:06:25 -0700 Patch bug-186446-20180608141850.patch text/plain 2411 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ODliNTczOTUwMDljYzA5ZDNmZDhhODQ2MGFmOTMxOWNmYTE0YmYxLi40N2Q3ZjIzOTIwNDNmNmE1 YzdlMDEwZGY4Mzg5MmMzYjE3MDNkZDRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wNi0wOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBqdW1wVHJ1ZU9yRmFsc2Ugb25seSB0YWtlcyB0aGUgZmFzdCBwYXRoIGZv ciBib29sZWFuIGZhbHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODY0NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQwOTQ5OTk1PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGp1bXBUcnVlT3JGYWxz ZSBkaWQgYSBtYXNrIGNoZWNrIHRvIHRha2UgdGhlIGZhc3QgcGF0aCBmb3IgYm9vbGVhbgorICAg ICAgICBsaXRlcmFscywgYnV0IGl0IHdvdWxkIG9ubHkgd29yayBmb3IgZmFsc2UuIENoYW5nZSBp dCBzbyB0aGF0IGl0IHRha2VzCisgICAgICAgIHRoZSBmYXN0IHBhdGggZm9yIHRydWUsIGZhbHNl IGFuZCB1bmRlZmluZWQuCisKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFz bToKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOgorCiAyMDE4LTA2 LTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGJhc2Ug Y2xhc3MgdG8gZ2V0IFdlYWtQdHJGYWN0b3J5IG1lbWJlciBhbmQgYXZvaWQgc29tZSBib2lsZXJw bGF0ZSBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlci5hc20gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlci5hc20KaW5kZXggNTQ5MTQ5ZmI5MGUxY2M0OTZjZWE1Mjg0ZWI1MDc2OWExZTI5 NzdkMy4uOWU4MzQzMDM2MTNhNWM5M2QzMWYwZmM1YzA0NjQwNmYzMjNmM2Q2YSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQpA QCAtMTU4MywxNCArMTU4MywxNCBAQCBfbGxpbnRfb3BfZGVmaW5lX2FjY2Vzc29yX3Byb3BlcnR5 OgogX2xsaW50X29wX2p0cnVlOgogICAgIHRyYWNlRXhlY3V0aW9uKCkKICAgICBqdW1wVHJ1ZU9y RmFsc2UoCi0gICAgICAgIG1hY3JvICh2YWx1ZSwgdGFyZ2V0KSBidGlueiB2YWx1ZSwgdGFyZ2V0 IGVuZCwKKyAgICAgICAgbWFjcm8gKHZhbHVlLCB0YXJnZXQpIGJ0aW56IHZhbHVlLCAxLCB0YXJn ZXQgZW5kLAogICAgICAgICBfbGxpbnRfc2xvd19wYXRoX2p0cnVlKQogCiAKIF9sbGludF9vcF9q ZmFsc2U6CiAgICAgdHJhY2VFeGVjdXRpb24oKQogICAgIGp1bXBUcnVlT3JGYWxzZSgKLSAgICAg ICAgbWFjcm8gKHZhbHVlLCB0YXJnZXQpIGJ0aXogdmFsdWUsIHRhcmdldCBlbmQsCisgICAgICAg IG1hY3JvICh2YWx1ZSwgdGFyZ2V0KSBidGl6IHZhbHVlLCAxLCB0YXJnZXQgZW5kLAogICAgICAg ICBfbGxpbnRfc2xvd19wYXRoX2pmYWxzZSkKIAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbSBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCmluZGV4IDhmYzQ3YTEyZWY2 ZTVhMDFjNTU4YWYzZWU4ODY5NThlNzQwNmU1OGEuLmFhN2JkOWVjMTk1ZGU2NGQ1MjU0MWI0NGQx NWYwZTI2MTJkNjZkNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9M b3dMZXZlbEludGVycHJldGVyNjQuYXNtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCkBAIC0xODIxLDggKzE4MjEsNyBAQCBfbGxpbnRf b3Bfam1wOgogbWFjcm8ganVtcFRydWVPckZhbHNlKGNvbmRpdGlvbk9wLCBzbG93KQogICAgIGxv YWRpc0Zyb21JbnN0cnVjdGlvbigxLCB0MSkKICAgICBsb2FkQ29uc3RhbnRPclZhcmlhYmxlKHQx LCB0MCkKLSAgICB4b3JxIFZhbHVlRmFsc2UsIHQwCi0gICAgYnRxbnogdDAsIC0xLCAuc2xvdwor ICAgIGJ0cW56IHQwLCB+MTUsIC5zbG93CiAgICAgY29uZGl0aW9uT3AodDAsIC50YXJnZXQpCiAg ICAgZGlzcGF0Y2goMykKIAo= 342346 2018-06-08 17:06:27 -0700 2018-06-08 17:57:29 -0700 Patch for landing bug-186446-20180608170627.patch text/plain 2444 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ODliNTczOTUwMDljYzA5ZDNmZDhhODQ2MGFmOTMxOWNmYTE0YmYxLi41OTMxZjA3OGZkMjBmMDNh Y2YwN2E5OTQ0OTRkODY0NWEyMWM5ZTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wNi0wOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBqdW1wVHJ1ZU9yRmFsc2Ugb25seSB0YWtlcyB0aGUgZmFzdCBwYXRoIGZv ciBib29sZWFuIGZhbHNlIG9uIDY0Yml0IExMSW50IAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NDQ2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 MDk0OTk5NT4KKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBPbiA2 NGJpdCBMTEludCwganVtcFRydWVPckZhbHNlIGRpZCBhIG1hc2sgY2hlY2sgdG8gdGFrZSB0aGUg ZmFzdCBwYXRoIGZvcgorICAgICAgICBib29sZWFuIGxpdGVyYWxzLCBidXQgaXQgd291bGQgb25s eSB3b3JrIGZvciBmYWxzZS4gQ2hhbmdlIGl0IHNvIHRoYXQgaXQKKyAgICAgICAgdGFrZXMgdGhl IGZhc3QgcGF0aCBmb3IgdHJ1ZSwgZmFsc2UsIG51bGwgYW5kIHVuZGVmaW5lZC4KKworICAgICAg ICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgorICAgICAgICAqIGxsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXI2NC5hc206CisKIDIwMTgtMDYtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYmFzZSBjbGFzcyB0byBnZXQgV2Vha1B0ckZhY3Rv cnkgbWVtYmVyIGFuZCBhdm9pZCBzb21lIGJvaWxlcnBsYXRlIGNvZGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQppbmRleCA1NDkx NDlmYjkwZTFjYzQ5NmNlYTUyODRlYjUwNzY5YTFlMjk3N2QzLi45ZTgzNDMwMzYxM2E1YzkzZDMx ZjBmYzVjMDQ2NDA2ZjMyM2YzZDZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC0xNTgzLDE0ICsxNTgzLDE0IEBAIF9s bGludF9vcF9kZWZpbmVfYWNjZXNzb3JfcHJvcGVydHk6CiBfbGxpbnRfb3BfanRydWU6CiAgICAg dHJhY2VFeGVjdXRpb24oKQogICAgIGp1bXBUcnVlT3JGYWxzZSgKLSAgICAgICAgbWFjcm8gKHZh bHVlLCB0YXJnZXQpIGJ0aW56IHZhbHVlLCB0YXJnZXQgZW5kLAorICAgICAgICBtYWNybyAodmFs dWUsIHRhcmdldCkgYnRpbnogdmFsdWUsIDEsIHRhcmdldCBlbmQsCiAgICAgICAgIF9sbGludF9z bG93X3BhdGhfanRydWUpCiAKIAogX2xsaW50X29wX2pmYWxzZToKICAgICB0cmFjZUV4ZWN1dGlv bigpCiAgICAganVtcFRydWVPckZhbHNlKAotICAgICAgICBtYWNybyAodmFsdWUsIHRhcmdldCkg YnRpeiB2YWx1ZSwgdGFyZ2V0IGVuZCwKKyAgICAgICAgbWFjcm8gKHZhbHVlLCB0YXJnZXQpIGJ0 aXogdmFsdWUsIDEsIHRhcmdldCBlbmQsCiAgICAgICAgIF9sbGludF9zbG93X3BhdGhfamZhbHNl KQogCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbElu dGVycHJldGVyNjQuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50 ZXJwcmV0ZXI2NC5hc20KaW5kZXggOGZjNDdhMTJlZjZlNWEwMWM1NThhZjNlZTg4Njk1OGU3NDA2 ZTU4YS4uZjg2NzU5N2ZjNDZlNTMxYTM4NTU2MWYyNzFiODcxYTk4NDIyYmFiMCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20K KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5h c20KQEAgLTE4MjEsOCArMTgyMSw3IEBAIF9sbGludF9vcF9qbXA6CiBtYWNybyBqdW1wVHJ1ZU9y RmFsc2UoY29uZGl0aW9uT3AsIHNsb3cpCiAgICAgbG9hZGlzRnJvbUluc3RydWN0aW9uKDEsIHQx KQogICAgIGxvYWRDb25zdGFudE9yVmFyaWFibGUodDEsIHQwKQotICAgIHhvcnEgVmFsdWVGYWxz ZSwgdDAKLSAgICBidHFueiB0MCwgLTEsIC5zbG93CisgICAgYnRxbnogdDAsIH4weGYsIC5zbG93 CiAgICAgY29uZGl0aW9uT3AodDAsIC50YXJnZXQpCiAgICAgZGlzcGF0Y2goMykKIAo=