<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>186444</bug_id>
          
          <creation_ts>2018-06-08 13:54:55 -0700</creation_ts>
          <short_desc>[CoordGraphics] CompositingRunLoop assumes a WorkQueue has a RunLoop</short_desc>
          <delta_ts>2019-03-01 10:37:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>195208</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=195208</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>186364</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>fujii</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ysuzuki</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1431396</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-06-08 13:54:55 -0700</bug_when>
    <thetext>CompositingRunLoop has a method runLoop() which gets the runLoop of a WorkQueue. This is GTK and generic run loop specific so WinCairo cannot currently use this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1431529</commentid>
    <comment_count>1</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-06-08 20:37:03 -0700</bug_when>
    <thetext>I don&apos;t think WorkQueue should expose RunLoop in its member function since it&apos;s implementation detail. If handling RunLoop is required, it means that WorkQueue abstraction is too high to use there. CompositingRunLoop should use RunLoop instead of WorkQueue I think.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1510902</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-02-28 05:16:20 -0800</bug_when>
    <thetext>We have two options here, either use our own thread with a run loop, or keep using a work queue, but making the timer creation platform specific (I guess in windows you could add a WorkQueue::timerQueue() similar to dispatchQueue() used by cocoa and runLoop() used by glib and generic) and create the timer with  CreateTimerQueueTimer().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1511394</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-03-01 06:58:46 -0800</bug_when>
    <thetext>This will be fixed in bug #195208</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1511454</commentid>
    <comment_count>4</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2019-03-01 10:37:15 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 195208 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>