186440 2018-06-08 13:01:04 -0700 http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with PSON enabled 2018-06-13 16:30:37 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186542 1 cdumez cdumez beidson commit-queue ggaren webkit-bug-importer oldest_to_newest 1431362 0 cdumez 2018-06-08 13:01:04 -0700 http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with PSON enabled: --- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/http/tests/navigation/https-no-store-subframe-in-page-cache-expected.txt +++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/http/tests/navigation/https-no-store-subframe-in-page-cache-actual.txt @@ -1,3 +1,3 @@ ALERT: This page is https and has has a subframe with the no-store cache-control directive. It should go in to the page cache. -ALERT: PASS: The page was restored from the page cache. Good job! +ALERT: FAIL: The page was reloaded on back. It should NOT have been. Looks like we fail to restore the page from PageCache. 1431368 1 342311 cdumez 2018-06-08 13:07:56 -0700 Created attachment 342311 Patch 1431371 2 342311 ggaren 2018-06-08 13:14:17 -0700 Comment on attachment 342311 Patch r=me 1431401 3 342311 commit-queue 2018-06-08 13:59:49 -0700 Comment on attachment 342311 Patch Clearing flags on attachment: 342311 Committed r232638: <https://trac.webkit.org/changeset/232638> 1431402 4 commit-queue 2018-06-08 13:59:50 -0700 All reviewed patches have been landed. Closing bug. 1431404 5 webkit-bug-importer 2018-06-08 14:00:41 -0700 <rdar://problem/40949724> 342311 2018-06-08 13:07:56 -0700 2018-06-08 13:59:49 -0700 Patch bug-186440-20180608130756.patch text/plain 2528 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNjE5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjRkNDA5YWZkOWJhMTVlNDQxYjYy OWNhMDc0MjNjZDc0MjQ1MjYyZi4uMmM2YjZlZTJlNjg1MDI1N2UwZDgwZjVmYTUyODFmN2Q4NTA1 NGZhOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTA4ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2h0dHBzLW5v LXN0b3JlLXN1YmZyYW1lLWluLXBhZ2UtY2FjaGUuaHRtbCBmYWlscyB3aXRoIFBTT04gZW5hYmxl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NDQw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3ZlcnJp ZGUgdGhlIFBhZ2VDYWNoZSBzZXR0aW5nICphZnRlciogdGhlIGNyb3NzLW9yaWdpbiBuYXZpZ2F0 aW9uLiBJdCB3YXMgcHJldmlvdXNseQorICAgICAgICBvdmVycmlkZW4gYmVmb3JlIHRoZSBuYXZp Z2F0aW9uIGFuZCB0aHVzIHdvdWxkIG5vdCBwZXJzaXN0IHdpdGggcHJvY2VzcyBzd2FwIG9uIG5h dmlnYXRpb24KKyAgICAgICAgZW5hYmxlZC4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdh dGlvbi9odHRwcy1uby1zdG9yZS1zdWJmcmFtZS1pbi1wYWdlLWNhY2hlLmh0bWw6CisgICAgICAg ICogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9odHRwcy1uby1zdG9yZS1zdWJmcmFt ZS1pbi1wYWdlLWNhY2hlLmh0bWw6CisKIDIwMTgtMDYtMDcgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIEVuaGFuY2UgcnVuLWpzYy1zdHJlc3MtdGVzdHMgdG8gYWxs b3cgYSB0ZXN0IHRvIHNwZWNpZnkgdGVzdCBzcGVjaWZpYyBvcHRpb25zIHJlcXVpcmVkIGZvciBp dCB0byBydW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24v aHR0cHMtbm8tc3RvcmUtc3ViZnJhbWUtaW4tcGFnZS1jYWNoZS5odG1sIGIvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2h0dHBzLW5vLXN0b3JlLXN1YmZyYW1lLWluLXBhZ2UtY2Fj aGUuaHRtbAppbmRleCBjMjRjYjU5NGJjMTUzM2Y1YWMwMmNjYmE5NWY2ZjZhMDY0MTY2YzRjLi45 MDcxYmEzZmE5NDg5MzFkMmI2NTFiNTY4ZDM3MzU2MWVjNjcxMzU2IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vaHR0cHMtbm8tc3RvcmUtc3ViZnJhbWUtaW4t cGFnZS1jYWNoZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9o dHRwcy1uby1zdG9yZS1zdWJmcmFtZS1pbi1wYWdlLWNhY2hlLmh0bWwKQEAgLTMsNyArMyw2IEBA CiBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK ICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKLSAgICB0ZXN0UnVubmVyLm92ZXJyaWRl UHJlZmVyZW5jZSgiV2ViS2l0VXNlc1BhZ2VDYWNoZVByZWZlcmVuY2VLZXkiLCAxKTsKIH0KIAog aWYgKGxvY2F0aW9uLnByb3RvY29sICE9ICJodHRwczoiKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9odHRwcy1uby1zdG9yZS1zdWJmcmFt ZS1pbi1wYWdlLWNhY2hlLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24v cmVzb3VyY2VzL2h0dHBzLW5vLXN0b3JlLXN1YmZyYW1lLWluLXBhZ2UtY2FjaGUuaHRtbAppbmRl eCA2MzZkMTE4NmViYjRjOTZhYWJmY2QzODgwYzJhNDI2YjY3YjZiYzlkLi5jYzE0ZDY3NTBjYmNm MmZmYjNkMmFmMTAyNGE2M2Y3MjdhNDgyZDZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL2h0dHBzLW5vLXN0b3JlLXN1YmZyYW1lLWluLXBh Z2UtY2FjaGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVz b3VyY2VzL2h0dHBzLW5vLXN0b3JlLXN1YmZyYW1lLWluLXBhZ2UtY2FjaGUuaHRtbApAQCAtMTMs NiArMTMsOSBAQCB3aW5kb3cub25wYWdlc2hvdyA9IGZ1bmN0aW9uKGV2dCkKIAogd2luZG93Lm9u bG9hZCA9IGZ1bmN0aW9uKCkKIHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAg IHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRVc2VzUGFnZUNhY2hlUHJlZmVy ZW5jZUtleSIsIDEpOworCiAgICAgaWYgKHdpbmRvdy5zZXNzaW9uU3RvcmFnZS5odHRwc19pbl9w YWdlX2NhY2hlX3N0YXJ0ZWQpIHsKICAgICAgICAgYWxlcnQoIkZBSUw6IFRoZSBwYWdlIHdhcyBy ZWxvYWRlZCBvbiBiYWNrLiBJdCBzaG91bGQgTk9UIGhhdmUgYmVlbi4iKTsKICAgICAgICAgaWYg KHdpbmRvdy50ZXN0UnVubmVyKQo=