18643 2008-04-20 16:36:14 -0700 SQUIRRELFISH: need to support implicit function calls (valueOf, toString) 2008-04-29 22:15:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 18624 1 mjs oliver oliver zwarich oldest_to_newest 78342 0 mjs 2008-04-20 16:36:14 -0700 SquirrelFish does not yet properly handle property getters and setters. 78692 1 oliver 2008-04-23 13:14:03 -0700 The problem for these implicit function calls (valueOf is called by toNumber, toString by +, etc, getters/setters by resolve) is that they may require a function call in the VM, which may inturn result in resizing of the RegisterFile which would invalidate state in the originating privateExecute frame. Adding the required guards around all call sites would almost certainly be a perf hit but maybe possible at a few places (resolve?) 78731 2 zwarich 2008-04-23 21:20:47 -0700 This is causing a lot of failures in the remaining JavaScriptCore test failures, e.g. the instanceof tests. We should really find a way to fix this without too large of a performance regression. 78748 3 mjs 2008-04-24 00:50:33 -0700 I'm not sure valueOf / toString are quire the same issue as getters and setters, and we might not want to solve them the exact same way necessarily. 79262 4 oliver 2008-04-29 22:15:40 -0700 Committed r32669 and r32718