186409 2018-06-07 13:52:00 -0700 Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run. 2018-06-07 15:07:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue lforschler saam webkit-bug-importer oldest_to_newest 1431010 0 mark.lam 2018-06-07 13:52:00 -0700 This is needed because some tests are written with specific features in mind, and we may not necessarily want to enable that option for all tests. 1431011 1 webkit-bug-importer 2018-06-07 13:52:36 -0700 <rdar://problem/40909007> 1431015 2 342204 mark.lam 2018-06-07 14:03:26 -0700 Created attachment 342204 proposed patch. 1431024 3 342204 mark.lam 2018-06-07 14:40:04 -0700 Comment on attachment 342204 proposed patch. Thanks for the review. 1431044 4 342204 commit-queue 2018-06-07 15:07:42 -0700 Comment on attachment 342204 proposed patch. Clearing flags on attachment: 342204 Committed r232603: <https://trac.webkit.org/changeset/232603> 1431045 5 commit-queue 2018-06-07 15:07:44 -0700 All reviewed patches have been landed. Closing bug. 342204 2018-06-07 14:03:26 -0700 2018-06-07 15:07:42 -0700 proposed patch. bug-186409.patch text/plain 6258 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMjU5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE4LTA2LTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBFbmhhbmNlIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzIHRvIGFsbG93IGEgdGVzdCB0byBz cGVjaWZ5IHRlc3Qgc3BlY2lmaWMgb3B0aW9ucyByZXF1aXJlZCBmb3IgaXQgdG8gcnVuLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NDA5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80MDkwOTAwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIG5lZWRlZCBiZWNhdXNlIHNvbWUgdGVzdHMg YXJlIHdyaXR0ZW4gd2l0aCBzcGVjaWZpYyBmZWF0dXJlcyBpbiBtaW5kLCBhbmQKKyAgICAgICAg d2UgbWF5IG5vdCBuZWNlc3NhcmlseSB3YW50IHRvIGVuYWJsZSB0aGF0IG9wdGlvbiBmb3IgYWxs IHRlc3RzLgorCisgICAgICAgIFdlIGNhbiBub3cgc3BlY2lmeSBzb21ldGhpbmcgbGlrZSB0aGlz IGF0IHRoZSB0b3Agb2YgYSB0ZXN0IGZpbGU6CisgICAgICAgICAgICAvL0AgcmVxdWlyZU9wdGlv bnMoIi0tdXNlSW50bFBsdXJhbFJ1bGVzPXRydWUiKQorCisgICAgICAgIC4uLiBhbmQgZW5zdXJl IHRoYXQgdGhhdCB0ZXN0IHdpbGwgYmUgcnVuIHdpdGggdGhlIC0tdXNlSW50bFBsdXJhbFJ1bGVz PXRydWUKKyAgICAgICAgb3B0aW9uIGZvciBhbGwgdGVzdCBjb25maWd1cmF0aW9ucyB0aGF0IHJ1 biB0aGUgdGVzdC4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6CisK IDIwMTgtMDYtMDcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjIzMjU0NCk6IFtpT1NdIFRlc3RXZWJLaXRBUEkuV2ViS2l0Lk92 ZXJyaWRlTGF5b3V0U2l6ZUNoYW5nZXNEdXJpbmdBbmltYXRlZFJlc2l6ZVN1Y2NlZWQgaXMgZmFp bGluZwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCShyZXZpc2lvbiAyMzI1ODQp CisrKyBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBA IC01MDMsNiArNTAzLDcgQEAgZGVmIHBhdGhUb0hlbHBlcnMKIGVuZAogCiAkcnVuQ29tbWFuZE9w dGlvbnMgPSB7fQorJHRlc3RTcGVjaWZpY1JlcXVpcmVkT3B0aW9ucyA9IFtdCiAKICR1bmlxdWVG aWxlbmFtZUNvdW50ZXIgPSAwCiBkZWYgdW5pcXVlRmlsZW5hbWUoZXh0ZW5zaW9uKQpAQCAtNTcy LDggKzU3MywxMiBAQCBkZWYgc2xvdyEKICAgICAkcnVuQ29tbWFuZE9wdGlvbnNbOmlzU2xvd10g PSB0cnVlCiBlbmQKIAorZGVmIHJlcXVpcmVPcHRpb25zKCpvcHRpb25zKQorICAgICR0ZXN0U3Bl Y2lmaWNSZXF1aXJlZE9wdGlvbnMgKz0gb3B0aW9ucworZW5kCisKIGRlZiBydW5XaXRoT3V0cHV0 SGFuZGxlcihraW5kLCBvdXRwdXRIYW5kbGVyLCAqb3B0aW9ucykKLSAgICBhZGRSdW5Db21tYW5k KGtpbmQsIFtwYXRoVG9WTS50b19zXSArIEJBU0VfT1BUSU9OUyArIG9wdGlvbnMgKyBbJGJlbmNo bWFyay50b19zXSwgb3V0cHV0SGFuZGxlciwgc2ltcGxlRXJyb3JIYW5kbGVyKQorICAgIGFkZFJ1 bkNvbW1hbmQoa2luZCwgW3BhdGhUb1ZNLnRvX3NdICsgQkFTRV9PUFRJT05TICsgJHRlc3RTcGVj aWZpY1JlcXVpcmVkT3B0aW9ucyArIG9wdGlvbnMgKyBbJGJlbmNobWFyay50b19zXSwgb3V0cHV0 SGFuZGxlciwgc2ltcGxlRXJyb3JIYW5kbGVyKQogZW5kCiAKIGRlZiBydW4oa2luZCwgKm9wdGlv bnMpCkBAIC05MTQsNyArOTE5LDcgQEAgZGVmIHJ1blRlc3QyNjIobW9kZSwgZXhjZXB0aW9uLCBp bmNsdWRlRgogCiAgICAgcHJlcGFyZUV4dHJhUmVsYXRpdmVGaWxlcyhpbmNsdWRlRmlsZXMubWFw IHsgfGZ8ICIuLi8iICsgZiB9LCAkY29sbGVjdGlvbikKIAotICAgIGFyZ3MgPSBbcGF0aFRvVk0u dG9fc10gKyBCQVNFX09QVElPTlMKKyAgICBhcmdzID0gW3BhdGhUb1ZNLnRvX3NdICsgQkFTRV9P UFRJT05TICsgJHRlc3RTcGVjaWZpY1JlcXVpcmVkT3B0aW9ucwogICAgIGFyZ3MgPDwgIi0tZXhj ZXB0aW9uPSIgKyBleGNlcHRpb24gaWYgZmFpbHNXaXRoRXhjZXB0aW9uCiAgICAgYXJncyA8PCAi LS10ZXN0MjYyLWFzeW5jIiBpZiBpc0FzeW5jCiAgICAgYXJncyArPSBpbmNsdWRlRmlsZXMKQEAg LTk1Niw3ICs5NjEsNyBAQCBkZWYgcHJlcGFyZVRlc3QyNjJGaXh0dXJlCiBlbmQKIAogZGVmIHJ1 bkVTNihtb2RlKQotICAgIGFyZ3MgPSBbcGF0aFRvVk0udG9fc10gKyBCQVNFX09QVElPTlMgKyBb JGJlbmNobWFyay50b19zXQorICAgIGFyZ3MgPSBbcGF0aFRvVk0udG9fc10gKyBCQVNFX09QVElP TlMgKyAkdGVzdFNwZWNpZmljUmVxdWlyZWRPcHRpb25zICsgWyRiZW5jaG1hcmsudG9fc10KICAg ICBjYXNlIG1vZGUKICAgICB3aGVuIDpub3JtYWwKICAgICAgICAgZXJyb3JIYW5kbGVyID0gc2lt cGxlRXJyb3JIYW5kbGVyCkBAIC0xMDg3LDcgKzEwOTIsNyBAQCBkZWYgcnVuQ2hha3JhKG1vZGUs IGV4Y2VwdGlvbiwgYmFzZWxpbmVGCiAgICAgcHJlcGFyZUV4dHJhQWJzb2x1dGVGaWxlcyhDSEFL UkFURVNUU19QQVRILCBbImpzYy1saWIuanMiXSkKICAgICBwcmVwYXJlRXh0cmFSZWxhdGl2ZUZp bGVzKGV4dHJhRmlsZXMubWFwIHsgfGZ8ICIuLi8iICsgZiB9LCAkY29sbGVjdGlvbikKIAotICAg IGFyZ3MgPSBbcGF0aFRvVk0udG9fc10gKyBCQVNFX09QVElPTlMKKyAgICBhcmdzID0gW3BhdGhU b1ZNLnRvX3NdICsgQkFTRV9PUFRJT05TICsgJHRlc3RTcGVjaWZpY1JlcXVpcmVkT3B0aW9ucwog ICAgIGFyZ3MgKz0gRlRMX09QVElPTlMgaWYgJGlzRlRMUGxhdGZvcm0KICAgICBhcmdzICs9IEVB R0VSX09QVElPTlMKICAgICBhcmdzIDw8ICItLWV4Y2VwdGlvbj0iICsgZXhjZXB0aW9uIGlmIGZh aWxzV2l0aEV4Y2VwdGlvbgpAQCAtMTEyOCw3ICsxMTMzLDcgQEAgZGVmIHJ1bkxheW91dFRlc3Qo a2luZCwgKm9wdGlvbnMpCiAgICAgcHJlcGFyZUV4dHJhUmVsYXRpdmVGaWxlcyhbIi4uLyN7dGVz dE5hbWV9LWV4cGVjdGVkLnR4dCJdLCAkYmVuY2htYXJrRGlyZWN0b3J5KQogICAgIHByZXBhcmVF eHRyYUFic29sdXRlRmlsZXMoTEFZT1VUVEVTVFNfUEFUSCwgWyJyZXNvdXJjZXMvc3RhbmRhbG9u ZS1wcmUuanMiLCAicmVzb3VyY2VzL3N0YW5kYWxvbmUtcG9zdC5qcyJdKQogCi0gICAgYXJncyA9 IFtwYXRoVG9WTS50b19zXSArIEJBU0VfT1BUSU9OUyArIG9wdGlvbnMgKworICAgIGFyZ3MgPSBb cGF0aFRvVk0udG9fc10gKyBCQVNFX09QVElPTlMgKyAkdGVzdFNwZWNpZmljUmVxdWlyZWRPcHRp b25zICsgb3B0aW9ucyArCiAgICAgICAgIFsoUGF0aG5hbWUubmV3KCJyZXNvdXJjZXMiKSArICJz dGFuZGFsb25lLXByZS5qcyIpLnRvX3MsCiAgICAgICAgICAkYmVuY2htYXJrLnRvX3MsCiAgICAg ICAgICAoUGF0aG5hbWUubmV3KCJyZXNvdXJjZXMiKSArICJzdGFuZGFsb25lLXBvc3QuanMiKS50 b19zXQpAQCAtMTI2OCw3ICsxMjczLDcgQEAgZGVmIHJ1bk1vemlsbGFUZXN0KGtpbmQsIG1vZGUs IGV4dHJhRmlsZQogICAgICAgICBraW5kID0gIm1vemlsbGEiCiAgICAgZW5kCiAgICAgcHJlcGFy ZUV4dHJhUmVsYXRpdmVGaWxlcyhleHRyYUZpbGVzLm1hcHt8dnwgKFBhdGhuYW1lKCIuLiIpICsg dikudG9fc30sICRjb2xsZWN0aW9uKQotICAgIGFyZ3MgPSBbcGF0aFRvVk0udG9fc10gKyBCQVNF X09QVElPTlMgKyBvcHRpb25zICsgZXh0cmFGaWxlcy5tYXB7fHZ8IHYudG9fc30gKyBbJGJlbmNo bWFyay50b19zXQorICAgIGFyZ3MgPSBbcGF0aFRvVk0udG9fc10gKyBCQVNFX09QVElPTlMgKyAk dGVzdFNwZWNpZmljUmVxdWlyZWRPcHRpb25zICsgb3B0aW9ucyArIGV4dHJhRmlsZXMubWFwe3x2 fCB2LnRvX3N9ICsgWyRiZW5jaG1hcmsudG9fc10KICAgICBjYXNlIG1vZGUKICAgICB3aGVuIDpu b3JtYWwKICAgICAgICAgZXJyb3JIYW5kbGVyID0gbW96aWxsYUVycm9ySGFuZGxlcgpAQCAtMTMz OCw3ICsxMzQzLDcgQEAgZGVmIGRlZmF1bHRSdW5Nb3ppbGxhVGVzdChtb2RlLCAqZXh0cmFGaQog ZW5kCiAKIGRlZiBydW5Ob2lzeVRlc3RJbXBsKGtpbmQsIG9wdGlvbnMsIGFkZGl0aW9uYWxFbnYp Ci0gICAgYWRkUnVuQ29tbWFuZChraW5kLCBbcGF0aFRvVk0udG9fc10gKyBCQVNFX09QVElPTlMg KyBvcHRpb25zICsgWyRiZW5jaG1hcmsudG9fc10sIG5vaXN5T3V0cHV0SGFuZGxlciwgbm9pc3lF cnJvckhhbmRsZXIsICphZGRpdGlvbmFsRW52KQorICAgIGFkZFJ1bkNvbW1hbmQoa2luZCwgW3Bh dGhUb1ZNLnRvX3NdICsgQkFTRV9PUFRJT05TICsgJHRlc3RTcGVjaWZpY1JlcXVpcmVkT3B0aW9u cyArIG9wdGlvbnMgKyBbJGJlbmNobWFyay50b19zXSwgbm9pc3lPdXRwdXRIYW5kbGVyLCBub2lz eUVycm9ySGFuZGxlciwgKmFkZGl0aW9uYWxFbnYpCiBlbmQKIAogZGVmIHJ1bk5vaXN5VGVzdChr aW5kLCAqb3B0aW9ucykKQEAgLTE1MzYsNiArMTU0MSw3IEBAIGRlZiBoYW5kbGVDb2xsZWN0aW9u RGlyZWN0b3J5KGNvbGxlY3Rpb24KICAgICAgICAgICAgICRiZW5jaG1hcmsgPSBwYXRoLmJhc2Vu YW1lCiAgICAgICAgICAgICAKICAgICAgICAgICAgICRydW5Db21tYW5kT3B0aW9ucyA9IHt9Cisg ICAgICAgICAgICAkdGVzdFNwZWNpZmljUmVxdWlyZWRPcHRpb25zID0gW10KICAgICAgICAgICAg IGRlZmF1bHRSdW4gdW5sZXNzIHBhcnNlUnVuQ29tbWFuZHMKICAgICAgICAgfQogICAgIH0KSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDIzMjU4NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA2LTA3ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBFbmhhbmNlIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzIHRvIGFs bG93IGEgdGVzdCB0byBzcGVjaWZ5IHRlc3Qgc3BlY2lmaWMgb3B0aW9ucyByZXF1aXJlZCBmb3Ig aXQgdG8gcnVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg2NDA5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDkwOTAwNz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy9p bnRsLXBsdXJhbHJ1bGVzLmpzOgorCiAyMDE4LTA2LTA3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdo YW1AYXBwbGUuY29tPgogCiAgICAgICAgIEhhbmRsZSBTdG9yYWdlIEFjY2VzcyBBUEkgY2FsbHMg aW4gdGhlIGFic2VuY2Ugb2YgYW4gYXR0YWNoZWQgZnJhbWUKSW5kZXg6IExheW91dFRlc3RzL2pz L3NjcmlwdC10ZXN0cy9pbnRsLXBsdXJhbHJ1bGVzLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2pzL3NjcmlwdC10ZXN0cy9pbnRsLXBsdXJhbHJ1bGVzLmpzCShyZXZpc2lvbiAyMzI1ODQp CisrKyBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvaW50bC1wbHVyYWxydWxlcy5qcwkod29y a2luZyBjb3B5KQpAQCAtMSw0ICsxLDYgQEAKIC8vQCBza2lwIGlmICRob3N0T1MgPT0gIndpbmRv d3MiIG9yICRob3N0T1MgPT0gImxpbnV4IgorLy9AIHJlcXVpcmVPcHRpb25zKCItLXVzZUludGxQ bHVyYWxSdWxlcz10cnVlIikKKwogZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBjaGVja3MgdGhlIGJl aGF2aW9yIG9mIEludGwuUGx1cmFsUnVsZXMgYXMgZGVzY3JpYmVkIGluIHRoZSBFQ01BU2NyaXB0 IEludGVybmF0aW9uYWxpemF0aW9uIEFQSSBTcGVjaWZpY2F0aW9uLiIpOwogCiAvLyBodHRwczov L3RjMzkuZ2l0aHViLmlvL2VjbWE0MDIvI3BsdXJhbHJ1bGVzLW9iamVjdHMK