186403 2018-06-07 11:53:34 -0700 [webkitpy] Treat svn versions as Version objects 2018-06-07 16:15:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186404 https://bugs.webkit.org/show_bug.cgi?id=186401 InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue ddkilzer ews-watchlist glenn lforschler mitz ryanhaddad webkit-bug-importer oldest_to_newest 1430971 0 jbedard 2018-06-07 11:53:34 -0700 Seems like webkit-patch is generating diffs in a weird way with an svn checkout on Mojave seed 1. svn-create-patch works just fine, so the root of the problem is somewhere in webkit-patch. 1430974 1 webkit-bug-importer 2018-06-07 11:57:55 -0700 <rdar://problem/40904860> 1431043 2 jbedard 2018-06-07 15:07:31 -0700 Looks like there are a few other svn problems in Mojave too, revealed by running 'test-webkitpy --all'. 1431057 3 342213 jbedard 2018-06-07 15:43:46 -0700 Created attachment 342213 Patch 1431069 4 342213 commit-queue 2018-06-07 16:15:47 -0700 Comment on attachment 342213 Patch Clearing flags on attachment: 342213 Committed r232605: <https://trac.webkit.org/changeset/232605> 1431070 5 commit-queue 2018-06-07 16:15:48 -0700 All reviewed patches have been landed. Closing bug. 342213 2018-06-07 15:43:46 -0700 2018-06-07 16:15:47 -0700 Patch bug-186403-20180607154346.patch text/plain 4003 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMjYwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTA2LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFRyZWF0IHN2biB2ZXJzaW9ucyBhcyBWZXJzaW9uIG9i amVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 NjQwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDA5MDQ4NjA+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jaGVja291dC9zY20vc2NtX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zdm4ucHk6CisgICAgICAgIChTVk4uc3ZuX3ZlcnNpb24p OiBSZXR1cm4gVmVyc2lvbiBvYmplY3QgaW5zdGVhZCBvZiBzdHJpbmcuCisgICAgICAgIChTVk4u X3N0YXR1c19yZWdleHApOiBDb252ZXJ0IHZlcnNpb24gc3RyaW5nIHRvIFZlcnNpb24gb2JqZWN0 LgorICAgICAgICAoU1ZOLmFkZF9saXN0KTogRGl0dG8uCisKIDIwMTgtMDYtMDcgIE1hcmsgTGFt ICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEVuaGFuY2UgcnVuLWpzYy1zdHJlc3Mt dGVzdHMgdG8gYWxsb3cgYSB0ZXN0IHRvIHNwZWNpZnkgdGVzdCBzcGVjaWZpYyBvcHRpb25zIHJl cXVpcmVkIGZvciBpdCB0byBydW4uCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jaGVja291dC9zY20vc2NtX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zY21fdW5pdHRlc3QucHkJKHJldmlzaW9u IDIzMjU4MCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9z Y21fdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTUyLDYgKzUyLDcgQEAgZnJvbSB3ZWJr aXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbQogZnJvbSB3ZWJraXRweS5jb21tb24uc3lz dGVtLmZpbGVzeXN0ZW1fbW9jayBpbXBvcnQgTW9ja0ZpbGVTeXN0ZW0KIGZyb20gd2Via2l0cHku Y29tbW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJlIGltcG9ydCBPdXRwdXRDYXB0dXJlCiBmcm9tIHdl YmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlX21vY2sgaW1wb3J0IE1vY2tFeGVjdXRpdmUK K2Zyb20gd2Via2l0cHkuY29tbW9uLnZlcnNpb24gaW1wb3J0IFZlcnNpb24KIGZyb20gLmdpdCBp bXBvcnQgR2l0LCBBbWJpZ3VvdXNDb21taXRFcnJvcgogZnJvbSAuZGV0ZWN0aW9uIGltcG9ydCBk ZXRlY3Rfc2NtX3N5c3RlbQogZnJvbSAuc2NtIGltcG9ydCBTQ00sIENoZWNrb3V0TmVlZHNVcGRh dGUsIGNvbW1pdF9lcnJvcl9oYW5kbGVyLCBBdXRoZW50aWNhdGlvbkVycm9yCkBAIC05NTMsNyAr OTU0LDcgQEAgRU5ECiAgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2Uob3MucGF0aC5leGlzdHMoc2Vs Zi5ib2d1c19kaXIpKQogCiAgICAgZGVmIHRlc3Rfc3ZuX2xvY2soc2VsZik6Ci0gICAgICAgIGlm IHNlbGYuc2NtLnN2bl92ZXJzaW9uKCkgPj0gIjEuNyI6CisgICAgICAgIGlmIHNlbGYuc2NtLnN2 bl92ZXJzaW9uKCkgPj0gVmVyc2lvbigxLCA3KToKICAgICAgICAgICAgICMgdGhlIGZvbGxvd2lu ZyB0ZWNobmlxdWUgd2l0aCAuc3ZuL2xvY2sgdGhlbiBzdm4gdXBkYXRlIGRvZXNuJ3Qgd29yayB3 aXRoIHN1YnZlcnNpb24gY2xpZW50IDEuNyBvciBsYXRlcgogICAgICAgICAgICAgcGFzcwogICAg ICAgICBlbHNlOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQv c2NtL3N2bi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j aGVja291dC9zY20vc3ZuLnB5CShyZXZpc2lvbiAyMzI1ODApCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc3ZuLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00MCw2 ICs0MCw3IEBAIGZyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZy51cmxzIGltcG9ydCAKIGZyb20g d2Via2l0cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAogZnJvbSB3ZWJraXRweS5j b21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgRXhlY3V0aXZlLCBTY3JpcHRFcnJvcgogZnJv bSB3ZWJraXRweS5jb21tb24ud2Via2l0X2ZpbmRlciBpbXBvcnQgV2ViS2l0RmluZGVyCitmcm9t IHdlYmtpdHB5LmNvbW1vbi52ZXJzaW9uIGltcG9ydCBWZXJzaW9uCiAKIGZyb20gLnNjbSBpbXBv cnQgQXV0aGVudGljYXRpb25FcnJvciwgU0NNLCBjb21taXRfZXJyb3JfaGFuZGxlcgogCkBAIC0x MzksNyArMTQwLDcgQEAgY2xhc3MgU1ZOKFNDTSwgU1ZOUmVwb3NpdG9yeSk6CiAKICAgICBAbWVt b2l6ZWQKICAgICBkZWYgc3ZuX3ZlcnNpb24oc2VsZik6Ci0gICAgICAgIHJldHVybiBzZWxmLl9y dW5fc3ZuKFsnLS12ZXJzaW9uJywgJy0tcXVpZXQnXSkKKyAgICAgICAgcmV0dXJuIFZlcnNpb24u ZnJvbV9zdHJpbmcoc2VsZi5fcnVuX3N2bihbJy0tdmVyc2lvbicsICctLXF1aWV0J10pKQogCiAg ICAgZGVmIGhhc193b3JraW5nX2RpcmVjdG9yeV9jaGFuZ2VzKHNlbGYpOgogICAgICAgICAjIEZJ WE1FOiBXaGF0IGFib3V0IGZpbGVzIHdoaWNoIGFyZSBub3QgY29tbWl0dGVkIHlldD8KQEAgLTE4 Myw3ICsxODQsNyBAQCBjbGFzcyBTVk4oU0NNLCBTVk5SZXBvc2l0b3J5KToKICAgICAgICAgcmV0 dXJuIFtzZWxmLmV4ZWN1dGFibGVfbmFtZSwgJ3N0YXR1cyddCiAKICAgICBkZWYgX3N0YXR1c19y ZWdleHAoc2VsZiwgZXhwZWN0ZWRfdHlwZXMpOgotICAgICAgICBmaWVsZF9jb3VudCA9IDYgaWYg c2VsZi5zdm5fdmVyc2lvbigpID4gIjEuNiIgZWxzZSA1CisgICAgICAgIGZpZWxkX2NvdW50ID0g NiBpZiBzZWxmLnN2bl92ZXJzaW9uKCkgPiBWZXJzaW9uKDEsIDYpIGVsc2UgNQogICAgICAgICBy ZXR1cm4gIl4oP1A8c3RhdHVzPlslc10pLnslc30gKD9QPGZpbGVuYW1lPi4rKSQiICUgKGV4cGVj dGVkX3R5cGVzLCBmaWVsZF9jb3VudCkKIAogICAgIGRlZiBfYWRkX3BhcmVudF9kaXJlY3Rvcmll cyhzZWxmLCBwYXRoKToKQEAgLTE5NSw3ICsxOTYsNyBAQCBjbGFzcyBTVk4oU0NNLCBTVk5SZXBv c2l0b3J5KToKICAgICBkZWYgYWRkX2xpc3Qoc2VsZiwgcGF0aHMpOgogICAgICAgICBmb3IgcGF0 aCBpbiBwYXRoczoKICAgICAgICAgICAgIHNlbGYuX2FkZF9wYXJlbnRfZGlyZWN0b3JpZXMob3Mu cGF0aC5kaXJuYW1lKG9zLnBhdGguYWJzcGF0aChwYXRoKSkpCi0gICAgICAgIGlmIHNlbGYuc3Zu X3ZlcnNpb24oKSA+PSAiMS43IjoKKyAgICAgICAgaWYgc2VsZi5zdm5fdmVyc2lvbigpID49IFZl cnNpb24oMSwgNyk6CiAgICAgICAgICAgICAjIEZvciBzdWJ2ZXJzaW9uIGNsaWVudCAxLjcgYW5k IGxhdGVyLCBuZWVkIHRvIGFkZCAnLS1wYXJlbnRzJyBvcHRpb24gdG8gZW5zdXJlIGludGVybWVk aWF0ZSBkaXJlY3RvcmllcwogICAgICAgICAgICAgIyBhcmUgYWRkZWQ7IGluIGFkZGl0aW9uLCAx LjcgcmV0dXJucyBhbiBleGl0IGNvZGUgb2YgMSBmcm9tIHN2biBhZGQgaWYgb25lIG9yIG1vcmUg b2YgdGhlIHJlcXVlc3RlZAogICAgICAgICAgICAgIyBhZGRzIGFyZSBhbHJlYWR5IHVuZGVyIHZl cnNpb24gY29udHJvbCwgaW5jbHVkaW5nIGludGVybWVkaWF0ZSBkaXJlY3RvcmllcyBzdWJqZWN0 IHRvIGFkZGl0aW9uCg==