186402 2018-06-07 10:49:14 -0700 REGRESSION(r224134) Client certificate challenges don't always appear 2018-06-08 08:56:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen bweinstein commit-queue dbates ews-watchlist ggaren webkit-bug-importer oldest_to_newest 1430930 0 achristensen 2018-06-07 10:49:14 -0700 REGRESSION(r224134) Client certificate challenges don't always appear 1430932 1 342189 achristensen 2018-06-07 10:50:21 -0700 Created attachment 342189 Patch 1430935 2 ews-watchlist 2018-06-07 10:52:10 -0700 Attachment 342189 did not pass style-queue: ERROR: Source/WebKit/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1430947 3 342189 bweinstein 2018-06-07 11:18:28 -0700 Comment on attachment 342189 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342189&action=review > Source/WebKit/NetworkProcess/NetworkLoad.cpp:340 > + bool isTLSHandshake = m_challenge->protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested Is it worth pulling m_challenge->protectionSpace().authenticationScheme() into a local? 1430965 4 342194 achristensen 2018-06-07 11:40:01 -0700 Created attachment 342194 Patch 1430984 5 342194 commit-queue 2018-06-07 12:19:38 -0700 Comment on attachment 342194 Patch Clearing flags on attachment: 342194 Committed r232594: <https://trac.webkit.org/changeset/232594> 1430985 6 commit-queue 2018-06-07 12:19:39 -0700 All reviewed patches have been landed. Closing bug. 1430986 7 webkit-bug-importer 2018-06-07 12:20:21 -0700 <rdar://problem/40905729> 342189 2018-06-07 10:50:21 -0700 2018-06-07 11:39:59 -0700 Patch bug-186402-20180607105020.patch text/plain 1925 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzI1ODcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTA3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjI0MTM0KSBDbGllbnQgY2VydGlmaWNhdGUgY2hhbGxlbmdlcyBkb24ndCBhbHdheXMgYXBwZWFy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY0MDIK KwkJPHJkYXI6Ly9wcm9ibGVtLzM1OTY3MTUwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwOgor ICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6Y29tcGxldGVBdXRoZW50aWNhdGlvbkNoYWxs ZW5nZSk6CisJCUFkZCBhbiBleGNlcHRpb24gZm9yIGFsbCBUTFMtaGFuZHNoYWtlLXJlbGF0ZWQg Y2hhbGxlbmdlcywgbm90IGp1c3Qgc2VydmVyIHRydXN0LgorCiAyMDE4LTA2LTA0ICBLb2NzZW4g Q2h1bmcgIDxrb2NzZW5fY2h1bmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFwcGx5IHBhdGNoLiBy ZGFyOi8vcHJvYmxlbS80MDY4ODYzOApJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrTG9hZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrTG9hZC5jcHAJKHJldmlzaW9uIDIzMjU3OSkKKysrIFNvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMzcsOCAr MzM3LDkgQEAgdm9pZCBOZXR3b3JrTG9hZDo6ZGlkUmVjZWl2ZUNoYWxsZW5nZShjbwogCiB2b2lk IE5ldHdvcmtMb2FkOjpjb21wbGV0ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKENoYWxsZW5nZUNv bXBsZXRpb25IYW5kbGVyJiYgY29tcGxldGlvbkhhbmRsZXIpCiB7Ci0gICAgYm9vbCBpc1NlcnZl clRydXN0RXZhbHVhdGlvbiA9IG1fY2hhbGxlbmdlLT5wcm90ZWN0aW9uU3BhY2UoKS5hdXRoZW50 aWNhdGlvblNjaGVtZSgpID09IFByb3RlY3Rpb25TcGFjZUF1dGhlbnRpY2F0aW9uU2NoZW1lU2Vy dmVyVHJ1c3RFdmFsdWF0aW9uUmVxdWVzdGVkOwotICAgIGlmICghaXNBbGxvd2VkVG9Bc2tVc2Vy Rm9yQ3JlZGVudGlhbHMoKSAmJiAhaXNTZXJ2ZXJUcnVzdEV2YWx1YXRpb24pIHsKKyAgICBib29s IGlzVExTSGFuZHNoYWtlID0gbV9jaGFsbGVuZ2UtPnByb3RlY3Rpb25TcGFjZSgpLmF1dGhlbnRp Y2F0aW9uU2NoZW1lKCkgPT0gUHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWVTZXJ2 ZXJUcnVzdEV2YWx1YXRpb25SZXF1ZXN0ZWQKKyAgICAgICAgfHwgbV9jaGFsbGVuZ2UtPnByb3Rl Y3Rpb25TcGFjZSgpLmF1dGhlbnRpY2F0aW9uU2NoZW1lKCkgPT0gUHJvdGVjdGlvblNwYWNlQXV0 aGVudGljYXRpb25TY2hlbWVDbGllbnRDZXJ0aWZpY2F0ZVJlcXVlc3RlZDsKKyAgICBpZiAoIWlz QWxsb3dlZFRvQXNrVXNlckZvckNyZWRlbnRpYWxzKCkgJiYgIWlzVExTSGFuZHNoYWtlKSB7CiAg ICAgICAgIG1fY2xpZW50LmdldCgpLmRpZEJsb2NrQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoKTsK ICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQXV0aGVudGljYXRpb25DaGFsbGVuZ2VEaXNwb3Np dGlvbjo6VXNlQ3JlZGVudGlhbCwgeyB9KTsKICAgICAgICAgcmV0dXJuOwo= 342194 2018-06-07 11:40:01 -0700 2018-06-07 12:19:38 -0700 Patch bug-186402-20180607113957.patch text/plain 1919 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzI1ODcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTA3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjI0MTM0KSBDbGllbnQgY2VydGlmaWNhdGUgY2hhbGxlbmdlcyBkb24ndCBhbHdheXMgYXBwZWFy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODY0MDIK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1OTY3MTUwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IEJyaWFuIFdlaW5zdGVpbi4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2Fk LmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0xvYWQ6OmNvbXBsZXRlQXV0aGVudGljYXRp b25DaGFsbGVuZ2UpOgorICAgICAgICBBZGQgYW4gZXhjZXB0aW9uIGZvciBhbGwgVExTLWhhbmRz aGFrZS1yZWxhdGVkIGNoYWxsZW5nZXMsIG5vdCBqdXN0IHNlcnZlciB0cnVzdC4KKwogMjAxOC0w Ni0wNCAgS29jc2VuIENodW5nICA8a29jc2VuX2NodW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBB cHBseSBwYXRjaC4gcmRhcjovL3Byb2JsZW0vNDA2ODg2MzgKSW5kZXg6IFNvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCShyZXZpc2lvbiAyMzI1NzkpCisrKyBT b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzM3LDggKzMzNywxMCBAQCB2b2lkIE5ldHdvcmtMb2FkOjpkaWRSZWNlaXZlQ2hhbGxl bmdlKGNvCiAKIHZvaWQgTmV0d29ya0xvYWQ6OmNvbXBsZXRlQXV0aGVudGljYXRpb25DaGFsbGVu Z2UoQ2hhbGxlbmdlQ29tcGxldGlvbkhhbmRsZXImJiBjb21wbGV0aW9uSGFuZGxlcikKIHsKLSAg ICBib29sIGlzU2VydmVyVHJ1c3RFdmFsdWF0aW9uID0gbV9jaGFsbGVuZ2UtPnByb3RlY3Rpb25T cGFjZSgpLmF1dGhlbnRpY2F0aW9uU2NoZW1lKCkgPT0gUHJvdGVjdGlvblNwYWNlQXV0aGVudGlj YXRpb25TY2hlbWVTZXJ2ZXJUcnVzdEV2YWx1YXRpb25SZXF1ZXN0ZWQ7Ci0gICAgaWYgKCFpc0Fs bG93ZWRUb0Fza1VzZXJGb3JDcmVkZW50aWFscygpICYmICFpc1NlcnZlclRydXN0RXZhbHVhdGlv bikgeworICAgIGF1dG8gc2NoZW1lID0gbV9jaGFsbGVuZ2UtPnByb3RlY3Rpb25TcGFjZSgpLmF1 dGhlbnRpY2F0aW9uU2NoZW1lKCk7CisgICAgYm9vbCBpc1RMU0hhbmRzaGFrZSA9IHNjaGVtZSA9 PSBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGVtZVNlcnZlclRydXN0RXZhbHVhdGlv blJlcXVlc3RlZAorICAgICAgICB8fCBzY2hlbWUgPT0gUHJvdGVjdGlvblNwYWNlQXV0aGVudGlj YXRpb25TY2hlbWVDbGllbnRDZXJ0aWZpY2F0ZVJlcXVlc3RlZDsKKyAgICBpZiAoIWlzQWxsb3dl ZFRvQXNrVXNlckZvckNyZWRlbnRpYWxzKCkgJiYgIWlzVExTSGFuZHNoYWtlKSB7CiAgICAgICAg IG1fY2xpZW50LmdldCgpLmRpZEJsb2NrQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoKTsKICAgICAg ICAgY29tcGxldGlvbkhhbmRsZXIoQXV0aGVudGljYXRpb25DaGFsbGVuZ2VEaXNwb3NpdGlvbjo6 VXNlQ3JlZGVudGlhbCwgeyB9KTsKICAgICAgICAgcmV0dXJuOwo=