186400 2018-06-07 10:01:13 -0700 bmalloc: Fix 'noreturn' warnings when compiling with -std=gnu++17 2018-06-07 14:06:18 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue fpizlo ggaren jfbastien msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1430903 0 ddkilzer 2018-06-07 10:01:13 -0700 Fix 'noreturn' warnings when compiling bmalloc with -std=gnu++17: Source/bmalloc/bmalloc/Scavenger.cpp:363:1: error: function 'threadRunLoop' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn] { ^ Source/bmalloc/bmalloc/Scavenger.cpp:358:1: error: function 'threadEntryPoint' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn] { ^ 2 errors generated. 1430911 1 342184 ddkilzer 2018-06-07 10:20:03 -0700 Created attachment 342184 Patch v1 1430913 2 342184 ddkilzer 2018-06-07 10:27:24 -0700 Comment on attachment 342184 Patch v1 Oh dear. Older compilers don't realize this method doesn't return! 1430918 3 342185 ddkilzer 2018-06-07 10:36:16 -0700 Created attachment 342185 Patch v2 1430937 4 342185 saam 2018-06-07 10:54:57 -0700 Comment on attachment 342185 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=342185&action=review > Source/bmalloc/bmalloc/BCompiler.h:51 > +#if defined(_MSC_VER) > +#define BCOMPILER_MSVC 1 > +#endif Why do we care about this? We don't compile bmalloc on windows AFAIK. 1430942 5 ddkilzer 2018-06-07 11:14:57 -0700 (In reply to Saam Barati from comment #4) > Comment on attachment 342185 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342185&action=review > > > Source/bmalloc/bmalloc/BCompiler.h:51 > > +#if defined(_MSC_VER) > > +#define BCOMPILER_MSVC 1 > > +#endif > > Why do we care about this? We don't compile bmalloc on windows AFAIK. I was porting the WTF_NO_RETURN macro over will full fidelity. If we don't compile bmalloc for Windows, then yes, we can leave this out. 1430981 6 342199 ddkilzer 2018-06-07 12:17:19 -0700 Created attachment 342199 Patch v3 1431016 7 342199 commit-queue 2018-06-07 14:05:35 -0700 Comment on attachment 342199 Patch v3 Clearing flags on attachment: 342199 Committed r232599: <https://trac.webkit.org/changeset/232599> 1431017 8 commit-queue 2018-06-07 14:05:36 -0700 All reviewed patches have been landed. Closing bug. 1431018 9 webkit-bug-importer 2018-06-07 14:06:18 -0700 <rdar://problem/40909586> 342184 2018-06-07 10:20:03 -0700 2018-06-07 10:34:57 -0700 Patch v1 bug-186400-20180607102002.patch text/plain 3432 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMmU5YzgyOWJlMjliYmIx OWEyMmQzM2JlNTVkYzg2N2MwYjViYmY4Yy4uOGJiYTFkNjE2MDQwYzYyMWZmYjc1YWVkNjhiNTE2 NWY3NTg0Mjg3NSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE4LTA2LTA3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogRml4ICdu b3JldHVybicgd2FybmluZ3Mgd2hlbiBjb21waWxpbmcgd2l0aCAtc3RkPWdudSsrMTcKKyAgICAg ICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE4NjQwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyB0aGUgZm9sbG93aW5nIHdhcm5pbmdzIHdo ZW4gY29tcGlsaW5nIHdpdGggZ251KysxNzoKKworICAgICAgICAgICAgU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9TY2F2ZW5nZXIuY3BwOjM2MzoxOiBlcnJvcjogZnVuY3Rpb24gJ3RocmVhZFJ1bkxv b3AnIGNvdWxkIGJlIGRlY2xhcmVkIHdpdGggYXR0cmlidXRlICdub3JldHVybicgWy1XZXJyb3Is LVdtaXNzaW5nLW5vcmV0dXJuXQorICAgICAgICAgICAgeworICAgICAgICAgICAgXgorICAgICAg ICAgICAgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3BwOjM1ODoxOiBlcnJvcjog ZnVuY3Rpb24gJ3RocmVhZEVudHJ5UG9pbnQnIGNvdWxkIGJlIGRlY2xhcmVkIHdpdGggYXR0cmli dXRlICdub3JldHVybicgWy1XZXJyb3IsLVdtaXNzaW5nLW5vcmV0dXJuXQorICAgICAgICAgICAg eworICAgICAgICAgICAgXgorCisgICAgICAgICogYm1hbGxvYy9CQ29tcGlsZXIuaDoKKyAgICAg ICAgKEJDT01QSUxFUik6IEFkZCBzdXBwb3J0IGZvciB0aGUgQkNPTVBJTEVSKCkgbWFjcm8sIHRo ZW4gYWRkCisgICAgICAgIEJDT01QSUxFUihHQ0NfT1JfQ0xBTkcpIGFuZCBCQ09NUElMRVIoTVNW QykuICBUYWtlbiBmcm9tCisgICAgICAgIFNvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmguCisgICAg ICAgIChCTk9fUkVUVVJOKTogSW1wbGVtZW50ICdub3JlcnR1cm4nIHN1cHBvcnQgdXNpbmcgdGhl IG5ldworICAgICAgICBCQ09NUElMRVIoKSBtYWNyb3MuICBUYWtlbiBmcm9tIFNvdXJjZS9XVEYv d3RmL0NvbXBpbGVyLmguCisgICAgICAgICogYm1hbGxvYy9TY2F2ZW5nZXIuaDoKKyAgICAgICAg KGJtYWxsb2M6OlNjYXZlbmdlcjo6dGhyZWFkRW50cnlQb2ludCk6IEFkZCBCTk9fUkVUVVJOIGF0 dHJpYnV0ZS4KKyAgICAgICAgKGJtYWxsb2M6OlNjYXZlbmdlcjo6dGhyZWFkUnVuTG9vcCk6IERp dHRvLgorCiAyMDE4LTA1LTI5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAg ICAgICAgIEpTQyBzaG91bGQgcHV0IGJtYWxsb2MncyBzY2F2ZW5nZXIgaW50byBtaW5pIG1vZGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQkNvbXBpbGVyLmggYi9Tb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL0JDb21waWxlci5oCmluZGV4IDFhOTI3ZDg0NDBjZGNlODAwNmM4NzZl NTE3YjRiMGQwMmFkNmRkNTkuLmU0ZjY3ODZmMGM4MjA4NGYyODJiNmE4ZDk4NWExMTA3MDIxZTNm ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQkNvbXBpbGVyLmgKKysrIGIv U291cmNlL2JtYWxsb2MvYm1hbGxvYy9CQ29tcGlsZXIuaApAQCAtMjUsNiArMjUsOSBAQAogCiAj cHJhZ21hIG9uY2UKIAorLyogQkNPTVBJTEVSKCkgLSB0aGUgY29tcGlsZXIgYmVpbmcgdXNlZCB0 byBidWlsZCB0aGUgcHJvamVjdCAqLworI2RlZmluZSBCQ09NUElMRVIoQkZFQVRVUkUpIChkZWZp bmVkIEJDT01QSUxFUl8jI0JGRUFUVVJFICYmIEJDT01QSUxFUl8jI0JGRUFUVVJFKQorCiAvKiBC Q09NUElMRVJfSEFTX0NMQU5HX0ZFQVRVUkUoKSAtIHdoZXRoZXIgdGhlIGNvbXBpbGVyIHN1cHBv cnRzIGEgcGFydGljdWxhciBsYW5ndWFnZSBvciBsaWJyYXJ5IGZlYXR1cmUuICovCiAvKiBodHRw Oi8vY2xhbmcubGx2bS5vcmcvZG9jcy9MYW5ndWFnZUV4dGVuc2lvbnMuaHRtbCNoYXMtZmVhdHVy ZS1hbmQtaGFzLWV4dGVuc2lvbiAqLwogI2lmZGVmIF9faGFzX2ZlYXR1cmUKQEAgLTM1LDMgKzM4 LDI5IEBACiAKICNkZWZpbmUgQkFTQU5fRU5BQkxFRCBCQ09NUElMRVJfSEFTX0NMQU5HX0ZFQVRV UkUoYWRkcmVzc19zYW5pdGl6ZXIpCiAKKy8qIEJDT01QSUxFUihHQ0NfT1JfQ0xBTkcpIC0gR05V IENvbXBpbGVyIENvbGxlY3Rpb24gb3IgQ2xhbmcgKi8KKworI2lmIGRlZmluZWQoX19HTlVDX18p CisjZGVmaW5lIEJDT01QSUxFUl9HQ0NfT1JfQ0xBTkcgMQorI2VuZGlmCisKKy8qIEJDT01QSUxF UihNU1ZDKSAtIE1pY3Jvc29mdCBWaXN1YWwgQysrICovCisKKyNpZiBkZWZpbmVkKF9NU0NfVkVS KQorI2RlZmluZSBCQ09NUElMRVJfTVNWQyAxCisjZW5kaWYKKworLyogQk5PX1JFVFVSTiAqLwor CisjaWYgIWRlZmluZWQoQk5PX1JFVFVSTikgJiYgQkNPTVBJTEVSKEdDQ19PUl9DTEFORykKKyNk ZWZpbmUgQk5PX1JFVFVSTiBfX2F0dHJpYnV0ZSgoX19ub3JldHVybl9fKSkKKyNlbmRpZgorCisj aWYgIWRlZmluZWQoQk5PX1JFVFVSTikgJiYgQkNPTVBJTEVSKE1TVkMpCisjZGVmaW5lIEJOT19S RVRVUk4gX19kZWNsc3BlYyhub3JldHVybikKKyNlbmRpZgorCisjaWYgIWRlZmluZWQoQk5PX1JF VFVSTikKKyNkZWZpbmUgQk5PX1JFVFVSTgorI2VuZGlmCisKZGlmZiAtLWdpdCBhL1NvdXJjZS9i bWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmggYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1NjYXZl bmdlci5oCmluZGV4IDkxOWY2ZTlkYjlmMGE5ZGY3NWZjYTlmYTQ2MmU1YmRkNTI0NWEyNzMuLjg0 OWQ0ZDkyMThlZTZlMWYxZDE0NTIzMTAwYjAwMzExY2M3N2Q0MzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9ibWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmgKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9TY2F2ZW5nZXIuaApAQCAtODIsOCArODIsOCBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBzY2hl ZHVsZUlmVW5kZXJNZW1vcnlQcmVzc3VyZUhvbGRpbmdMb2NrKHNpemVfdCBieXRlcyk7CiAKLSAg ICBzdGF0aWMgdm9pZCB0aHJlYWRFbnRyeVBvaW50KFNjYXZlbmdlciopOwotICAgIHZvaWQgdGhy ZWFkUnVuTG9vcCgpOworICAgIEJOT19SRVRVUk4gc3RhdGljIHZvaWQgdGhyZWFkRW50cnlQb2lu dChTY2F2ZW5nZXIqKTsKKyAgICBCTk9fUkVUVVJOIHZvaWQgdGhyZWFkUnVuTG9vcCgpOwogICAg IAogICAgIHZvaWQgc2V0U2VsZlFPU0NsYXNzKCk7CiAgICAgdm9pZCBzZXRUaHJlYWROYW1lKGNv bnN0IGNoYXIqKTsK 342185 2018-06-07 10:36:16 -0700 2018-06-07 12:16:36 -0700 Patch v2 bug-186400-20180607103615.patch text/plain 4336 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMmU5YzgyOWJlMjliYmIx OWEyMmQzM2JlNTVkYzg2N2MwYjViYmY4Yy4uYTRjOWNmMjQ5Njg0ZTAyYmIwN2NkMDZiYTNiMmU0 OWI1YjcwNmE2YiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE4LTA2LTA3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogRml4ICdu b3JldHVybicgd2FybmluZ3Mgd2hlbiBjb21waWxpbmcgd2l0aCAtc3RkPWdudSsrMTcKKyAgICAg ICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE4NjQwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyB0aGUgZm9sbG93aW5nIHdhcm5pbmdzIHdo ZW4gY29tcGlsaW5nIHdpdGggZ251KysxNzoKKworICAgICAgICAgICAgU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9TY2F2ZW5nZXIuY3BwOjM2MzoxOiBlcnJvcjogZnVuY3Rpb24gJ3RocmVhZFJ1bkxv b3AnIGNvdWxkIGJlIGRlY2xhcmVkIHdpdGggYXR0cmlidXRlICdub3JldHVybicgWy1XZXJyb3Is LVdtaXNzaW5nLW5vcmV0dXJuXQorICAgICAgICAgICAgeworICAgICAgICAgICAgXgorICAgICAg ICAgICAgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3BwOjM1ODoxOiBlcnJvcjog ZnVuY3Rpb24gJ3RocmVhZEVudHJ5UG9pbnQnIGNvdWxkIGJlIGRlY2xhcmVkIHdpdGggYXR0cmli dXRlICdub3JldHVybicgWy1XZXJyb3IsLVdtaXNzaW5nLW5vcmV0dXJuXQorICAgICAgICAgICAg eworICAgICAgICAgICAgXgorCisgICAgICAgICogYm1hbGxvYy9CQ29tcGlsZXIuaDoKKyAgICAg ICAgKEJDT01QSUxFUik6IEFkZCBzdXBwb3J0IGZvciB0aGUgQkNPTVBJTEVSKCkgbWFjcm8sIHRo ZW4gYWRkCisgICAgICAgIEJDT01QSUxFUihHQ0NfT1JfQ0xBTkcpIGFuZCBCQ09NUElMRVIoTVNW QykuICBUYWtlbiBmcm9tCisgICAgICAgIFNvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmguCisgICAg ICAgIChCTk9fUkVUVVJOKTogSW1wbGVtZW50ICdub3JlcnR1cm4nIHN1cHBvcnQgdXNpbmcgdGhl IG5ldworICAgICAgICBCQ09NUElMRVIoKSBtYWNyb3MuICBUYWtlbiBmcm9tIFNvdXJjZS9XVEYv d3RmL0NvbXBpbGVyLmguCisgICAgICAgICogYm1hbGxvYy9TY2F2ZW5nZXIuY3BwOgorICAgICAg ICAoYm1hbGxvYzo6U2NhdmVuZ2VyOjp0aHJlYWRSdW5Mb29wKTogUmVtb3ZlIHRoZSB3b3JrYXJv dW5kIHRoYXQKKyAgICAgICAgdHJpY2tlZCBvbGRlciBjb21waWxlcnMgaW50byB0aGlua2luZyB0 aGUgd2hpbGUoKSBsb29wIHdhc24ndAorICAgICAgICBpbmZpbml0ZS4KKyAgICAgICAgKiBibWFs bG9jL1NjYXZlbmdlci5oOgorICAgICAgICAoYm1hbGxvYzo6U2NhdmVuZ2VyOjp0aHJlYWRFbnRy eVBvaW50KTogQWRkIEJOT19SRVRVUk4gYXR0cmlidXRlLgorICAgICAgICAoYm1hbGxvYzo6U2Nh dmVuZ2VyOjp0aHJlYWRSdW5Mb29wKTogRGl0dG8uCisKIDIwMTgtMDUtMjkgIFNhYW0gQmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIHNob3VsZCBwdXQgYm1hbGxvYydz IHNjYXZlbmdlciBpbnRvIG1pbmkgbW9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1h bGxvYy9CQ29tcGlsZXIuaCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQkNvbXBpbGVyLmgKaW5k ZXggMWE5MjdkODQ0MGNkY2U4MDA2Yzg3NmU1MTdiNGIwZDAyYWQ2ZGQ1OS4uZTRmNjc4NmYwYzgy MDg0ZjI4MmI2YThkOTg1YTExMDcwMjFlM2ZlNSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9CQ29tcGlsZXIuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JDb21waWxl ci5oCkBAIC0yNSw2ICsyNSw5IEBACiAKICNwcmFnbWEgb25jZQogCisvKiBCQ09NUElMRVIoKSAt IHRoZSBjb21waWxlciBiZWluZyB1c2VkIHRvIGJ1aWxkIHRoZSBwcm9qZWN0ICovCisjZGVmaW5l IEJDT01QSUxFUihCRkVBVFVSRSkgKGRlZmluZWQgQkNPTVBJTEVSXyMjQkZFQVRVUkUgJiYgQkNP TVBJTEVSXyMjQkZFQVRVUkUpCisKIC8qIEJDT01QSUxFUl9IQVNfQ0xBTkdfRkVBVFVSRSgpIC0g d2hldGhlciB0aGUgY29tcGlsZXIgc3VwcG9ydHMgYSBwYXJ0aWN1bGFyIGxhbmd1YWdlIG9yIGxp YnJhcnkgZmVhdHVyZS4gKi8KIC8qIGh0dHA6Ly9jbGFuZy5sbHZtLm9yZy9kb2NzL0xhbmd1YWdl RXh0ZW5zaW9ucy5odG1sI2hhcy1mZWF0dXJlLWFuZC1oYXMtZXh0ZW5zaW9uICovCiAjaWZkZWYg X19oYXNfZmVhdHVyZQpAQCAtMzUsMyArMzgsMjkgQEAKIAogI2RlZmluZSBCQVNBTl9FTkFCTEVE IEJDT01QSUxFUl9IQVNfQ0xBTkdfRkVBVFVSRShhZGRyZXNzX3Nhbml0aXplcikKIAorLyogQkNP TVBJTEVSKEdDQ19PUl9DTEFORykgLSBHTlUgQ29tcGlsZXIgQ29sbGVjdGlvbiBvciBDbGFuZyAq LworCisjaWYgZGVmaW5lZChfX0dOVUNfXykKKyNkZWZpbmUgQkNPTVBJTEVSX0dDQ19PUl9DTEFO RyAxCisjZW5kaWYKKworLyogQkNPTVBJTEVSKE1TVkMpIC0gTWljcm9zb2Z0IFZpc3VhbCBDKysg Ki8KKworI2lmIGRlZmluZWQoX01TQ19WRVIpCisjZGVmaW5lIEJDT01QSUxFUl9NU1ZDIDEKKyNl bmRpZgorCisvKiBCTk9fUkVUVVJOICovCisKKyNpZiAhZGVmaW5lZChCTk9fUkVUVVJOKSAmJiBC Q09NUElMRVIoR0NDX09SX0NMQU5HKQorI2RlZmluZSBCTk9fUkVUVVJOIF9fYXR0cmlidXRlKChf X25vcmV0dXJuX18pKQorI2VuZGlmCisKKyNpZiAhZGVmaW5lZChCTk9fUkVUVVJOKSAmJiBCQ09N UElMRVIoTVNWQykKKyNkZWZpbmUgQk5PX1JFVFVSTiBfX2RlY2xzcGVjKG5vcmV0dXJuKQorI2Vu ZGlmCisKKyNpZiAhZGVmaW5lZChCTk9fUkVUVVJOKQorI2RlZmluZSBCTk9fUkVUVVJOCisjZW5k aWYKKwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3BwIGIv U291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3BwCmluZGV4IDcyNGMzZjcyMTY2Yjc2 YmM4OTJlM2JjNTllMDIwN2VlOTQ0ZjBmNDEuLmRlOTljMTc2YmM5Y2M4OTQ1M2QzNTRlMjgwNGI1 Yjc5NGE4OWNmNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2Vy LmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1NjYXZlbmdlci5jcHAKQEAgLTM3NCw5 ICszNzQsNyBAQCB2b2lkIFNjYXZlbmdlcjo6dGhyZWFkUnVuTG9vcCgpCiAgICAgLy8gV2UgcmVx dWlyZSBhbnkgc3RhdGUgY2hhbmdlIHdoaWxlIHdlIGFyZSBzbGVlcGluZyB0byBzaWduYWwgdG8g b3VyCiAgICAgLy8gY29uZGl0aW9uIHZhcmlhYmxlIGFuZCB3YWtlIHVzIHVwLgogICAgIAotICAg IGF1dG8gdHJ1dGggPSBbXSB7IHJldHVybiB0cnVlOyB9OwotICAgIAotICAgIHdoaWxlICh0cnV0 aCgpKSB7CisgICAgd2hpbGUgKHRydWUpIHsKICAgICAgICAgaWYgKG1fc3RhdGUgPT0gU3RhdGU6 OlNsZWVwKSB7CiAgICAgICAgICAgICBzdGQ6OnVuaXF1ZV9sb2NrPE11dGV4PiBsb2NrKG1fbXV0 ZXgpOwogICAgICAgICAgICAgbV9jb25kaXRpb24ud2FpdChsb2NrLCBbJl0oKSB7IHJldHVybiBt X3N0YXRlICE9IFN0YXRlOjpTbGVlcDsgfSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9i bWFsbG9jL1NjYXZlbmdlci5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuaApp bmRleCA5MTlmNmU5ZGI5ZjBhOWRmNzVmY2E5ZmE0NjJlNWJkZDUyNDVhMjczLi44NDlkNGQ5MjE4 ZWU2ZTFmMWQxNDUyMzEwMGIwMDMxMWNjNzdkNDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxv Yy9ibWFsbG9jL1NjYXZlbmdlci5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvU2NhdmVu Z2VyLmgKQEAgLTgyLDggKzgyLDggQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgc2NoZWR1bGVJZlVu ZGVyTWVtb3J5UHJlc3N1cmVIb2xkaW5nTG9jayhzaXplX3QgYnl0ZXMpOwogCi0gICAgc3RhdGlj IHZvaWQgdGhyZWFkRW50cnlQb2ludChTY2F2ZW5nZXIqKTsKLSAgICB2b2lkIHRocmVhZFJ1bkxv b3AoKTsKKyAgICBCTk9fUkVUVVJOIHN0YXRpYyB2b2lkIHRocmVhZEVudHJ5UG9pbnQoU2NhdmVu Z2VyKik7CisgICAgQk5PX1JFVFVSTiB2b2lkIHRocmVhZFJ1bkxvb3AoKTsKICAgICAKICAgICB2 b2lkIHNldFNlbGZRT1NDbGFzcygpOwogICAgIHZvaWQgc2V0VGhyZWFkTmFtZShjb25zdCBjaGFy Kik7Cg== 342199 2018-06-07 12:17:19 -0700 2018-06-07 14:05:35 -0700 Patch v3 bug-186400-20180607121719.patch text/plain 4104 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMmU5YzgyOWJlMjliYmIx OWEyMmQzM2JlNTVkYzg2N2MwYjViYmY4Yy4uNTAwMDkzYzM2YzExYzZlZGQ3M2I1OTMzOTk5NDI5 ZDkxMjU3OTA0MiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE4LTA2LTA3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogRml4ICdu b3JldHVybicgd2FybmluZ3Mgd2hlbiBjb21waWxpbmcgd2l0aCAtc3RkPWdudSsrMTcKKyAgICAg ICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE4NjQwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyB0aGUgZm9sbG93aW5nIHdhcm5pbmdzIHdo ZW4gY29tcGlsaW5nIHdpdGggZ251KysxNzoKKworICAgICAgICAgICAgU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9TY2F2ZW5nZXIuY3BwOjM2MzoxOiBlcnJvcjogZnVuY3Rpb24gJ3RocmVhZFJ1bkxv b3AnIGNvdWxkIGJlIGRlY2xhcmVkIHdpdGggYXR0cmlidXRlICdub3JldHVybicgWy1XZXJyb3Is LVdtaXNzaW5nLW5vcmV0dXJuXQorICAgICAgICAgICAgeworICAgICAgICAgICAgXgorICAgICAg ICAgICAgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3BwOjM1ODoxOiBlcnJvcjog ZnVuY3Rpb24gJ3RocmVhZEVudHJ5UG9pbnQnIGNvdWxkIGJlIGRlY2xhcmVkIHdpdGggYXR0cmli dXRlICdub3JldHVybicgWy1XZXJyb3IsLVdtaXNzaW5nLW5vcmV0dXJuXQorICAgICAgICAgICAg eworICAgICAgICAgICAgXgorCisgICAgICAgICogYm1hbGxvYy9CQ29tcGlsZXIuaDoKKyAgICAg ICAgKEJDT01QSUxFUik6IEFkZCBzdXBwb3J0IGZvciB0aGUgQkNPTVBJTEVSKCkgbWFjcm8sIHRo ZW4gYWRkCisgICAgICAgIEJDT01QSUxFUihHQ0NfT1JfQ0xBTkcpLiAgVGFrZW4gZnJvbSBTb3Vy Y2UvV1RGL3d0Zi9Db21waWxlci5oLgorICAgICAgICAoQk5PX1JFVFVSTik6IEltcGxlbWVudCAn bm9yZXJ0dXJuJyBzdXBwb3J0IHVzaW5nIHRoZSBuZXcKKyAgICAgICAgQkNPTVBJTEVSKCkgbWFj cm9zLiAgVGFrZW4gZnJvbSBTb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oLgorICAgICAgICAqIGJt YWxsb2MvU2NhdmVuZ2VyLmNwcDoKKyAgICAgICAgKGJtYWxsb2M6OlNjYXZlbmdlcjo6dGhyZWFk UnVuTG9vcCk6IFJlbW92ZSB0aGUgd29ya2Fyb3VuZCB0aGF0CisgICAgICAgIHRyaWNrZWQgb2xk ZXIgY29tcGlsZXJzIGludG8gdGhpbmtpbmcgdGhlIHdoaWxlKCkgbG9vcCB3YXNuJ3QKKyAgICAg ICAgaW5maW5pdGUuCisgICAgICAgICogYm1hbGxvYy9TY2F2ZW5nZXIuaDoKKyAgICAgICAgKGJt YWxsb2M6OlNjYXZlbmdlcjo6dGhyZWFkRW50cnlQb2ludCk6IEFkZCBCTk9fUkVUVVJOIGF0dHJp YnV0ZS4KKyAgICAgICAgKGJtYWxsb2M6OlNjYXZlbmdlcjo6dGhyZWFkUnVuTG9vcCk6IERpdHRv LgorCiAyMDE4LTA1LTI5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAg ICAgIEpTQyBzaG91bGQgcHV0IGJtYWxsb2MncyBzY2F2ZW5nZXIgaW50byBtaW5pIG1vZGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQkNvbXBpbGVyLmggYi9Tb3VyY2UvYm1h bGxvYy9ibWFsbG9jL0JDb21waWxlci5oCmluZGV4IDFhOTI3ZDg0NDBjZGNlODAwNmM4NzZlNTE3 YjRiMGQwMmFkNmRkNTkuLjA1NTMyNmU1M2FiNmUxOWQ5ZDg4NzcxZjgwNWZmM2FmNDQ5YzQyZjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQkNvbXBpbGVyLmgKKysrIGIvU291 cmNlL2JtYWxsb2MvYm1hbGxvYy9CQ29tcGlsZXIuaApAQCAtMjUsNiArMjUsOSBAQAogCiAjcHJh Z21hIG9uY2UKIAorLyogQkNPTVBJTEVSKCkgLSB0aGUgY29tcGlsZXIgYmVpbmcgdXNlZCB0byBi dWlsZCB0aGUgcHJvamVjdCAqLworI2RlZmluZSBCQ09NUElMRVIoQkZFQVRVUkUpIChkZWZpbmVk IEJDT01QSUxFUl8jI0JGRUFUVVJFICYmIEJDT01QSUxFUl8jI0JGRUFUVVJFKQorCiAvKiBCQ09N UElMRVJfSEFTX0NMQU5HX0ZFQVRVUkUoKSAtIHdoZXRoZXIgdGhlIGNvbXBpbGVyIHN1cHBvcnRz IGEgcGFydGljdWxhciBsYW5ndWFnZSBvciBsaWJyYXJ5IGZlYXR1cmUuICovCiAvKiBodHRwOi8v Y2xhbmcubGx2bS5vcmcvZG9jcy9MYW5ndWFnZUV4dGVuc2lvbnMuaHRtbCNoYXMtZmVhdHVyZS1h bmQtaGFzLWV4dGVuc2lvbiAqLwogI2lmZGVmIF9faGFzX2ZlYXR1cmUKQEAgLTM1LDMgKzM4LDE5 IEBACiAKICNkZWZpbmUgQkFTQU5fRU5BQkxFRCBCQ09NUElMRVJfSEFTX0NMQU5HX0ZFQVRVUkUo YWRkcmVzc19zYW5pdGl6ZXIpCiAKKy8qIEJDT01QSUxFUihHQ0NfT1JfQ0xBTkcpIC0gR05VIENv bXBpbGVyIENvbGxlY3Rpb24gb3IgQ2xhbmcgKi8KKworI2lmIGRlZmluZWQoX19HTlVDX18pCisj ZGVmaW5lIEJDT01QSUxFUl9HQ0NfT1JfQ0xBTkcgMQorI2VuZGlmCisKKy8qIEJOT19SRVRVUk4g Ki8KKworI2lmICFkZWZpbmVkKEJOT19SRVRVUk4pICYmIEJDT01QSUxFUihHQ0NfT1JfQ0xBTkcp CisjZGVmaW5lIEJOT19SRVRVUk4gX19hdHRyaWJ1dGUoKF9fbm9yZXR1cm5fXykpCisjZW5kaWYK KworI2lmICFkZWZpbmVkKEJOT19SRVRVUk4pCisjZGVmaW5lIEJOT19SRVRVUk4KKyNlbmRpZgor CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1NjYXZlbmdlci5jcHAgYi9Tb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL1NjYXZlbmdlci5jcHAKaW5kZXggNzI0YzNmNzIxNjZiNzZiYzg5 MmUzYmM1OWUwMjA3ZWU5NDRmMGY0MS4uZGU5OWMxNzZiYzljYzg5NDUzZDM1NGUyODA0YjViNzk0 YTg5Y2Y2NyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3Bw CisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmNwcApAQCAtMzc0LDkgKzM3 NCw3IEBAIHZvaWQgU2NhdmVuZ2VyOjp0aHJlYWRSdW5Mb29wKCkKICAgICAvLyBXZSByZXF1aXJl IGFueSBzdGF0ZSBjaGFuZ2Ugd2hpbGUgd2UgYXJlIHNsZWVwaW5nIHRvIHNpZ25hbCB0byBvdXIK ICAgICAvLyBjb25kaXRpb24gdmFyaWFibGUgYW5kIHdha2UgdXMgdXAuCiAgICAgCi0gICAgYXV0 byB0cnV0aCA9IFtdIHsgcmV0dXJuIHRydWU7IH07Ci0gICAgCi0gICAgd2hpbGUgKHRydXRoKCkp IHsKKyAgICB3aGlsZSAodHJ1ZSkgewogICAgICAgICBpZiAobV9zdGF0ZSA9PSBTdGF0ZTo6U2xl ZXApIHsKICAgICAgICAgICAgIHN0ZDo6dW5pcXVlX2xvY2s8TXV0ZXg+IGxvY2sobV9tdXRleCk7 CiAgICAgICAgICAgICBtX2NvbmRpdGlvbi53YWl0KGxvY2ssIFsmXSgpIHsgcmV0dXJuIG1fc3Rh dGUgIT0gU3RhdGU6OlNsZWVwOyB9KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvU2NhdmVuZ2VyLmggYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1NjYXZlbmdlci5oCmluZGV4 IDkxOWY2ZTlkYjlmMGE5ZGY3NWZjYTlmYTQ2MmU1YmRkNTI0NWEyNzMuLjg0OWQ0ZDkyMThlZTZl MWYxZDE0NTIzMTAwYjAwMzExY2M3N2Q0MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvU2NhdmVuZ2VyLmgKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIu aApAQCAtODIsOCArODIsOCBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBzY2hlZHVsZUlmVW5kZXJN ZW1vcnlQcmVzc3VyZUhvbGRpbmdMb2NrKHNpemVfdCBieXRlcyk7CiAKLSAgICBzdGF0aWMgdm9p ZCB0aHJlYWRFbnRyeVBvaW50KFNjYXZlbmdlciopOwotICAgIHZvaWQgdGhyZWFkUnVuTG9vcCgp OworICAgIEJOT19SRVRVUk4gc3RhdGljIHZvaWQgdGhyZWFkRW50cnlQb2ludChTY2F2ZW5nZXIq KTsKKyAgICBCTk9fUkVUVVJOIHZvaWQgdGhyZWFkUnVuTG9vcCgpOwogICAgIAogICAgIHZvaWQg c2V0U2VsZlFPU0NsYXNzKCk7CiAgICAgdm9pZCBzZXRUaHJlYWROYW1lKGNvbnN0IGNoYXIqKTsK