186398 2018-06-07 09:22:23 -0700 [Cocoa] Turn on ARC for the single Objective-C++ source file in bmalloc 2018-06-08 10:25:20 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 darin darin andersca dbates fpizlo ggaren mitz saam webkit-bug-importer oldest_to_newest 1430865 0 darin 2018-06-07 09:22:23 -0700 [Cocoa] Turn on ARC for the single Objective-C++ source file in bmalloc 1430867 1 342175 darin 2018-06-07 09:23:51 -0700 Created attachment 342175 Patch 1430871 2 342175 darin 2018-06-07 09:25:38 -0700 Comment on attachment 342175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342175&action=review > Source/bmalloc/bmalloc/ProcessCheck.mm:37 > + // If we wanted to make it efficient to call mroe than once, we could memoize the result in a global boolean. Oops, I’ll fix my "mroe" typo. 1431286 3 darin 2018-06-08 10:24:06 -0700 Committed r232626: <https://trac.webkit.org/changeset/232626> 1431287 4 webkit-bug-importer 2018-06-08 10:25:20 -0700 <rdar://problem/40941316> 342175 2018-06-07 09:23:51 -0700 2018-06-07 10:56:35 -0700 Patch bug-186398-20180607092351.patch text/plain 2966 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMmU5YzgyOWJlMjliYmIx OWEyMmQzM2JlNTVkYzg2N2MwYjViYmY4Yy4uYzlhYzVmZWFjMjIwMTQxYjg0YThiYmY3NzIyMjgz ZWYyZTc1ZjEyZCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA2LTA3ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIFR1cm4gb24gQVJD IGZvciB0aGUgc2luZ2xlIE9iamVjdGl2ZS1DKysgc291cmNlIGZpbGUgaW4gYm1hbGxvYworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2Mzk4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0 aW9ucy9CYXNlLnhjY29uZmlnOiBUdXJuIG9uIEFSQy4KKyAgICAgICAgKiBibWFsbG9jL1Byb2Nl c3NDaGVjay5tbToKKyAgICAgICAgKGJtYWxsb2M6OmdpZ2FjYWdlRW5hYmxlZEZvclByb2Nlc3Mp OiBSZW1vdmVkIHRoZSBnbG9iYWxzIGZyb20gdGhpcyBmdW5jdGlvbiwKKyAgICAgICAgc2luY2Ug aXQncyBvbmx5IGNhbGxlZCBvbmNlLiBJZiBpdCB3YXMgY2FsbGVkIG1vcmUgdGhhbiBvbmNlLCB3 ZSBjb3VsZCBvcHRpbWl6ZQorICAgICAgICB0aGF0IHdpdGggYSBzaW5nbGUgYm9vbGVhbiBnbG9i YWwgcmF0aGVyIHRoYW4gdHdvIHN0cmluZ3MgYW5kIHR3byBib29sZWFucy4KKwogMjAxOC0wNS0y OSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBKU0Mgc2hvdWxk IHB1dCBibWFsbG9jJ3Mgc2NhdmVuZ2VyIGludG8gbWluaSBtb2RlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvYm1hbGxvYy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIvU291cmNlL2JtYWxsb2Mv Q29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwppbmRleCA5ZjU3Mjg5MzU4MGRhNmE0OTNkMWI0 NTIyZDgwNGYzZjk1YTg2MDEyLi5mNmEzYmI2MzI3OGY0MjE5NDdiZDE5ZGFhNzU1MzkzMTg3MGZm ZTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29u ZmlnCisrKyBiL1NvdXJjZS9ibWFsbG9jL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKQEAg LTMyLDYgKzMyLDcgQEAgQUxXQVlTX1NFQVJDSF9VU0VSX1BBVEhTID0gTk87CiAKIENMQU5HX0NY WF9MQU5HVUFHRV9TVEFOREFSRCA9IGdudSsrMTQ7CiBDTEFOR19DWFhfTElCUkFSWSA9IGxpYmMr KzsKK0NMQU5HX0VOQUJMRV9PQkpDX0FSQyA9IFlFUzsKIENMQU5HX0VOQUJMRV9PQkpDX1dFQUsg PSBZRVM7CiBDTEFOR19XQVJOX0JMT0NLX0NBUFRVUkVfQVVUT1JFTEVBU0lORyA9IFlFUzsKIENM QU5HX1dBUk5fQk9PTF9DT05WRVJTSU9OID0gWUVTOwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxs b2MvYm1hbGxvYy9Qcm9jZXNzQ2hlY2subW0gYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1Byb2Nl c3NDaGVjay5tbQppbmRleCA1Yzc1MTljODY1ZWRjNTdjYzViMzhiM2VkNWViNjBhMzIwMmE3M2U5 Li40NWE5YjI0OWNlM2YwNjE2MjdiYTAwMzVkYWE2OTBmNDg5Mjc3YzY5IDEwMDY0NAotLS0gYS9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL1Byb2Nlc3NDaGVjay5tbQorKysgYi9Tb3VyY2UvYm1hbGxv Yy9ibWFsbG9jL1Byb2Nlc3NDaGVjay5tbQpAQCAtMzMsMTYgKzMzLDE5IEBAIG5hbWVzcGFjZSBi bWFsbG9jIHsKIAogYm9vbCBnaWdhY2FnZUVuYWJsZWRGb3JQcm9jZXNzKCkKIHsKLSAgICBzdGF0 aWMgTlNTdHJpbmcgKmFwcE5hbWUgPSBbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1bmRsZUlkZW50 aWZpZXJdOworICAgIC8vIE5vdGUgdGhhdCB0aGlzIGZ1bmN0aW9uIGlzIG9ubHkgY2FsbGVkIG9u Y2UuCisgICAgLy8gSWYgd2Ugd2FudGVkIHRvIG1ha2UgaXQgZWZmaWNpZW50IHRvIGNhbGwgbXJv ZSB0aGFuIG9uY2UsIHdlIGNvdWxkIG1lbW9pemUgdGhlIHJlc3VsdCBpbiBhIGdsb2JhbCBib29s ZWFuLgorCisgICAgTlNTdHJpbmcgKmFwcE5hbWUgPSBbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1 bmRsZUlkZW50aWZpZXJdOwogICAgIGlmIChhcHBOYW1lKSB7Ci0gICAgICAgIHN0YXRpYyBib29s IGlzV2ViUHJvY2VzcyA9IFthcHBOYW1lIGlzRXF1YWxUb1N0cmluZzpAImNvbS5hcHBsZS5XZWJL aXQuV2ViQ29udGVudC5EZXZlbG9wbWVudCJdCisgICAgICAgIGJvb2wgaXNXZWJQcm9jZXNzID0g W2FwcE5hbWUgaXNFcXVhbFRvU3RyaW5nOkAiY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRl dmVsb3BtZW50Il0KICAgICAgICAgICAgIHx8IFthcHBOYW1lIGlzRXF1YWxUb1N0cmluZzpAImNv bS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCJdCiAgICAgICAgICAgICB8fCBbYXBwTmFtZSBpc0Vx dWFsVG9TdHJpbmc6QCJjb20uYXBwbGUuV2ViUHJvY2VzcyJdOwogICAgICAgICByZXR1cm4gaXNX ZWJQcm9jZXNzOwogICAgIH0KIAotICAgIHN0YXRpYyBOU1N0cmluZyAqcHJvY2Vzc05hbWUgPSBb W05TUHJvY2Vzc0luZm8gcHJvY2Vzc0luZm9dIHByb2Nlc3NOYW1lXTsKLSAgICBzdGF0aWMgYm9v bCBpc09wdEluQmluYXJ5ID0gW3Byb2Nlc3NOYW1lIGlzRXF1YWxUb1N0cmluZzpAImpzYyJdCisg ICAgTlNTdHJpbmcgKnByb2Nlc3NOYW1lID0gW1tOU1Byb2Nlc3NJbmZvIHByb2Nlc3NJbmZvXSBw cm9jZXNzTmFtZV07CisgICAgYm9vbCBpc09wdEluQmluYXJ5ID0gW3Byb2Nlc3NOYW1lIGlzRXF1 YWxUb1N0cmluZzpAImpzYyJdCiAgICAgICAgIHx8IFtwcm9jZXNzTmFtZSBpc0VxdWFsVG9TdHJp bmc6QCJ3YXNtIl0KICAgICAgICAgfHwgW3Byb2Nlc3NOYW1lIGhhc1ByZWZpeDpAInRlc3QiXTsK IAo=