186397 2018-06-07 09:20:16 -0700 Only display refresh monitors having requested display refresh callback should get notified on screen updates. 2022-10-09 06:06:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan ahmad.saleem792 bfulgham commit-queue webkit-bug-importer oldest_to_newest 1430864 0 pvollan 2018-06-07 09:20:16 -0700 Since all display refresh monitors in the WebContent process share a single UI process display link, we should make sure that only the monitors having requested callback, are getting notified on screen updates. This does not appear to be a problem currently, but we should safeguard the code for future code changes. 1430884 1 342180 pvollan 2018-06-07 09:34:57 -0700 Created attachment 342180 Patch 1430886 2 webkit-bug-importer 2018-06-07 09:35:34 -0700 <rdar://problem/40897835> 1431332 3 342300 pvollan 2018-06-08 11:34:14 -0700 Created attachment 342300 Patch 1431339 4 342300 bfulgham 2018-06-08 11:47:12 -0700 Comment on attachment 342300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342300&action=review I think this seems like a very reasonable approach. We just need to be sure there aren't cases where we were relying on an active monitor (that has not sent a message recently) getting updates. We might find that we need to be more explicit about specifically requesting refresh callback if we encounter animation or other rendering issues. > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=186397 Radar? > Source/WebCore/ChangeLog:9 > + we should make sure that only the monitors having requested callback, are getting notified on screen No comma after "callback" please. > Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:131 > + if (monitor->hasRequestedRefreshCallback()) How frequently do we have active monitors that have not requested refresh callbacks? I'm curious how much of a benefit this might be... 1431344 5 pvollan 2018-06-08 11:54:25 -0700 (In reply to Brent Fulgham from comment #4) > Comment on attachment 342300 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342300&action=review > > I think this seems like a very reasonable approach. We just need to be sure > there aren't cases where we were relying on an active monitor (that has not > sent a message recently) getting updates. > > We might find that we need to be more explicit about specifically requesting > refresh callback if we encounter animation or other rendering issues. > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=186397 > > Radar? > > > Source/WebCore/ChangeLog:9 > > + we should make sure that only the monitors having requested callback, are getting notified on screen > > No comma after "callback" please. > > > Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:131 > > + if (monitor->hasRequestedRefreshCallback()) > > How frequently do we have active monitors that have not requested refresh > callbacks? I'm curious how much of a benefit this might be... I think this is rare. While inspecting the code, I only found that this is only possible if the window is changing screen while a display refresh monitor is active. Thanks for reviewing! 1431421 6 342327 pvollan 2018-06-08 14:22:37 -0700 Created attachment 342327 Patch 1431491 7 342327 commit-queue 2018-06-08 16:50:19 -0700 Comment on attachment 342327 Patch Clearing flags on attachment: 342327 Committed r232652: <https://trac.webkit.org/changeset/232652> 1904341 8 ahmad.saleem792 2022-10-09 06:06:41 -0700 Checked via GitHub using BugID and it landed in following: https://github.com/WebKit/WebKit/commit/86295446fc35891e6e5c57909e64023fbc77380f and didn't backed out. Marking this as "RESOLVED FIXED". Thanks! 342180 2018-06-07 09:34:57 -0700 2018-06-08 11:34:13 -0700 Patch bug-186397-20180607093457.patch text/plain 4194 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjU4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA2LTA3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBPbmx5IGRpc3BsYXkgcmVm cmVzaCBtb25pdG9ycyBoYXZpbmcgcmVxdWVzdGVkIGRpc3BsYXkgcmVmcmVzaCBjYWxsYmFjayBz aG91bGQgZ2V0IG5vdGlmaWVkIG9uIHNjcmVlbiB1cGRhdGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2Mzk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgYWxsIGRpc3BsYXkgcmVmcmVzaCBt b25pdG9ycyBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzIHNoYXJlIGEgc2luZ2xlIFVJIHByb2Nl c3MgZGlzcGxheSBsaW5rLAorICAgICAgICB3ZSBzaG91bGQgbWFrZSBzdXJlIHRoYXQgb25seSB0 aGUgbW9uaXRvcnMgaGF2aW5nIHJlcXVlc3RlZCBjYWxsYmFjaywgYXJlIGdldHRpbmcgbm90aWZp ZWQgb24gc2NyZWVuCisgICAgICAgIHVwZGF0ZXMuIEkgaGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJl cHJvZHVjZSBhIGNhc2Ugd2hlcmUgYSBtb25pdG9yIGlzIGJlaW5nIG5vdGlmaWVkIHdpdGhvdXQg aGF2aW5nCisgICAgICAgIHJlcXVlc3RlZCB1cGRhdGVzLCBidXQgd2Ugc2hvdWxkIHNhZmVndWFy ZCB0aGUgY29kZSBmb3IgZnV0dXJlIGNvZGUgY2hhbmdlcy4KKworICAgICAgICBObyBuZXcgdGVz dHMsIHNpbmNlIHRoaXMgaXMgYSBzYWZlZ3VhcmRpbmcgbWVhc3VyZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oOgorICAgICAgICAoV2ViQ29y ZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yOjpoYXNSZXF1ZXN0ZWRSZWZyZXNoQ2FsbGJhY2sgY29u c3QpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1h bmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdl cjo6ZGlzcGxheVdhc1VwZGF0ZWQpOgorCiAyMDE4LTA2LTA3ICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gTWVyZ2UgaGVpZ2h0IGFuZCB2ZXJ0aWNhbCBt YXJnaW4gY29tcHV0YXRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCShyZXZpc2lvbiAyMzI1ODEp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0 b3IuaAkod29ya2luZyBjb3B5KQpAQCAtODEsNiArODEsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgYm9v bCBpc1ByZXZpb3VzRnJhbWVEb25lKCkgY29uc3QgeyByZXR1cm4gbV9wcmV2aW91c0ZyYW1lRG9u ZTsgfQogICAgIHZvaWQgc2V0SXNQcmV2aW91c0ZyYW1lRG9uZShib29sIGRvbmUpIHsgbV9wcmV2 aW91c0ZyYW1lRG9uZSA9IGRvbmU7IH0KIAorICAgIHZpcnR1YWwgYm9vbCBoYXNSZXF1ZXN0ZWRS ZWZyZXNoQ2FsbGJhY2soKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorCiBwcml2YXRlOgogICAg IHZvaWQgZGlzcGxheURpZFJlZnJlc2goKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9y TWFuYWdlci5jcHAJKHJldmlzaW9uIDIzMjU4MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMjgsNyArMTI4LDcgQEAgdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjp3 aW5kbwogdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpkaXNwbGF5V2FzVXBkYXRl ZCgpCiB7CiAgICAgZm9yIChhdXRvIG1vbml0b3IgOiBtX21vbml0b3JzKSB7Ci0gICAgICAgIGlm IChtb25pdG9yLT5pc0FjdGl2ZSgpKQorICAgICAgICBpZiAobW9uaXRvci0+aGFzUmVxdWVzdGVk UmVmcmVzaENhbGxiYWNrKCkpCiAgICAgICAgICAgICBtb25pdG9yLT5kaXNwbGF5TGlua0ZpcmVk KCk7CiAgICAgfQogfQpJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjU4MSkKKysrIFNvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDYt MDcgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIE9ubHkg ZGlzcGxheSByZWZyZXNoIG1vbml0b3JzIGhhdmluZyByZXF1ZXN0ZWQgZGlzcGxheSByZWZyZXNo IGNhbGxiYWNrIHNob3VsZCBnZXQgbm90aWZpZWQgb24gc2NyZWVuIHVwZGF0ZXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYzOTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBhbGwgZGlzcGxh eSByZWZyZXNoIG1vbml0b3JzIGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3Mgc2hhcmUgYSBzaW5n bGUgVUkgcHJvY2VzcyBkaXNwbGF5IGxpbmssCisgICAgICAgIHdlIHNob3VsZCBtYWtlIHN1cmUg dGhhdCBvbmx5IHRoZSBtb25pdG9ycyBoYXZpbmcgcmVxdWVzdGVkIGNhbGxiYWNrLCBhcmUgZ2V0 dGluZyBub3RpZmllZCBvbiBzY3JlZW4KKyAgICAgICAgdXBkYXRlcy4gSSBoYXZlIG5vdCBiZWVu IGFibGUgdG8gcmVwcm9kdWNlIGEgY2FzZSB3aGVyZSBhIG1vbml0b3IgaXMgYmVpbmcgbm90aWZp ZWQgd2l0aG91dCBoYXZpbmcKKyAgICAgICAgcmVxdWVzdGVkIHVwZGF0ZXMsIGJ1dCB3ZSBzaG91 bGQgc2FmZWd1YXJkIHRoZSBjb2RlIGZvciBmdXR1cmUgY29kZSBjaGFuZ2VzLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9EcmF3aW5nQXJlYU1hYy5jcHA6CisKIDIwMTgtMDYt MDcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O IChyMjMyNTIwKTogQ3Jhc2ggdW5kZXIgSVBDOjpBcmd1bWVudENvZGVyPFdlYkNvcmU6OkNyZWRl bnRpYWw+OjplbmNvZGVQbGF0Zm9ybURhdGEKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9EcmF3aW5nQXJlYU1hYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhTWFjLmNwcAkocmV2aXNpb24g MjMyNTgxKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdB cmVhTWFjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsOCBAQCBwdWJsaWM6CiBwcml2 YXRlOgogICAgIGV4cGxpY2l0IERpc3BsYXlSZWZyZXNoTW9uaXRvck1hYyhQbGF0Zm9ybURpc3Bs YXlJRCwgV2ViUGFnZSYpOwogICAgIAorICAgIGJvb2wgaGFzUmVxdWVzdGVkUmVmcmVzaENhbGxi YWNrKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gbV9oYXNTZW50TWVzc2FnZTsgfQorCiAgICAg UmVmPFdlYlBhZ2U+IG1fd2ViUGFnZTsKICAgICBib29sIG1faGFzU2VudE1lc3NhZ2UgeyBmYWxz ZSB9OwogICAgIHVuc2lnbmVkIG1fb2JzZXJ2ZXJJRDsK 342300 2018-06-08 11:34:14 -0700 2018-06-08 11:47:12 -0700 Patch bug-186397-20180608113413.patch text/plain 4167 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjYzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA2LTA4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBPbmx5IGRpc3BsYXkgcmVm cmVzaCBtb25pdG9ycyBoYXZpbmcgcmVxdWVzdGVkIGRpc3BsYXkgcmVmcmVzaCBjYWxsYmFjayBz aG91bGQgZ2V0IG5vdGlmaWVkIG9uIHNjcmVlbiB1cGRhdGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2Mzk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgYWxsIGRpc3BsYXkgcmVmcmVzaCBt b25pdG9ycyBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzIHNoYXJlIGEgc2luZ2xlIFVJIHByb2Nl c3MgZGlzcGxheSBsaW5rLAorICAgICAgICB3ZSBzaG91bGQgbWFrZSBzdXJlIHRoYXQgb25seSB0 aGUgbW9uaXRvcnMgaGF2aW5nIHJlcXVlc3RlZCBjYWxsYmFjaywgYXJlIGdldHRpbmcgbm90aWZp ZWQgb24gc2NyZWVuCisgICAgICAgIHVwZGF0ZXMuIEkgaGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJl cHJvZHVjZSBhIGNhc2Ugd2hlcmUgYSBtb25pdG9yIGlzIGJlaW5nIG5vdGlmaWVkIHdpdGhvdXQg aGF2aW5nCisgICAgICAgIHJlcXVlc3RlZCB1cGRhdGVzLCBidXQgd2Ugc2hvdWxkIHNhZmVndWFy ZCB0aGUgY29kZSBmb3IgZnV0dXJlIGNvZGUgY2hhbmdlcy4KKworICAgICAgICBObyBuZXcgdGVz dHMsIHNpbmNlIHRoaXMgaXMgYSBzYWZlZ3VhcmRpbmcgbWVhc3VyZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oOgorICAgICAgICAoV2ViQ29y ZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yOjpoYXNSZXF1ZXN0ZWRSZWZyZXNoQ2FsbGJhY2sgY29u c3QpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1h bmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdl cjo6ZGlzcGxheVdhc1VwZGF0ZWQpOgorCiAyMDE4LTA2LTA4ICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMzA5MzApOiBMaW5rIGRy YWcgaW1hZ2UgaXMgdmVyeSBibHVycnkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCShyZXZpc2lvbiAy MzI2MzIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVz aE1vbml0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtODEsNiArODEsOCBAQCBwcm90ZWN0ZWQ6CiAg ICAgYm9vbCBpc1ByZXZpb3VzRnJhbWVEb25lKCkgY29uc3QgeyByZXR1cm4gbV9wcmV2aW91c0Zy YW1lRG9uZTsgfQogICAgIHZvaWQgc2V0SXNQcmV2aW91c0ZyYW1lRG9uZShib29sIGRvbmUpIHsg bV9wcmV2aW91c0ZyYW1lRG9uZSA9IGRvbmU7IH0KIAorICAgIHZpcnR1YWwgYm9vbCBoYXNSZXF1 ZXN0ZWRSZWZyZXNoQ2FsbGJhY2soKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorCiBwcml2YXRl OgogICAgIHZvaWQgZGlzcGxheURpZFJlZnJlc2goKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hN b25pdG9yTWFuYWdlci5jcHAJKHJldmlzaW9uIDIzMjYzMikKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMjgsNyArMTI4LDcgQEAgdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5h Z2VyOjp3aW5kbwogdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpkaXNwbGF5V2Fz VXBkYXRlZCgpCiB7CiAgICAgZm9yIChhdXRvIG1vbml0b3IgOiBtX21vbml0b3JzKSB7Ci0gICAg ICAgIGlmIChtb25pdG9yLT5pc0FjdGl2ZSgpKQorICAgICAgICBpZiAobW9uaXRvci0+aGFzUmVx dWVzdGVkUmVmcmVzaENhbGxiYWNrKCkpCiAgICAgICAgICAgICBtb25pdG9yLT5kaXNwbGF5TGlu a0ZpcmVkKCk7CiAgICAgfQogfQpJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjYzMikKKysrIFNv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIw MTgtMDYtMDggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAg IE9ubHkgZGlzcGxheSByZWZyZXNoIG1vbml0b3JzIGhhdmluZyByZXF1ZXN0ZWQgZGlzcGxheSBy ZWZyZXNoIGNhbGxiYWNrIHNob3VsZCBnZXQgbm90aWZpZWQgb24gc2NyZWVuIHVwZGF0ZXMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYzOTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBhbGwg ZGlzcGxheSByZWZyZXNoIG1vbml0b3JzIGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3Mgc2hhcmUg YSBzaW5nbGUgVUkgcHJvY2VzcyBkaXNwbGF5IGxpbmssCisgICAgICAgIHdlIHNob3VsZCBtYWtl IHN1cmUgdGhhdCBvbmx5IHRoZSBtb25pdG9ycyBoYXZpbmcgcmVxdWVzdGVkIGNhbGxiYWNrLCBh cmUgZ2V0dGluZyBub3RpZmllZCBvbiBzY3JlZW4KKyAgICAgICAgdXBkYXRlcy4gSSBoYXZlIG5v dCBiZWVuIGFibGUgdG8gcmVwcm9kdWNlIGEgY2FzZSB3aGVyZSBhIG1vbml0b3IgaXMgYmVpbmcg bm90aWZpZWQgd2l0aG91dCBoYXZpbmcKKyAgICAgICAgcmVxdWVzdGVkIHVwZGF0ZXMsIGJ1dCB3 ZSBzaG91bGQgc2FmZWd1YXJkIHRoZSBjb2RlIGZvciBmdXR1cmUgY29kZSBjaGFuZ2VzLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9EcmF3aW5nQXJlYU1hYy5jcHA6CisKIDIw MTgtMDYtMDggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFNlbmQgZGlzcGxheSBsaW5rIElQQyBtZXNzYWdlIGZyb20gZGlzcGxheSBsaW5rIHRocmVhZC4K SW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9EcmF3aW5nQXJlYU1h Yy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L0RyYXdpbmdBcmVhTWFjLmNwcAkocmV2aXNpb24gMjMyNjMyKQorKysgU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhTWFjLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTUsNiArNTUsOCBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIGV4cGxpY2l0IERpc3BsYXlS ZWZyZXNoTW9uaXRvck1hYyhQbGF0Zm9ybURpc3BsYXlJRCwgV2ViUGFnZSYpOwogICAgIAorICAg IGJvb2wgaGFzUmVxdWVzdGVkUmVmcmVzaENhbGxiYWNrKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1 cm4gbV9oYXNTZW50TWVzc2FnZTsgfQorCiAgICAgUmVmPFdlYlBhZ2U+IG1fd2ViUGFnZTsKICAg ICBib29sIG1faGFzU2VudE1lc3NhZ2UgeyBmYWxzZSB9OwogICAgIHVuc2lnbmVkIG1fb2JzZXJ2 ZXJJRDsK 342327 2018-06-08 14:22:37 -0700 2018-06-08 16:50:19 -0700 Patch bug-186397-20180608142236.patch text/plain 4296 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjYzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA2LTA4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBPbmx5IGRpc3BsYXkgcmVm cmVzaCBtb25pdG9ycyBoYXZpbmcgcmVxdWVzdGVkIGRpc3BsYXkgcmVmcmVzaCBjYWxsYmFjayBz aG91bGQgZ2V0IG5vdGlmaWVkIG9uIHNjcmVlbiB1cGRhdGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2Mzk3CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80MDg5NzgzNT4KKworICAgICAgICBSZXZpZXdlZCBieSBCcmVudCBGdWxnaGFtLgorCisg ICAgICAgIFNpbmNlIGFsbCBkaXNwbGF5IHJlZnJlc2ggbW9uaXRvcnMgaW4gdGhlIFdlYkNvbnRl bnQgcHJvY2VzcyBzaGFyZSBhIHNpbmdsZSBVSSBwcm9jZXNzIGRpc3BsYXkgbGluaywKKyAgICAg ICAgd2Ugc2hvdWxkIG1ha2Ugc3VyZSB0aGF0IG9ubHkgdGhlIG1vbml0b3JzIGhhdmluZyByZXF1 ZXN0ZWQgY2FsbGJhY2sgYXJlIGdldHRpbmcgbm90aWZpZWQgb24gc2NyZWVuCisgICAgICAgIHVw ZGF0ZXMuIEkgaGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJvZHVjZSBhIGNhc2Ugd2hlcmUgYSBt b25pdG9yIGlzIGJlaW5nIG5vdGlmaWVkIHdpdGhvdXQgaGF2aW5nCisgICAgICAgIHJlcXVlc3Rl ZCB1cGRhdGVzLCBidXQgd2Ugc2hvdWxkIHNhZmVndWFyZCB0aGUgY29kZSBmb3IgZnV0dXJlIGNv ZGUgY2hhbmdlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIHRoaXMgaXMgYSBzYWZl Z3VhcmRpbmcgbWVhc3VyZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlS ZWZyZXNoTW9uaXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9y OjpoYXNSZXF1ZXN0ZWRSZWZyZXNoQ2FsbGJhY2sgY29uc3QpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6ZGlzcGxheVdhc1VwZGF0ZWQpOgor CiAyMDE4LTA2LTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IFJFR1JFU1NJT04obWFjT1MgTW9qYXZlKTogbW92ZS1ieS13b3JkLXZpc3VhbGx5LWlubGluZS1i bG9jay1wb3NpdGlvbmVkLWVsZW1lbnQuaHRtbCBmYWlscwpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yLmgJ KHJldmlzaW9uIDIzMjYzOCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rp c3BsYXlSZWZyZXNoTW9uaXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC04MSw2ICs4MSw4IEBAIHBy b3RlY3RlZDoKICAgICBib29sIGlzUHJldmlvdXNGcmFtZURvbmUoKSBjb25zdCB7IHJldHVybiBt X3ByZXZpb3VzRnJhbWVEb25lOyB9CiAgICAgdm9pZCBzZXRJc1ByZXZpb3VzRnJhbWVEb25lKGJv b2wgZG9uZSkgeyBtX3ByZXZpb3VzRnJhbWVEb25lID0gZG9uZTsgfQogCisgICAgdmlydHVhbCBi b29sIGhhc1JlcXVlc3RlZFJlZnJlc2hDYWxsYmFjaygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CisKIHByaXZhdGU6CiAgICAgdm9pZCBkaXNwbGF5RGlkUmVmcmVzaCgpOwogCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2Vy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNw bGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLmNwcAkocmV2aXNpb24gMjMyNjM4KQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEyOCw3ICsxMjgsNyBAQCB2b2lkIERpc3BsYXlSZWZyZXNo TW9uaXRvck1hbmFnZXI6OndpbmRvCiB2b2lkIERpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXI6 OmRpc3BsYXlXYXNVcGRhdGVkKCkKIHsKICAgICBmb3IgKGF1dG8gbW9uaXRvciA6IG1fbW9uaXRv cnMpIHsKLSAgICAgICAgaWYgKG1vbml0b3ItPmlzQWN0aXZlKCkpCisgICAgICAgIGlmIChtb25p dG9yLT5oYXNSZXF1ZXN0ZWRSZWZyZXNoQ2FsbGJhY2soKSkKICAgICAgICAgICAgIG1vbml0b3It PmRpc3BsYXlMaW5rRmlyZWQoKTsKICAgICB9CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjMy NjM4KQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxOCBAQAorMjAxOC0wNi0wOCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+ CisKKyAgICAgICAgT25seSBkaXNwbGF5IHJlZnJlc2ggbW9uaXRvcnMgaGF2aW5nIHJlcXVlc3Rl ZCBkaXNwbGF5IHJlZnJlc2ggY2FsbGJhY2sgc2hvdWxkIGdldCBub3RpZmllZCBvbiBzY3JlZW4g dXBkYXRlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NjM5NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDA4OTc4MzU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKworICAgICAgICBTaW5jZSBhbGwgZGlzcGxheSByZWZy ZXNoIG1vbml0b3JzIGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3Mgc2hhcmUgYSBzaW5nbGUgVUkg cHJvY2VzcyBkaXNwbGF5IGxpbmssCisgICAgICAgIHdlIHNob3VsZCBtYWtlIHN1cmUgdGhhdCBv bmx5IHRoZSBtb25pdG9ycyBoYXZpbmcgcmVxdWVzdGVkIGNhbGxiYWNrIGFyZSBnZXR0aW5nIG5v dGlmaWVkIG9uIHNjcmVlbgorICAgICAgICB1cGRhdGVzLiBJIGhhdmUgbm90IGJlZW4gYWJsZSB0 byByZXByb2R1Y2UgYSBjYXNlIHdoZXJlIGEgbW9uaXRvciBpcyBiZWluZyBub3RpZmllZCB3aXRo b3V0IGhhdmluZworICAgICAgICByZXF1ZXN0ZWQgdXBkYXRlcywgYnV0IHdlIHNob3VsZCBzYWZl Z3VhcmQgdGhlIGNvZGUgZm9yIGZ1dHVyZSBjb2RlIGNoYW5nZXMuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhTWFjLmNwcDoKKwogMjAxOC0wNi0wOCAgQnJp YW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFdlYiBBdXRvbWF0 aW9uOiBpbmNsdWRlIGJyb3dzZXIgbmFtZSBhbmQgdmVyc2lvbiBpbiBsaXN0aW5nIGZvciBhdXRv bWF0aW9uIHRhcmdldHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9EcmF3aW5nQXJlYU1hYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhTWFjLmNwcAkocmV2aXNpb24gMjMyNjM4KQorKysg U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0RyYXdpbmdBcmVhTWFjLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsOCBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIGV4 cGxpY2l0IERpc3BsYXlSZWZyZXNoTW9uaXRvck1hYyhQbGF0Zm9ybURpc3BsYXlJRCwgV2ViUGFn ZSYpOwogICAgIAorICAgIGJvb2wgaGFzUmVxdWVzdGVkUmVmcmVzaENhbGxiYWNrKCkgY29uc3Qg b3ZlcnJpZGUgeyByZXR1cm4gbV9oYXNTZW50TWVzc2FnZTsgfQorCiAgICAgUmVmPFdlYlBhZ2U+ IG1fd2ViUGFnZTsKICAgICBib29sIG1faGFzU2VudE1lc3NhZ2UgeyBmYWxzZSB9OwogICAgIHVu c2lnbmVkIG1fb2JzZXJ2ZXJJRDsK