186396 2018-06-07 09:09:08 -0700 [Cocoa] Minor ARC tidying of libwebrtc 2018-06-08 15:31:19 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 darin darin andersca dbates eric.carlson ews-watchlist mitz webkit-bug-importer youennf oldest_to_newest 1430858 0 darin 2018-06-07 09:09:08 -0700 [Cocoa] Minor ARC tidying of libwebrtc 1430859 1 342173 darin 2018-06-07 09:10:36 -0700 Created attachment 342173 Patch 1430887 2 342173 darin 2018-06-07 09:35:47 -0700 Comment on attachment 342173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342173&action=review > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13 > CLANG_ENABLE_OBJC_WEAK = YES; Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding CLANG_ENABLE_OBJC_ARC since it’s redundant? 1430895 3 mitz 2018-06-07 09:51:44 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 342173 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342173&action=review > > > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13 > > CLANG_ENABLE_OBJC_WEAK = YES; > > Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding > CLANG_ENABLE_OBJC_ARC since it’s redundant? If we end up opting individual files out of ARC, either temporarily or permanently, we’d still want them to use Objective-C weak. 1431304 4 darin 2018-06-08 10:43:35 -0700 Anyone willing to review? Everything’s working. 1431464 5 darin 2018-06-08 15:30:27 -0700 Committed r232644: <https://trac.webkit.org/changeset/232644> 1431466 6 webkit-bug-importer 2018-06-08 15:31:19 -0700 <rdar://problem/40953310> 342173 2018-06-07 09:10:36 -0700 2018-06-08 10:44:46 -0700 Patch bug-186396-20180607091035.patch text/plain 5154 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAyZTMxMWZkNmIxYjUzYjNlNzk5ZGIyYjEzZDU4OWUwN2VhM2UwZTNhLi5jN2Q2 OTgxM2M4ZTMyM2YyODViMmU5MjExYjExMTM1OGNlY2I1MDQ2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOC0wNi0wNyAgRGFyaW4gQWRs ZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBNaW5vciBBUkMgdGlkeWlu ZyBvZiBsaWJ3ZWJydGMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4NjM5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZzogU2V0IENMQU5HX0VOQUJMRV9P QkpDX0FSQyBoZXJlIGFzIHdlIHdpbGwgZXZlbnR1YWxseSBiZQorICAgICAgICBkb2luZyBpbiBh bGwgdGhlIHZhcmlvdXMgQmFzZS54Y2NvbmZpZyBmaWxlcyBhcyB3ZSBtYWtlIHByb2dyZXNzIG9u IGNvbnZlcnNpb24uCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9saWJ3ZWJydGMueGNjb25m aWc6IFJlbW92ZWQgb3ZlcnJpZGUgb2YgQ0xBTkdfRU5BQkxFX09CSkNfQVJDIGhlcmUgYW5kCisg ICAgICAgIGFsc28gcmVtb3ZlZCBmaXZlIG90aGVyIHJlZHVuZGFudCBzZXR0aW5ncyB0aGF0IG1h dGNoIEJhc2UueGNjb25maWcuCisKKyAgICAgICAgKiBsaWJ3ZWJydGMueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvajogUmVtb3ZlZCBleHBsaWNpdCAtZm9iamMtYXJjIHRoYXQgd2FzIHNldCBvbgor ICAgICAgICBvbmUgcGFydGljdWxhciBzb3VyY2UgZmlsZSwgc2luY2UgdGhhdCdzIGFscmVhZHkg dGhlIGRlZmF1bHQgZm9yIHRoZSBwcm9qZWN0LgorCiAyMDE4LTA2LTA0ICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0sxXSBBZGQgYW4gb3B0aW9uIHRvIHJl c3RyaWN0IGNvbW11bmljYXRpb24gdG8gbG9jYWxob3N0IHNvY2tldHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIv U291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcK aW5kZXggYWE0NDQyMDc4OTc1ZmFhNDE1ZjNhZDEzZjEwMTNjNzFlM2QwNTA3NC4uZWUyYjMxODdj MDE5MjAxMzNhYjJhYjMxNDYwOWZlZTNjYjI2ZjAyNiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJk UGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKKysrIGIvU291cmNl L1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKQEAgLTks NiArOSw3IEBAIEFMV0FZU19TRUFSQ0hfVVNFUl9QQVRIUyA9IE5POwogCiBDTEFOR19DWFhfTEFO R1VBR0VfU1RBTkRBUkQgPSBnbnUrKzE0OwogQ0xBTkdfQ1hYX0xJQlJBUlkgPSBsaWJjKys7CitD TEFOR19FTkFCTEVfT0JKQ19BUkMgPSBZRVM7CiBDTEFOR19FTkFCTEVfT0JKQ19XRUFLID0gWUVT OwogQ0xBTkdfV0FSTl9CTE9DS19DQVBUVVJFX0FVVE9SRUxFQVNJTkcgPSBZRVM7CiBDTEFOR19X QVJOX0JPT0xfQ09OVkVSU0lPTiA9IFlFUzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3ZWJydGMueGNjb25maWcgYi9Tb3VyY2UvVGhp cmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvbGlid2VicnRjLnhjY29uZmlnCmluZGV4 IDUwNThkYmIxYmYwY2NmZDBiYjlhMTcwMjNmOGZhYmNjYjY3Y2FiOTEuLmQ4Y2Y0ODdlOTEyNDZi MmU0MmIwY2RhZGJlNWYxYmIwMDM3MGY0YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3ZWJydGMueGNjb25maWcKKysrIGIvU291cmNl L1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL2xpYndlYnJ0Yy54Y2NvbmZpZwpA QCAtMTcsMTQgKzE3LDcgQEAgRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfVVNFX09WRVJSSURFX0ZS QU1FV09SS1NfRElSX1lFUyA9IEBsb2FkZXJfcGF0aC8uLi8uLi8uLi8KIERZTElCX0lOU1RBTExf TkFNRV9CQVNFX1dLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS1NfID0gJChEWUxJQl9JTlNUQUxMX05B TUVfQkFTRSk7CiBEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9XS19SRUxPQ0FUQUJMRV9GUkFNRVdP UktTX1lFUyA9IEBsb2FkZXJfcGF0aC8uLi8uLi8uLi87CiAKLUNMQU5HX0VOQUJMRV9PQkpDX0FS QyA9IFlFUzsKLQotQ0xBTkdfV0FSTl9CT09MX0NPTlZFUlNJT04gPSBZRVM7Ci1DTEFOR19XQVJO X0VOVU1fQ09OVkVSU0lPTiA9IFlFUzsKLUNMQU5HX1dBUk5fSU5UX0NPTlZFUlNJT04gPSBZRVM7 CiBHQ0NfV0FSTl82NF9UT18zMl9CSVRfQ09OVkVSU0lPTiA9IE5POwotQ09NQklORV9ISURQSV9J TUFHRVMgPSBOTzsKLUVOQUJMRV9TVFJJQ1RfT0JKQ19NU0dTRU5EID0gWUVTOwogSEVBREVSX1NF QVJDSF9QQVRIUyA9IFNvdXJjZSBTb3VyY2UvdGhpcmRfcGFydHkvanNvbmNwcC9zb3VyY2UvaW5j bHVkZSBTb3VyY2UvdGhpcmRfcGFydHkvbGlic3J0cC9jcnlwdG8vaW5jbHVkZSBTb3VyY2UvdGhp cmRfcGFydHkvbGlic3J0cC9pbmNsdWRlIFNvdXJjZS90aGlyZF9wYXJ0eS9ib3Jpbmdzc2wvc3Jj L2luY2x1ZGUgU291cmNlL3RoaXJkX3BhcnR5L2xpYnl1di9pbmNsdWRlIFNvdXJjZS90aGlyZF9w YXJ0eS91c3JzY3RwL3VzcnNjdHBsaWIgU291cmNlL3RoaXJkX3BhcnR5L3VzcnNjdHAvdXNyc2N0 cGxpYi91c3JzY3RwbGliIFNvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0hlYWRlcnMg U291cmNlL3dlYnJ0Yy9jb21tb25fYXVkaW8vc2lnbmFsX3Byb2Nlc3NpbmcvaW5jbHVkZSBTb3Vy Y2Uvd2VicnRjL21vZHVsZXMvYXVkaW9fY29kaW5nL2NvZGVjcy9pc2FjL21haW4vaW5jbHVkZSBT b3VyY2UvdGhpcmRfcGFydHkvb3B1cy9zcmMvY2VsdCBTb3VyY2UvdGhpcmRfcGFydHkvb3B1cy9z cmMvaW5jbHVkZSBTb3VyY2UvdGhpcmRfcGFydHkvb3B1cy9zcmMvc3JjIFNvdXJjZS93ZWJydGMv bW9kdWxlcy9hdWRpb19kZXZpY2UvbWFjIFNvdXJjZS90aGlyZF9wYXJ0eS91c3JzY3RwL3VzcnNj dHBsaWIvdXNyc2N0cGxpYi9uZXRpbmV0IFNvdXJjZS93ZWJydGMvbW9kdWxlcy9hdWRpb19kZXZp Y2UvaW9zOwogCiBQVUJMSUNfSEVBREVSU19GT0xERVJfUEFUSCA9IC91c3IvbG9jYWwvaW5jbHVk ZS9saWJ3ZWJydGM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvbGli d2VicnRjLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3 ZWJydGMvbGlid2VicnRjLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggZjIxN2VjMzY3 Y2Y0NTUzZjJmNWE4NDc3Njk1MDU2MjczM2M2NmU2MC4uNWRhNTU4MjQ5NzlmZDM5YzczZjcwZTZl MGUyOTEyMjhkNjU1YTA5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L2xpYndlYnJ0Yy54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9UaGlyZFBh cnR5L2xpYndlYnJ0Yy9saWJ3ZWJydGMueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMjc0 NSw3ICsyNzQ1LDcgQEAKIAkJNUNGRDUzN0MxRTRCQTRGNTAwNDgyOTA4IC8qIGF1ZGlvX2Rldmlj ZV9pb3MuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDVD RkQ1Mzc1MUU0QkE0RjUwMDQ4MjkwOCAvKiBhdWRpb19kZXZpY2VfaW9zLmggKi87IH07CiAJCTVD RkQ1MzgwMUU0QkE0RjUwMDQ4MjkwOCAvKiBhdWRpb19zZXNzaW9uX29ic2VydmVyLmggaW4gSGVh ZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1Q0ZENTM3OTFFNEJBNEY1 MDA0ODI5MDggLyogYXVkaW9fc2Vzc2lvbl9vYnNlcnZlci5oICovOyB9OwogCQk1Q0ZENTM4MTFF NEJBNEY1MDA0ODI5MDggLyogdm9pY2VfcHJvY2Vzc2luZ19hdWRpb191bml0LmggaW4gSGVhZGVy cyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1Q0ZENTM3QTFFNEJBNEY1MDA0 ODI5MDggLyogdm9pY2VfcHJvY2Vzc2luZ19hdWRpb191bml0LmggKi87IH07Ci0JCTVDRkQ1Mzgy MUU0QkE0RjUwMDQ4MjkwOCAvKiB2b2ljZV9wcm9jZXNzaW5nX2F1ZGlvX3VuaXQubW0gaW4gU291 cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1Q0ZENTM3QjFFNEJBNEY1 MDA0ODI5MDggLyogdm9pY2VfcHJvY2Vzc2luZ19hdWRpb191bml0Lm1tICovOyBzZXR0aW5ncyA9 IHtDT01QSUxFUl9GTEFHUyA9ICItZm9iamMtYXJjIjsgfTsgfTsKKwkJNUNGRDUzODIxRTRCQTRG NTAwNDgyOTA4IC8qIHZvaWNlX3Byb2Nlc3NpbmdfYXVkaW9fdW5pdC5tbSBpbiBTb3VyY2VzICov ID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDVDRkQ1MzdCMUU0QkE0RjUwMDQ4Mjkw OCAvKiB2b2ljZV9wcm9jZXNzaW5nX2F1ZGlvX3VuaXQubW0gKi87IH07CiAJCTVDRkQ1MzhEMUU0 QkQzQTMwMDQ4MjkwOCAvKiBjb21wYXJlX25lb24uY2MgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQ QlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1Q0ZENTM4NTFFNEJEM0EzMDA0ODI5MDggLyogY29tcGFy ZV9uZW9uLmNjICovOyB9OwogCQk1Q0ZENTM4RTFFNEJEM0EzMDA0ODI5MDggLyogY29tcGFyZV9u ZW9uNjQuY2MgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1 Q0ZENTM4NjFFNEJEM0EzMDA0ODI5MDggLyogY29tcGFyZV9uZW9uNjQuY2MgKi87IH07CiAJCTVD RkQ1MzhGMUU0QkQzQTMwMDQ4MjkwOCAvKiByb3RhdGVfbmVvbi5jYyBpbiBTb3VyY2VzICovID0g e2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDVDRkQ1Mzg3MUU0QkQzQTMwMDQ4MjkwOCAv KiByb3RhdGVfbmVvbi5jYyAqLzsgfTsK