186395 2018-06-07 09:00:25 -0700 REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing 2018-06-07 12:17:47 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186130 InRadar P2 Normal --- 1 ryanhaddad thorton commit-queue realdawei simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1430850 0 ryanhaddad 2018-06-07 09:00:25 -0700 The following API test is failing after https://trac.webkit.org/changeset/232544/webkit TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:215 Value of: 100 Expected: innerWidth Which is: 200 /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:216 Value of: 200 Expected: innerHeight Which is: 50 https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/5419/steps/run-api-tests/logs/stdio 1430881 1 thorton 2018-06-07 09:32:20 -0700 Heh, that makes sense. I should be able to fix by sprinkling some doAfterNextPresentationUpdate in there. 1430882 2 thorton 2018-06-07 09:32:44 -0700 (In the test) 1430941 3 webkit-bug-importer 2018-06-07 11:09:52 -0700 <rdar://problem/40902427> 1430966 4 342195 thorton 2018-06-07 11:45:36 -0700 Created attachment 342195 Patch 1430982 5 342195 commit-queue 2018-06-07 12:17:45 -0700 Comment on attachment 342195 Patch Clearing flags on attachment: 342195 Committed r232593: <https://trac.webkit.org/changeset/232593> 1430983 6 commit-queue 2018-06-07 12:17:47 -0700 All reviewed patches have been landed. Closing bug. 342195 2018-06-07 11:45:36 -0700 2018-06-07 12:17:45 -0700 Patch bug-186395-20180607114535.patch text/plain 2285 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmQwNDkyZmIwYTU0ODRkZGZjNGY3OTQ2MjU0NGRlZjg1 OGZmZWE3ZC4uOTk3NDE5Yjc0YmUwZjhhZTFmOTc4NGUxNDkyNWJhM2UxNzUwNjlkNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTA2LTA3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKHIyMzI1NDQpOiBbaU9TXSBUZXN0V2ViS2l0QVBJLldlYktp dC5PdmVycmlkZUxheW91dFNpemVDaGFuZ2VzRHVyaW5nQW5pbWF0ZWRSZXNpemVTdWNjZWVkIGlz IGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NjM5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDA5MDI0Mjc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL0FuaW1hdGVkUmVzaXplLm1tOgorICAgICAgICAoVEVTVCk6CisgICAgICAg IGVuZEFuaW1hdGVkUmVzaXplIG5vIGxvbmdlciBzeW5jaHJvbml6ZXMsIHNvIHdlIGhhdmUgdG8g d2FpdCBmb3IgdGhlIG5leHQgcHJlc2VudGF0aW9uIHVwZGF0ZS4KKwogMjAxOC0wNi0wNSAgQnJl bnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpc2UgREVGQVVM VF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxFRCB0byB3b3JrIHByb3Blcmx5IG9uIEFwcGxl IGJ1aWxkcwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9BbmltYXRlZFJlc2l6ZS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvQW5pbWF0ZWRSZXNpemUubW0KaW5kZXggNWQyOTJjYjE2OTM1OGYwYWI1NWQ1MzUzZjJmNjUw ZmM5NzVmNTE0NC4uMGQxNGVkNzFlNWQzYzQ1YzA4OTA1NzExNzkwNzE4ZDk0ZmI0YmFhOCAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9BbmltYXRlZFJl c2l6ZS5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0FuaW1h dGVkUmVzaXplLm1tCkBAIC0yMDgsMTUgKzIwOCwxOSBAQCBURVNUKFdlYktpdCwgT3ZlcnJpZGVM YXlvdXRTaXplQ2hhbmdlc0R1cmluZ0FuaW1hdGVkUmVzaXplU3VjY2VlZCkKICAgICBbd2ViVmll dyBfZW5kQW5pbWF0ZWRSZXNpemVdOwogCiAgICAgX19ibG9jayBib29sIGRpZFJlYWRMYXlvdXRT aXplID0gZmFsc2U7Ci0gICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0OkAiW3dpbmRvdy5p bm5lcldpZHRoLCB3aW5kb3cuaW5uZXJIZWlnaHRdIiBjb21wbGV0aW9uSGFuZGxlcjpeKGlkIHZh bHVlLCBOU0Vycm9yICplcnJvcikgewotICAgICAgICBDR0Zsb2F0IGlubmVyV2lkdGggPSBbW3Zh bHVlIG9iamVjdEF0SW5kZXg6MF0gZmxvYXRWYWx1ZV07Ci0gICAgICAgIENHRmxvYXQgaW5uZXJI ZWlnaHQgPSBbW3ZhbHVlIG9iamVjdEF0SW5kZXg6MV0gZmxvYXRWYWx1ZV07CiAKLSAgICAgICAg RVhQRUNUX0VRKGlubmVyV2lkdGgsIDEwMCk7Ci0gICAgICAgIEVYUEVDVF9FUShpbm5lckhlaWdo dCwgMjAwKTsKKyAgICBbd2ViVmlldyBfZG9BZnRlck5leHRQcmVzZW50YXRpb25VcGRhdGU6XnsK KyAgICAgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0OkAiW3dpbmRvdy5pbm5lcldpZHRo LCB3aW5kb3cuaW5uZXJIZWlnaHRdIiBjb21wbGV0aW9uSGFuZGxlcjpeKGlkIHZhbHVlLCBOU0Vy cm9yICplcnJvcikgeworICAgICAgICAgICAgQ0dGbG9hdCBpbm5lcldpZHRoID0gW1t2YWx1ZSBv YmplY3RBdEluZGV4OjBdIGZsb2F0VmFsdWVdOworICAgICAgICAgICAgQ0dGbG9hdCBpbm5lckhl aWdodCA9IFtbdmFsdWUgb2JqZWN0QXRJbmRleDoxXSBmbG9hdFZhbHVlXTsKIAotICAgICAgICBk aWRSZWFkTGF5b3V0U2l6ZSA9IHRydWU7CisgICAgICAgICAgICBFWFBFQ1RfRVEoaW5uZXJXaWR0 aCwgMTAwKTsKKyAgICAgICAgICAgIEVYUEVDVF9FUShpbm5lckhlaWdodCwgMjAwKTsKKworICAg ICAgICAgICAgZGlkUmVhZExheW91dFNpemUgPSB0cnVlOworICAgICAgICB9XTsKICAgICB9XTsK KyAgICAKICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRpZFJlYWRMYXlvdXRTaXplKTsK IH0KIAo=