186386 2018-06-07 00:11:11 -0700 TierUpCheckInjectionPhase systematically never puts the outer-most loop in an inner loop's vector of outer loops 2018-06-07 15:07:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1430746 0 saam 2018-06-07 00:11:11 -0700 When looking at TierUpInjectionPhase recently, it often seemed that the outermost loop would not be an OSR entry candidate. We should see why this is happening. This could probably help in some benchmarks. 1430768 1 saam 2018-06-07 01:12:26 -0700 Fixing the systematic issue looks like a speedup on a kraken subtest: og change ai-astar 85.692+-0.627 85.500+-0.840 audio-beat-detection 39.132+-2.003 38.364+-0.357 might be 1.0200x faster audio-dft 95.293+-0.681 ? 96.690+-1.584 ? might be 1.0147x slower audio-fft 28.706+-0.107 ? 28.733+-0.360 ? audio-oscillator 44.681+-0.460 ? 44.772+-0.427 ? imaging-darkroom 58.974+-0.416 58.969+-0.539 imaging-desaturate 45.945+-1.371 ? 46.142+-1.571 ? imaging-gaussian-blur 61.139+-1.573 ^ 55.691+-1.727 ^ definitely 1.0978x faster json-parse-financial 29.528+-0.587 ^ 28.671+-0.200 ^ definitely 1.0299x faster json-stringify-tinderbox 19.068+-0.402 18.986+-0.365 stanford-crypto-aes 44.608+-0.564 ? 45.408+-0.493 ? might be 1.0179x slower stanford-crypto-ccm 40.929+-1.719 40.911+-1.484 stanford-crypto-pbkdf2 60.492+-1.020 59.223+-1.505 might be 1.0214x faster stanford-crypto-sha256-iterative 18.558+-0.220 ? 18.672+-0.295 ? <arithmetic> 48.053+-0.265 47.624+-0.200 might be 1.0090x faster 1430769 2 342138 saam 2018-06-07 01:14:41 -0700 Created attachment 342138 WIP 1430940 3 342191 saam 2018-06-07 11:09:26 -0700 Created attachment 342191 patch 1431040 4 342191 commit-queue 2018-06-07 15:06:49 -0700 Comment on attachment 342191 patch Clearing flags on attachment: 342191 Committed r232602: <https://trac.webkit.org/changeset/232602> 1431041 5 commit-queue 2018-06-07 15:06:50 -0700 All reviewed patches have been landed. Closing bug. 1431042 6 webkit-bug-importer 2018-06-07 15:07:22 -0700 <rdar://problem/40912318> 342138 2018-06-07 01:14:41 -0700 2018-06-07 11:09:26 -0700 WIP c-backup.diff text/plain 1102 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHVGllclVwQ2hlY2tJbmplY3Rpb25Q aGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdUaWVy VXBDaGVja0luamVjdGlvblBoYXNlLmNwcAkocmV2aXNpb24gMjMyNTczKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdUaWVyVXBDaGVja0luamVjdGlvblBoYXNlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTIyLDggKzEyMiw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAg ICAgIGlmIChpdCAhPSBuYXR1cmFsTG9vcFRvTG9vcEhpbnQuZW5kKCkpCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZGVzY3JpcHRvci5vc3JFbnRyeUNhbmRpZGF0ZXMuYXBwZW5kKGl0LT52 YWx1ZSk7CiAgICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICAgICAgaWYgKCFk ZXNjcmlwdG9yLm9zckVudHJ5Q2FuZGlkYXRlcy5pc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAg ICAgICAgICB0aWVyVXBIaWVyYXJjaHkuYWRkKGJ5dGVjb2RlSW5kZXgsIFdURk1vdmUoZGVzY3Jp cHRvcikpOworICAgICAgICAgICAgICAgICAgICB0aWVyVXBIaWVyYXJjaHkuYWRkKGJ5dGVjb2Rl SW5kZXgsIFdURk1vdmUoZGVzY3JpcHRvcikpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KQEAgLTE0Niw3ICsxNDUsNyBAQCBwdWJsaWM6 CiAgICAgICAgICAgICAgICAgICAgICYmIGRlc2NyaXB0b3JJdC0+dmFsdWUuY2FuT1NSRW50ZXIp CiAgICAgICAgICAgICAgICAgICAgIHRpZXJVcENhbmRpZGF0ZXMuYXBwZW5kKGJ5dGVjb2RlSW5k ZXgpOwogICAgICAgICAgICAgfQotCisgICAgICAgICAgICAKICAgICAgICAgICAgIGlmICghdGll clVwQ2FuZGlkYXRlcy5pc0VtcHR5KCkpCiAgICAgICAgICAgICAgICAgbV9ncmFwaC5tX3BsYW4u dGllclVwSW5Mb29wSGllcmFyY2h5LmFkZChlbnRyeS5rZXksIFdURk1vdmUodGllclVwQ2FuZGlk YXRlcykpOwogICAgICAgICB9Cg== 342191 2018-06-07 11:09:26 -0700 2018-06-07 15:06:49 -0700 patch c-backup.diff text/plain 1649 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMyNTg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTA2LTA3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRpZXJVcENoZWNrSW5qZWN0aW9uUGhhc2Ugc3lzdGVtYXRpY2FsbHkgbmV2ZXIgcHV0cyB0aGUg b3V0ZXItbW9zdCBsb29wIGluIGFuIGlubmVyIGxvb3AncyB2ZWN0b3Igb2Ygb3V0ZXIgbG9vcHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjM4Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgbG9v a3MgbGlrZSBhbiA4JSBzcGVlZHVwIG9uIEtyYWtlbidzIGltYWdpbmctZ2F1c3NpYW4tYmx1ciBz dWJ0ZXN0LgorCisgICAgICAgICogZGZnL0RGR1RpZXJVcENoZWNrSW5qZWN0aW9uUGhhc2UuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OlRpZXJVcENoZWNrSW5qZWN0aW9uUGhhc2U6OnJ1bik6CisK IDIwMTgtMDYtMDcgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBERkcgdG8gRlRMIE9TUiBlbnRyeSBjb2RlIG1vcmUgc2FuZSBieSByZW1vdmluZyBiYWQg UkVMRUFTRV9BU1NFUlRTIGFuZCBtYWtpbmcgaXQgdHJpZ2dlciBjb21waWxlcyBpbiBvdXRlciBs b29wcyBiZWZvcmUgaW5uZXIgb25lcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdUaWVyVXBDaGVja0luamVjdGlvblBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1RpZXJVcENoZWNrSW5qZWN0aW9uUGhhc2UuY3BwCShyZXZpc2lv biAyMzI1ODcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1RpZXJVcENoZWNrSW5q ZWN0aW9uUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjIsOCArMTIyLDcgQEAgcHVibGlj OgogICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGl0ICE9IG5hdHVyYWxMb29wVG9Mb29wSGlu dC5lbmQoKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXNjcmlwdG9yLm9zckVudHJ5 Q2FuZGlkYXRlcy5hcHBlbmQoaXQtPnZhbHVlKTsKICAgICAgICAgICAgICAgICAgICAgfQotICAg ICAgICAgICAgICAgICAgICBpZiAoIWRlc2NyaXB0b3Iub3NyRW50cnlDYW5kaWRhdGVzLmlzRW1w dHkoKSkKLSAgICAgICAgICAgICAgICAgICAgICAgIHRpZXJVcEhpZXJhcmNoeS5hZGQoYnl0ZWNv ZGVJbmRleCwgV1RGTW92ZShkZXNjcmlwdG9yKSk7CisgICAgICAgICAgICAgICAgICAgIHRpZXJV cEhpZXJhcmNoeS5hZGQoYnl0ZWNvZGVJbmRleCwgV1RGTW92ZShkZXNjcmlwdG9yKSk7CiAgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQo=