186380 2018-06-06 19:58:56 -0700 [Xcode] Opt out of the New Build System 2018-06-07 10:36:09 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz webkit-unassigned ap commit-queue darin dbates ews-watchlist jbedard krollin lforschler simon.fraser webkit-bug-importer oldest_to_newest 1430684 0 mitz 2018-06-06 19:58:56 -0700 In Xcode 10 beta 1, the New Build System is used by default. Until all projects in the stack are building successfully with the New Build System, we should opt out of using it. For command-line builds, I think this can be done by changing webkitdirs.pm to include -UseNewBuildSystem=NO in the xcodebuild command-line. For building from within Xcode, I think this can be done by changing the WebKit workspace at the root of the source tree. People opening individual projects in Xcode, or using their own workspaces, will need to change the project or workspace settings to select the Legacy Build System. 1430685 1 342109 mitz 2018-06-06 20:05:53 -0700 Created attachment 342109 Use the Legacy Build System in the workspace and in command-line builds 1430710 2 342109 commit-queue 2018-06-06 22:09:29 -0700 Comment on attachment 342109 Use the Legacy Build System in the workspace and in command-line builds Clearing flags on attachment: 342109 Committed r232573: <https://trac.webkit.org/changeset/232573> 1430711 3 commit-queue 2018-06-06 22:09:31 -0700 All reviewed patches have been landed. Closing bug. 1430712 4 webkit-bug-importer 2018-06-06 22:10:23 -0700 <rdar://problem/40881265> 1430862 5 darin 2018-06-07 09:13:14 -0700 (In reply to mitz from comment #0) > In Xcode 10 beta 1, the New Build System is used by default. Until all > projects in the stack are building successfully with the New Build System, > we should opt out of using it. Just curious: Which projects don’t build successfully with it? 1430866 6 jbedard 2018-06-07 09:23:11 -0700 (In reply to Darin Adler from comment #5) > (In reply to mitz from comment #0) > > In Xcode 10 beta 1, the New Build System is used by default. Until all > > projects in the stack are building successfully with the New Build System, > > we should opt out of using it. > > Just curious: Which projects don’t build successfully with it? WebCore and WebKit are the big ones, but I think WebInspector has issues as well. 1430875 7 darin 2018-06-07 09:27:17 -0700 (In reply to Jonathan Bedard from comment #6) > WebCore and WebKit are the big ones, but I think WebInspector has issues as > well. Is someone working on that, or are we putting it off? 1430885 8 jbedard 2018-06-07 09:35:15 -0700 (In reply to Darin Adler from comment #7) > (In reply to Jonathan Bedard from comment #6) > > WebCore and WebKit are the big ones, but I think WebInspector has issues as > > well. > > Is someone working on that, or are we putting it off? I think we're still determining who will be doing this. For the time being, we are putting it off, but I don't think we will be able to get away with pushing it back much farther than September or October. 1430890 9 mitz 2018-06-07 09:42:05 -0700 (In reply to Darin Adler from comment #5) > (In reply to mitz from comment #0) > > In Xcode 10 beta 1, the New Build System is used by default. Until all > > projects in the stack are building successfully with the New Build System, > > we should opt out of using it. > > Just curious: Which projects don’t build successfully with it? Last I tried, JavaScriptCore was the first project in the stack to fail to build. I should file a bug here to track that (I want it to be linked to the Apple-internal bug and I was too lazy to find that one last night). 342109 2018-06-06 20:05:53 -0700 2018-06-06 22:09:29 -0700 Use the Legacy Build System in the workspace and in command-line builds file_186380.txt text/plain 2480 mitz SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMjMy NDg4KQ0KKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxMiBAQA0KKzIw MTgtMDYtMDYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4NCisNCisgICAgICAgIFtY Y29kZV0gT3B0IG91dCBvZiB0aGUgTmV3IEJ1aWxkIFN5c3RlbQ0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjM4MA0KKw0KKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICAqIFdlYktpdC54Y3dvcmtzcGFjZS94 Y3NoYXJlZGRhdGEvV29ya3NwYWNlU2V0dGluZ3MueGNzZXR0aW5nczogVXNlIHRoZSBMZWdhY3kg QnVpbGQgU3lzdGVtLg0KKw0KIDIwMTgtMDUtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPg0KIA0KICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNH VEsuY21ha2UgYW5kIE5FV1MgZm9yIDIuMjEuMyByZWxlYXNlLg0KSW5kZXg6IFRvb2xzL0NoYW5n ZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQ0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjMyNTY4KQ0K KysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxMyBAQA0KKzIw MTgtMDYtMDYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4NCisNCisgICAgICAgIFtY Y29kZV0gT3B0IG91dCBvZiB0aGUgTmV3IEJ1aWxkIFN5c3RlbQ0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjM4MA0KKw0KKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToNCisgICAgICAgIChYY29kZU9wdGlvbnMpOiBIYXZlIC1Vc2VOZXdCdWlsZFN5c3RlbT1OTyBw YXNzZWQgdG8geGNvZGVidWlsZC4NCisNCiAyMDE4LTA2LTA2ICBBbnRvaW5lIFF1aW50ICA8Z3Jh b3V0c0BhcHBsZS5jb20+DQogDQogICAgICAgICBSZW5hbWUgY29sb3ItZmlsdGVyIHRvIC1hcHBs ZS1jb2xvci1maWx0ZXIgYW5kIGRvIG5vdCBleHBvc2UgaXQgdG8gV2ViIGNvbnRlbnQNCkluZGV4 OiBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0NCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDIzMjQ4OCkNCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkNCkBAIC04NTAsNiArODUwLDcgQEAgc3ViIFhjb2Rl T3B0aW9ucw0KICAgICBkZXRlcm1pbmVYY29kZVNESygpOw0KIA0KICAgICBteSBAb3B0aW9uczsN CisgICAgcHVzaCBAb3B0aW9ucywgIi1Vc2VOZXdCdWlsZFN5c3RlbT1OTyI7DQogICAgIHB1c2gg QG9wdGlvbnMsICItVXNlU2FuaXRpemVkQnVpbGRTeXN0ZW1FbnZpcm9ubWVudD1ZRVMiOw0KICAg ICBwdXNoIEBvcHRpb25zLCAoIi1jb25maWd1cmF0aW9uIiwgJGNvbmZpZ3VyYXRpb24pOw0KICAg ICBwdXNoIEBvcHRpb25zLCAoIi14Y2NvbmZpZyIsIHNvdXJjZURpcigpIC4gIi9Ub29scy9hc2Fu L2FzYW4ueGNjb25maWciLCAiQVNBTl9JR05PUkU9IiAuIHNvdXJjZURpcigpIC4gIi9Ub29scy9h c2FuL3dlYmtpdC1hc2FuLWlnbm9yZS50eHQiKSBpZiAkYXNhbklzRW5hYmxlZDsNCkluZGV4OiBX ZWJLaXQueGN3b3Jrc3BhY2UveGNzaGFyZWRkYXRhL1dvcmtzcGFjZVNldHRpbmdzLnhjc2V0dGlu Z3MNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQueGN3b3Jrc3BhY2UveGNzaGFyZWRkYXRhL1dvcmtz cGFjZVNldHRpbmdzLnhjc2V0dGluZ3MJKHJldmlzaW9uIDIzMjQ4OCkNCisrKyBXZWJLaXQueGN3 b3Jrc3BhY2UveGNzaGFyZWRkYXRhL1dvcmtzcGFjZVNldHRpbmdzLnhjc2V0dGluZ3MJKHdvcmtp bmcgY29weSkNCkBAIC0yLDYgKzIsOCBAQA0KIDwhRE9DVFlQRSBwbGlzdCBQVUJMSUMgIi0vL0Fw cGxlLy9EVEQgUExJU1QgMS4wLy9FTiIgImh0dHA6Ly93d3cuYXBwbGUuY29tL0RURHMvUHJvcGVy dHlMaXN0LTEuMC5kdGQiPg0KIDxwbGlzdCB2ZXJzaW9uPSIxLjAiPg0KIDxkaWN0Pg0KKwk8a2V5 PkJ1aWxkU3lzdGVtVHlwZTwva2V5Pg0KKwk8c3RyaW5nPk9yaWdpbmFsPC9zdHJpbmc+DQogCTxr ZXk+SURFV29ya3NwYWNlU2hhcmVkU2V0dGluZ3NfQXV0b2NyZWF0ZUNvbnRleHRzSWZOZWVkZWQ8 L2tleT4NCiAJPGZhbHNlLz4NCiA8L2RpY3Q+DQo=