186370 2018-06-06 16:32:50 -0700 Crash in lambda function WTF::Function<void ()>::CallableWrapper<WebKit::DisplayLink::displayLinkCallback 2018-06-06 17:42:49 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue thorton webkit-bug-importer oldest_to_newest 1430620 0 pvollan 2018-06-06 16:32:50 -0700 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff6665e1be __abort_with_payload + 10 1 libsystem_kernel.dylib 0x00007fff66658202 abort_with_payload_wrapper_internal + 82 2 libsystem_kernel.dylib 0x00007fff666581b0 abort_with_reason + 22 3 libobjc.A.dylib 0x00007fff6557c63b _objc_fatalv(unsigned long long, unsigned long long, char const*, __va_list_tag*) + 108 4 libobjc.A.dylib 0x00007fff6557c4fd _objc_fatal(char const*, ...) + 127 5 libobjc.A.dylib 0x00007fff6557ffd1 checkIsKnownClass(objc_class*) + 52 6 libobjc.A.dylib 0x00007fff6556cd9b lookUpImpOrForward + 116 7 libobjc.A.dylib 0x00007fff6556c894 _objc_msgSend_uncached + 68 8 com.apple.WebKit 0x00007fff48392a8b WTF::Function<void ()>::CallableWrapper<WebKit::DisplayLink::displayLinkCallback(__CVDisplayLink*, CVTimeStamp const*, CVTimeStamp const*, unsigned long long, unsigned long long*, void*)::$_0>::~CallableWrapper() + 39 9 com.apple.JavaScriptCore 0x00007fff3c993917 WTF::dispatchFunctionsFromMainThread() + 263 10 com.apple.Foundation 0x00007fff3b6ff0a4 __NSThreadPerformPerform + 325 11 com.apple.CoreFoundation 0x00007fff392ea69e __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 12 com.apple.CoreFoundation 0x00007fff3938bada __CFRunLoopDoSource0 + 108 13 com.apple.CoreFoundation 0x00007fff392d0d8b __CFRunLoopDoSources0 + 228 14 com.apple.CoreFoundation 0x00007fff392d030f __CFRunLoopRun + 1246 15 com.apple.CoreFoundation 0x00007fff392cfc0d CFRunLoopRunSpecific + 510 16 com.apple.HIToolbox 0x00007fff3856ff4d RunCurrentEventLoopInMode + 293 17 com.apple.HIToolbox 0x00007fff3856fc87 ReceiveNextEventCommon + 618 18 com.apple.HIToolbox 0x00007fff3856fa04 _BlockUntilNextEventMatchingListInModeWithFilter + 64 19 com.apple.AppKit 0x00007fff368b8dd2 _DPSNextEvent + 1000 20 com.apple.AppKit 0x00007fff36ff6f48 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1356 21 com.apple.Safari.framework 0x00007fff5d48575a -[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 273 22 com.apple.AppKit 0x00007fff368ae66e -[NSApplication run] + 699 23 com.apple.AppKit 0x00007fff3687e87a NSApplicationMain + 780 24 libdyld.dylib 0x00007fff664f0f44 0x7fff664f0000 + 3908 1430621 1 pvollan 2018-06-06 16:34:48 -0700 <rdar://problem/40439109> 1430627 2 342095 pvollan 2018-06-06 16:47:12 -0700 Created attachment 342095 Patch 1430629 3 342095 bfulgham 2018-06-06 16:50:39 -0700 Comment on attachment 342095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342095&action=review r=me, if EWS is satisfied. > Source/WebKit/UIProcess/mac/DisplayLink.cpp:101 > + RunLoop::main().dispatch([weakPtr = webPageProxy->createWeakPtr()] { You should be able to use "weakPtr = makeWeakPtr(*webPageProxy)" 1430638 4 pvollan 2018-06-06 17:17:04 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 342095 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342095&action=review > > r=me, if EWS is satisfied. > > > Source/WebKit/UIProcess/mac/DisplayLink.cpp:101 > > + RunLoop::main().dispatch([weakPtr = webPageProxy->createWeakPtr()] { > > You should be able to use "weakPtr = makeWeakPtr(*webPageProxy)" It seems the WebPageProxy class does not have the method weakPtrFactory() which appears to be needed to do this. Thanks for reviewing! 1430640 5 pvollan 2018-06-06 17:21:13 -0700 <rdar://problem/39791647> 1430646 6 342095 commit-queue 2018-06-06 17:42:48 -0700 Comment on attachment 342095 Patch Clearing flags on attachment: 342095 Committed r232564: <https://trac.webkit.org/changeset/232564> 1430647 7 commit-queue 2018-06-06 17:42:49 -0700 All reviewed patches have been landed. Closing bug. 342095 2018-06-06 16:47:12 -0700 2018-06-06 17:42:48 -0700 Patch bug-186370-20180606164711.patch text/plain 2629 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzI1NDMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA2LTA2ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBsYW1iZGEgZnVu Y3Rpb24gV1RGOjpGdW5jdGlvbjx2b2lkICgpPjo6Q2FsbGFibGVXcmFwcGVyPFdlYktpdDo6RGlz cGxheUxpbms6OmRpc3BsYXlMaW5rQ2FsbGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjM3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk3 OTE2NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiB0aGUgZGlzcGxheSBsaW5rIGlzIGZpcmluZywgdGhlIGNhbGxiYWNrIGZ1bmN0aW9uIGlz IGNhbGxlZCBvbiB0aGUgZGlzcGxheSBsaW5rIHRocmVhZCwgd2hlcmUgYSBsYW1iZGEgZnVuY3Rp b24KKyAgICAgICAgaXMgY3JlYXRlZCB0byBiZSBleGVjdXRlZCBvbiB0aGUgbWFpbiB0aHJlYWQu IFRoZSBXZWJQYWdlUHJveHkgb2JqZWN0IGlzIGNhcHR1cmVkIGFzIGEgUmVmUHRyIGluIHRoZSBs YW1iZGEuIFRoaXMKKyAgICAgICAgbWlnaHQgY3Jhc2ggd2hlbiBleGVjdXRpbmcgb24gdGhlIG1h aW4gdGhyZWFkLCBzaW5jZSB0aGUgV2ViUGFnZVByb3h5IG9iamVjdCBpcyBwb3NzaWJseSBkZWxl dGVkIHRoZW4uIENhcHR1cmluZworICAgICAgICB0aGUgV2ViUGFnZVByb3h5IHdpbGwgbm90IHBy ZXZlbnQgdGhlIG9iamVjdCBmcm9tIGJlaW5nIGRlbGV0ZWQgaWYgdGhlIGRlc3RydWN0aW9uIG9m IHRoZSBXZWJQYWdlUHJveHkgb2JqZWN0IGFscmVhZHkKKyAgICAgICAgaGFzIHN0YXJ0ZWQgb24g dGhlIG1haW4gdGhyZWFkIHdoZW4gdGhlIG9iamVjdCBpcyBjYXB0dXJlZCwgd2hpY2ggc29tZXRp bWVzIGlzIHRoZSBjYXNlLiBJbnN0ZWFkLCB3ZSBjYW4gY3JlYXRlIGEKKyAgICAgICAgd2VhayBw b2ludGVyIHRvIHRoZSBvYmplY3QsIHdoaWNoIHdpbGwgd29yayBhcyBpbnRlbmRlZCwgZXZlbiBp ZiB0aGUgV2ViUGFnZVByb3h5IG9iamVjdCBpcyBpbiB0aGUgcHJvY2VzcyBvZiBiZWluZworICAg ICAgICBkZWxldGVkLiBUaGlzIGFsc28gbWF0Y2hlcyB0aGUgZGlzcGxheSBsaW5rIGltcGxlbWVu dGF0aW9uIHVzZWQgd2hlbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGhhcyBhY2Nlc3MgdG8gdGhl CisgICAgICAgIFdpbmRvd1NlcnZlci4gVGhpcyBpcyBub3QgYSBmcmVxdWVudCBjcmFzaC4gSSBo YXZlIG5vdCBiZWVuIGFibGUgdG8gcmVwcm9kdWNlIGl0LgorIAorICAgICAgICAqIFVJUHJvY2Vz cy9tYWMvRGlzcGxheUxpbmsuY3BwOgorICAgICAgICAoV2ViS2l0OjpEaXNwbGF5TGluazo6ZGlz cGxheUxpbmtDYWxsYmFjayk6CisKIDIwMTgtMDYtMDUgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgT3BlbkdMIGRpc3BsYXkgbWFzayB0byBzY3Jl ZW4gZGF0YSBzdHJ1Y3QuCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvRGlzcGxh eUxpbmsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9EaXNw bGF5TGluay5jcHAJKHJldmlzaW9uIDIzMjU0MykKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L21hYy9EaXNwbGF5TGluay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk4LDggKzk4LDkgQEAgdm9p ZCBEaXNwbGF5TGluazo6cmVzdW1lKCkKIENWUmV0dXJuIERpc3BsYXlMaW5rOjpkaXNwbGF5TGlu a0NhbGxiYWNrKENWRGlzcGxheUxpbmtSZWYgZGlzcGxheUxpbmtSZWYsIGNvbnN0IENWVGltZVN0 YW1wKiwgY29uc3QgQ1ZUaW1lU3RhbXAqLCBDVk9wdGlvbkZsYWdzLCBDVk9wdGlvbkZsYWdzKiwg dm9pZCogZGF0YSkKIHsKICAgICBXZWJQYWdlUHJveHkqIHdlYlBhZ2VQcm94eSA9IHJlaW50ZXJw cmV0X2Nhc3Q8V2ViUGFnZVByb3h5Kj4oZGF0YSk7Ci0gICAgY2FsbE9uTWFpblRocmVhZChbd2Vi UGFnZVByb3h5ID0gbWFrZVJlZlB0cih3ZWJQYWdlUHJveHkpXSB7Ci0gICAgICAgIHdlYlBhZ2VQ cm94eS0+cHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6OkRyYXdpbmdBcmVhOjpEaXNwbGF5V2FzUmVm cmVzaGVkKCksIHdlYlBhZ2VQcm94eS0+cGFnZUlEKCkpOworICAgIFJ1bkxvb3A6Om1haW4oKS5k aXNwYXRjaChbd2Vha1B0ciA9IHdlYlBhZ2VQcm94eS0+Y3JlYXRlV2Vha1B0cigpXSB7CisgICAg ICAgIGlmIChhdXRvKiBwcm94eSA9IHdlYWtQdHIuZ2V0KCkpCisgICAgICAgICAgICBwcm94eS0+ cHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6OkRyYXdpbmdBcmVhOjpEaXNwbGF5V2FzUmVmcmVzaGVk KCksIHByb3h5LT5wYWdlSUQoKSk7CiAgICAgfSk7CiAgICAgcmV0dXJuIGtDVlJldHVyblN1Y2Nl c3M7CiB9Cg==